Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/89179/?format=api
{ "id": 89179, "url": "https://patches.dpdk.org/api/patches/89179/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210316061544.861619-6-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210316061544.861619-6-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210316061544.861619-6-andrew.rybchenko@oktetlabs.ru", "date": "2021-03-16T06:15:41", "name": "[v3,5/8] common/sfc_efx/base: add support to verify virtio features", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4f31dccfa1142f43e64ff4f7f7d1ad87408c2868", "submitter": { "id": 2013, "url": "https://patches.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210316061544.861619-6-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 15680, "url": "https://patches.dpdk.org/api/series/15680/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15680", "date": "2021-03-16T06:15:36", "name": "common/sfc_efx: prepare to introduce vDPA driver", "version": 3, "mbox": "https://patches.dpdk.org/series/15680/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/89179/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/89179/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9A4F8A054F;\n\tTue, 16 Mar 2021 07:16:31 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 127AD2427E7;\n\tTue, 16 Mar 2021 07:16:11 +0100 (CET)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 6581B2427B6\n for <dev@dpdk.org>; Tue, 16 Mar 2021 07:16:09 +0100 (CET)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id 40ED77F5D5; Tue, 16 Mar 2021 09:16:09 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id B58117F5B3;\n Tue, 16 Mar 2021 09:15:50 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B58117F5B3", "Authentication-Results": "shelob.oktetlabs.ru/B58117F5B3; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org,\n\tVijay Kumar Srivastava <vsrivast@xilinx.com>", "Date": "Tue, 16 Mar 2021 09:15:41 +0300", "Message-Id": "<20210316061544.861619-6-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.1", "In-Reply-To": "<20210316061544.861619-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210311110325.3291203-1-andrew.rybchenko@oktetlabs.ru>\n <20210316061544.861619-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 5/8] common/sfc_efx/base: add support to\n verify virtio features", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Vijay Kumar Srivastava <vsrivast@xilinx.com>\n\nAdd an API to verify virtio features supported by device.\n\nSigned-off-by: Vijay Kumar Srivastava <vsrivast@xilinx.com>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n drivers/common/sfc_efx/base/efx.h | 7 ++++\n drivers/common/sfc_efx/base/efx_impl.h | 2 +\n drivers/common/sfc_efx/base/efx_virtio.c | 38 +++++++++++++++++++\n drivers/common/sfc_efx/base/rhead_impl.h | 7 ++++\n drivers/common/sfc_efx/base/rhead_virtio.c | 44 ++++++++++++++++++++++\n 5 files changed, 98 insertions(+)", "diff": "diff --git a/drivers/common/sfc_efx/base/efx.h b/drivers/common/sfc_efx/base/efx.h\nindex e3ac51eae0..ff5091a36b 100644\n--- a/drivers/common/sfc_efx/base/efx.h\n+++ b/drivers/common/sfc_efx/base/efx.h\n@@ -4501,6 +4501,13 @@ efx_virtio_get_features(\n \t__in\t\tefx_virtio_device_type_t type,\n \t__out\t\tuint64_t *featuresp);\n \n+LIBEFX_API\n+extern\t__checkReturn\tefx_rc_t\n+efx_virtio_verify_features(\n+\t__in\t\tefx_nic_t *enp,\n+\t__in\t\tefx_virtio_device_type_t type,\n+\t__in\t\tuint64_t features);\n+\n #endif /* EFSYS_OPT_VIRTIO */\n \n #ifdef\t__cplusplus\ndiff --git a/drivers/common/sfc_efx/base/efx_impl.h b/drivers/common/sfc_efx/base/efx_impl.h\nindex 758206d382..aa878014c1 100644\n--- a/drivers/common/sfc_efx/base/efx_impl.h\n+++ b/drivers/common/sfc_efx/base/efx_impl.h\n@@ -320,6 +320,8 @@ typedef struct efx_virtio_ops_s {\n \t\t\t\tuint32_t *);\n \tefx_rc_t\t(*evo_get_features)(efx_nic_t *,\n \t\t\t\tefx_virtio_device_type_t, uint64_t *);\n+\tefx_rc_t\t(*evo_verify_features)(efx_nic_t *,\n+\t\t\t\tefx_virtio_device_type_t, uint64_t);\n } efx_virtio_ops_t;\n #endif /* EFSYS_OPT_VIRTIO */\n \ndiff --git a/drivers/common/sfc_efx/base/efx_virtio.c b/drivers/common/sfc_efx/base/efx_virtio.c\nindex 20c22f02b5..b46997c09e 100644\n--- a/drivers/common/sfc_efx/base/efx_virtio.c\n+++ b/drivers/common/sfc_efx/base/efx_virtio.c\n@@ -14,6 +14,7 @@ static const efx_virtio_ops_t\t__efx_virtio_rhead_ops = {\n \trhead_virtio_qstop,\t\t\t/* evo_virtio_qstop */\n \trhead_virtio_get_doorbell_offset,\t/* evo_get_doorbell_offset */\n \trhead_virtio_get_features,\t\t/* evo_get_features */\n+\trhead_virtio_verify_features,\t\t/* evo_verify_features */\n };\n #endif /* EFSYS_OPT_RIVERHEAD */\n \n@@ -299,4 +300,41 @@ efx_virtio_get_features(\n \treturn (rc);\n }\n \n+\t__checkReturn\tefx_rc_t\n+efx_virtio_verify_features(\n+\t__in\t\tefx_nic_t *enp,\n+\t__in\t\tefx_virtio_device_type_t type,\n+\t__in\t\tuint64_t features)\n+{\n+\tconst efx_virtio_ops_t *evop = enp->en_evop;\n+\tefx_rc_t rc;\n+\n+\tif (type >= EFX_VIRTIO_DEVICE_NTYPES) {\n+\t\trc = EINVAL;\n+\t\tgoto fail1;\n+\t}\n+\n+\tEFSYS_ASSERT3U(enp->en_magic, ==, EFX_NIC_MAGIC);\n+\tEFSYS_ASSERT3U(enp->en_mod_flags, &, EFX_MOD_VIRTIO);\n+\n+\tif (evop == NULL) {\n+\t\trc = ENOTSUP;\n+\t\tgoto fail2;\n+\t}\n+\n+\tif ((rc = evop->evo_verify_features(enp, type, features)) != 0)\n+\t\tgoto fail3;\n+\n+\treturn (0);\n+\n+fail3:\n+\tEFSYS_PROBE(fail3);\n+fail2:\n+\tEFSYS_PROBE(fail2);\n+fail1:\n+\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n+\n+\treturn (rc);\n+}\n+\n #endif /* EFSYS_OPT_VIRTIO */\ndiff --git a/drivers/common/sfc_efx/base/rhead_impl.h b/drivers/common/sfc_efx/base/rhead_impl.h\nindex 69d701a47e..3bf9beceb0 100644\n--- a/drivers/common/sfc_efx/base/rhead_impl.h\n+++ b/drivers/common/sfc_efx/base/rhead_impl.h\n@@ -505,6 +505,13 @@ rhead_virtio_get_features(\n \t__in\t\t\t\tefx_virtio_device_type_t type,\n \t__out\t\t\t\tuint64_t *featuresp);\n \n+LIBEFX_INTERNAL\n+extern\t__checkReturn\t\t\tefx_rc_t\n+rhead_virtio_verify_features(\n+\t__in\t\t\t\tefx_nic_t *enp,\n+\t__in\t\t\t\tefx_virtio_device_type_t type,\n+\t__in\t\t\t\tuint64_t features);\n+\n #endif /* EFSYS_OPT_VIRTIO */\n \n #ifdef\t__cplusplus\ndiff --git a/drivers/common/sfc_efx/base/rhead_virtio.c b/drivers/common/sfc_efx/base/rhead_virtio.c\nindex 508d03d58f..0023ea1e83 100644\n--- a/drivers/common/sfc_efx/base/rhead_virtio.c\n+++ b/drivers/common/sfc_efx/base/rhead_virtio.c\n@@ -332,4 +332,48 @@ rhead_virtio_get_features(\n \treturn (rc);\n }\n \n+\t__checkReturn\tefx_rc_t\n+rhead_virtio_verify_features(\n+\t__in\t\tefx_nic_t *enp,\n+\t__in\t\tefx_virtio_device_type_t type,\n+\t__in\t\tuint64_t features)\n+{\n+\tefx_mcdi_req_t req;\n+\tEFX_MCDI_DECLARE_BUF(payload, MC_CMD_VIRTIO_TEST_FEATURES_IN_LEN,\n+\t\tMC_CMD_VIRTIO_TEST_FEATURES_OUT_LEN);\n+\tefx_rc_t rc;\n+\n+\tEFX_STATIC_ASSERT(EFX_VIRTIO_DEVICE_TYPE_NET ==\n+\t\tMC_CMD_VIRTIO_GET_FEATURES_IN_NET);\n+\tEFX_STATIC_ASSERT(EFX_VIRTIO_DEVICE_TYPE_BLOCK ==\n+\t\tMC_CMD_VIRTIO_GET_FEATURES_IN_BLOCK);\n+\n+\treq.emr_cmd = MC_CMD_VIRTIO_TEST_FEATURES;\n+\treq.emr_in_buf = payload;\n+\treq.emr_in_length = MC_CMD_VIRTIO_TEST_FEATURES_IN_LEN;\n+\treq.emr_out_buf = payload;\n+\treq.emr_out_length = MC_CMD_VIRTIO_TEST_FEATURES_OUT_LEN;\n+\n+\tMCDI_IN_SET_DWORD(req, VIRTIO_TEST_FEATURES_IN_DEVICE_ID, type);\n+\n+\tMCDI_IN_SET_DWORD(req, VIRTIO_TEST_FEATURES_IN_FEATURES_LO,\n+\t\tfeatures & 0xFFFFFFFF);\n+\tMCDI_IN_SET_DWORD(req, VIRTIO_TEST_FEATURES_IN_FEATURES_HI,\n+\t\t((features >> 32) & 0xFFFFFFFF));\n+\n+\tefx_mcdi_execute(enp, &req);\n+\n+\tif (req.emr_rc != 0) {\n+\t\trc = req.emr_rc;\n+\t\tgoto fail1;\n+\t}\n+\n+\treturn (0);\n+\n+fail1:\n+\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n+\n+\treturn (rc);\n+}\n+\n #endif\t/* EFSYS_OPT_RIVERHEAD && EFSYS_OPT_VIRTIO */\n", "prefixes": [ "v3", "5/8" ] }