Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/89131/?format=api
{ "id": 89131, "url": "https://patches.dpdk.org/api/patches/89131/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210315135823.605774-7-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210315135823.605774-7-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210315135823.605774-7-andrew.rybchenko@oktetlabs.ru", "date": "2021-03-15T13:58:21", "name": "[v2,6/8] common/sfc_efx: add support to get the device class", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "4b6abb3999967f9faa5470d6db1b7fc30343d460", "submitter": { "id": 2013, "url": "https://patches.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210315135823.605774-7-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 15659, "url": "https://patches.dpdk.org/api/series/15659/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15659", "date": "2021-03-15T13:58:15", "name": "common/sfc_efx: prepare to introduce vDPA driver", "version": 2, "mbox": "https://patches.dpdk.org/series/15659/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/89131/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/89131/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D1E53A054F;\n\tMon, 15 Mar 2021 15:00:54 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8A1BB24269A;\n\tMon, 15 Mar 2021 15:00:11 +0100 (CET)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 9850F24267F\n for <dev@dpdk.org>; Mon, 15 Mar 2021 15:00:07 +0100 (CET)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id 6BF7D7F5AE; Mon, 15 Mar 2021 17:00:07 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id 222687F5B8;\n Mon, 15 Mar 2021 16:59:48 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 222687F5B8", "Authentication-Results": "shelob.oktetlabs.ru/222687F5B8; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org,\n\tVijay Kumar Srivastava <vsrivast@xilinx.com>", "Date": "Mon, 15 Mar 2021 16:58:21 +0300", "Message-Id": "<20210315135823.605774-7-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.1", "In-Reply-To": "<20210315135823.605774-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210311110325.3291203-1-andrew.rybchenko@oktetlabs.ru>\n <20210315135823.605774-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 6/8] common/sfc_efx: add support to get the\n device class", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Vijay Kumar Srivastava <vsrivast@xilinx.com>\n\nDevice class argument would be used to select compatible driver.\nDriver probe would be skipped for incompatible device class.\n\nSigned-off-by: Vijay Kumar Srivastava <vsrivast@xilinx.com>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n drivers/common/sfc_efx/sfc_efx.c | 49 ++++++++++++++++++++++++++++++\n drivers/common/sfc_efx/sfc_efx.h | 34 +++++++++++++++++++++\n drivers/common/sfc_efx/version.map | 2 ++\n 3 files changed, 85 insertions(+)\n create mode 100644 drivers/common/sfc_efx/sfc_efx.h", "diff": "diff --git a/drivers/common/sfc_efx/sfc_efx.c b/drivers/common/sfc_efx/sfc_efx.c\nindex d7a84c9835..a3146db255 100644\n--- a/drivers/common/sfc_efx/sfc_efx.c\n+++ b/drivers/common/sfc_efx/sfc_efx.c\n@@ -7,12 +7,61 @@\n * for Solarflare) and Solarflare Communications, Inc.\n */\n \n+#include <string.h>\n #include <rte_log.h>\n+#include <rte_kvargs.h>\n+#include <rte_devargs.h>\n \n #include \"sfc_efx_log.h\"\n+#include \"sfc_efx.h\"\n \n uint32_t sfc_efx_logtype;\n \n+static int\n+sfc_efx_kvarg_dev_class_handler(__rte_unused const char *key,\n+\t\t\t\tconst char *class_str, void *opaque)\n+{\n+\tenum sfc_efx_dev_class *dev_class = opaque;\n+\n+\tif (class_str == NULL)\n+\t\treturn *dev_class;\n+\n+\tif (strcmp(class_str, \"vdpa\") == 0) {\n+\t\t*dev_class = SFC_EFX_DEV_CLASS_VDPA;\n+\t} else if (strcmp(class_str, \"net\") == 0) {\n+\t\t*dev_class = SFC_EFX_DEV_CLASS_NET;\n+\t} else {\n+\t\tSFC_EFX_LOG(ERR, \"Unsupported class %s.\", class_str);\n+\t\t*dev_class = SFC_EFX_DEV_CLASS_INVALID;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+enum sfc_efx_dev_class\n+sfc_efx_dev_class_get(struct rte_devargs *devargs)\n+{\n+\tstruct rte_kvargs *kvargs;\n+\tconst char *key = SFC_EFX_KVARG_DEV_CLASS;\n+\tenum sfc_efx_dev_class dev_class = SFC_EFX_DEV_CLASS_NET;\n+\n+\tif (devargs == NULL)\n+\t\treturn dev_class;\n+\n+\tkvargs = rte_kvargs_parse(devargs->args, NULL);\n+\tif (kvargs == NULL)\n+\t\treturn dev_class;\n+\n+\tif (rte_kvargs_count(kvargs, key) != 0) {\n+\t\trte_kvargs_process(kvargs, key, sfc_efx_kvarg_dev_class_handler,\n+\t\t\t\t &dev_class);\n+\t}\n+\n+\trte_kvargs_free(kvargs);\n+\n+\treturn dev_class;\n+}\n+\n RTE_INIT(sfc_efx_register_logtype)\n {\n \tint ret;\ndiff --git a/drivers/common/sfc_efx/sfc_efx.h b/drivers/common/sfc_efx/sfc_efx.h\nnew file mode 100644\nindex 0000000000..bbccd3e9e8\n--- /dev/null\n+++ b/drivers/common/sfc_efx/sfc_efx.h\n@@ -0,0 +1,34 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ *\n+ * Copyright(c) 2019-2020 Xilinx, Inc.\n+ * Copyright(c) 2019 Solarflare Communications Inc.\n+ *\n+ * This software was jointly developed between OKTET Labs (under contract\n+ * for Solarflare) and Solarflare Communications, Inc.\n+ */\n+\n+#ifndef _SFC_EFX_H_\n+#define _SFC_EFX_H_\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+#define SFC_EFX_KVARG_DEV_CLASS\t\"class\"\n+\n+enum sfc_efx_dev_class {\n+\tSFC_EFX_DEV_CLASS_INVALID = 0,\n+\tSFC_EFX_DEV_CLASS_NET,\n+\tSFC_EFX_DEV_CLASS_VDPA,\n+\n+\tSFC_EFX_DEV_NCLASS\n+};\n+\n+__rte_internal\n+enum sfc_efx_dev_class sfc_efx_dev_class_get(struct rte_devargs *devargs);\n+\n+#ifdef __cplusplus\n+}\n+#endif\n+\n+#endif /* _SFC_EFX_H_ */\ndiff --git a/drivers/common/sfc_efx/version.map b/drivers/common/sfc_efx/version.map\nindex 403feeaf11..a3345d34f7 100644\n--- a/drivers/common/sfc_efx/version.map\n+++ b/drivers/common/sfc_efx/version.map\n@@ -221,6 +221,8 @@ INTERNAL {\n \tefx_txq_nbufs;\n \tefx_txq_size;\n \n+\tsfc_efx_dev_class_get;\n+\n \tsfc_efx_mcdi_init;\n \tsfc_efx_mcdi_fini;\n \n", "prefixes": [ "v2", "6/8" ] }