Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/89130/?format=api
{ "id": 89130, "url": "https://patches.dpdk.org/api/patches/89130/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210315135823.605774-8-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210315135823.605774-8-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210315135823.605774-8-andrew.rybchenko@oktetlabs.ru", "date": "2021-03-15T13:58:22", "name": "[v2,7/8] net/sfc: skip driver probe for incompatible device class", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5fd30132adbb20b13005137e840b427cf08a9d92", "submitter": { "id": 2013, "url": "https://patches.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210315135823.605774-8-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 15659, "url": "https://patches.dpdk.org/api/series/15659/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15659", "date": "2021-03-15T13:58:15", "name": "common/sfc_efx: prepare to introduce vDPA driver", "version": 2, "mbox": "https://patches.dpdk.org/series/15659/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/89130/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/89130/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 101D9A054F;\n\tMon, 15 Mar 2021 15:00:46 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 665DB242695;\n\tMon, 15 Mar 2021 15:00:10 +0100 (CET)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 908F2242677\n for <dev@dpdk.org>; Mon, 15 Mar 2021 15:00:07 +0100 (CET)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id 6CF557F5B3; Mon, 15 Mar 2021 17:00:07 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id 3A6367F5BC;\n Mon, 15 Mar 2021 16:59:48 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 3A6367F5BC", "Authentication-Results": "shelob.oktetlabs.ru/3A6367F5BC; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org,\n\tVijay Kumar Srivastava <vsrivast@xilinx.com>", "Date": "Mon, 15 Mar 2021 16:58:22 +0300", "Message-Id": "<20210315135823.605774-8-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.1", "In-Reply-To": "<20210315135823.605774-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210311110325.3291203-1-andrew.rybchenko@oktetlabs.ru>\n <20210315135823.605774-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 7/8] net/sfc: skip driver probe for\n incompatible device class", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Vijay Kumar Srivastava <vsrivast@xilinx.com>\n\nDriver would be probed only for the net device class.\n\nSigned-off-by: Vijay Kumar Srivastava <vsrivast@xilinx.com>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n doc/guides/nics/sfc_efx.rst | 8 ++++++++\n drivers/net/sfc/sfc.h | 1 +\n drivers/net/sfc/sfc_ethdev.c | 7 +++++++\n drivers/net/sfc/sfc_kvargs.c | 1 +\n 4 files changed, 17 insertions(+)", "diff": "diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst\nindex b6047cf5c7..cf1269cc03 100644\n--- a/doc/guides/nics/sfc_efx.rst\n+++ b/doc/guides/nics/sfc_efx.rst\n@@ -357,6 +357,14 @@ allow option like \"-a 02:00.0,arg1=value1,...\".\n Case-insensitive 1/y/yes/on or 0/n/no/off may be used to specify\n boolean parameters value.\n \n+- ``class`` [net|vdpa] (default **net**)\n+\n+ Choose the mode of operation of ef100 device.\n+ **net** device will work as network device and will be probed by net/sfc driver.\n+ **vdpa** device will work as vdpa device and will be probed by vdpa/sfc driver.\n+ If this parameter is not specified then ef100 device will operate as\n+ network device.\n+\n - ``rx_datapath`` [auto|efx|ef10|ef10_essb] (default **auto**)\n \n Choose receive datapath implementation.\ndiff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h\nindex c2945b6ba2..b48a818adb 100644\n--- a/drivers/net/sfc/sfc.h\n+++ b/drivers/net/sfc/sfc.h\n@@ -22,6 +22,7 @@\n #include \"efx.h\"\n \n #include \"sfc_efx_mcdi.h\"\n+#include \"sfc_efx.h\"\n \n #include \"sfc_debug.h\"\n #include \"sfc_log.h\"\ndiff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 00a0fd3d02..23828c24ff 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -2161,6 +2161,13 @@ sfc_eth_dev_init(struct rte_eth_dev *dev)\n \tconst struct rte_ether_addr *from;\n \tint ret;\n \n+\tif (sfc_efx_dev_class_get(pci_dev->device.devargs) !=\n+\t\t\tSFC_EFX_DEV_CLASS_NET) {\n+\t\tSFC_GENERIC_LOG(DEBUG,\n+\t\t\t\"Incompatible device class: skip probing, should be probed by other sfc driver.\");\n+\t\treturn 1;\n+\t}\n+\n \tsfc_register_dp();\n \n \tlogtype_main = sfc_register_logtype(&pci_dev->addr,\ndiff --git a/drivers/net/sfc/sfc_kvargs.c b/drivers/net/sfc/sfc_kvargs.c\nindex c42b326ab0..0efa92ed28 100644\n--- a/drivers/net/sfc/sfc_kvargs.c\n+++ b/drivers/net/sfc/sfc_kvargs.c\n@@ -28,6 +28,7 @@ sfc_kvargs_parse(struct sfc_adapter *sa)\n \t\tSFC_KVARG_TX_DATAPATH,\n \t\tSFC_KVARG_FW_VARIANT,\n \t\tSFC_KVARG_RXD_WAIT_TIMEOUT_NS,\n+\t\tSFC_EFX_KVARG_DEV_CLASS,\n \t\tNULL,\n \t};\n \n", "prefixes": [ "v2", "7/8" ] }