Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88978/?format=api
{ "id": 88978, "url": "https://patches.dpdk.org/api/patches/88978/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210312052109.9847-2-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210312052109.9847-2-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210312052109.9847-2-somnath.kotur@broadcom.com", "date": "2021-03-12T05:21:08", "name": "[1/2] net/bnxt: fix to return count in xstats get op in all cases", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "cd780f380445a1fd6a023d3d21a662537f4eccf4", "submitter": { "id": 908, "url": "https://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210312052109.9847-2-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 15625, "url": "https://patches.dpdk.org/api/series/15625/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15625", "date": "2021-03-12T05:21:07", "name": "bnxt patches", "version": 1, "mbox": "https://patches.dpdk.org/series/15625/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/88978/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/88978/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3F4BDA00C2;\n\tFri, 12 Mar 2021 06:21:53 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C9080160836;\n\tFri, 12 Mar 2021 06:21:48 +0100 (CET)", "from relay.smtp-ext.broadcom.com (saphodev.broadcom.com\n [192.19.232.172])\n by mails.dpdk.org (Postfix) with ESMTP id 4B3BA160832;\n Fri, 12 Mar 2021 06:21:47 +0100 (CET)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (bgccx-dev-host-lnx35.bec.broadcom.net [10.123.153.55])\n (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 3672E7FCC;\n Thu, 11 Mar 2021 21:21:45 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 3672E7FCC", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1615526506;\n bh=OVFzO/kwsx/DlFXfnoyVPnyNRVLxFE5avQ8DGgIF8Cs=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=gUpUIIvpWmP4nPn20ODTYtqMRIV809k8ehd5BVWFwUViSfIfwdBfKBi/4MSy97JTs\n aNxcLmcZ2myCdJTNA+ODqXBIhbMZpb6ND1kyJoIEB1DAgNwNDEBjtbPukyyz+tcibV\n g0Rfs221CeJdUYDIYF/vIkFkD/tEyNYBeHJMSny4=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Somnath Kotur <somnath.kotur@broadcom.com>,\n stable@dpdk.org,\n Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>,\n Lance Richardson <lance.richardson@broadcom.com>", "Date": "Fri, 12 Mar 2021 10:51:08 +0530", "Message-Id": "<20210312052109.9847-2-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.28.0.450.g3a238e5", "In-Reply-To": "<20210312052109.9847-1-somnath.kotur@broadcom.com>", "References": "<20210312052109.9847-1-somnath.kotur@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/2] net/bnxt: fix to return count in xstats get\n op in all cases", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Driver was returning 0 if the 'xstats' parameter being passed to\nxstats_get_op was NULL. This won't work on some applications that\nrely on a valid count being passed even in this case so that it can\nallocate memory accordingly followed by a reissue of the xstats_get_op\nto get the actual stats populated by the driver.\n\nFixes: 063e59ddd28 (\"net/bnxt: fix crash in xstats get\")\nCc: stable@dpdk.org\n\nReviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Lance Richardson <lance.richardson@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_stats.c | 23 +++++++++--------------\n 1 file changed, 9 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c\nindex 01d90dee8d..bb4b2eee19 100644\n--- a/drivers/net/bnxt/bnxt_stats.c\n+++ b/drivers/net/bnxt/bnxt_stats.c\n@@ -594,10 +594,15 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,\n \tif (rc)\n \t\treturn rc;\n \n-\tif (xstats == NULL)\n-\t\treturn 0;\n+\tstat_count = RTE_DIM(bnxt_rx_stats_strings) +\n+\t\tRTE_DIM(bnxt_tx_stats_strings) +\n+\t\tRTE_DIM(bnxt_func_stats_strings) +\n+\t\tRTE_DIM(bnxt_rx_ext_stats_strings) +\n+\t\tRTE_DIM(bnxt_tx_ext_stats_strings) +\n+\t\tbnxt_flow_stats_cnt(bp);\n \n-\tmemset(xstats, 0, sizeof(*xstats));\n+\tif (n < stat_count || xstats == NULL)\n+\t\treturn stat_count;\n \n \tbnxt_hwrm_func_qstats(bp, 0xffff, NULL, &func_qstats);\n \tbnxt_hwrm_port_qstats(bp);\n@@ -609,17 +614,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,\n \t\t\t\t\t(bp->fw_tx_port_stats_ext_size /\n \t\t\t\t\t stat_size));\n \n-\tcount = RTE_DIM(bnxt_rx_stats_strings) +\n-\t\tRTE_DIM(bnxt_tx_stats_strings) +\n-\t\tRTE_DIM(bnxt_func_stats_strings) +\n-\t\tRTE_DIM(bnxt_rx_ext_stats_strings) +\n-\t\tRTE_DIM(bnxt_tx_ext_stats_strings) +\n-\t\tbnxt_flow_stats_cnt(bp);\n-\n-\tstat_count = count;\n-\n-\tif (n < count)\n-\t\treturn count;\n+\tmemset(xstats, 0, sizeof(*xstats));\n \n \tcount = 0;\n \tfor (i = 0; i < RTE_DIM(bnxt_rx_stats_strings); i++) {\n", "prefixes": [ "1/2" ] }