Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88910/?format=api
{ "id": 88910, "url": "https://patches.dpdk.org/api/patches/88910/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210310212637.72205-12-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210310212637.72205-12-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210310212637.72205-12-ajit.khaparde@broadcom.com", "date": "2021-03-10T21:26:36", "name": "[v2,11/12] net/bnxt: fix FW readiness check during recovery", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "d7ce7ce08e16766243b1f8d068dccce44fdc3566", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210310212637.72205-12-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 15591, "url": "https://patches.dpdk.org/api/series/15591/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15591", "date": "2021-03-10T21:26:25", "name": "bnxt fixes", "version": 2, "mbox": "https://patches.dpdk.org/series/15591/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/88910/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/88910/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2DEF2A056A;\n\tWed, 10 Mar 2021 22:28:10 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B13C222A61B;\n\tWed, 10 Mar 2021 22:27:10 +0100 (CET)", "from mail-pg1-f176.google.com (mail-pg1-f176.google.com\n [209.85.215.176])\n by mails.dpdk.org (Postfix) with ESMTP id 7CC7222A59C\n for <dev@dpdk.org>; Wed, 10 Mar 2021 22:27:06 +0100 (CET)", "by mail-pg1-f176.google.com with SMTP id x29so12255575pgk.6\n for <dev@dpdk.org>; Wed, 10 Mar 2021 13:27:06 -0800 (PST)", "from localhost.localdomain ([192.19.228.250])\n by smtp.gmail.com with ESMTPSA id f2sm265059pju.46.2021.03.10.13.27.04\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 10 Mar 2021 13:27:04 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version; bh=AJj/0vy2mvqSsoPPEPyaxXJWVjx1BRqPe749wyeY+CU=;\n b=JgZzmh4HFOCbVEVSCGkNao4lS5CLS3+NEpM+/9ob7UGJQhif2cLGIDird3YlZfXgy8\n EMOQrV3fRxZyaPIvIgCHAwAN55N1Tspr2G+ZQGCUgdTBRYEXzTO97Ya3xYt3piIElDfG\n 7yGFeDXULbDjZWEkxOW/qoRew25WuV3xqNHHU=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version;\n bh=AJj/0vy2mvqSsoPPEPyaxXJWVjx1BRqPe749wyeY+CU=;\n b=RcZOKzvPvxl3gg+nk5g0aZNdFF6pdCG3enxvRWLGkdzfSZT59uQPzkZJU9UL6Z/TaK\n wa4phQSIfrSh0ju6SKCMw855mp+W6fN4g5KVrBPY/91hUQgaN5PTORkOnYx66FzVUo6a\n DmbhLNihF49PSwW3U8kZPaKHcXXPnd/Q3iG+XQ+v3zhGvuXmxMxh4dBgXU+LmzznbYwD\n /YBEmQ24oiI3uF+a30aegD8gJIwzNQEpi9kKC2YTcbAXl00FV4qRsx9bsWDzEqhwpGId\n W9HnYl3cR2FnVQL4Y5YSGT6pRFm9Gr3N98LOMzH6pXqrryMceGl0/7RVJXqE12A5LBcm\n mavw==", "X-Gm-Message-State": "AOAM532Xcqf7TLIaPFfH3vroQXPJ+LeHVjTLyJjSZFdOhfZkJaeHnHHA\n IeQSLv4YOVJBDerUpS+J5k76Uw==", "X-Google-Smtp-Source": "\n ABdhPJxtXI35N/hZ6EDyR/8T3xeTnGbgI1ZTe/3aDA6jvPGk89+oxz4M+znaAOQ57vusyt7qaXpbEg==", "X-Received": "by 2002:aa7:80c6:0:b029:1b6:92ae:a199 with SMTP id\n a6-20020aa780c60000b02901b692aea199mr4588489pfn.71.1615411625598;\n Wed, 10 Mar 2021 13:27:05 -0800 (PST)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "ferruh.yigit@intel.com", "Cc": "ajit.khaparde@broadcom.com, dev@dpdk.org,\n kalesh-anakkur.purayil@broadcom.com, stable@dpdk.org,\n Somnath Kotur <somnath.kotur@broadcom.com>", "Date": "Wed, 10 Mar 2021 13:26:36 -0800", "Message-Id": "<20210310212637.72205-12-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20210310212637.72205-1-ajit.khaparde@broadcom.com>", "References": "<d3d41dec-035d-7dd5-ec5b-cd9f6f3536cb@intel.com>\n <20210310212637.72205-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; protocol=\"application/pkcs7-signature\";\n micalg=sha-256; boundary=\"000000000000221ad005bd3554fd\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.29", "Subject": "[dpdk-dev] [PATCH v2 11/12] net/bnxt: fix FW readiness check during\n recovery", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nMoved fw readiness check to a new routine bnxt_check_fw_ready().\n\nDuring error recovery, driver needs to wait for fw readiness.\nFor that, it uses bnxt_hwrm_ver_get() function now and that\nfunction does parsing of the VER_GET response as well.\n\nAdded a new lightweight function bnxt_hwrm_poll_ver_get() for polling\nthe firmware readiness which issues VER_GET and checks for success\nwithout processing the command response.\n\nFixes: df6cd7c1f73a (\"net/bnxt: handle reset notify async event from FW\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 33 +++++++++++++++++++++------------\n drivers/net/bnxt/bnxt_hwrm.c | 22 ++++++++++++++++++++++\n drivers/net/bnxt/bnxt_hwrm.h | 1 +\n 3 files changed, 44 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 67ff800da5..af146451a5 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -3859,10 +3859,28 @@ static int bnxt_restore_filters(struct bnxt *bp)\n \treturn ret;\n }\n \n+static int bnxt_check_fw_ready(struct bnxt *bp)\n+{\n+\tint timeout = bp->fw_reset_max_msecs;\n+\tint rc = 0;\n+\n+\tdo {\n+\t\trc = bnxt_hwrm_poll_ver_get(bp);\n+\t\tif (rc == 0)\n+\t\t\tbreak;\n+\t\trte_delay_ms(BNXT_FW_READY_WAIT_INTERVAL);\n+\t\ttimeout -= BNXT_FW_READY_WAIT_INTERVAL;\n+\t} while (rc && timeout > 0);\n+\n+\tif (rc)\n+\t\tPMD_DRV_LOG(ERR, \"FW is not Ready after reset\\n\");\n+\n+\treturn rc;\n+}\n+\n static void bnxt_dev_recover(void *arg)\n {\n \tstruct bnxt *bp = arg;\n-\tint timeout = bp->fw_reset_max_msecs;\n \tint rc = 0;\n \n \tpthread_mutex_lock(&bp->err_recovery_lock);\n@@ -3876,18 +3894,9 @@ static void bnxt_dev_recover(void *arg)\n \t/* Clear Error flag so that device re-init should happen */\n \tbp->flags &= ~BNXT_FLAG_FATAL_ERROR;\n \n-\tdo {\n-\t\trc = bnxt_hwrm_ver_get(bp, SHORT_HWRM_CMD_TIMEOUT);\n-\t\tif (rc == 0)\n-\t\t\tbreak;\n-\t\trte_delay_ms(BNXT_FW_READY_WAIT_INTERVAL);\n-\t\ttimeout -= BNXT_FW_READY_WAIT_INTERVAL;\n-\t} while (rc && timeout);\n-\n-\tif (rc) {\n-\t\tPMD_DRV_LOG(ERR, \"FW is not Ready after reset\\n\");\n+\trc = bnxt_check_fw_ready(bp);\n+\tif (rc)\n \t\tgoto err;\n-\t}\n \n \trc = bnxt_init_resources(bp, true);\n \tif (rc) {\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 9142119954..0b5318e238 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -5913,3 +5913,25 @@ int bnxt_hwrm_fw_echo_reply(struct bnxt *bp, uint32_t echo_req_data1,\n \n \treturn rc;\n }\n+\n+int bnxt_hwrm_poll_ver_get(struct bnxt *bp)\n+{\n+\tstruct hwrm_ver_get_input req = {.req_type = 0 };\n+\tstruct hwrm_ver_get_output *resp = bp->hwrm_cmd_resp_addr;\n+\tint rc = 0;\n+\n+\tbp->max_req_len = HWRM_MAX_REQ_LEN;\n+\tbp->hwrm_cmd_timeout = SHORT_HWRM_CMD_TIMEOUT;\n+\n+\tHWRM_PREP(&req, HWRM_VER_GET, BNXT_USE_CHIMP_MB);\n+\treq.hwrm_intf_maj = HWRM_VERSION_MAJOR;\n+\treq.hwrm_intf_min = HWRM_VERSION_MINOR;\n+\treq.hwrm_intf_upd = HWRM_VERSION_UPDATE;\n+\n+\trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n+\n+\tHWRM_CHECK_RESULT_SILENT();\n+\tHWRM_UNLOCK();\n+\n+\treturn rc;\n+}\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h\nindex c47c2498e9..785e321bfd 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.h\n+++ b/drivers/net/bnxt/bnxt_hwrm.h\n@@ -304,4 +304,5 @@ int bnxt_hwrm_cfa_pair_free(struct bnxt *bp, struct bnxt_representor *rep);\n int bnxt_hwrm_cfa_adv_flow_mgmt_qcaps(struct bnxt *bp);\n int bnxt_hwrm_fw_echo_reply(struct bnxt *bp, uint32_t echo_req_data1,\n \t\t\t uint32_t echo_req_data2);\n+int bnxt_hwrm_poll_ver_get(struct bnxt *bp);\n #endif\n", "prefixes": [ "v2", "11/12" ] }