Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88836/?format=api
{ "id": 88836, "url": "https://patches.dpdk.org/api/patches/88836/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210310121626.2019863-6-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210310121626.2019863-6-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210310121626.2019863-6-qi.z.zhang@intel.com", "date": "2021-03-10T12:16:23", "name": "[5/8] net/iavf: refine debug compile option", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5b75281e21b2321e108c23f915af5ba40c822775", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210310121626.2019863-6-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 15577, "url": "https://patches.dpdk.org/api/series/15577/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15577", "date": "2021-03-10T12:16:18", "name": "ether: refine debug compile option", "version": 1, "mbox": "https://patches.dpdk.org/series/15577/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/88836/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/88836/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 72684A0567;\n\tWed, 10 Mar 2021 13:13:15 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1324F22A553;\n\tWed, 10 Mar 2021 13:13:15 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 0ACB422A546\n for <dev@dpdk.org>; Wed, 10 Mar 2021 13:13:12 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Mar 2021 04:12:52 -0800", "from dpdk51.sh.intel.com ([10.67.111.142])\n by fmsmga005.fm.intel.com with ESMTP; 10 Mar 2021 04:12:50 -0800" ], "IronPort-SDR": [ "\n 9ydpT3Hfe78PYuf5I++VAjOpnnxPsgw264wDBiGceVwbM2VGWM8/2O/5BFsJL5zJCi9sLvSO7L\n lWG1Szmvt0AQ==", "\n L9deNpCP8s5ZMw4TeyOjLkRAnq7vE7w4VX/hY7svh4j4xpy3LBaRDWeF9AUiGxOMt8CAbv2Q5s\n HfkNEc3ITs4g==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9917\"; a=\"187812399\"", "E=Sophos;i=\"5.81,237,1610438400\"; d=\"scan'208\";a=\"187812399\"", "E=Sophos;i=\"5.81,237,1610438400\"; d=\"scan'208\";a=\"603065452\"" ], "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, xiao.w.wang@intel.com, jingjing.wu@intel.com,\n beilei.xing@intel.com, jia.guo@intel.com, qiming.yang@intel.com,\n haiyue.wang@intel.comi, Qi Zhang <qi.z.zhang@intel.com>", "Date": "Wed, 10 Mar 2021 20:16:23 +0800", "Message-Id": "<20210310121626.2019863-6-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20210310121626.2019863-1-qi.z.zhang@intel.com>", "References": "<20210310121626.2019863-1-qi.z.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 5/8] net/iavf: refine debug compile option", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "1. replace RTE_LIBRTE_IAVF_DEBUG_RX with RTE_LIBRTE_ETHDEV_DEBUG_RX.\n2. replace RTE_LIBRTE_IAVF_DEBUG_TX whth RTE_LIBRTE_ETHDEV_DEBUG_TX.\n3. merge RTE_LIBRTE_IAVF_DEBUG_TX_FREE and RTE_LIBRTE_ETHDEV_DEBUG\n into RTE_LIBRTE_ETHDEV_DEBUG_TX\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/iavf/iavf_ethdev.c | 7 ++-----\n drivers/net/iavf/iavf_log.h | 13 ++-----------\n drivers/net/iavf/iavf_rxtx.c | 8 ++++----\n 3 files changed, 8 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex 4d37722022..863160135f 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -2360,12 +2360,9 @@ RTE_PMD_REGISTER_KMOD_DEP(net_iavf, \"* igb_uio | vfio-pci\");\n RTE_PMD_REGISTER_PARAM_STRING(net_iavf, \"cap=dcf\");\n RTE_LOG_REGISTER(iavf_logtype_init, pmd.net.iavf.init, NOTICE);\n RTE_LOG_REGISTER(iavf_logtype_driver, pmd.net.iavf.driver, NOTICE);\n-#ifdef RTE_LIBRTE_IAVF_DEBUG_RX\n+#ifdef RTE_LIBRTE_ETHDEV_DEBUG_RX\n RTE_LOG_REGISTER(iavf_logtype_rx, pmd.net.iavf.rx, DEBUG);\n #endif\n-#ifdef RTE_LIBRTE_IAVF_DEBUG_TX\n+#ifdef RTE_LIBRTE_ETHDEV_DEBUG_TX\n RTE_LOG_REGISTER(iavf_logtype_tx, pmd.net.iavf.tx, DEBUG);\n #endif\n-#ifdef RTE_LIBRTE_IAVF_DEBUG_TX_FREE\n-RTE_LOG_REGISTER(iavf_logtype_tx_free, pmd.net.iavf.tx_free, DEBUG);\n-#endif\ndiff --git a/drivers/net/iavf/iavf_log.h b/drivers/net/iavf/iavf_log.h\nindex 1088ec75f5..c83f09cc25 100644\n--- a/drivers/net/iavf/iavf_log.h\n+++ b/drivers/net/iavf/iavf_log.h\n@@ -21,7 +21,7 @@ extern int iavf_logtype_driver;\n #define PMD_DRV_FUNC_TRACE() PMD_DRV_LOG(DEBUG, \" >>\")\n \n \n-#ifdef RTE_LIBRTE_IAVF_DEBUG_RX\n+#ifdef RTE_LIBRTE_ETHDEV_DEBUG_RX\n extern int iavf_logtype_rx;\n #define PMD_RX_LOG(level, fmt, args...)\t\t\t\\\n \trte_log(RTE_LOG_ ## level, iavf_logtype_rx,\t\\\n@@ -30,7 +30,7 @@ extern int iavf_logtype_rx;\n #define PMD_RX_LOG(level, fmt, args...) do { } while (0)\n #endif\n \n-#ifdef RTE_LIBRTE_IAVF_DEBUG_TX\n+#ifdef RTE_LIBRTE_ETHDEV_DEBUG_TX\n extern int iavf_logtype_tx;\n #define PMD_TX_LOG(level, fmt, args...)\t\t\t\\\n \trte_log(RTE_LOG_ ## level, iavf_logtype_tx,\t\\\n@@ -39,13 +39,4 @@ extern int iavf_logtype_tx;\n #define PMD_TX_LOG(level, fmt, args...) do { } while (0)\n #endif\n \n-#ifdef RTE_LIBRTE_IAVF_DEBUG_TX_FREE\n-extern int iavf_logtype_tx_free;\n-#define PMD_TX_FREE_LOG(level, fmt, args...)\t\t\t\\\n-\trte_log(RTE_LOG_ ## level, iavf_logtype_tx_free,\t\\\n-\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n-#else\n-#define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0)\n-#endif\n-\n #endif /* _IAVF_LOG_H_ */\ndiff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c\nindex 8fafe4579b..c4611c0431 100644\n--- a/drivers/net/iavf/iavf_rxtx.c\n+++ b/drivers/net/iavf/iavf_rxtx.c\n@@ -1979,9 +1979,9 @@ iavf_xmit_cleanup(struct iavf_tx_queue *txq)\n \tif ((txd[desc_to_clean_to].cmd_type_offset_bsz &\n \t\t\trte_cpu_to_le_64(IAVF_TXD_QW1_DTYPE_MASK)) !=\n \t\t\trte_cpu_to_le_64(IAVF_TX_DESC_DTYPE_DESC_DONE)) {\n-\t\tPMD_TX_FREE_LOG(DEBUG, \"TX descriptor %4u is not done \"\n-\t\t\t\t\"(port=%d queue=%d)\", desc_to_clean_to,\n-\t\t\t\ttxq->port_id, txq->queue_id);\n+\t\tPMD_TX_LOG(DEBUG, \"TX descriptor %4u is not done \"\n+\t\t\t \"(port=%d queue=%d)\", desc_to_clean_to,\n+\t\t\t txq->port_id, txq->queue_id);\n \t\treturn -1;\n \t}\n \n@@ -2335,7 +2335,7 @@ iavf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\treturn i;\n \t\t}\n \n-#ifdef RTE_LIBRTE_ETHDEV_DEBUG\n+#ifdef RTE_LIBRTE_ETHDEV_DEBUG_TX\n \t\tret = rte_validate_tx_offload(m);\n \t\tif (ret != 0) {\n \t\t\trte_errno = -ret;\n", "prefixes": [ "5/8" ] }