Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88768/?format=api
{ "id": 88768, "url": "https://patches.dpdk.org/api/patches/88768/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210309233116.1934666-9-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210309233116.1934666-9-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20210309233116.1934666-9-thomas@monjalon.net", "date": "2021-03-09T23:31:12", "name": "[08/11] app: fix exit messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "05e85b60a777b4105b23fe5a7399d76ad5336d75", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210309233116.1934666-9-thomas@monjalon.net/mbox/", "series": [ { "id": 15554, "url": "https://patches.dpdk.org/api/series/15554/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15554", "date": "2021-03-09T23:31:04", "name": "improve options help", "version": 1, "mbox": "https://patches.dpdk.org/series/15554/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/88768/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/88768/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 238B8A0567;\n\tWed, 10 Mar 2021 00:32:35 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2744022A577;\n\tWed, 10 Mar 2021 00:31:54 +0100 (CET)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id B783322A577\n for <dev@dpdk.org>; Wed, 10 Mar 2021 00:31:51 +0100 (CET)", "from compute4.internal (compute4.nyi.internal [10.202.2.44])\n by mailout.nyi.internal (Postfix) with ESMTP id 69B705C009A;\n Tue, 9 Mar 2021 18:31:51 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute4.internal (MEProxy); Tue, 09 Mar 2021 18:31:51 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 4AC2C24005C;\n Tue, 9 Mar 2021 18:31:50 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm3; bh=Fgfo1neXw1UDf\n P7XX3YHJ166s5XmszJQa+uhOpXiX+g=; b=ePDDEIaiW6kKKPsOsHQthCsc8YDNj\n ZjThEREwVXVvSlOTGZAuM7QoRlQZeqbhdnjxhcgBEi12pZz8stgAiJR6snigmgjm\n dRTnDy/WrE8WjCju1K3xrZZ7o27FQAGBn2UgB0D8aE5xbsCAsh1BGPJC3ntGYRfu\n FEiMjLEBaPfPbo4+Oc2ctus7WIm9Vmx2eWUEKAGiq7P8iz3n0yqAVOywCU/3nZo7\n 5DcJ6PDAJcEd1Fe3j5BIgKJuUfBv0gdL6IPl8yzU/++IzAViHc/xNkMpR9o/fvxN\n 4pyvHhW6m7FKg9WPews83i9lsOGjistJRh0XzKN6IpK/G3+xYfbL8rC9w==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm2; bh=Fgfo1neXw1UDfP7XX3YHJ166s5XmszJQa+uhOpXiX+g=; b=WX9pEwI1\n hsMZOFP4eq9bfdRoQfRXIr6jxeCKH9roPl1gEZt7gWlWTVmBle+LKFf5FK8cDb1Q\n +i7c9sRmglsUHnJf/dMhQS8uR9QkdwpY6VmXGfdbd34D4ur2dmhIV5z8w2eZMB8M\n +OCVFMmW3l0+UP/lduShFCe8Ujefh7cNUJEBTkzWYcQar3mN8YzvVfEXVcXwhzmZ\n pPi7b2xBrA5zqrnwxwr7K2+lbzRwiz3hRz/kOLRxXtZQqxrdBBDi4bLvR82C2/IP\n oB68anKAeZ7YiojniAjg2KbLnzqXPkpgRoVlulrBDjVvVqrGF4QvAiPle6CtWyDa\n +aKU5rCinhpiYg==" ], "X-ME-Sender": "<xms:ZwVIYFxCmjnVZQmRupkXd-j_QkhVoN0l2h2CIbUXQRl5cLrOLS8z2A>\n <xme:ZwVIYDhvlXXaRF86SSz7IEQCoNr02XfYs4wCGZpNGpcXq1jEeTuEpoKjB5oH5XFyB\n fC_84S8HeN8fvNOSg>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduledrudduiedgudejfecutefuodetggdotefrod\n ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh\n necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd\n enucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhm\n rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc\n ggtffrrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedt\n gfeutdehtdegveenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh\n fuihiivgepvdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr\n lhhonhdrnhgvth", "X-ME-Proxy": "<xmx:ZwVIYIruemHzWEbwPR9Mh-eWQVz9-M6lMOt5HpIhNG9sQt0uEed4Iw>\n <xmx:ZwVIYKhfxH3dbAlZInNStxdo98hi-bFRxtIHE46Z9WSSpzMX2yT7Cg>\n <xmx:ZwVIYKPFOKnAukPjL_Gjw2lLbtwxOlzpM7NWh7R5VkhBavMO0sLf7A>\n <xmx:ZwVIYO5MI4RUI9p2bw1CBm59UtLOajyTqTFoz7m-0SXLm3yHOA6bdQ>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, Declan Doherty <declan.doherty@intel.com>,\n Ciara Power <ciara.power@intel.com>, Wisam Jaddo <wisamm@nvidia.com>,\n Xiaoyun Li <xiaoyun.li@intel.com>, Ori Kam <orika@nvidia.com>", "Date": "Wed, 10 Mar 2021 00:31:12 +0100", "Message-Id": "<20210309233116.1934666-9-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.30.1", "In-Reply-To": "<20210309233116.1934666-1-thomas@monjalon.net>", "References": "<20210309233116.1934666-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 08/11] app: fix exit messages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some applications were printing useless messages with rte_exit()\nafter showing the help. Using exit() is enough in this case.\n\nSome applications were using a redundant printf or fprintf() before\ncalling rte_exit(). The messages are unified in a single rte_exit().\n\nSome rte_exit() calls were missing a line feed or returning a wrong code.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n .../comp_perf_options_parse.c | 2 +-\n app/test-crypto-perf/cperf_options_parsing.c | 2 +-\n app/test-flow-perf/main.c | 59 +++++++++----------\n app/test-pmd/parameters.c | 4 +-\n app/test-regex/main.c | 3 +-\n 5 files changed, 33 insertions(+), 37 deletions(-)", "diff": "diff --git a/app/test-compress-perf/comp_perf_options_parse.c b/app/test-compress-perf/comp_perf_options_parse.c\nindex 04a8d2fbee..019eddb7bd 100644\n--- a/app/test-compress-perf/comp_perf_options_parse.c\n+++ b/app/test-compress-perf/comp_perf_options_parse.c\n@@ -620,7 +620,7 @@ comp_perf_options_parse(struct comp_test_data *test_data, int argc, char **argv)\n \t\tswitch (opt) {\n \t\tcase 'h':\n \t\t\tusage(argv[0]);\n-\t\t\trte_exit(EXIT_SUCCESS, \"Displayed help\\n\");\n+\t\t\texit(EXIT_SUCCESS);\n \t\t\tbreak;\n \t\t/* long options */\n \t\tcase 0:\ndiff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c\nindex 0466f7baf8..40b6dfb648 100644\n--- a/app/test-crypto-perf/cperf_options_parsing.c\n+++ b/app/test-crypto-perf/cperf_options_parsing.c\n@@ -983,7 +983,7 @@ cperf_options_parse(struct cperf_options *options, int argc, char **argv)\n \t\tswitch (opt) {\n \t\tcase 'h':\n \t\t\tusage(argv[0]);\n-\t\t\trte_exit(EXIT_SUCCESS, \"Displayed help\\n\");\n+\t\t\texit(EXIT_SUCCESS);\n \t\t\tbreak;\n \t\t/* long options */\n \t\tcase 0:\ndiff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c\nindex 99d0463456..0aef767350 100644\n--- a/app/test-flow-perf/main.c\n+++ b/app/test-flow-perf/main.c\n@@ -639,7 +639,7 @@ args_parse(int argc, char **argv)\n \t\tcase 0:\n \t\t\tif (strcmp(lgopts[opt_idx].name, \"help\") == 0) {\n \t\t\t\tusage(argv[0]);\n-\t\t\t\trte_exit(EXIT_SUCCESS, \"Displayed help\\n\");\n+\t\t\t\texit(EXIT_SUCCESS);\n \t\t\t}\n \n \t\t\tif (strcmp(lgopts[opt_idx].name, \"group\") == 0) {\n@@ -647,7 +647,7 @@ args_parse(int argc, char **argv)\n \t\t\t\tif (n >= 0)\n \t\t\t\t\tflow_group = n;\n \t\t\t\telse\n-\t\t\t\t\trte_exit(EXIT_SUCCESS,\n+\t\t\t\t\trte_exit(EXIT_FAILURE,\n \t\t\t\t\t\t\"flow group should be >= 0\\n\");\n \t\t\t\tprintf(\"group %d / \", flow_group);\n \t\t\t}\n@@ -667,7 +667,7 @@ args_parse(int argc, char **argv)\n \t\t\t\tif (n > 0)\n \t\t\t\t\thairpin_queues_num = n;\n \t\t\t\telse\n-\t\t\t\t\trte_exit(EXIT_SUCCESS,\n+\t\t\t\t\trte_exit(EXIT_FAILURE,\n \t\t\t\t\t\t\"Hairpin queues should be > 0\\n\");\n \n \t\t\t\tflow_actions[actions_idx++] =\n@@ -680,7 +680,7 @@ args_parse(int argc, char **argv)\n \t\t\t\tif (n > 0)\n \t\t\t\t\thairpin_queues_num = n;\n \t\t\t\telse\n-\t\t\t\t\trte_exit(EXIT_SUCCESS,\n+\t\t\t\t\trte_exit(EXIT_FAILURE,\n \t\t\t\t\t\t\"Hairpin queues should be > 0\\n\");\n \n \t\t\t\tflow_actions[actions_idx++] =\n@@ -704,11 +704,9 @@ args_parse(int argc, char **argv)\n \t\t\t\t\t\t\tbreak;\n \t\t\t\t\t\t}\n \t\t\t\t\t\t/* Reached last item with no match */\n-\t\t\t\t\t\tif (i == (RTE_DIM(flow_options) - 1)) {\n-\t\t\t\t\t\t\tfprintf(stderr, \"Invalid encap item: %s\\n\", token);\n-\t\t\t\t\t\t\tusage(argv[0]);\n-\t\t\t\t\t\t\trte_exit(EXIT_SUCCESS, \"Invalid encap item\\n\");\n-\t\t\t\t\t\t}\n+\t\t\t\t\t\tif (i == (RTE_DIM(flow_options) - 1))\n+\t\t\t\t\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\t\t\t\t\"Invalid encap item: %s\\n\", token);\n \t\t\t\t\t}\n \t\t\t\t\ttoken = strtok(NULL, \",\");\n \t\t\t\t}\n@@ -730,11 +728,9 @@ args_parse(int argc, char **argv)\n \t\t\t\t\t\t\tbreak;\n \t\t\t\t\t\t}\n \t\t\t\t\t\t/* Reached last item with no match */\n-\t\t\t\t\t\tif (i == (RTE_DIM(flow_options) - 1)) {\n-\t\t\t\t\t\t\tfprintf(stderr, \"Invalid decap item: %s\\n\", token);\n-\t\t\t\t\t\t\tusage(argv[0]);\n-\t\t\t\t\t\t\trte_exit(EXIT_SUCCESS, \"Invalid decap item\\n\");\n-\t\t\t\t\t\t}\n+\t\t\t\t\t\tif (i == (RTE_DIM(flow_options) - 1))\n+\t\t\t\t\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\t\t\t\t\"Invalid decap item %s\\n\", token);\n \t\t\t\t\t}\n \t\t\t\t\ttoken = strtok(NULL, \",\");\n \t\t\t\t}\n@@ -747,9 +743,9 @@ args_parse(int argc, char **argv)\n \t\t\t\tif (n >= DEFAULT_RULES_BATCH)\n \t\t\t\t\trules_batch = n;\n \t\t\t\telse {\n-\t\t\t\t\tprintf(\"\\n\\nrules_batch should be >= %d\\n\",\n+\t\t\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\t\t\"rules_batch should be >= %d\\n\",\n \t\t\t\t\t\tDEFAULT_RULES_BATCH);\n-\t\t\t\t\trte_exit(EXIT_SUCCESS, \" \");\n \t\t\t\t}\n \t\t\t}\n \t\t\tif (strcmp(lgopts[opt_idx].name,\n@@ -758,7 +754,8 @@ args_parse(int argc, char **argv)\n \t\t\t\tif (n >= (int) rules_batch)\n \t\t\t\t\trules_count = n;\n \t\t\t\telse {\n-\t\t\t\t\tprintf(\"\\n\\nrules_count should be >= %d\\n\",\n+\t\t\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\t\t\"rules_count should be >= %d\\n\",\n \t\t\t\t\t\trules_batch);\n \t\t\t\t}\n \t\t\t}\n@@ -786,23 +783,23 @@ args_parse(int argc, char **argv)\n \t\t\tif (strcmp(lgopts[opt_idx].name, \"cores\") == 0) {\n \t\t\t\tn = atoi(optarg);\n \t\t\t\tif ((int) rte_lcore_count() <= n) {\n-\t\t\t\t\tprintf(\"\\nError: you need %d cores to run on multi-cores\\n\"\n+\t\t\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\t\t\"Error: you need %d cores to run on multi-cores\\n\"\n \t\t\t\t\t\t\"Existing cores are: %d\\n\", n, rte_lcore_count());\n-\t\t\t\t\trte_exit(EXIT_FAILURE, \" \");\n \t\t\t\t}\n \t\t\t\tif (n <= RTE_MAX_LCORE && n > 0)\n \t\t\t\t\tmc_pool.cores_count = n;\n \t\t\t\telse {\n-\t\t\t\t\tprintf(\"Error: cores count must be > 0 \"\n-\t\t\t\t\t\t\" and < %d\\n\", RTE_MAX_LCORE);\n-\t\t\t\t\trte_exit(EXIT_FAILURE, \" \");\n+\t\t\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\t\t\"Error: cores count must be > 0 and < %d\\n\",\n+\t\t\t\t\t\tRTE_MAX_LCORE);\n \t\t\t\t}\n \t\t\t}\n \t\t\tbreak;\n \t\tdefault:\n-\t\t\tfprintf(stderr, \"Invalid option: %s\\n\", argv[optind]);\n \t\t\tusage(argv[0]);\n-\t\t\trte_exit(EXIT_SUCCESS, \"Invalid option\\n\");\n+\t\t\trte_exit(EXIT_FAILURE, \"Invalid option: %s\\n\",\n+\t\t\t\t\targv[optind]);\n \t\t\tbreak;\n \t\t}\n \t}\n@@ -936,7 +933,7 @@ create_meter_rule(int port_id, uint32_t counter)\n \t\tprintf(\"Port %u create meter idx(%d) error(%d) message: %s\\n\",\n \t\t\tport_id, counter, error.type,\n \t\t\terror.message ? error.message : \"(no stated reason)\");\n-\t\trte_exit(EXIT_FAILURE, \"error in creating meter\");\n+\t\trte_exit(EXIT_FAILURE, \"Error in creating meter\\n\");\n \t}\n }\n \n@@ -949,7 +946,7 @@ destroy_meter_rule(int port_id, uint32_t counter)\n \t\tprintf(\"Port %u destroy meter(%d) error(%d) message: %s\\n\",\n \t\t\tport_id, counter, error.type,\n \t\t\terror.message ? error.message : \"(no stated reason)\");\n-\t\trte_exit(EXIT_FAILURE, \"Error in deleting meter rule\");\n+\t\trte_exit(EXIT_FAILURE, \"Error in deleting meter rule\\n\");\n \t}\n }\n \n@@ -1097,7 +1094,7 @@ destroy_flows(int port_id, uint8_t core_id, struct rte_flow **flows_list)\n \t\tmemset(&error, 0x33, sizeof(error));\n \t\tif (rte_flow_destroy(port_id, flows_list[i], &error)) {\n \t\t\tprint_flow_error(error);\n-\t\t\trte_exit(EXIT_FAILURE, \"Error in deleting flow\");\n+\t\t\trte_exit(EXIT_FAILURE, \"Error in deleting flow\\n\");\n \t\t}\n \n \t\t/*\n@@ -1160,7 +1157,7 @@ insert_flows(int port_id, uint8_t core_id)\n \tflows_list = rte_zmalloc(\"flows_list\",\n \t\t(sizeof(struct rte_flow *) * rules_count_per_core) + 1, 0);\n \tif (flows_list == NULL)\n-\t\trte_exit(EXIT_FAILURE, \"No Memory available!\");\n+\t\trte_exit(EXIT_FAILURE, \"No Memory available!\\n\");\n \n \tcpu_time_used = 0;\n \tflow_index = 0;\n@@ -1180,7 +1177,7 @@ insert_flows(int port_id, uint8_t core_id)\n \n \t\tif (flow == NULL) {\n \t\t\tprint_flow_error(error);\n-\t\t\trte_exit(EXIT_FAILURE, \"error in creating flow\");\n+\t\t\trte_exit(EXIT_FAILURE, \"Error in creating flow\\n\");\n \t\t}\n \t\tflows_list[flow_index++] = flow;\n \t}\n@@ -1199,7 +1196,7 @@ insert_flows(int port_id, uint8_t core_id)\n \n \t\tif (!flow) {\n \t\t\tprint_flow_error(error);\n-\t\t\trte_exit(EXIT_FAILURE, \"error in creating flow\");\n+\t\t\trte_exit(EXIT_FAILURE, \"Error in creating flow\\n\");\n \t\t}\n \n \t\tflows_list[flow_index++] = flow;\n@@ -1517,7 +1514,7 @@ packet_per_second_stats(void)\n \told = rte_zmalloc(\"old\",\n \t\tsizeof(struct lcore_info) * RTE_MAX_LCORE, 0);\n \tif (old == NULL)\n-\t\trte_exit(EXIT_FAILURE, \"No Memory available!\");\n+\t\trte_exit(EXIT_FAILURE, \"No Memory available!\\n\");\n \n \tmemcpy(old, lcore_infos,\n \t\tsizeof(struct lcore_info) * RTE_MAX_LCORE);\ndiff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c\nindex c8acd5d1b7..55ecea6338 100644\n--- a/app/test-pmd/parameters.c\n+++ b/app/test-pmd/parameters.c\n@@ -632,7 +632,7 @@ launch_args_parse(int argc, char** argv)\n \t\tcase 0: /*long options */\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"help\")) {\n \t\t\t\tusage(argv[0]);\n-\t\t\t\trte_exit(EXIT_SUCCESS, \"Displayed help\\n\");\n+\t\t\t\texit(EXIT_SUCCESS);\n \t\t\t}\n #ifdef RTE_LIB_CMDLINE\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"interactive\")) {\n@@ -1369,7 +1369,7 @@ launch_args_parse(int argc, char** argv)\n \t\t\tbreak;\n \t\tcase 'h':\n \t\t\tusage(argv[0]);\n-\t\t\trte_exit(EXIT_SUCCESS, \"Displayed help\\n\");\n+\t\t\texit(EXIT_SUCCESS);\n \t\t\tbreak;\n \t\tdefault:\n \t\t\tusage(argv[0]);\ndiff --git a/app/test-regex/main.c b/app/test-regex/main.c\nindex aea4fa6b88..7bb87bb1b8 100644\n--- a/app/test-regex/main.c\n+++ b/app/test-regex/main.c\n@@ -154,9 +154,8 @@ args_parse(int argc, char **argv, char *rules_file, char *data_file,\n \t\t\tusage(\"RegEx test app\");\n \t\t\tbreak;\n \t\tdefault:\n-\t\t\tfprintf(stderr, \"Invalid option: %s\\n\", argv[optind]);\n \t\t\tusage(\"RegEx test app\");\n-\t\t\trte_exit(EXIT_FAILURE, \"Invalid option\\n\");\n+\t\t\trte_exit(EXIT_FAILURE, \"Invalid option: %s\\n\", argv[optind]);\n \t\t\tbreak;\n \t\t}\n \t}\n", "prefixes": [ "08/11" ] }