Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88737/?format=api
{ "id": 88737, "url": "https://patches.dpdk.org/api/patches/88737/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210309084315.12276-1-xiao.w.wang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210309084315.12276-1-xiao.w.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210309084315.12276-1-xiao.w.wang@intel.com", "date": "2021-03-09T08:43:15", "name": "vdpa/ifc: check return value for PCI config read", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "18ceb93e3191033cd5ba1d57bd3a1203c07c7be6", "submitter": { "id": 281, "url": "https://patches.dpdk.org/api/people/281/?format=api", "name": "Xiao Wang", "email": "xiao.w.wang@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210309084315.12276-1-xiao.w.wang@intel.com/mbox/", "series": [ { "id": 15543, "url": "https://patches.dpdk.org/api/series/15543/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15543", "date": "2021-03-09T08:43:15", "name": "vdpa/ifc: check return value for PCI config read", "version": 1, "mbox": "https://patches.dpdk.org/series/15543/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/88737/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/88737/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 74136A0567;\n\tTue, 9 Mar 2021 10:03:29 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4B1D922A443;\n\tTue, 9 Mar 2021 10:03:29 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 28CA04069D;\n Tue, 9 Mar 2021 10:03:28 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Mar 2021 01:03:16 -0800", "from dpdk-xiao1.sh.intel.com ([10.67.110.193])\n by orsmga005.jf.intel.com with ESMTP; 09 Mar 2021 01:03:14 -0800" ], "IronPort-SDR": [ "\n arNMNRVnsfhaf2lKW1cWnXym8WMknkFj1GCoYvTxb19OGSPpPHDYSyuthVQQkCEtdge5xm2puj\n Qd/vaytCtgLA==", "\n /7jkQmASo+BdIQ7zIGn/wXtg9xahiFlmpqlNBDLKUkMXUYpHRZ3MAdMI2CiwUkchCfPWF1YLJ3\n 4u+59UEdhZ0w==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9917\"; a=\"273221668\"", "E=Sophos;i=\"5.81,234,1610438400\"; d=\"scan'208\";a=\"273221668\"", "E=Sophos;i=\"5.81,234,1610438400\"; d=\"scan'208\";a=\"588365735\"" ], "X-ExtLoop1": "1", "From": "Xiao Wang <xiao.w.wang@intel.com>", "To": "chenbo.xia@intel.com", "Cc": "dev@dpdk.org,\n\tXiao Wang <xiao.w.wang@intel.com>,\n\tstable@dpdk.org", "Date": "Tue, 9 Mar 2021 16:43:15 +0800", "Message-Id": "<20210309084315.12276-1-xiao.w.wang@intel.com>", "X-Mailer": "git-send-email 2.15.1", "Subject": "[dpdk-dev] [PATCH] vdpa/ifc: check return value for PCI config read", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The return value of rte_pci_read_config should be checked.\n\nCoverity issue: 302860\nFixes: a3f8150eac6d (\"net/ifcvf: add ifcvf vDPA driver\")\nCc: stable@dpdk.org\n\nSigned-off-by: Xiao Wang <xiao.w.wang@intel.com>\n---\n drivers/vdpa/ifc/base/ifcvf.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c\nindex 3c0b2dff66..721cb1da8a 100644\n--- a/drivers/vdpa/ifc/base/ifcvf.c\n+++ b/drivers/vdpa/ifc/base/ifcvf.c\n@@ -65,8 +65,13 @@ ifcvf_init_hw(struct ifcvf_hw *hw, PCI_DEV *dev)\n \t\t\thw->common_cfg = get_cap_addr(hw, &cap);\n \t\t\tbreak;\n \t\tcase IFCVF_PCI_CAP_NOTIFY_CFG:\n-\t\t\tPCI_READ_CONFIG_DWORD(dev, &hw->notify_off_multiplier,\n+\t\t\tret = PCI_READ_CONFIG_DWORD(dev,\n+\t\t\t\t\t&hw->notify_off_multiplier,\n \t\t\t\t\tpos + sizeof(cap));\n+\t\t\tif (ret < 0) {\n+\t\t\t\tDEBUGOUT(\"failed to read notify_off_multiplier\\n\");\n+\t\t\t\treturn -1;\n+\t\t\t}\n \t\t\thw->notify_base = get_cap_addr(hw, &cap);\n \t\t\thw->notify_region = cap.bar;\n \t\t\tbreak;\n", "prefixes": [] }