Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/8873/?format=api
https://patches.dpdk.org/api/patches/8873/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1447312143-12215-1-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1447312143-12215-1-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1447312143-12215-1-git-send-email-helin.zhang@intel.com", "date": "2015-11-12T07:09:03", "name": "[dpdk-dev] i40e: fix the issue of trying more VSIs for VMDq than available", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "22faf79416a3c4cc37c8a854e0066cdef50aa8ff", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1447312143-12215-1-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/8873/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/8873/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E4653918F;\n\tThu, 12 Nov 2015 08:09:11 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id A008E8F9D\n\tfor <dev@dpdk.org>; Thu, 12 Nov 2015 08:09:10 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga101.fm.intel.com with ESMTP; 11 Nov 2015 23:09:10 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby FMSMGA003.fm.intel.com with ESMTP; 11 Nov 2015 23:09:08 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id tAC796Vj025003;\n\tThu, 12 Nov 2015 15:09:06 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid tAC7933g012253; Thu, 12 Nov 2015 15:09:05 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id tAC793c0012249; \n\tThu, 12 Nov 2015 15:09:03 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,280,1444719600\"; d=\"scan'208\";a=\"598883563\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 12 Nov 2015 15:09:03 +0800", "Message-Id": "<1447312143-12215-1-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "Subject": "[dpdk-dev] [PATCH] i40e: fix the issue of trying more VSIs for VMDq\n\tthan available", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "It fixes the issue of trying to allocate more VSIs for VMDq than\nhardware remaining. It adds a check of the hardware remaining\nbefore allocating VSIs for VMDq.\n\nFixes: c80707a0fd9c (\"i40e: fix VMDq pool limit\")\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n drivers/net/i40e/i40e_ethdev.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex e4684d3..323b1ff 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -3118,7 +3118,8 @@ i40e_pf_parameter_init(struct rte_eth_dev *dev)\n \tpf->vmdq_nb_qps = 0;\n \tpf->max_nb_vmdq_vsi = 0;\n \tif (hw->func_caps.vmdq) {\n-\t\tif (qp_count < hw->func_caps.num_tx_qp) {\n+\t\tif (qp_count < hw->func_caps.num_tx_qp &&\n+\t\t\tvsi_count < hw->func_caps.num_vsis) {\n \t\t\tpf->max_nb_vmdq_vsi = (hw->func_caps.num_tx_qp -\n \t\t\t\tqp_count) / pf->vmdq_nb_qp_max;\n \n@@ -3126,6 +3127,8 @@ i40e_pf_parameter_init(struct rte_eth_dev *dev)\n \t\t\t * ethdev can support\n \t\t\t */\n \t\t\tpf->max_nb_vmdq_vsi = RTE_MIN(pf->max_nb_vmdq_vsi,\n+\t\t\t\thw->func_caps.num_vsis - vsi_count);\n+\t\t\tpf->max_nb_vmdq_vsi = RTE_MIN(pf->max_nb_vmdq_vsi,\n \t\t\t\tETH_64_POOLS);\n \t\t\tif (pf->max_nb_vmdq_vsi) {\n \t\t\t\tpf->flags |= I40E_FLAG_VMDQ;\n@@ -3140,7 +3143,7 @@ i40e_pf_parameter_init(struct rte_eth_dev *dev)\n \t\t\t\t\t \"VMDq\");\n \t\t\t}\n \t\t} else {\n-\t\t\tPMD_DRV_LOG(INFO, \"No queue left for VMDq\");\n+\t\t\tPMD_DRV_LOG(INFO, \"No queue or VSI left for VMDq\");\n \t\t}\n \t}\n \tqp_count += pf->vmdq_nb_qps * pf->max_nb_vmdq_vsi;\n", "prefixes": [ "dpdk-dev" ] }{ "id": 8873, "url": "