Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/887/?format=api
{ "id": 887, "url": "https://patches.dpdk.org/api/patches/887/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1413900943-27711-1-git-send-email-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1413900943-27711-1-git-send-email-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1413900943-27711-1-git-send-email-pablo.de.lara.guarch@intel.com", "date": "2014-10-21T14:15:43", "name": "[dpdk-dev] librte_ip_frag: Disable ipv4/v6 fragmentation if RTE_MBUF_REFCNT=n", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "69034c6de896c84412f37da123f9d6f6412a581a", "submitter": { "id": 9, "url": "https://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1413900943-27711-1-git-send-email-pablo.de.lara.guarch@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/887/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/887/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A9CD07EA4;\n\tTue, 21 Oct 2014 22:41:15 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 39A387E7B\n\tfor <dev@dpdk.org>; Tue, 21 Oct 2014 22:41:12 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga101.fm.intel.com with ESMTP; 21 Oct 2014 10:56:53 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby FMSMGA003.fm.intel.com with ESMTP; 21 Oct 2014 07:08:08 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\ts9LEFhhi014185 for <dev@dpdk.org>; Tue, 21 Oct 2014 15:15:43 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id s9LEFhMu027747\n\tfor <dev@dpdk.org>; Tue, 21 Oct 2014 15:15:43 +0100", "(from pdelarax@localhost)\n\tby sivswdev02.ir.intel.com with id s9LEFhFe027743\n\tfor dev@dpdk.org; Tue, 21 Oct 2014 15:15:43 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"403530806\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 21 Oct 2014 15:15:43 +0100", "Message-Id": "<1413900943-27711-1-git-send-email-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "Subject": "[dpdk-dev] [PATCH] librte_ip_frag: Disable ipv4/v6 fragmentation if\n\tRTE_MBUF_REFCNT=n", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Ipv4/v6 fragmentation libraries depends on refcnt.\nThere was a compilation error if RTE_MBUF_REFCNT was disabled,\nso those libraries have been disabled in that situation.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n lib/librte_ip_frag/Makefile | 4 +++-\n lib/librte_ip_frag/rte_ip_frag.h | 5 ++++-\n 2 files changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_ip_frag/Makefile b/lib/librte_ip_frag/Makefile\nindex 2265c93..9043543 100644\n--- a/lib/librte_ip_frag/Makefile\n+++ b/lib/librte_ip_frag/Makefile\n@@ -38,9 +38,11 @@ CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR)\n \n #source files\n+ifeq ($(CONFIG_RTE_MBUF_REFCNT),y)\n SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv4_fragmentation.c\n-SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv4_reassembly.c\n SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv6_fragmentation.c\n+endif\n+SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv4_reassembly.c\n SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ipv6_reassembly.c\n SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += rte_ip_frag_common.c\n SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += ip_frag_internal.c\ndiff --git a/lib/librte_ip_frag/rte_ip_frag.h b/lib/librte_ip_frag/rte_ip_frag.h\nindex e0936dc..230a903 100644\n--- a/lib/librte_ip_frag/rte_ip_frag.h\n+++ b/lib/librte_ip_frag/rte_ip_frag.h\n@@ -175,6 +175,7 @@ rte_ip_frag_table_destroy( struct rte_ip_frag_tbl *tbl)\n \trte_free(tbl);\n }\n \n+#ifdef RTE_MBUF_REFCNT\n /**\n * This function implements the fragmentation of IPv6 packets.\n *\n@@ -203,7 +204,7 @@ rte_ipv6_fragment_packet(struct rte_mbuf *pkt_in,\n \t\tuint16_t mtu_size,\n \t\tstruct rte_mempool *pool_direct,\n \t\tstruct rte_mempool *pool_indirect);\n-\n+#endif\n \n /*\n * This function implements reassembly of fragmented IPv6 packets.\n@@ -252,6 +253,7 @@ rte_ipv6_frag_get_ipv6_fragment_header(struct ipv6_hdr *hdr)\n \t\treturn NULL;\n }\n \n+#ifdef RTE_MBUF_REFCNT\n /**\n * IPv4 fragmentation.\n *\n@@ -280,6 +282,7 @@ int32_t rte_ipv4_fragment_packet(struct rte_mbuf *pkt_in,\n \t\t\tuint16_t nb_pkts_out, uint16_t mtu_size,\n \t\t\tstruct rte_mempool *pool_direct,\n \t\t\tstruct rte_mempool *pool_indirect);\n+#endif\n \n /*\n * This function implements reassembly of fragmented IPv4 packets.\n", "prefixes": [ "dpdk-dev" ] }