Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88682/?format=api
{ "id": 88682, "url": "https://patches.dpdk.org/api/patches/88682/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210307091202.586-3-wisamm@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210307091202.586-3-wisamm@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210307091202.586-3-wisamm@nvidia.com", "date": "2021-03-07T09:11:59", "name": "[2/5] app/flow-perf: add new option to use unique data on the fly", "commit_ref": null, "pull_url": null, "state": "new", "archived": true, "hash": "15d429eeaab4870049c900d05072103a6a635cdc", "submitter": { "id": 1963, "url": "https://patches.dpdk.org/api/people/1963/?format=api", "name": "Wisam Monther", "email": "wisamm@nvidia.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210307091202.586-3-wisamm@nvidia.com/mbox/", "series": [ { "id": 15518, "url": "https://patches.dpdk.org/api/series/15518/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15518", "date": "2021-03-07T09:11:57", "name": "New flow-perf fixes", "version": 1, "mbox": "https://patches.dpdk.org/series/15518/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/88682/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/88682/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3EFF0A0562;\n\tSun, 7 Mar 2021 10:12:39 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 028D822A33D;\n\tSun, 7 Mar 2021 10:12:27 +0100 (CET)", "from NAM12-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam12on2062.outbound.protection.outlook.com [40.107.243.62])\n by mails.dpdk.org (Postfix) with ESMTP id 5F0AF22A337\n for <dev@dpdk.org>; Sun, 7 Mar 2021 10:12:25 +0100 (CET)", "from DM5PR1401CA0023.namprd14.prod.outlook.com (2603:10b6:4:4a::33)\n by DM5PR12MB2503.namprd12.prod.outlook.com (2603:10b6:4:b2::15) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.23; Sun, 7 Mar\n 2021 09:12:22 +0000", "from DM6NAM11FT046.eop-nam11.prod.protection.outlook.com\n (2603:10b6:4:4a:cafe::e8) by DM5PR1401CA0023.outlook.office365.com\n (2603:10b6:4:4a::33) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.26 via Frontend\n Transport; Sun, 7 Mar 2021 09:12:22 +0000", "from mail.nvidia.com (216.228.112.34) by\n DM6NAM11FT046.mail.protection.outlook.com (10.13.172.121) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.3912.17 via Frontend Transport; Sun, 7 Mar 2021 09:12:22 +0000", "from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 7 Mar\n 2021 09:12:20 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=kuPsyqD1FSKaCQ1qQvb6mVDZSAjsEiVRiK05YuIq0sWnLMmCMYbcnIklk8rEj2Sbps2f9I7PzYo85VcC45f75fMDefNmID1eTF1fTAFEeb+3d06y3kuIjrGFFqLEppni6urqa+TcF+E/eBHMoItIeYG3BWKGbedFfbt/N+31m7f+vcEvOQJLem46aSVjn8uGDtP2V0Yp9j5JDoOeL2sLAHbAzbhiIUNsnnu3L1ecUqGeXv9haWO5IFjT/y/JpCTaM4o6agSphJJI6QmIWysQRYhRCgv1ILVhy3OCHRLHI4SqpRAkzcGp5+3uI65PD8XcTfCSyWcB1M4NAwnYrj9T9A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=AvHZdkx0AHYe/mPdwjRY52oSvUNf/gicMEY/xL0naQA=;\n b=D3j3Dy+BUPQDPI+i5yShQBulC9Bkw04qhWazbLMFVSz1UZdLBZwLtqL5qQiWpSYgcoAHGa6ofDuUYGGJUixdQBSKnFu1d1+iu9d8txo1jvhDrFl2Qxm6hCkGY75F5xlwwTYMRg8yT5JyjSC3olKIyb8g0O5aIuzWKm1eCa0PKR6YIyvtbfuNr4I7MltAchl9cCAokPkG5tGlkQoGVqvo1ApCGqU91YC6BVK/L+O4x15Ag+Xs/zsX13S5DATAIl0QOxwmWR1o2uUeXzBD54LJvbMVjEs9mk/xu1tMIzNzwcoLny1okiihM7WsBOdoISQYbI/o0PVv/q2XD/EStZHaEA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=AvHZdkx0AHYe/mPdwjRY52oSvUNf/gicMEY/xL0naQA=;\n b=0VDCHdswnYr1aonsgQOWkG2UpTE98cqKBSB9YnXUhtP9PldUajy+sDTA3yPz0ibGs8Gy9jWrFGMFB/3vK0BBDPETmeyEENpLEr+g8Ud4xnu5ygnREyIHU/ccx/3ZeGjjk8NQ5C/TrkaK4RFY9qagWlvdeLXKqqnS5Uyw1Z1G2SU=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Wisam Jaddo <wisamm@nvidia.com>", "To": "<arybchenko@solarflare.com>, <thomas@monjalon.net>, <akozyrev@nvidia.com>,\n <rasland@nvidia.com>, <dev@dpdk.org>", "Date": "Sun, 7 Mar 2021 11:11:59 +0200", "Message-ID": "<20210307091202.586-3-wisamm@nvidia.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210307091202.586-1-wisamm@nvidia.com>", "References": "<20210307091202.586-1-wisamm@nvidia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.145.6]", "X-ClientProxiedBy": "HQMAIL101.nvidia.com (172.20.187.10) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "87347c51-189c-485b-89b9-08d8e1491df7", "X-MS-TrafficTypeDiagnostic": "DM5PR12MB2503:", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <DM5PR12MB2503BC7319FD1DAB5E35A415A4949@DM5PR12MB2503.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:321;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n fLookTzAkyxF4//e90484SuE9yttiLIYxXGcys8h08E7IuHALnaZ7wiTjzfNgQP9+0Wat+RJvJKWVKyjc9oLzFIKCbG6JiwYf3pwYXirPJ9Gd6QzsH2cs2PFJjbkJefY0s9shhWQ53l70kAQjhuhaSOQ0ogfe3VnhSZxwg/wTj8iIYVc9XXTLAhlDe4CD96/OlPXXcd2YHFj/fDdu8zVOEDtAKbwfmVvo14HdHjhr3wP+HsEOAEthHtjhVw/bjoKcqkexlsqVaHbwgut23BAxVgoYzMqgxkrrkr5Uj8c2SphvxnG7tcavJEn49Gow+VGuZ7ahwSVc9IsS4EneVpAJ6DRk9OWwXrIXb4vBOh+PguesaUcMa+3Ess4T5fTeF8vKNpPI76VKo22KS0HY4RM6IM+rYKtCbQEcImC/x7J7A9fcaiGsTMTWAFclo2xm0UyHpc8K+TWpNWofDG/g3vudazYFSfxMisQhJ/BAn7M9yFPGd/mYuP0HFpKsmYgGnTaEXYGJTlV0dJLKw7RJJs1JXIcXKLMwgJXhHgs29ZaNrD2ZLDZJnDmmUn41f12wnNWLrvLhnUPVaH4mDpJMNlRnKRIgWtnqB1jvg8tlb1NkznUAsmBbkIZDqVBi8MBQ/Ov7VPmDqy8bh8seq7/UQChyXwvDYqCw8ee+DUs2rSx4odoDG9yBbKEiDFrbtpVX3CE", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(376002)(396003)(346002)(39860400002)(136003)(36840700001)(46966006)(16526019)(8936002)(426003)(336012)(5660300002)(478600001)(7636003)(1076003)(47076005)(26005)(30864003)(70586007)(2616005)(6666004)(36756003)(8676002)(70206006)(186003)(7696005)(82740400003)(82310400003)(34020700004)(110136005)(83380400001)(55016002)(86362001)(36860700001)(6286002)(316002)(36906005)(2906002)(356005);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Mar 2021 09:12:22.3090 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 87347c51-189c-485b-89b9-08d8e1491df7", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT046.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM5PR12MB2503", "Subject": "[dpdk-dev] [PATCH 2/5] app/flow-perf: add new option to use unique\n data on the fly", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Current support for unique data is to compile with config.h\nvar as FIXED_VALUES as 0, and this is only supported on\ncompilation time, as a result the user may use only single\nmode for each compilation.\n\nStarting with this commit the user will have the ability to\nuse this feature on the fly by using this new option:\n--unique-data\n\nExample of unique data usage:\nInsert many rules with different encap data for a flows that\nhave encap action in it.\n\nSigned-off-by: Wisam Jaddo <wisamm@nvidia.com>\n---\n app/test-flow-perf/actions_gen.c | 77 +++++++++++++++++---------------\n app/test-flow-perf/actions_gen.h | 3 +-\n app/test-flow-perf/config.h | 8 +---\n app/test-flow-perf/flow_gen.c | 4 +-\n app/test-flow-perf/flow_gen.h | 1 +\n app/test-flow-perf/main.c | 13 ++++--\n doc/guides/tools/flow-perf.rst | 5 +++\n 7 files changed, 62 insertions(+), 49 deletions(-)", "diff": "diff --git a/app/test-flow-perf/actions_gen.c b/app/test-flow-perf/actions_gen.c\nindex 1f5c64fde9..82cddfc676 100644\n--- a/app/test-flow-perf/actions_gen.c\n+++ b/app/test-flow-perf/actions_gen.c\n@@ -30,6 +30,7 @@ struct additional_para {\n \tuint64_t encap_data;\n \tuint64_t decap_data;\n \tuint8_t core_idx;\n+\tbool unique_data;\n };\n \n /* Storage for struct rte_flow_action_raw_encap including external data. */\n@@ -202,14 +203,14 @@ add_count(struct rte_flow_action *actions,\n static void\n add_set_src_mac(struct rte_flow_action *actions,\n \tuint8_t actions_counter,\n-\t__rte_unused struct additional_para para)\n+\tstruct additional_para para)\n {\n \tstatic struct rte_flow_action_set_mac set_macs[RTE_MAX_LCORE] __rte_cache_aligned;\n \tuint32_t mac = para.counter;\n \tuint16_t i;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tmac = 1;\n \n \t/* Mac address to be set is random each time */\n@@ -225,14 +226,14 @@ add_set_src_mac(struct rte_flow_action *actions,\n static void\n add_set_dst_mac(struct rte_flow_action *actions,\n \tuint8_t actions_counter,\n-\t__rte_unused struct additional_para para)\n+\tstruct additional_para para)\n {\n \tstatic struct rte_flow_action_set_mac set_macs[RTE_MAX_LCORE] __rte_cache_aligned;\n \tuint32_t mac = para.counter;\n \tuint16_t i;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tmac = 1;\n \n \t/* Mac address to be set is random each time */\n@@ -248,13 +249,13 @@ add_set_dst_mac(struct rte_flow_action *actions,\n static void\n add_set_src_ipv4(struct rte_flow_action *actions,\n \tuint8_t actions_counter,\n-\t__rte_unused struct additional_para para)\n+\tstruct additional_para para)\n {\n \tstatic struct rte_flow_action_set_ipv4 set_ipv4[RTE_MAX_LCORE] __rte_cache_aligned;\n \tuint32_t ip = para.counter;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tip = 1;\n \n \t/* IPv4 value to be set is random each time */\n@@ -267,13 +268,13 @@ add_set_src_ipv4(struct rte_flow_action *actions,\n static void\n add_set_dst_ipv4(struct rte_flow_action *actions,\n \tuint8_t actions_counter,\n-\t__rte_unused struct additional_para para)\n+\tstruct additional_para para)\n {\n \tstatic struct rte_flow_action_set_ipv4 set_ipv4[RTE_MAX_LCORE] __rte_cache_aligned;\n \tuint32_t ip = para.counter;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tip = 1;\n \n \t/* IPv4 value to be set is random each time */\n@@ -286,14 +287,14 @@ add_set_dst_ipv4(struct rte_flow_action *actions,\n static void\n add_set_src_ipv6(struct rte_flow_action *actions,\n \tuint8_t actions_counter,\n-\t__rte_unused struct additional_para para)\n+\tstruct additional_para para)\n {\n \tstatic struct rte_flow_action_set_ipv6 set_ipv6[RTE_MAX_LCORE] __rte_cache_aligned;\n \tuint32_t ipv6 = para.counter;\n \tuint8_t i;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tipv6 = 1;\n \n \t/* IPv6 value to set is random each time */\n@@ -309,14 +310,14 @@ add_set_src_ipv6(struct rte_flow_action *actions,\n static void\n add_set_dst_ipv6(struct rte_flow_action *actions,\n \tuint8_t actions_counter,\n-\t__rte_unused struct additional_para para)\n+\tstruct additional_para para)\n {\n \tstatic struct rte_flow_action_set_ipv6 set_ipv6[RTE_MAX_LCORE] __rte_cache_aligned;\n \tuint32_t ipv6 = para.counter;\n \tuint8_t i;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tipv6 = 1;\n \n \t/* IPv6 value to set is random each time */\n@@ -332,13 +333,13 @@ add_set_dst_ipv6(struct rte_flow_action *actions,\n static void\n add_set_src_tp(struct rte_flow_action *actions,\n \tuint8_t actions_counter,\n-\t__rte_unused struct additional_para para)\n+\tstruct additional_para para)\n {\n \tstatic struct rte_flow_action_set_tp set_tp[RTE_MAX_LCORE] __rte_cache_aligned;\n \tuint32_t tp = para.counter;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\ttp = 100;\n \n \t/* TP src port is random each time */\n@@ -353,13 +354,13 @@ add_set_src_tp(struct rte_flow_action *actions,\n static void\n add_set_dst_tp(struct rte_flow_action *actions,\n \tuint8_t actions_counter,\n-\t__rte_unused struct additional_para para)\n+\tstruct additional_para para)\n {\n \tstatic struct rte_flow_action_set_tp set_tp[RTE_MAX_LCORE] __rte_cache_aligned;\n \tuint32_t tp = para.counter;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\ttp = 100;\n \n \t/* TP src port is random each time */\n@@ -375,13 +376,13 @@ add_set_dst_tp(struct rte_flow_action *actions,\n static void\n add_inc_tcp_ack(struct rte_flow_action *actions,\n \tuint8_t actions_counter,\n-\t__rte_unused struct additional_para para)\n+\tstruct additional_para para)\n {\n \tstatic rte_be32_t value[RTE_MAX_LCORE] __rte_cache_aligned;\n \tuint32_t ack_value = para.counter;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tack_value = 1;\n \n \tvalue[para.core_idx] = RTE_BE32(ack_value);\n@@ -393,13 +394,13 @@ add_inc_tcp_ack(struct rte_flow_action *actions,\n static void\n add_dec_tcp_ack(struct rte_flow_action *actions,\n \tuint8_t actions_counter,\n-\t__rte_unused struct additional_para para)\n+\tstruct additional_para para)\n {\n \tstatic rte_be32_t value[RTE_MAX_LCORE] __rte_cache_aligned;\n \tuint32_t ack_value = para.counter;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tack_value = 1;\n \n \tvalue[para.core_idx] = RTE_BE32(ack_value);\n@@ -411,13 +412,13 @@ add_dec_tcp_ack(struct rte_flow_action *actions,\n static void\n add_inc_tcp_seq(struct rte_flow_action *actions,\n \tuint8_t actions_counter,\n-\t__rte_unused struct additional_para para)\n+\tstruct additional_para para)\n {\n \tstatic rte_be32_t value[RTE_MAX_LCORE] __rte_cache_aligned;\n \tuint32_t seq_value = para.counter;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tseq_value = 1;\n \n \tvalue[para.core_idx] = RTE_BE32(seq_value);\n@@ -429,13 +430,13 @@ add_inc_tcp_seq(struct rte_flow_action *actions,\n static void\n add_dec_tcp_seq(struct rte_flow_action *actions,\n \tuint8_t actions_counter,\n-\t__rte_unused struct additional_para para)\n+\tstruct additional_para para)\n {\n \tstatic rte_be32_t value[RTE_MAX_LCORE] __rte_cache_aligned;\n \tuint32_t seq_value = para.counter;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tseq_value = 1;\n \n \tvalue[para.core_idx] = RTE_BE32(seq_value);\n@@ -447,13 +448,13 @@ add_dec_tcp_seq(struct rte_flow_action *actions,\n static void\n add_set_ttl(struct rte_flow_action *actions,\n \tuint8_t actions_counter,\n-\t__rte_unused struct additional_para para)\n+\tstruct additional_para para)\n {\n \tstatic struct rte_flow_action_set_ttl set_ttl[RTE_MAX_LCORE] __rte_cache_aligned;\n \tuint32_t ttl_value = para.counter;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tttl_value = 1;\n \n \t/* Set ttl to random value each time */\n@@ -476,13 +477,13 @@ add_dec_ttl(struct rte_flow_action *actions,\n static void\n add_set_ipv4_dscp(struct rte_flow_action *actions,\n \tuint8_t actions_counter,\n-\t__rte_unused struct additional_para para)\n+\tstruct additional_para para)\n {\n \tstatic struct rte_flow_action_set_dscp set_dscp[RTE_MAX_LCORE] __rte_cache_aligned;\n \tuint32_t dscp_value = para.counter;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tdscp_value = 1;\n \n \t/* Set dscp to random value each time */\n@@ -497,13 +498,13 @@ add_set_ipv4_dscp(struct rte_flow_action *actions,\n static void\n add_set_ipv6_dscp(struct rte_flow_action *actions,\n \tuint8_t actions_counter,\n-\t__rte_unused struct additional_para para)\n+\tstruct additional_para para)\n {\n \tstatic struct rte_flow_action_set_dscp set_dscp[RTE_MAX_LCORE] __rte_cache_aligned;\n \tuint32_t dscp_value = para.counter;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tdscp_value = 1;\n \n \t/* Set dscp to random value each time */\n@@ -577,7 +578,7 @@ add_ipv4_header(uint8_t **header, uint64_t data,\n \t\treturn;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tip_dst = 1;\n \n \tmemset(&ipv4_hdr, 0, sizeof(struct rte_ipv4_hdr));\n@@ -643,7 +644,7 @@ add_vxlan_header(uint8_t **header, uint64_t data,\n \t\treturn;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tvni_value = 1;\n \n \tmemset(&vxlan_hdr, 0, sizeof(struct rte_vxlan_hdr));\n@@ -666,7 +667,7 @@ add_vxlan_gpe_header(uint8_t **header, uint64_t data,\n \t\treturn;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tvni_value = 1;\n \n \tmemset(&vxlan_gpe_hdr, 0, sizeof(struct rte_vxlan_gpe_hdr));\n@@ -707,7 +708,7 @@ add_geneve_header(uint8_t **header, uint64_t data,\n \t\treturn;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tvni_value = 1;\n \n \tmemset(&geneve_hdr, 0, sizeof(struct rte_geneve_hdr));\n@@ -730,7 +731,7 @@ add_gtp_header(uint8_t **header, uint64_t data,\n \t\treturn;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tteid_value = 1;\n \n \tmemset(>p_hdr, 0, sizeof(struct rte_flow_item_gtp));\n@@ -849,7 +850,7 @@ add_vxlan_encap(struct rte_flow_action *actions,\n \tuint32_t ip_dst = para.counter;\n \n \t/* Fixed value */\n-\tif (FIXED_VALUES)\n+\tif (!para.unique_data)\n \t\tip_dst = 1;\n \n \titems[0].spec = &item_eth;\n@@ -907,7 +908,8 @@ add_meter(struct rte_flow_action *actions,\n void\n fill_actions(struct rte_flow_action *actions, uint64_t *flow_actions,\n \tuint32_t counter, uint16_t next_table, uint16_t hairpinq,\n-\tuint64_t encap_data, uint64_t decap_data, uint8_t core_idx)\n+\tuint64_t encap_data, uint64_t decap_data, uint8_t core_idx,\n+\tbool unique_data)\n {\n \tstruct additional_para additional_para_data;\n \tuint8_t actions_counter = 0;\n@@ -930,6 +932,7 @@ fill_actions(struct rte_flow_action *actions, uint64_t *flow_actions,\n \t\t.encap_data = encap_data,\n \t\t.decap_data = decap_data,\n \t\t.core_idx = core_idx,\n+\t\t.unique_data = unique_data,\n \t};\n \n \tif (hairpinq != 0) {\ndiff --git a/app/test-flow-perf/actions_gen.h b/app/test-flow-perf/actions_gen.h\nindex 77353cfe09..6f2f833496 100644\n--- a/app/test-flow-perf/actions_gen.h\n+++ b/app/test-flow-perf/actions_gen.h\n@@ -19,6 +19,7 @@\n \n void fill_actions(struct rte_flow_action *actions, uint64_t *flow_actions,\n \tuint32_t counter, uint16_t next_table, uint16_t hairpinq,\n-\tuint64_t encap_data, uint64_t decap_data, uint8_t core_idx);\n+\tuint64_t encap_data, uint64_t decap_data, uint8_t core_idx,\n+\tbool unique_data);\n \n #endif /* FLOW_PERF_ACTION_GEN */\ndiff --git a/app/test-flow-perf/config.h b/app/test-flow-perf/config.h\nindex 3d4696d61a..a14d4e05e1 100644\n--- a/app/test-flow-perf/config.h\n+++ b/app/test-flow-perf/config.h\n@@ -5,7 +5,7 @@\n #define FLOW_ITEM_MASK(_x) (UINT64_C(1) << _x)\n #define FLOW_ACTION_MASK(_x) (UINT64_C(1) << _x)\n #define FLOW_ATTR_MASK(_x) (UINT64_C(1) << _x)\n-#define GET_RSS_HF() (ETH_RSS_IP | ETH_RSS_TCP)\n+#define GET_RSS_HF() (ETH_RSS_IP)\n \n /* Configuration */\n #define RXQ_NUM 4\n@@ -19,12 +19,6 @@\n #define METER_CIR 1250000\n #define DEFAULT_METER_PROF_ID 100\n \n-/* This is used for encap/decap & header modify actions.\n- * When it's 1: it means all actions have fixed values.\n- * When it's 0: it means all actions will have different values.\n- */\n-#define FIXED_VALUES 1\n-\n /* Items/Actions parameters */\n #define JUMP_ACTION_TABLE 2\n #define VLAN_VALUE 1\ndiff --git a/app/test-flow-perf/flow_gen.c b/app/test-flow-perf/flow_gen.c\nindex df4af16de8..8f87fac5f6 100644\n--- a/app/test-flow-perf/flow_gen.c\n+++ b/app/test-flow-perf/flow_gen.c\n@@ -46,6 +46,7 @@ generate_flow(uint16_t port_id,\n \tuint64_t encap_data,\n \tuint64_t decap_data,\n \tuint8_t core_idx,\n+\tbool unique_data,\n \tstruct rte_flow_error *error)\n {\n \tstruct rte_flow_attr attr;\n@@ -61,7 +62,8 @@ generate_flow(uint16_t port_id,\n \n \tfill_actions(actions, flow_actions,\n \t\touter_ip_src, next_table, hairpinq,\n-\t\tencap_data, decap_data, core_idx);\n+\t\tencap_data, decap_data, core_idx,\n+\t\tunique_data);\n \n \tfill_items(items, flow_items, outer_ip_src, core_idx);\n \ndiff --git a/app/test-flow-perf/flow_gen.h b/app/test-flow-perf/flow_gen.h\nindex f1d0999af1..dc887fceae 100644\n--- a/app/test-flow-perf/flow_gen.h\n+++ b/app/test-flow-perf/flow_gen.h\n@@ -35,6 +35,7 @@ generate_flow(uint16_t port_id,\n \tuint64_t encap_data,\n \tuint64_t decap_data,\n \tuint8_t core_idx,\n+\tbool unique_data,\n \tstruct rte_flow_error *error);\n \n #endif /* FLOW_PERF_FLOW_GEN */\ndiff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c\nindex 8b5a11c15e..4054178273 100644\n--- a/app/test-flow-perf/main.c\n+++ b/app/test-flow-perf/main.c\n@@ -61,6 +61,7 @@ static bool dump_iterations;\n static bool delete_flag;\n static bool dump_socket_mem_flag;\n static bool enable_fwd;\n+static bool unique_data;\n \n static struct rte_mempool *mbuf_mp;\n static uint32_t nb_lcores;\n@@ -131,6 +132,8 @@ usage(char *progname)\n \tprintf(\" --enable-fwd: To enable packets forwarding\"\n \t\t\" after insertion\\n\");\n \tprintf(\" --portmask=N: hexadecimal bitmask of ports used\\n\");\n+\tprintf(\" --unique-data: flag to set using unique data for all\"\n+\t\t\" actions that support data, such as header modify and encap actions\\n\");\n \n \tprintf(\"To set flow attributes:\\n\");\n \tprintf(\" --ingress: set ingress attribute in flows\\n\");\n@@ -567,6 +570,7 @@ args_parse(int argc, char **argv)\n \t\t{ \"deletion-rate\", 0, 0, 0 },\n \t\t{ \"dump-socket-mem\", 0, 0, 0 },\n \t\t{ \"enable-fwd\", 0, 0, 0 },\n+\t\t{ \"unique-data\", 0, 0, 0 },\n \t\t{ \"portmask\", 1, 0, 0 },\n \t\t{ \"cores\", 1, 0, 0 },\n \t\t/* Attributes */\n@@ -765,6 +769,9 @@ args_parse(int argc, char **argv)\n \t\t\tif (strcmp(lgopts[opt_idx].name,\n \t\t\t\t\t\"dump-iterations\") == 0)\n \t\t\t\tdump_iterations = true;\n+\t\t\tif (strcmp(lgopts[opt_idx].name,\n+\t\t\t\t\t\"unique-data\") == 0)\n+\t\t\t\tunique_data = true;\n \t\t\tif (strcmp(lgopts[opt_idx].name,\n \t\t\t\t\t\"deletion-rate\") == 0)\n \t\t\t\tdelete_flag = true;\n@@ -1176,7 +1183,7 @@ insert_flows(int port_id, uint8_t core_id)\n \t\t */\n \t\tflow = generate_flow(port_id, 0, flow_attrs,\n \t\t\tglobal_items, global_actions,\n-\t\t\tflow_group, 0, 0, 0, 0, core_id, &error);\n+\t\t\tflow_group, 0, 0, 0, 0, core_id, unique_data, &error);\n \n \t\tif (flow == NULL) {\n \t\t\tprint_flow_error(error);\n@@ -1192,7 +1199,7 @@ insert_flows(int port_id, uint8_t core_id)\n \t\t\tJUMP_ACTION_TABLE, counter,\n \t\t\thairpin_queues_num,\n \t\t\tencap_data, decap_data,\n-\t\t\tcore_id, &error);\n+\t\t\tcore_id, unique_data, &error);\n \n \t\tif (force_quit)\n \t\t\tcounter = end_counter;\n@@ -1863,6 +1870,7 @@ main(int argc, char **argv)\n \tdelete_flag = false;\n \tdump_socket_mem_flag = false;\n \tflow_group = DEFAULT_GROUP;\n+\tunique_data = false;\n \n \tsignal(SIGINT, signal_handler);\n \tsignal(SIGTERM, signal_handler);\n@@ -1878,7 +1886,6 @@ main(int argc, char **argv)\n \tif (nb_lcores <= 1)\n \t\trte_exit(EXIT_FAILURE, \"This app needs at least two cores\\n\");\n \n-\n \tprintf(\":: Flows Count per port: %d\\n\\n\", rules_count);\n \n \tif (has_meter())\ndiff --git a/doc/guides/tools/flow-perf.rst b/doc/guides/tools/flow-perf.rst\nindex 017e200222..280bf7e0e0 100644\n--- a/doc/guides/tools/flow-perf.rst\n+++ b/doc/guides/tools/flow-perf.rst\n@@ -100,6 +100,11 @@ The command line options are:\n \tSet the number of needed cores to insert/delete rte_flow rules.\n \tDefault cores count is 1.\n \n+* ``--unique-data``\n+ Flag to set using unique data for all actions that support data,\n+ Such as header modify and encap actions. Default is using fixed\n+ data for any action that support data for all flows.\n+\n Attributes:\n \n *\t``--ingress``\n", "prefixes": [ "2/5" ] }