Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88485/?format=api
{ "id": 88485, "url": "https://patches.dpdk.org/api/patches/88485/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210304203321.6154-2-ed.czeck@atomicrules.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210304203321.6154-2-ed.czeck@atomicrules.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210304203321.6154-2-ed.czeck@atomicrules.com", "date": "2021-03-04T20:33:18", "name": "[v2,2/5] net/ark: refactor Rx buffer recovery", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3e7737070b38a62288f7971a331234e4aa698935", "submitter": { "id": 699, "url": "https://patches.dpdk.org/api/people/699/?format=api", "name": "Ed Czeck", "email": "ed.czeck@atomicrules.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210304203321.6154-2-ed.czeck@atomicrules.com/mbox/", "series": [ { "id": 15493, "url": "https://patches.dpdk.org/api/series/15493/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15493", "date": "2021-03-04T20:33:17", "name": "[v2,1/5] net/ark: update pkt director initial state", "version": 2, "mbox": "https://patches.dpdk.org/series/15493/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/88485/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/88485/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0F05DA0561;\n\tThu, 4 Mar 2021 21:33:43 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 962BA22A2DA;\n\tThu, 4 Mar 2021 21:33:33 +0100 (CET)", "from mail-qk1-f175.google.com (mail-qk1-f175.google.com\n [209.85.222.175])\n by mails.dpdk.org (Postfix) with ESMTP id E80B440691\n for <dev@dpdk.org>; Thu, 4 Mar 2021 21:33:31 +0100 (CET)", "by mail-qk1-f175.google.com with SMTP id f124so11102418qkj.5\n for <dev@dpdk.org>; Thu, 04 Mar 2021 12:33:31 -0800 (PST)", "from z390.czeck.local (pool-72-74-133-40.bstnma.fios.verizon.net.\n [72.74.133.40])\n by smtp.gmail.com with ESMTPSA id b65sm250710qkd.120.2021.03.04.12.33.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 04 Mar 2021 12:33:30 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=atomicrules-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=HZgcT0RypAkTBKk2dEI0odsRmmoAEKRjq5UGrRdfe+E=;\n b=IeTFEkItMjgIKmPP1uKEm5bIciGtzVRo9aea8+Y4fHmSM3jXfPH+L6/3/arDMntB9o\n 8PwC4BgZi28LGWYqRQYQ+CdqK2Jt5GZjNjCCHBnyGvQwaonqDv3GDtN2znPhhysRkIFY\n e+qoccECouNKmvj+C6SkxXvGRvu1+nXkRmD0nmMJyPAI0L7lMkkktHLCPYaEE8PrdfJH\n KriLls0NFY3EFxWM5SZgyjVWfGkXT6rCNAbrv6qvw3FruTMkzcrMqN0JN9YcLtvM3XKH\n 6oW47dlB7qZL2Nvvj+9QOfDC7g5B+FS0zObHb8ztDzvWcaCB+gg4Af0H8lWxOOMTcaYx\n +5eQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=HZgcT0RypAkTBKk2dEI0odsRmmoAEKRjq5UGrRdfe+E=;\n b=fywjvqJfH3Eq0H6syvlp5QI1g5u6Tx+qwUcFyI2CJLv80SH7B2yuBImyNqo54W2nrm\n 9AKA+d07m974HwCW7czlupn9dLT8YiAlNlco5ee23npF23forxJMWhJ581RNKUJ9Xl9F\n ShNxdLFzIUuIz05+YCIwlVQcPHDmyGxdCFnn6m3/vtgMqqak3oAGrGLEUflmB5KiwmZl\n DRirkXZ+Q/8CMA4SmZ5cDREkiRyWFOw76wbgPkIs7aDEhpnsABKNslrJh3L3PWNCiRQG\n ylgr68NdhZPOxUcA+NznzP+kX4KhvKkBBQohfzpPtSkDJ3KBdfPLjqqUJbfD7wMDR8fZ\n CpyA==", "X-Gm-Message-State": "AOAM530R+H8B/cIJZLe817L6X7ZkACLkqmvUgw/5GomvxHO1volM7RkP\n 9cPUjH8bHAwdjSmkrTcABU4LMtW/20vlEw==", "X-Google-Smtp-Source": "\n ABdhPJz0jBTn2ccMOjxXlhHLjGeoYb9uBqWktaQHptKLZu+pd9oJ5yyX5ISVpb3dG5r98YvMTKMq3g==", "X-Received": "by 2002:a37:584:: with SMTP id 126mr5607811qkf.274.1614890011116;\n Thu, 04 Mar 2021 12:33:31 -0800 (PST)", "From": "Ed Czeck <ed.czeck@atomicrules.com>", "To": "dev@dpdk.org,\n\tferruh.yigit@intel.com", "Cc": "shepard.siegel@atomicrules.com, john.miller@atomicrules.com,\n stable@dpdk.org", "Date": "Thu, 4 Mar 2021 15:33:18 -0500", "Message-Id": "<20210304203321.6154-2-ed.czeck@atomicrules.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210304203321.6154-1-ed.czeck@atomicrules.com>", "References": "<20210304165637.24658-1-ed.czeck@atomicrules.com>\n <20210304203321.6154-1-ed.czeck@atomicrules.com>", "Subject": "[dpdk-dev] [PATCH v2 2/5] net/ark: refactor Rx buffer recovery", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Allocate mbufs for Rx path in bulk of at least 64 buffers\nto improve performance. Allow recovery even without\na rx operation to support lack of buffers in pool.\n\nFixes: be410a861598 (\"net/ark: add recovery for lack of mbufs\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ed Czeck <ed.czeck@atomicrules.com>\n---\n drivers/net/ark/ark_ethdev_rx.c | 49 ++++++++-------------------------\n 1 file changed, 11 insertions(+), 38 deletions(-)", "diff": "diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c\nindex d29d3db78..8e55b851a 100644\n--- a/drivers/net/ark/ark_ethdev_rx.c\n+++ b/drivers/net/ark/ark_ethdev_rx.c\n@@ -26,9 +26,6 @@ static uint32_t eth_ark_rx_jumbo(struct ark_rx_queue *queue,\n \t\t\t\t struct rte_mbuf *mbuf0,\n \t\t\t\t uint32_t cons_index);\n static inline int eth_ark_rx_seed_mbufs(struct ark_rx_queue *queue);\n-static int eth_ark_rx_seed_recovery(struct ark_rx_queue *queue,\n-\t\t\t\t uint32_t *pnb,\n-\t\t\t\t struct rte_mbuf **mbufs);\n \n /* ************************************************************************* */\n struct ark_rx_queue {\n@@ -54,7 +51,7 @@ struct ark_rx_queue {\n \t/* The queue Index is used within the dpdk device structures */\n \tuint16_t queue_index;\n \n-\tuint32_t last_cons;\n+\tuint32_t unused;\n \n \t/* separate cache line */\n \t/* second cache line - fields only used in slow path */\n@@ -105,9 +102,8 @@ static inline void\n eth_ark_rx_update_cons_index(struct ark_rx_queue *queue, uint32_t cons_index)\n {\n \tqueue->cons_index = cons_index;\n-\teth_ark_rx_seed_mbufs(queue);\n-\tif (((cons_index - queue->last_cons) >= 64U)) {\n-\t\tqueue->last_cons = cons_index;\n+\tif ((cons_index + queue->queue_size - queue->seed_index) >= 64U) {\n+\t\teth_ark_rx_seed_mbufs(queue);\n \t\tark_mpu_set_producer(queue->mpu, queue->seed_index);\n \t}\n }\n@@ -321,9 +317,7 @@ eth_ark_recv_pkts(void *rx_queue,\n \t\t\tbreak;\n \t}\n \n-\tif (unlikely(nb != 0))\n-\t\t/* report next free to FPGA */\n-\t\teth_ark_rx_update_cons_index(queue, cons_index);\n+\teth_ark_rx_update_cons_index(queue, cons_index);\n \n \treturn nb;\n }\n@@ -458,11 +452,13 @@ eth_ark_rx_seed_mbufs(struct ark_rx_queue *queue)\n \tint status = rte_pktmbuf_alloc_bulk(queue->mb_pool, mbufs, nb);\n \n \tif (unlikely(status != 0)) {\n-\t\t/* Try to recover from lack of mbufs in pool */\n-\t\tstatus = eth_ark_rx_seed_recovery(queue, &nb, mbufs);\n-\t\tif (unlikely(status != 0)) {\n-\t\t\treturn -1;\n-\t\t}\n+\t\tARK_PMD_LOG(NOTICE,\n+\t\t\t \"Could not allocate %u mbufs from pool\"\n+\t\t\t \" for RX queue %u;\"\n+\t\t\t \" %u free buffers remaining in queue\\n\",\n+\t\t\t nb, queue->queue_index,\n+\t\t\t queue->seed_index - queue->cons_index);\n+\t\treturn -1;\n \t}\n \n \tif (ARK_DEBUG_CORE) {\t\t/* DEBUG */\n@@ -511,29 +507,6 @@ eth_ark_rx_seed_mbufs(struct ark_rx_queue *queue)\n \treturn 0;\n }\n \n-int\n-eth_ark_rx_seed_recovery(struct ark_rx_queue *queue,\n-\t\t\t uint32_t *pnb,\n-\t\t\t struct rte_mbuf **mbufs)\n-{\n-\tint status = -1;\n-\n-\t/* Ignore small allocation failures */\n-\tif (*pnb <= 64)\n-\t\treturn -1;\n-\n-\t*pnb = 64U;\n-\tstatus = rte_pktmbuf_alloc_bulk(queue->mb_pool, mbufs, *pnb);\n-\tif (status != 0) {\n-\t\tARK_PMD_LOG(NOTICE,\n-\t\t\t \"ARK: Could not allocate %u mbufs from pool for RX queue %u;\"\n-\t\t\t \" %u free buffers remaining in queue\\n\",\n-\t\t\t *pnb, queue->queue_index,\n-\t\t\t queue->seed_index - queue->cons_index);\n-\t}\n-\treturn status;\n-}\n-\n void\n eth_ark_rx_dump_queue(struct rte_eth_dev *dev, uint16_t queue_id,\n \t\t const char *msg)\n", "prefixes": [ "v2", "2/5" ] }