Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88263/?format=api
{ "id": 88263, "url": "https://patches.dpdk.org/api/patches/88263/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210226072200.227939-1-wenjun1.wu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210226072200.227939-1-wenjun1.wu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210226072200.227939-1-wenjun1.wu@intel.com", "date": "2021-02-26T07:22:00", "name": "[v2] net/ice: fix unchecked return value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "05cc9a7e06268f14b3b986e6c1c353cd9bdf87ec", "submitter": { "id": 2083, "url": "https://patches.dpdk.org/api/people/2083/?format=api", "name": "Wenjun Wu", "email": "wenjun1.wu@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210226072200.227939-1-wenjun1.wu@intel.com/mbox/", "series": [ { "id": 15394, "url": "https://patches.dpdk.org/api/series/15394/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15394", "date": "2021-02-26T07:22:00", "name": "[v2] net/ice: fix unchecked return value", "version": 2, "mbox": "https://patches.dpdk.org/series/15394/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/88263/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/88263/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8B39AA034F;\n\tFri, 26 Feb 2021 08:37:42 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0BC18407FF;\n\tFri, 26 Feb 2021 08:37:42 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id E0CE240692;\n Fri, 26 Feb 2021 08:37:39 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Feb 2021 23:37:38 -0800", "from wuwenjun.sh.intel.com ([10.67.110.153])\n by orsmga001.jf.intel.com with ESMTP; 25 Feb 2021 23:37:32 -0800" ], "IronPort-SDR": [ "\n t4HFxWbss4XgZp4L4VzrOiqPoVPoXdsYbPAQFE0TyE4m6Zlrv1DkWrWWPcL3178P6AjT9V8vgE\n i0xsw7fM+ZTA==", "\n TIMfVieVXw0N1K3wVDWbmhPbQwJ7JtnpCMadKowk4JPAHVi5DL/Bx8vvGGSXuAPn2RN5vrTNUT\n P3aUkQtggynw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9906\"; a=\"270780896\"", "E=Sophos;i=\"5.81,207,1610438400\"; d=\"scan'208\";a=\"270780896\"", "E=Sophos;i=\"5.81,207,1610438400\"; d=\"scan'208\";a=\"442955032\"" ], "X-ExtLoop1": "1", "From": "Wenjun Wu <wenjun1.wu@intel.com>", "To": "dev@dpdk.org,\n\tqiming.yang@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "Wenjun Wu <wenjun1.wu@intel.com>,\n\tstable@dpdk.org", "Date": "Fri, 26 Feb 2021 15:22:00 +0800", "Message-Id": "<20210226072200.227939-1-wenjun1.wu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210226022542.214104-1>", "References": "<20210226022542.214104-1>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] net/ice: fix unchecked return value", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix unchecked return values reported by coverity.\n\nCoverity issue: 349907\nFixes: 03a05924dad0 (\"net/ice: support device-specific DDP package loading\")\nCc: stable@dpdk.org\n\nSigned-off-by: Wenjun Wu <wenjun1.wu@intel.com>\n\n---\nv2: modify err message; fix the issue related to that reported by coverity\n---\n drivers/net/ice/ice_ethdev.c | 16 +++++++++++++---\n 1 file changed, 13 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex dfd99ace9..f43b2e0b2 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -1663,8 +1663,14 @@ ice_pkg_file_search_path(struct rte_pci_device *pci_dev, char *pkg_file)\n \tpos = rte_pci_find_ext_capability(pci_dev, RTE_PCI_EXT_CAP_ID_DSN);\n \n \tif (pos) {\n-\t\trte_pci_read_config(pci_dev, &dsn_low, 4, pos + 4);\n-\t\trte_pci_read_config(pci_dev, &dsn_high, 4, pos + 8);\n+\t\tif (rte_pci_read_config(pci_dev, &dsn_low, 4, pos + 4) < 0) {\n+\t\t\tPMD_INIT_LOG(ERR, \"Failed to read pci config space\\n\");\n+\t\t\treturn -1;\n+\t\t}\n+\t\tif (rte_pci_read_config(pci_dev, &dsn_high, 4, pos + 8) < 0) {\n+\t\t\tPMD_INIT_LOG(ERR, \"Failed to read pci config space\\n\");\n+\t\t\treturn -1;\n+\t\t}\n \t\tsnprintf(opt_ddp_filename, ICE_MAX_PKG_FILENAME_SIZE,\n \t\t\t \"ice-%08x%08x.pkg\", dsn_high, dsn_low);\n \t} else {\n@@ -1727,7 +1733,11 @@ static int ice_load_pkg(struct rte_eth_dev *dev)\n \tstruct ice_adapter *ad =\n \t\tICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \n-\tice_pkg_file_search_path(pci_dev, pkg_file);\n+\terr = ice_pkg_file_search_path(pci_dev, pkg_file);\n+\tif (err) {\n+\t\tPMD_INIT_LOG(ERR, \"failed to search file path\\n\");\n+\t\treturn err;\n+\t}\n \n \tfile = fopen(pkg_file, \"rb\");\n \tif (!file) {\n", "prefixes": [ "v2" ] }