Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 88255,
    "url": "https://patches.dpdk.org/api/patches/88255/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210225182250.1149592-17-thomas@monjalon.net/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210225182250.1149592-17-thomas@monjalon.net>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210225182250.1149592-17-thomas@monjalon.net",
    "date": "2021-02-25T18:22:49",
    "name": "[v5,16/17] app/testpmd: fix build with musl",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "1796c3c1d96bd6ba11fae44de5ac98b7e1c0433e",
    "submitter": {
        "id": 685,
        "url": "https://patches.dpdk.org/api/people/685/?format=api",
        "name": "Thomas Monjalon",
        "email": "thomas@monjalon.net"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210225182250.1149592-17-thomas@monjalon.net/mbox/",
    "series": [
        {
            "id": 15388,
            "url": "https://patches.dpdk.org/api/series/15388/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15388",
            "date": "2021-02-25T18:22:33",
            "name": "Alpine/musl build support",
            "version": 5,
            "mbox": "https://patches.dpdk.org/series/15388/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/88255/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/88255/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 52645A034F;\n\tThu, 25 Feb 2021 19:25:27 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3611D1608EE;\n\tThu, 25 Feb 2021 19:24:08 +0100 (CET)",
            "from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com\n [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 98E3916080A;\n Thu, 25 Feb 2021 19:24:07 +0100 (CET)",
            "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.nyi.internal (Postfix) with ESMTP id 40CE75C00C5;\n Thu, 25 Feb 2021 13:24:07 -0500 (EST)",
            "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Thu, 25 Feb 2021 13:24:07 -0500",
            "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 0E419240054;\n Thu, 25 Feb 2021 13:24:05 -0500 (EST)"
        ],
        "DKIM-Signature": [
            "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-type:content-transfer-encoding; s=fm3; bh=\n uuctzikRObxp0/hu4uvMy6utWUI8ejyogHL8LYIO85g=; b=tdbO4XBR3hkSx5uR\n KXcHTynsLmMjV8LAwwziqEyAi8yQ/OdOgsqutBz8BTroiBmWGYbIhFrBbIzOA9H/\n 0JUHF/tZgXzRRXbwMgVpMgwT9tWhww0b8Qt9HOSsJf8Mzqx5mC8GlvLoDYSt0zjw\n yRo26ypkLVFNwzd6igfmnH8VfCE3ShrXeJtojZqLf8zCnqSgYqVfXMjklSUbffc/\n vggny9lTGBCehC2TVxtjeRmmufGeggTZ27Jlyqmfurj8L9BS6vgKFBIDKBOljz0T\n 3nzWGX0GvIiQeV+akGsVOfM+x8QKwglCd6LVAZCMxiH56UnjFTDN5AZZwsaihzmv\n eXa9eA==",
            "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:content-type\n :date:from:in-reply-to:message-id:mime-version:references\n :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n :x-sasl-enc; s=fm2; bh=uuctzikRObxp0/hu4uvMy6utWUI8ejyogHL8LYIO8\n 5g=; b=GAFqVXxyEfALvJdqQfGdzczKIlr3kbiQ2pvD61FXhMKW2eqaQKj/GxWtj\n +P8uRU8kSJIsdA6jbooSbqJWJJogZPKscfOGtIHgDZSBUXW1ESlmc8Ch3qshyxuD\n MliFwjBF1tpNjWxD173bcF0KlIPpEOMp3siqRZYqU7Oyxf3gk/KT3DnnZuGvzG7c\n GqbMTGQwd3s1hxy/g+1o9rLcaZMazo0sAFTzwG936lGf684yR7wLfAVc9PluuOFg\n /gPFQngcs6d99DQiEYR+KPjld0lAkdIUH/CNMBN2drYNlkpzfy9yZgcQ9e0sppvZ\n ZWLOcJpEByeTJrb+fEoaomr7TJFRg=="
        ],
        "X-ME-Sender": "<xms:Rus3YOWwSmHlk-wMElPvLnKom7SqX0sx9ykEiaYrX3itILVM9ameYA>\n <xme:Rus3YKkrzXiXnZ3hrjn5igJhGIso9-8Zd1XbWpEmLuxPcWV646W278aofa-e9Hcjl\n 4hhKVLa7laONPEa0w>",
        "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduledrkeelgdduudegucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepvfhhohhm\n rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc\n ggtffrrghtthgvrhhnpeevuddtveeuveejkeevheehveffueegjedukeffledtleekieef\n geduhedvgeejhfenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh\n fuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr\n lhhonhdrnhgvth",
        "X-ME-Proxy": "<xmx:Rus3YCbFwYmMMsjIn8tB6ujlxiGPDLDy9ksi1neVKhPc61_1Asmwig>\n <xmx:Rus3YFWBjLaNwF2PccwvCYTekYw3v83ccRr61mo86L7WVZPO51GfjA>\n <xmx:Rus3YIkzpSJF_2_XLOxkrMSIma7y9fjmHwqtv6felLbpAAt6EpraKA>\n <xmx:R-s3YHtCKfZLZzwbM5up-Hk-S34MGBWLpf1M3UcCpurr5_Ev0nCkeQ>",
        "From": "Thomas Monjalon <thomas@monjalon.net>",
        "To": "dev@dpdk.org",
        "Cc": "ncopa@alpinelinux.org, stable@dpdk.org,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Xiaoyun Li <xiaoyun.li@intel.com>,\n =?utf-8?q?N=C3=A9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>,\n Ferruh Yigit <ferruh.yigit@intel.com>",
        "Date": "Thu, 25 Feb 2021 19:22:49 +0100",
        "Message-Id": "<20210225182250.1149592-17-thomas@monjalon.net>",
        "X-Mailer": "git-send-email 2.30.1",
        "In-Reply-To": "<20210225182250.1149592-1-thomas@monjalon.net>",
        "References": "<20190313170657.16688-1-ncopa@alpinelinux.org>\n <20210225182250.1149592-1-thomas@monjalon.net>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v5 16/17] app/testpmd: fix build with musl",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Natanael Copa <ncopa@alpinelinux.org>\n\n1/ Improve portability by avoiding use of non-standard 'uint'.\nUse uint8_t for hash_key_len as rss_key_len is a uint8_t type.\nThis solves following build error when building with musl libc:\n    app/test-pmd/testpmd.h:813:29: error: unknown type name 'uint'\n\n2/ In musl libc, stdout is of type (FILE * const).\nBecause of the const qualifier, a dark magic cast\nmust be achieved through uintptr_t.\n\nFixes: 8205e241b2b0 (\"app/testpmd: add missing type to RSS hash commands\")\nFixes: e977e4199a8d (\"app/testpmd: add commands to load/unload BPF filters\")\nCc: stable@dpdk.org\n\nSigned-off-by: Natanael Copa <ncopa@alpinelinux.org>\nReviewed-by: Morten Brørup <mb@smartsharesystems.com>\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n app/test-pmd/bpf_cmd.c | 2 +-\n app/test-pmd/config.c  | 2 +-\n app/test-pmd/testpmd.h | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/app/test-pmd/bpf_cmd.c b/app/test-pmd/bpf_cmd.c\nindex 066619e115..6980291f07 100644\n--- a/app/test-pmd/bpf_cmd.c\n+++ b/app/test-pmd/bpf_cmd.c\n@@ -20,7 +20,7 @@ static const struct rte_bpf_xsym bpf_xsym[] = {\n \t\t.name = RTE_STR(stdout),\n \t\t.type = RTE_BPF_XTYPE_VAR,\n \t\t.var = {\n-\t\t\t.val = &stdout,\n+\t\t\t.val = (void *)(uintptr_t)&stdout,\n \t\t\t.desc = {\n \t\t\t\t.type = RTE_BPF_ARG_PTR,\n \t\t\t\t.size = sizeof(stdout),\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex dab8afe5dd..9ca03c236e 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -2963,7 +2963,7 @@ port_rss_hash_conf_show(portid_t port_id, int show_rss_key)\n \n void\n port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *hash_key,\n-\t\t\t uint hash_key_len)\n+\t\t\t uint8_t hash_key_len)\n {\n \tstruct rte_eth_rss_conf rss_conf;\n \tint diag;\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex 4aca522859..5437b6229e 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -935,7 +935,7 @@ int set_vf_rate_limit(portid_t port_id, uint16_t vf, uint16_t rate,\n \n void port_rss_hash_conf_show(portid_t port_id, int show_rss_key);\n void port_rss_hash_key_update(portid_t port_id, char rss_type[],\n-\t\t\t      uint8_t *hash_key, uint hash_key_len);\n+\t\t\t      uint8_t *hash_key, uint8_t hash_key_len);\n int rx_queue_id_is_invalid(queueid_t rxq_id);\n int tx_queue_id_is_invalid(queueid_t txq_id);\n void setup_gro(const char *onoff, portid_t port_id);\n",
    "prefixes": [
        "v5",
        "16/17"
    ]
}