Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88242/?format=api
{ "id": 88242, "url": "https://patches.dpdk.org/api/patches/88242/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210225182250.1149592-4-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210225182250.1149592-4-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20210225182250.1149592-4-thomas@monjalon.net", "date": "2021-02-25T18:22:36", "name": "[v5,03/17] build: detect execinfo library on Linux", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cf7cbab48cdca95c4504d8a3ec3207f741a5a67a", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210225182250.1149592-4-thomas@monjalon.net/mbox/", "series": [ { "id": 15388, "url": "https://patches.dpdk.org/api/series/15388/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15388", "date": "2021-02-25T18:22:33", "name": "Alpine/musl build support", "version": 5, "mbox": "https://patches.dpdk.org/series/15388/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/88242/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/88242/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7D76CA034F;\n\tThu, 25 Feb 2021 19:23:38 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4CE23160828;\n\tThu, 25 Feb 2021 19:23:27 +0100 (CET)", "from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com\n [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 57522160806;\n Thu, 25 Feb 2021 19:23:25 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.nyi.internal (Postfix) with ESMTP id EE6B55C00AE;\n Thu, 25 Feb 2021 13:23:24 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Thu, 25 Feb 2021 13:23:24 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 45277240065;\n Thu, 25 Feb 2021 13:23:24 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm3; bh=BgeJ+Y5pK8WsD\n A+DYJfdzKbbUcW7A3oG9YMbHxH+ykU=; b=tvm1/ar2VD5ktJXt8lDa3dtO8Zt0O\n qr6qu2Q/y1Fhx230nJYNEts2dnmAcD0tpK/CY2iGseazYWmr17W97QhYd28vv5Jl\n EdOypAb/Ys1V0UwdnYnt7GNFmE//s8U9UQcCpU8U2ZXzvtyQQOctn4wPSqiysCVH\n Pf5ophh/5CEu+OPdquYNTQU1ataLMLswsjxqNXuWJJH/w00JS7vxyhy51Owjn+rb\n 50Gw4HGZoaJZwVI6qh6mmx8imaZ4rzZ9hnNpWAOP9lrGmWp2r7hcJzYfRQA6Vu45\n hg85tlr7+p/gzvtlfeKaRsJBhWU/nrO/PDb3TNOMXbEbUZqKklun6Np+A==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm2; bh=BgeJ+Y5pK8WsDA+DYJfdzKbbUcW7A3oG9YMbHxH+ykU=; b=SqoaKUrb\n PC16NTyPSqpNuBiVzqQIii93YYs5WpWJE4g2qVuEP7JuPo/M+ngb7fRhVUUBzuG5\n KrCQwtDdwZQcFLBvxvneEstcQ4pE1873UifzOxT9QUoXJ667eUS8kGqsZvnxse/z\n kENMAMNrgZjL8d7Cmg3mJl6eh++DREw5jPyNdQtVRTdTppP0wR8C+sA5vsJTTurI\n PWsqWn4yBDrHthwNW7sK4hEvZFUM9MDCWYJ2JpE0EfWY5O7/Z/GhVrdkqNReqevx\n Y95MvTvzTQDR1HMx8+mLiQ6bHIrAp+jr3jBLcZqCQ/JaRic9Jmoz6JsgjooPfQM5\n Csqfbd5T27efcw==" ], "X-ME-Sender": "<xms:HOs3YOoBOQHPxA4NJ9fb54w0gcwlsv82kWkZ19v1MAMc55IBQQp9ow>\n <xme:HOs3YMoorLSBJXXDQ9-_iPQvT6Hy1Zadt7F95wsZZl1ZxJyNfrXjgXd23XLwvXqVo\n 5vgx4Z_Pk7SS1FOIA>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduledrkeelgdduudegucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:HOs3YDMyi1deWBsdG9-lOjSZ66PpKftK_qclGxws0hJQ4M6J8IsFQw>\n <xmx:HOs3YN6dRRtRRYXthZysLyPptAxrVOgzh5YzgHUkrZEvNuyfOYZKeQ>\n <xmx:HOs3YN5vZXEzsuWg8YunsWD9uUCUcczP6EHqVPUqYlOpiyfWov9Flw>\n <xmx:HOs3YPRGc4_z86if2KBMCWt_dOkhDt_pY28ty_IWXeAt1m8edD0k0Q>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ncopa@alpinelinux.org, stable@dpdk.org,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 25 Feb 2021 19:22:36 +0100", "Message-Id": "<20210225182250.1149592-4-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.30.1", "In-Reply-To": "<20210225182250.1149592-1-thomas@monjalon.net>", "References": "<20190313170657.16688-1-ncopa@alpinelinux.org>\n <20210225182250.1149592-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 03/17] build: detect execinfo library on Linux", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The library execinfo and its header file can be installed on Alpine Linux\nwhere the backtrace feature is not part of musl libc:\n\tapk add libexecinfo-dev\n\nAs a consequence, this library should not be restricted to BSD only.\n\nAt the same time, the library and header are detected once and added\nglobally to be linked with any application, internal or external.\n\nFixes: 9065b1fac65f (\"build: fix dependency on execinfo for BSD meson builds\")\nCc: stable@dpdk.org\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n app/meson.build | 4 ----\n app/test/meson.build | 1 -\n config/meson.build | 9 ++++++---\n examples/meson.build | 4 +---\n 4 files changed, 7 insertions(+), 11 deletions(-)", "diff": "diff --git a/app/meson.build b/app/meson.build\nindex 87fc195dbf..50a53dbde8 100644\n--- a/app/meson.build\n+++ b/app/meson.build\n@@ -21,9 +21,6 @@ apps = [\n \t'test-regex',\n \t'test-sad']\n \n-# for BSD only\n-lib_execinfo = cc.find_library('execinfo', required: false)\n-\n default_cflags = machine_args + ['-DALLOW_EXPERIMENTAL_API']\n default_ldflags = []\n if get_option('default_library') == 'static' and not is_windows\n@@ -53,7 +50,6 @@ foreach app:apps\n \t\t\tdep_objs += get_variable(get_option('default_library')\n \t\t\t\t + '_rte_' + d)\n \t\tendforeach\n-\t\tdep_objs += lib_execinfo\n \n \t\tlink_libs = []\n \t\tif get_option('default_library') == 'static'\ndiff --git a/app/test/meson.build b/app/test/meson.build\nindex 561e493a29..099895fc87 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -426,7 +426,6 @@ foreach d:test_deps\n \tdef_lib = get_option('default_library')\n \ttest_dep_objs += get_variable(def_lib + '_rte_' + d)\n endforeach\n-test_dep_objs += cc.find_library('execinfo', required: false)\n \n link_libs = []\n if get_option('default_library') == 'static'\ndiff --git a/config/meson.build b/config/meson.build\nindex 3cf560b8a3..66a2edcc47 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -125,11 +125,8 @@ if cc.find_library('m', required : false).found()\n \tdpdk_extra_ldflags += '-lm'\n endif\n \n-# for linux link against dl, for bsd execinfo\n if is_linux\n \tlink_lib = 'dl'\n-elif is_freebsd\n-\tlink_lib = 'execinfo'\n else\n \tlink_lib = ''\n endif\n@@ -166,6 +163,12 @@ if fdt_dep.found() and cc.has_header('fdt.h')\n \tdpdk_extra_ldflags += '-lfdt'\n endif\n \n+libexecinfo = cc.find_library('libexecinfo', required: false)\n+if libexecinfo.found() and cc.has_header('execinfo.h')\n+\tadd_project_link_arguments('-lexecinfo', language: 'c')\n+\tdpdk_extra_ldflags += '-lexecinfo'\n+endif\n+\n # check for libbsd\n libbsd = dependency('libbsd', required: false, method: 'pkg-config')\n if libbsd.found()\ndiff --git a/examples/meson.build b/examples/meson.build\nindex b9ab24223f..ab06e2da33 100644\n--- a/examples/meson.build\n+++ b/examples/meson.build\n@@ -6,8 +6,6 @@ if get_option('default_library') == 'static'\n \tlink_whole_libs = dpdk_static_libraries + dpdk_drivers\n endif\n \n-execinfo = cc.find_library('execinfo', required: false)\n-\n # list of all example apps. Keep 1-3 per line, in alphabetical order.\n all_examples = [\n \t'bbdev_app', 'bond',\n@@ -76,7 +74,7 @@ foreach example: examples\n \tcflags = default_cflags\n \tldflags = default_ldflags\n \n-\text_deps = [execinfo]\n+\text_deps = []\n \tincludes = [include_directories(example)]\n \tdeps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline']\n \tsubdir(example)\n", "prefixes": [ "v5", "03/17" ] }