Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 88205,
    "url": "https://patches.dpdk.org/api/patches/88205/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210225093213.2811627-2-feifei.wang2@arm.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210225093213.2811627-2-feifei.wang2@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210225093213.2811627-2-feifei.wang2@arm.com",
    "date": "2021-02-25T09:32:13",
    "name": "[v2,1/1] app/test: collect perf data after worker threads exit",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "cdc66dda56bbcf9568419588e7a08606d69bd4c5",
    "submitter": {
        "id": 1771,
        "url": "https://patches.dpdk.org/api/people/1771/?format=api",
        "name": "Feifei Wang",
        "email": "feifei.wang2@arm.com"
    },
    "delegate": {
        "id": 24651,
        "url": "https://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210225093213.2811627-2-feifei.wang2@arm.com/mbox/",
    "series": [
        {
            "id": 15373,
            "url": "https://patches.dpdk.org/api/series/15373/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15373",
            "date": "2021-02-25T09:32:12",
            "name": "remove smp barriers in app/test",
            "version": 2,
            "mbox": "https://patches.dpdk.org/series/15373/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/88205/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/88205/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E747AA034F;\n\tThu, 25 Feb 2021 10:32:29 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 56BF116076E;\n\tThu, 25 Feb 2021 10:32:26 +0100 (CET)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 2B50B160749;\n Thu, 25 Feb 2021 10:32:25 +0100 (CET)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7924AED1;\n Thu, 25 Feb 2021 01:32:24 -0800 (PST)",
            "from net-x86-dell-8268.shanghai.arm.com\n (net-x86-dell-8268.shanghai.arm.com [10.169.210.127])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5C4553F73D;\n Thu, 25 Feb 2021 01:32:21 -0800 (PST)"
        ],
        "From": "Feifei Wang <feifei.wang2@arm.com>",
        "To": "Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n David Marchand <david.marchand@redhat.com>",
        "Cc": "dev@dpdk.org, nd@arm.com, Feifei Wang <feifei.wang2@arm.com>,\n stable@dpdk.org, Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>",
        "Date": "Thu, 25 Feb 2021 17:32:13 +0800",
        "Message-Id": "<20210225093213.2811627-2-feifei.wang2@arm.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20210225093213.2811627-1-feifei.wang2@arm.com>",
        "References": "<20210225093213.2811627-1-feifei.wang2@arm.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v2 1/1] app/test: collect perf data after worker\n threads exit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The measure_perf function should be executed after worker threads exit\nto collect correct perf data. Otherwise, while workers are running, the\nmain thread may get incomplete data from workers.\n\nIn the meanwhile, remove unnecessary barrier in the test.\nFor signal variables \"ldata.done\" and \"ldata.start\", no operations\nshould keep the order that being executed after them. So the wmb after\nthem can be moved.\n\nFixes: 16a277a24c9f (\"test/trace: add performance test cases\")\nCc: jerinj@marvell.com\nCc: stable@dpdk.org\n\nSuggested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n app/test/test_trace_perf.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/app/test/test_trace_perf.c b/app/test/test_trace_perf.c\nindex e1ad8e6f5..46ae7d807 100644\n--- a/app/test/test_trace_perf.c\n+++ b/app/test/test_trace_perf.c\n@@ -79,7 +79,6 @@ signal_workers_to_finish(struct test_data *data)\n \n \tfor (workers = 0; workers < data->nb_workers; workers++) {\n \t\tdata->ldata[workers].done = 1;\n-\t\trte_smp_wmb();\n \t}\n }\n \n@@ -102,7 +101,6 @@ worker_fn_##func(void *arg) \\\n { \\\n \tstruct lcore_data *ldata = arg; \\\n \tldata->started = 1; \\\n-\trte_smp_wmb(); \\\n \t__worker_##func(ldata); \\\n \treturn 0; \\\n }\n@@ -137,11 +135,12 @@ run_test(const char *str, lcore_function_t f, struct test_data *data, size_t sz)\n \n \twait_till_workers_are_ready(data);\n \trte_delay_ms(100); /* Wait for some time to accumulate the stats */\n-\tmeasure_perf(str, data);\n \tsignal_workers_to_finish(data);\n \n \tRTE_LCORE_FOREACH_WORKER(id)\n \t\trte_eal_wait_lcore(id);\n+\n+\tmeasure_perf(str, data);\n }\n \n static int\n",
    "prefixes": [
        "v2",
        "1/1"
    ]
}