Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88138/?format=api
{ "id": 88138, "url": "https://patches.dpdk.org/api/patches/88138/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210224124311.29799-3-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210224124311.29799-3-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210224124311.29799-3-hemant.agrawal@nxp.com", "date": "2021-02-24T12:42:50", "name": "[v3,02/23] bus/dpaa: fix statistics reading", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2ed2afd4a0a607eeca47f497a8790b3599a09b5e", "submitter": { "id": 477, "url": "https://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210224124311.29799-3-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 15361, "url": "https://patches.dpdk.org/api/series/15361/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15361", "date": "2021-02-24T12:42:48", "name": "NXP DPAAx ethernet PMD changes", "version": 3, "mbox": "https://patches.dpdk.org/series/15361/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/88138/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/88138/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 535C2A034F;\n\tWed, 24 Feb 2021 13:43:34 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3227D16083C;\n\tWed, 24 Feb 2021 13:43:23 +0100 (CET)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n by mails.dpdk.org (Postfix) with ESMTP id 0C47F16082D;\n Wed, 24 Feb 2021 13:43:21 +0100 (CET)", "from inva020.nxp.com (localhost [127.0.0.1])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id C0DE51A0396;\n Wed, 24 Feb 2021 13:43:20 +0100 (CET)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 3E35F1A0391;\n Wed, 24 Feb 2021 13:43:18 +0100 (CET)", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id A4F6B40324;\n Wed, 24 Feb 2021 13:43:14 +0100 (CET)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, stable@dpdk.org, Nipun Gupta <nipun.gupta@nxp.com>", "Date": "Wed, 24 Feb 2021 18:12:50 +0530", "Message-Id": "<20210224124311.29799-3-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210224124311.29799-1-hemant.agrawal@nxp.com>", "References": "<20210211141620.12482-1-hemant.agrawal@nxp.com>\n <20210224124311.29799-1-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v3 02/23] bus/dpaa: fix statistics reading", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nipun Gupta <nipun.gupta@nxp.com>\n\nReading of word un-aligned values after reading word aligned\nvalues lead to corrution of memory, such that older value.\nThis patch make changes such that word alignedaccess is made,\nbefore making an un-aligned access\n\nFixes: 6d6b4f49a155 (\"bus/dpaa: add FMAN hardware operations\")\nCc: stable@dpdk.org\n\nSigned-off-by: Nipun Gupta <nipun.gupta@nxp.com>\nAcked-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/bus/dpaa/base/fman/fman_hw.c | 33 ++++++++++++++--------------\n 1 file changed, 16 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/bus/dpaa/base/fman/fman_hw.c b/drivers/bus/dpaa/base/fman/fman_hw.c\nindex 4ab49f7853..af9bac76c2 100644\n--- a/drivers/bus/dpaa/base/fman/fman_hw.c\n+++ b/drivers/bus/dpaa/base/fman/fman_hw.c\n@@ -1,6 +1,6 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n *\n- * Copyright 2017 NXP\n+ * Copyright 2017,2020 NXP\n *\n */\n \n@@ -219,20 +219,20 @@ fman_if_stats_get(struct fman_if *p, struct rte_eth_stats *stats)\n \tstruct memac_regs *regs = m->ccsr_map;\n \n \t/* read recved packet count */\n-\tstats->ipackets = ((u64)in_be32(®s->rfrm_u)) << 32 |\n-\t\t\tin_be32(®s->rfrm_l);\n-\tstats->ibytes = ((u64)in_be32(®s->roct_u)) << 32 |\n-\t\t\tin_be32(®s->roct_l);\n-\tstats->ierrors = ((u64)in_be32(®s->rerr_u)) << 32 |\n-\t\t\tin_be32(®s->rerr_l);\n+\tstats->ipackets = (u64)in_be32(®s->rfrm_l) |\n+\t\t\t((u64)in_be32(®s->rfrm_u)) << 32;\n+\tstats->ibytes = (u64)in_be32(®s->roct_l) |\n+\t\t\t((u64)in_be32(®s->roct_u)) << 32;\n+\tstats->ierrors = (u64)in_be32(®s->rerr_l) |\n+\t\t\t((u64)in_be32(®s->rerr_u)) << 32;\n \n \t/* read xmited packet count */\n-\tstats->opackets = ((u64)in_be32(®s->tfrm_u)) << 32 |\n-\t\t\tin_be32(®s->tfrm_l);\n-\tstats->obytes = ((u64)in_be32(®s->toct_u)) << 32 |\n-\t\t\tin_be32(®s->toct_l);\n-\tstats->oerrors = ((u64)in_be32(®s->terr_u)) << 32 |\n-\t\t\tin_be32(®s->terr_l);\n+\tstats->opackets = (u64)in_be32(®s->tfrm_l) |\n+\t\t\t((u64)in_be32(®s->tfrm_u)) << 32;\n+\tstats->obytes = (u64)in_be32(®s->toct_l) |\n+\t\t\t((u64)in_be32(®s->toct_u)) << 32;\n+\tstats->oerrors = (u64)in_be32(®s->terr_l) |\n+\t\t\t((u64)in_be32(®s->terr_u)) << 32;\n }\n \n void\n@@ -244,10 +244,9 @@ fman_if_stats_get_all(struct fman_if *p, uint64_t *value, int n)\n \tuint64_t base_offset = offsetof(struct memac_regs, reoct_l);\n \n \tfor (i = 0; i < n; i++)\n-\t\tvalue[i] = ((u64)in_be32((char *)regs\n-\t\t\t\t+ base_offset + 8 * i + 4)) << 32 |\n-\t\t\t\t((u64)in_be32((char *)regs\n-\t\t\t\t+ base_offset + 8 * i));\n+\t\tvalue[i] = (((u64)in_be32((char *)regs + base_offset + 8 * i) |\n+\t\t\t\t(u64)in_be32((char *)regs + base_offset +\n+\t\t\t\t8 * i + 4)) << 32);\n }\n \n void\n", "prefixes": [ "v3", "02/23" ] }