Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88058/?format=api
{ "id": 88058, "url": "https://patches.dpdk.org/api/patches/88058/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210221111637.31193-3-irusskikh@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210221111637.31193-3-irusskikh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210221111637.31193-3-irusskikh@marvell.com", "date": "2021-02-21T11:16:37", "name": "[2/2] qede: make driver accept bigger rss tables", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "7c581ef5a2cfc16f027084bf0823bfa1a865c3cf", "submitter": { "id": 1972, "url": "https://patches.dpdk.org/api/people/1972/?format=api", "name": "Igor Russkikh", "email": "irusskikh@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210221111637.31193-3-irusskikh@marvell.com/mbox/", "series": [ { "id": 15321, "url": "https://patches.dpdk.org/api/series/15321/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15321", "date": "2021-02-21T11:16:35", "name": "qede: 2020-02 minor fixes", "version": 1, "mbox": "https://patches.dpdk.org/series/15321/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/88058/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/88058/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 84134A034F;\n\tSun, 21 Feb 2021 12:16:57 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 03AEB22A2A7;\n\tSun, 21 Feb 2021 12:16:47 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id F13A122A2A4;\n Sun, 21 Feb 2021 12:16:45 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 11LB9eMW020545; Sun, 21 Feb 2021 03:16:45 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com with ESMTP id 36u2tu1jcr-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Sun, 21 Feb 2021 03:16:45 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Sun, 21 Feb 2021 03:16:43 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Sun, 21 Feb 2021 03:16:43 -0800", "from EL-LT0043.marvell.com (unknown [10.193.38.106])\n by maili.marvell.com (Postfix) with ESMTP id 0B12D3F703F;\n Sun, 21 Feb 2021 03:16:41 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=UuYLNLVvs2EEUerQ0Sbf/NZWMvmILP9lVNcUj1q3bPU=;\n b=Qjt3ZtCnZG4rp24QKJDjU3hhqB5ZoNZ9LyVrAswIg0+UqP7rhFQgdJj+7ThThDIobnya\n zvmvVbTT0tvf7X0rYhgTHYmGrVFxbT2sJ+22sQj1bcBvZ62Kpm5q3jDRtL3FKUQ10SZY\n 4u4zrofxb78Xb2LFhEYLCxnoQ0P5zEXV7JkPwPs1JjXXqjUO1cjbRm22GnGc3iSw/JDR\n F6FWTxxysZy9wCP+vvbeeUlnVIa2KIwhwyYtJ9EcKfDt4jDvHaCsSyOppcqxRPfWEvkw\n i+EEqGhSPa1TfrQwQXyGgwdVk78GXG8kg/4Qs3woVMaNgUuRbR5z3IN4Y+THIfmJOf5O 4A==", "From": "Igor Russkikh <irusskikh@marvell.com>", "To": "<dev@dpdk.org>", "CC": "Rasesh Mody <rmody@marvell.com>, Devendra Singh Rawat\n <dsinghrawat@marvell.com>,\n Igor Russkikh <irusskikh@marvell.com>, <stable@dpdk.org>", "Date": "Sun, 21 Feb 2021 12:16:37 +0100", "Message-ID": "<20210221111637.31193-3-irusskikh@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210221111637.31193-1-irusskikh@marvell.com>", "References": "<20210221111637.31193-1-irusskikh@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761\n definitions=2021-02-21_03:2021-02-18,\n 2021-02-21 signatures=0", "Subject": "[dpdk-dev] [PATCH 2/2] qede: make driver accept bigger rss tables", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We found some dpdk applications blindly pass fixed side rss hash tables,\nand do not check driver/device capabilities.\n\nMoreover, many other drivers do not do such a strong check as well.\n\nSo here we fix it, making qede accept any size rss_key. For larger key\ntables we just crop it with notice trace message.\n\nCC: stable@dpdk.org\nSigned-off-by: Igor Russkikh <irusskikh@marvell.com>\n---\n drivers/net/qede/qede_ethdev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c\nindex ab5f5b106..7363d98f2 100644\n--- a/drivers/net/qede/qede_ethdev.c\n+++ b/drivers/net/qede/qede_ethdev.c\n@@ -2139,8 +2139,8 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev,\n \t\t/* RSS hash key */\n \t\tif (key) {\n \t\t\tif (len > (ECORE_RSS_KEY_SIZE * sizeof(uint32_t))) {\n-\t\t\t\tDP_ERR(edev, \"RSS key length exceeds limit\\n\");\n-\t\t\t\treturn -EINVAL;\n+\t\t\t\tlen = ECORE_RSS_KEY_SIZE * sizeof(uint32_t);\n+\t\t\t\tDP_NOTICE(edev, false, \"RSS key length exceeds limit\\n\");\n \t\t\t}\n \t\t\tDP_INFO(edev, \"Applying user supplied hash key\\n\");\n \t\t\trss_params.update_rss_key = 1;\n", "prefixes": [ "2/2" ] }