Patch Comment List
List patch comments
GET /api/patches/88/comments/?format=api
[ { "id": 224, "web_url": "https://patches.dpdk.org/comment/224/", "msgid": "<2490690.EmSZ5vBN3i@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/2490690.EmSZ5vBN3i@xps13", "date": "2014-07-24T07:48:25", "subject": "Re: [dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet\n\tclassification type", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "Hi Helin,\n\n2014-07-24 14:42, Helin Zhang:\n> For better understanding, 'PCTYPE' was added to the name of i40e\n> RSS shift macros.\n> \n> Signed-off-by: Helin Zhang <helin.zhang@intel.com>\n\n> -#define ETH_RSS_NONF_IPV4_UDP_SHIFT 31\n> +#define ETH_PCTYPE_NONF_IPV4_UDP 31\n\nWhy is it clearer? I don't understand what means PCTYPE.", "headers": { "Return-Path": "<thomas.monjalon@6wind.com>", "Received": [ "from mail-wg0-f48.google.com (mail-wg0-f48.google.com\n\t[74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 54B8A594D\n\tfor <dev@dpdk.org>; Thu, 24 Jul 2014 09:47:08 +0200 (CEST)", "by mail-wg0-f48.google.com with SMTP id x13so2270979wgg.7\n\tfor <dev@dpdk.org>; Thu, 24 Jul 2014 00:48:35 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\td4sm19493166wiy.13.2014.07.24.00.48.33 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 24 Jul 2014 00:48:34 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=908tTS6bpo86Z8qZL1+WB3CGzY/5RhueScjvHQlx3Ag=;\n\tb=hyGwNy9bZZ01qWcJ5SSVehU+zbOZpAuDi1ELODsbJl1HDp3PiRVJ/EVHdUDBcR7gNE\n\tCpLOrW5kQ4v6XAPSueyeVtEAA8SaDg4djQm6WB8ti3q+61fe9hSkbiaEu+IvA+MW5ty8\n\t+jc9hmbBxSbaNT2CJhAXcVGNKxOqEBqchdVOpwgEgAMJIc2m2Uz9A4YtuiszBhyzDzq/\n\tbASTs0qwwTV4QCucq6osIbDVcusGBgGtFdE7PFyTLNFRfPN3r+hiqpWIOlWt7vIUNui0\n\tYLCu2+gVnYl3Pi/gZQw4HSrfXEts1lhe0Xo1UXAx+Kl6VF8fCEG0XdVSyFLKC6a2ta8G\n\t3rGQ==", "X-Gm-Message-State": "ALoCoQlqrqrJsCPV2XgFeu5dJ6NuMkm2h6uHV72yhEtT87+ymrcgXapj2xaZl1cqYWj9vfzjqTSZ", "X-Received": "by 10.194.48.103 with SMTP id k7mr9432638wjn.68.1406188115161;\n\tThu, 24 Jul 2014 00:48:35 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Helin Zhang <helin.zhang@intel.com>", "Date": "Thu, 24 Jul 2014 09:48:25 +0200", "Message-ID": "<2490690.EmSZ5vBN3i@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.2 (Linux/3.15.5-2-ARCH; KDE/4.13.2; x86_64; ; )", "In-Reply-To": "<1406184149-11531-2-git-send-email-helin.zhang@intel.com>", "References": "<1406184149-11531-1-git-send-email-helin.zhang@intel.com>\n\t<1406184149-11531-2-git-send-email-helin.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet\n\tclassification type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Thu, 24 Jul 2014 07:47:08 -0000" }, "addressed": null }, { "id": 229, "web_url": "https://patches.dpdk.org/comment/229/", "msgid": "<F35DEAC7BCE34641BA9FAC6BCA4A12E70A7627BF@SHSMSX104.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/F35DEAC7BCE34641BA9FAC6BCA4A12E70A7627BF@SHSMSX104.ccr.corp.intel.com", "date": "2014-07-24T08:14:32", "subject": "Re: [dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet\n\tclassification type", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "content": "> -----Original Message-----\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> Sent: Thursday, July 24, 2014 3:48 PM\n> To: Zhang, Helin\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet\n> classification type\n> \n> Hi Helin,\n> \n> 2014-07-24 14:42, Helin Zhang:\n> > For better understanding, 'PCTYPE' was added to the name of i40e RSS\n> > shift macros.\n> >\n> > Signed-off-by: Helin Zhang <helin.zhang@intel.com>\n> \n> > -#define ETH_RSS_NONF_IPV4_UDP_SHIFT 31\n> > +#define ETH_PCTYPE_NONF_IPV4_UDP 31\n> \n> Why is it clearer? I don't understand what means PCTYPE.\n> \n> --\n> Thomas\n\nHi Thomas\n\nIt is 'packet classification type' defined in data sheet, and widely used. It is not just for RSS only, it can be used for flow director possibly. That's why I think it would be better to rename it with PCTYPE names. Thank you!\n\nRegards,\nHelin", "headers": { "Return-Path": "<helin.zhang@intel.com>", "Received": [ "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 34F1D5930\n\tfor <dev@dpdk.org>; Thu, 24 Jul 2014 10:13:10 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 24 Jul 2014 01:14:36 -0700", "from fmsmsx104.amr.corp.intel.com ([10.19.9.35])\n\tby fmsmga002.fm.intel.com with ESMTP; 24 Jul 2014 01:14:36 -0700", "from fmsmsx151.amr.corp.intel.com (10.19.17.220) by\n\tFMSMSX104.amr.corp.intel.com (10.19.9.35) with Microsoft SMTP Server\n\t(TLS) id 14.3.123.3; Thu, 24 Jul 2014 01:14:35 -0700", "from shsmsx102.ccr.corp.intel.com (10.239.4.154) by\n\tFMSMSX151.amr.corp.intel.com (10.19.17.220) with Microsoft SMTP\n\tServer (TLS) id 14.3.123.3; Thu, 24 Jul 2014 01:14:35 -0700", "from shsmsx104.ccr.corp.intel.com ([169.254.5.204]) by\n\tshsmsx102.ccr.corp.intel.com ([169.254.2.120]) with mapi id\n\t14.03.0123.003; Thu, 24 Jul 2014 16:14:34 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.01,722,1400050800\"; d=\"scan'208\";a=\"574670842\"", "From": "\"Zhang, Helin\" <helin.zhang@intel.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet\n\tclassification type", "Thread-Index": "AQHPpxO7hZbuZpxe6Uy2+vEfk1yc85uu3+ng", "Date": "Thu, 24 Jul 2014 08:14:32 +0000", "Message-ID": "<F35DEAC7BCE34641BA9FAC6BCA4A12E70A7627BF@SHSMSX104.ccr.corp.intel.com>", "References": "<1406184149-11531-1-git-send-email-helin.zhang@intel.com>\n\t<1406184149-11531-2-git-send-email-helin.zhang@intel.com>\n\t<2490690.EmSZ5vBN3i@xps13>", "In-Reply-To": "<2490690.EmSZ5vBN3i@xps13>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet\n\tclassification type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Thu, 24 Jul 2014 08:13:10 -0000" }, "addressed": null }, { "id": 231, "web_url": "https://patches.dpdk.org/comment/231/", "msgid": "<5763244.xFk97hyylc@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/5763244.xFk97hyylc@xps13", "date": "2014-07-24T08:19:45", "subject": "Re: [dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet\n\tclassification type", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-07-24 08:14, Zhang, Helin:\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> > 2014-07-24 14:42, Helin Zhang:\n> > > For better understanding, 'PCTYPE' was added to the name of i40e RSS\n> > > shift macros.\n> > >\n> > > Signed-off-by: Helin Zhang <helin.zhang@intel.com>\n> > \n> > > -#define ETH_RSS_NONF_IPV4_UDP_SHIFT 31\n> > > +#define ETH_PCTYPE_NONF_IPV4_UDP 31\n> > \n> > Why is it clearer? I don't understand what means PCTYPE.\n> \n> It is 'packet classification type' defined in data sheet, and widely used.\n\nWidely used? No it seems to be an i40e naming.\nWhich datasheet are you pointing?\n\n> It is not just for RSS only, it can be used for flow director possibly.\n> That's why I think it would be better to rename it with PCTYPE names.\n\nAt least, you should add a comment in the code to explain the meaning.\n\nThank you", "headers": { "Return-Path": "<thomas.monjalon@6wind.com>", "Received": [ "from mail-wi0-f180.google.com (mail-wi0-f180.google.com\n\t[209.85.212.180]) by dpdk.org (Postfix) with ESMTP id C677D5930\n\tfor <dev@dpdk.org>; Thu, 24 Jul 2014 10:18:28 +0200 (CEST)", "by mail-wi0-f180.google.com with SMTP id n3so3532391wiv.13\n\tfor <dev@dpdk.org>; Thu, 24 Jul 2014 01:19:56 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tey16sm20054568wid.14.2014.07.24.01.19.54 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 24 Jul 2014 01:19:54 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=e1FPLfabNoBW3aU56+8n5NMacOKaE0LUAd3Wav22ip8=;\n\tb=CnarluNGqbDoJZmpeh3FNDS6orPvzBnX4CO1I0sHfBy6B6f+0gPdx+LPyCGgOEc7D7\n\tsmEt5UBWadXwktj99Hf3JVtlcK2yUkKf6EpKP6Wh+8d8IP7n7RyhPj/lHZdInTo0AlDg\n\ttCcDvJutWJwD7fmoieYMd/kzXRq0tQqBC8tZCkcqbdZtBUOzYH4Wqd2JER4BEgfSvUby\n\tcQVibu6WVKaM/8kxS+roZfeOB3/PnL8qUmaK16P39Irl4lJqu3a7WcMThMbJRrdNMEfX\n\tIxK4oBfCCVA4OWk3dBAOVQFn+zJvJktxCD8cI0u+lTf8ywd7KrJXc7jaLrcZMjrg8HRC\n\t6c5A==", "X-Gm-Message-State": "ALoCoQlBsiiDS8tsuk2rYBZ2YzIXruyr3MBhn36vLby8MBxerLrIzLUwTSitx2FbQ7UU627/Ba5u", "X-Received": "by 10.180.80.70 with SMTP id p6mr32902508wix.22.1406189995376;\n\tThu, 24 Jul 2014 01:19:55 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "\"Zhang, Helin\" <helin.zhang@intel.com>", "Date": "Thu, 24 Jul 2014 10:19:45 +0200", "Message-ID": "<5763244.xFk97hyylc@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.2 (Linux/3.15.5-2-ARCH; KDE/4.13.2; x86_64; ; )", "In-Reply-To": "<F35DEAC7BCE34641BA9FAC6BCA4A12E70A7627BF@SHSMSX104.ccr.corp.intel.com>", "References": "<1406184149-11531-1-git-send-email-helin.zhang@intel.com>\n\t<2490690.EmSZ5vBN3i@xps13>\n\t<F35DEAC7BCE34641BA9FAC6BCA4A12E70A7627BF@SHSMSX104.ccr.corp.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet\n\tclassification type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Thu, 24 Jul 2014 08:18:28 -0000" }, "addressed": null }, { "id": 232, "web_url": "https://patches.dpdk.org/comment/232/", "msgid": "<F35DEAC7BCE34641BA9FAC6BCA4A12E70A7627F2@SHSMSX104.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/F35DEAC7BCE34641BA9FAC6BCA4A12E70A7627F2@SHSMSX104.ccr.corp.intel.com", "date": "2014-07-24T08:23:46", "subject": "Re: [dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet\n\tclassification type", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "content": "> -----Original Message-----\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> Sent: Thursday, July 24, 2014 4:20 PM\n> To: Zhang, Helin\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet\n> classification type\n> \n> 2014-07-24 08:14, Zhang, Helin:\n> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> > > 2014-07-24 14:42, Helin Zhang:\n> > > > For better understanding, 'PCTYPE' was added to the name of i40e\n> > > > RSS shift macros.\n> > > >\n> > > > Signed-off-by: Helin Zhang <helin.zhang@intel.com>\n> > >\n> > > > -#define ETH_RSS_NONF_IPV4_UDP_SHIFT 31\n> > > > +#define ETH_PCTYPE_NONF_IPV4_UDP 31\n> > >\n> > > Why is it clearer? I don't understand what means PCTYPE.\n> >\n> > It is 'packet classification type' defined in data sheet, and widely used.\n> \n> Widely used? No it seems to be an i40e naming.\n> Which datasheet are you pointing?\n\nSorry, it is widely used in i40e. That might not so widely for the whole DPDK.\nThe datasheet I mentioned is the Intel(r) 40G NIC datasheet.\n\n> \n> > It is not just for RSS only, it can be used for flow director possibly.\n> > That's why I think it would be better to rename it with PCTYPE names.\n> \n> At least, you should add a comment in the code to explain the meaning.\n\nOK, good comments!\n\n> \n> Thank you\n> --\n> Thomas", "headers": { "Return-Path": "<helin.zhang@intel.com>", "Received": [ "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 9F494594D\n\tfor <dev@dpdk.org>; Thu, 24 Jul 2014 10:22:30 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 24 Jul 2014 01:23:56 -0700", "from fmsmsx107.amr.corp.intel.com ([10.19.9.54])\n\tby fmsmga002.fm.intel.com with ESMTP; 24 Jul 2014 01:23:48 -0700", "from fmsmsx152.amr.corp.intel.com (10.19.17.221) by\n\tFMSMSX107.amr.corp.intel.com (10.19.9.54) with Microsoft SMTP Server\n\t(TLS) id 14.3.123.3; Thu, 24 Jul 2014 01:23:48 -0700", "from shsmsx102.ccr.corp.intel.com (10.239.4.154) by\n\tfmsmsx152.amr.corp.intel.com (10.19.17.221) with Microsoft SMTP\n\tServer (TLS) id 14.3.123.3; Thu, 24 Jul 2014 01:23:48 -0700", "from shsmsx104.ccr.corp.intel.com ([169.254.5.204]) by\n\tshsmsx102.ccr.corp.intel.com ([169.254.2.120]) with mapi id\n\t14.03.0123.003; Thu, 24 Jul 2014 16:23:46 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.01,722,1400050800\"; d=\"scan'208\";a=\"574675312\"", "From": "\"Zhang, Helin\" <helin.zhang@intel.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet\n\tclassification type", "Thread-Index": "AQHPpxO7hZbuZpxe6Uy2+vEfk1yc85uu3+ng//974ICAAIZdYA==", "Date": "Thu, 24 Jul 2014 08:23:46 +0000", "Message-ID": "<F35DEAC7BCE34641BA9FAC6BCA4A12E70A7627F2@SHSMSX104.ccr.corp.intel.com>", "References": "<1406184149-11531-1-git-send-email-helin.zhang@intel.com>\n\t<2490690.EmSZ5vBN3i@xps13>\n\t<F35DEAC7BCE34641BA9FAC6BCA4A12E70A7627BF@SHSMSX104.ccr.corp.intel.com>\n\t<5763244.xFk97hyylc@xps13>", "In-Reply-To": "<5763244.xFk97hyylc@xps13>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet\n\tclassification type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Thu, 24 Jul 2014 08:22:31 -0000" }, "addressed": null } ]