Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87765/?format=api
{ "id": 87765, "url": "https://patches.dpdk.org/api/patches/87765/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210204195853.13411-11-aboyer@pensando.io/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210204195853.13411-11-aboyer@pensando.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20210204195853.13411-11-aboyer@pensando.io", "date": "2021-02-04T19:58:49", "name": "[10/14] net/ionic: break up queue post function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d13145d9374a1f287d5d0dba053b8034f23099b8", "submitter": { "id": 2036, "url": "https://patches.dpdk.org/api/people/2036/?format=api", "name": "Andrew Boyer", "email": "aboyer@pensando.io" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210204195853.13411-11-aboyer@pensando.io/mbox/", "series": [ { "id": 15176, "url": "https://patches.dpdk.org/api/series/15176/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15176", "date": "2021-02-04T19:58:39", "name": "net/ionic: struct optimizations, fixes", "version": 1, "mbox": "https://patches.dpdk.org/series/15176/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87765/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87765/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 81413A0524;\n\tThu, 4 Feb 2021 21:00:32 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7F70F240823;\n\tThu, 4 Feb 2021 20:59:39 +0100 (CET)", "from mail-pf1-f172.google.com (mail-pf1-f172.google.com\n [209.85.210.172])\n by mails.dpdk.org (Postfix) with ESMTP id 84CF4240825\n for <dev@dpdk.org>; Thu, 4 Feb 2021 20:59:38 +0100 (CET)", "by mail-pf1-f172.google.com with SMTP id f63so2763459pfa.13\n for <dev@dpdk.org>; Thu, 04 Feb 2021 11:59:38 -0800 (PST)", "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id r14sm7757915pgi.27.2021.02.04.11.59.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 04 Feb 2021 11:59:36 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=m9sKlXNQYdJ4z0CAnxovLiWvUBdvQ9sCvXdUrdix9dE=;\n b=eB/PYx7YslszjEMOBEcwclkvsRPg+CKfDpzJrgXLGkLWPn84zMW/0+KoTWCHLjhVhl\n ouOsLIYzsdwK4SC18DC/XK5BPaWAbQgwYPdLXmwL8H6XlJoSamCEv5t1tfxrYmUvf6lC\n ZtYh2BTVG4BVf4jev7pojbf1+rRjRaaKLj5jjz/jJl1TuK9hIUDFQ9IkCJ2f+q5Ma6cb\n eAGmVueotCd+PjCxP4EchFw4PI8squs9pOmOoVR2Gg37ZqzoOLWQvNTUs/iJ9GfB/R3u\n GqBnP+vhJ8U1P4ZBK70F9qKGhi8F1P7Cyfu+DtGOIJ/dRGbpYRIMY3rK/DLG8SM5142j\n xq1A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=m9sKlXNQYdJ4z0CAnxovLiWvUBdvQ9sCvXdUrdix9dE=;\n b=G7EcwEDrNeDDRge4XjJT5KHYmCBD19a4AY8Sv/z9zh+gPuZEn2GA9u+4hVh9tLknvi\n E6YLdUnRJtSecivI05jWdpGU5vUgnL9sdWCOmsYxNSnMRdVk/j+48I5OaKSEx3skTCsv\n gvSPSotz195SomTghvEKnR5JCA4mWqCPIhb5x8vsRG6T1dXRO+kpqcdWYcz0Ae3tgMTP\n vYbnAtsqCHKtq9JJtSS2u4pLXr4dXkjUGNe9eIsdXwgDD6/Cuxdgof/6wlSWsjQU2rDb\n PlNm8IVtcJuajGmIWOGBFgwntpGlQN4COqnrihdTu3hOVei3Km27h6niaJx2b2Lc8fur\n M8vQ==", "X-Gm-Message-State": "AOAM5336xatFINHXUaDsgAgMtmeTp7stxyCSnAboOF1LrBV/m1X7uCCN\n HIR/wNQu2LKXhi5uKLvPxN/RySWLqVmYjg==", "X-Google-Smtp-Source": "\n ABdhPJwmfV/NKjBCZxFk9w32KAXBPr2PrFvMSXvybKrRAOOaSMqx6iH5ohFsoP+Uvh/LKDaUnuoKLw==", "X-Received": "by 2002:a63:dc56:: with SMTP id f22mr666375pgj.106.1612468777295;\n Thu, 04 Feb 2021 11:59:37 -0800 (PST)", "From": "Andrew Boyer <aboyer@pensando.io>", "To": "dev@dpdk.org", "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>", "Date": "Thu, 4 Feb 2021 11:58:49 -0800", "Message-Id": "<20210204195853.13411-11-aboyer@pensando.io>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210204195853.13411-1-aboyer@pensando.io>", "References": "<20210204195853.13411-1-aboyer@pensando.io>", "Subject": "[dpdk-dev] [PATCH 10/14] net/ionic: break up queue post function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Break it up rather than inlining it, so that we can remove\nbranches from the hot path.\n\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/ionic/ionic_dev.c | 11 ----------\n drivers/net/ionic/ionic_dev.h | 1 -\n drivers/net/ionic/ionic_main.c | 10 ++++++++-\n drivers/net/ionic/ionic_rxtx.c | 37 ++++++++++++++++++++++++++++++----\n 4 files changed, 42 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_dev.c b/drivers/net/ionic/ionic_dev.c\nindex cfaf4abc23..43e9ca3de3 100644\n--- a/drivers/net/ionic/ionic_dev.c\n+++ b/drivers/net/ionic/ionic_dev.c\n@@ -438,14 +438,3 @@ ionic_q_sg_map(struct ionic_queue *q, void *base, rte_iova_t base_pa)\n \tq->sg_base = base;\n \tq->sg_base_pa = base_pa;\n }\n-\n-void\n-ionic_q_post(struct ionic_queue *q, bool ring_doorbell, void *cb_arg)\n-{\n-\tq->info[q->head_idx] = cb_arg;\n-\n-\tq->head_idx = Q_NEXT_TO_POST(q, 1);\n-\n-\tif (ring_doorbell)\n-\t\tionic_q_flush(q);\n-}\ndiff --git a/drivers/net/ionic/ionic_dev.h b/drivers/net/ionic/ionic_dev.h\nindex 0d1aff776b..4c7f6f647b 100644\n--- a/drivers/net/ionic/ionic_dev.h\n+++ b/drivers/net/ionic/ionic_dev.h\n@@ -225,7 +225,6 @@ uint32_t ionic_cq_service(struct ionic_cq *cq, uint32_t work_to_do,\n int ionic_q_init(struct ionic_queue *q, uint32_t index, uint16_t num_descs);\n void ionic_q_map(struct ionic_queue *q, void *base, rte_iova_t base_pa);\n void ionic_q_sg_map(struct ionic_queue *q, void *base, rte_iova_t base_pa);\n-void ionic_q_post(struct ionic_queue *q, bool ring_doorbell, void *cb_arg);\n \n static inline uint16_t\n ionic_q_space_avail(struct ionic_queue *q)\ndiff --git a/drivers/net/ionic/ionic_main.c b/drivers/net/ionic/ionic_main.c\nindex 05dc72e834..b65f538fe5 100644\n--- a/drivers/net/ionic/ionic_main.c\n+++ b/drivers/net/ionic/ionic_main.c\n@@ -197,6 +197,7 @@ ionic_adminq_post(struct ionic_lif *lif, struct ionic_admin_ctx *ctx)\n \tstruct ionic_queue *q = &lif->adminqcq->qcq.q;\n \tstruct ionic_admin_cmd *q_desc_base = q->base;\n \tstruct ionic_admin_cmd *q_desc;\n+\tvoid **info;\n \tint err = 0;\n \n \trte_spinlock_lock(&lif->adminq_lock);\n@@ -210,7 +211,14 @@ ionic_adminq_post(struct ionic_lif *lif, struct ionic_admin_ctx *ctx)\n \n \tmemcpy(q_desc, &ctx->cmd, sizeof(ctx->cmd));\n \n-\tionic_q_post(q, true, ctx);\n+\tinfo = IONIC_INFO_PTR(q, q->head_idx);\n+\tinfo[0] = ctx;\n+\n+\tq->head_idx = Q_NEXT_TO_POST(q, 1);\n+\n+\t/* Ring doorbell */\n+\trte_wmb();\n+\tionic_q_flush(q);\n \n err_out:\n \trte_spinlock_unlock(&lif->adminq_lock);\ndiff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex 9d0df2a098..c671b34e94 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -302,6 +302,7 @@ ionic_tx_tso_post(struct ionic_queue *q, struct ionic_txq_desc *desc,\n \t\tuint16_t vlan_tci, bool has_vlan,\n \t\tbool start, bool done)\n {\n+\tvoid **info;\n \tuint8_t flags = 0;\n \tflags |= has_vlan ? IONIC_TXQ_DESC_FLAG_VLAN : 0;\n \tflags |= encap ? IONIC_TXQ_DESC_FLAG_ENCAP : 0;\n@@ -315,7 +316,15 @@ ionic_tx_tso_post(struct ionic_queue *q, struct ionic_txq_desc *desc,\n \tdesc->hdr_len = hdrlen;\n \tdesc->mss = mss;\n \n-\tionic_q_post(q, done, done ? txm : NULL);\n+\tif (done) {\n+\t\tinfo = IONIC_INFO_PTR(q, q->head_idx);\n+\t\tinfo[0] = txm;\n+\t}\n+\n+\tq->head_idx = Q_NEXT_TO_POST(q, 1);\n+\n+\tif (done)\n+\t\tionic_q_flush(q);\n }\n \n static struct ionic_txq_desc *\n@@ -465,6 +474,7 @@ ionic_tx(struct ionic_tx_qcq *txq, struct rte_mbuf *txm,\n \tstruct ionic_txq_sg_elem *elem;\n \tstruct ionic_tx_stats *stats = &txq->stats;\n \tstruct rte_mbuf *txm_seg;\n+\tvoid **info;\n \tbool encap;\n \tbool has_vlan;\n \tuint64_t ol_flags = txm->ol_flags;\n@@ -473,6 +483,7 @@ ionic_tx(struct ionic_tx_qcq *txq, struct rte_mbuf *txm,\n \tuint8_t flags = 0;\n \n \tdesc = &desc_base[q->head_idx];\n+\tinfo = IONIC_INFO_PTR(q, q->head_idx);\n \n \tif ((ol_flags & PKT_TX_IP_CKSUM) &&\n \t (txq->flags & IONIC_QCQ_F_CSUM_L3)) {\n@@ -506,7 +517,10 @@ ionic_tx(struct ionic_tx_qcq *txq, struct rte_mbuf *txm,\n \tdesc->len = txm->data_len;\n \tdesc->vlan_tci = txm->vlan_tci;\n \n+\tinfo[0] = txm;\n+\n \telem = sg_desc_base[q->head_idx].elems;\n+\n \ttxm_seg = txm->next;\n \twhile (txm_seg != NULL) {\n \t\telem->len = txm_seg->data_len;\n@@ -515,7 +529,10 @@ ionic_tx(struct ionic_tx_qcq *txq, struct rte_mbuf *txm,\n \t\ttxm_seg = txm_seg->next;\n \t}\n \n-\tionic_q_post(q, not_xmit_more, txm);\n+\tq->head_idx = Q_NEXT_TO_POST(q, 1);\n+\n+\tif (not_xmit_more)\n+\t\tionic_q_flush(q);\n \n \treturn 0;\n }\n@@ -920,7 +937,11 @@ ionic_rx_recycle(struct ionic_queue *q, uint32_t q_desc_index,\n \tnew->addr = old->addr;\n \tnew->len = old->len;\n \n-\tionic_q_post(q, true, mbuf);\n+\tq->info[q->head_idx] = mbuf;\n+\n+\tq->head_idx = Q_NEXT_TO_POST(q, 1);\n+\n+\tionic_q_flush(q);\n }\n \n static __rte_always_inline int\n@@ -930,6 +951,7 @@ ionic_rx_fill(struct ionic_rx_qcq *rxq, uint32_t len)\n \tstruct ionic_rxq_desc *desc, *desc_base = q->base;\n \tstruct ionic_rxq_sg_desc *sg_desc, *sg_desc_base = q->sg_base;\n \tstruct ionic_rxq_sg_elem *elem;\n+\tvoid **info;\n \trte_iova_t dma_addr;\n \tuint32_t i, j, nsegs, buf_size, size;\n \tbool ring_doorbell;\n@@ -947,6 +969,8 @@ ionic_rx_fill(struct ionic_rx_qcq *rxq, uint32_t len)\n \t\t\treturn -ENOMEM;\n \t\t}\n \n+\t\tinfo = IONIC_INFO_PTR(q, q->head_idx);\n+\n \t\tnsegs = (len + buf_size - 1) / buf_size;\n \n \t\tdesc = &desc_base[q->head_idx];\n@@ -989,7 +1013,12 @@ ionic_rx_fill(struct ionic_rx_qcq *rxq, uint32_t len)\n \t\tring_doorbell = ((q->head_idx + 1) &\n \t\t\tIONIC_RX_RING_DOORBELL_STRIDE) == 0;\n \n-\t\tionic_q_post(q, ring_doorbell, rxm);\n+\t\tinfo[0] = rxm;\n+\n+\t\tq->head_idx = Q_NEXT_TO_POST(q, 1);\n+\n+\t\tif (ring_doorbell)\n+\t\t\tionic_q_flush(q);\n \t}\n \n \treturn 0;\n", "prefixes": [ "10/14" ] }