Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87656/?format=api
{ "id": 87656, "url": "https://patches.dpdk.org/api/patches/87656/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1612338382-3253-2-git-send-email-oulijun@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1612338382-3253-2-git-send-email-oulijun@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1612338382-3253-2-git-send-email-oulijun@huawei.com", "date": "2021-02-03T07:46:06", "name": "[01/17] net/hns3: support module EEPROM dump", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "86f6535ea4b19805937629bbda969ea33a5ba751", "submitter": { "id": 1675, "url": "https://patches.dpdk.org/api/people/1675/?format=api", "name": "Lijun Ou", "email": "oulijun@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1612338382-3253-2-git-send-email-oulijun@huawei.com/mbox/", "series": [ { "id": 15115, "url": "https://patches.dpdk.org/api/series/15115/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15115", "date": "2021-02-03T07:46:05", "name": "bugfixes and small functionality for hns3", "version": 1, "mbox": "https://patches.dpdk.org/series/15115/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87656/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87656/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 13AFBA0A0E;\n\tWed, 3 Feb 2021 08:47:33 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 44C8F24046B;\n\tWed, 3 Feb 2021 08:46:59 +0100 (CET)", "from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35])\n by mails.dpdk.org (Postfix) with ESMTP id 07FBB240445\n for <dev@dpdk.org>; Wed, 3 Feb 2021 08:46:52 +0100 (CET)", "from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4DVtyN2bm3z7gP6;\n Wed, 3 Feb 2021 15:45:32 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id\n 14.3.498.0; Wed, 3 Feb 2021 15:46:47 +0800" ], "From": "Lijun Ou <oulijun@huawei.com>", "To": "<ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, <linuxarm@openeuler.org>", "Date": "Wed, 3 Feb 2021 15:46:06 +0800", "Message-ID": "<1612338382-3253-2-git-send-email-oulijun@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1612338382-3253-1-git-send-email-oulijun@huawei.com>", "References": "<1612338382-3253-1-git-send-email-oulijun@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 01/17] net/hns3: support module EEPROM dump", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengchang Tang <tangchengchang@huawei.com>\n\nThis patch add support for dumping module EEPROM.\n\nSigned-off-by: Chengchang Tang <tangchengchang@huawei.com>\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\n---\nDepends-on: series-10000 (\"update doc for hns3\")\n---\n doc/guides/nics/features/hns3.ini | 1 +\n doc/guides/rel_notes/release_21_02.rst | 1 +\n drivers/net/hns3/hns3_cmd.h | 16 ++++\n drivers/net/hns3/hns3_ethdev.c | 159 +++++++++++++++++++++++++++++++++\n 4 files changed, 177 insertions(+)", "diff": "diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini\nindex 452a7b5..40febb0 100644\n--- a/doc/guides/nics/features/hns3.ini\n+++ b/doc/guides/nics/features/hns3.ini\n@@ -38,6 +38,7 @@ Extended stats = Y\n Stats per queue = Y\n FW version = Y\n Registers dump = Y\n+Module EEPROM dump = Y\n Multiprocess aware = Y\n FEC = Y\n Linux = Y\ndiff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst\nindex b87db22..cfbc42f 100644\n--- a/doc/guides/rel_notes/release_21_02.rst\n+++ b/doc/guides/rel_notes/release_21_02.rst\n@@ -95,6 +95,7 @@ New Features\n * **Updated hns3 driver.**\n \n * Added support for traffic management\n+ * Added support for module EEPROM dumping\n \n * **Updated Intel ice driver.**\n \ndiff --git a/drivers/net/hns3/hns3_cmd.h b/drivers/net/hns3/hns3_cmd.h\nindex dc97a1a..e5852dc 100644\n--- a/drivers/net/hns3/hns3_cmd.h\n+++ b/drivers/net/hns3/hns3_cmd.h\n@@ -207,6 +207,8 @@ enum hns3_opcode_type {\n \tHNS3_OPC_CLEAR_HW_STATE = 0x700B,\n \n \t/* SFP command */\n+\tHNS3_OPC_GET_SFP_EEPROM = 0x7100,\n+\tHNS3_OPC_GET_SFP_EXIST = 0x7101,\n \tHNS3_OPC_SFP_GET_SPEED = 0x7104,\n \n \t/* Interrupts commands */\n@@ -698,6 +700,20 @@ struct hns3_config_auto_neg_cmd {\n #define HNS3_MAC_FEC_BASER\t\t1\n #define HNS3_MAC_FEC_RS\t\t\t2\n \n+#define HNS3_SFP_INFO_BD0_LEN 20UL\n+#define HNS3_SFP_INFO_BDX_LEN 24UL\n+\n+struct hns3_sfp_info_bd0_cmd {\n+\tuint16_t offset;\n+\tuint16_t read_len;\n+\tuint8_t data[HNS3_SFP_INFO_BD0_LEN];\n+};\n+\n+struct hns3_sfp_type {\n+\tuint8_t type;\n+\tuint8_t ext_type;\n+};\n+\n struct hns3_sfp_speed_cmd {\n \tuint32_t sfp_speed;\n \tuint8_t query_type; /* 0: sfp speed, 1: active fec */\ndiff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 221e008..31418b8 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -6105,6 +6105,163 @@ hns3_query_dev_fec_info(struct hns3_hw *hw)\n \treturn ret;\n }\n \n+static bool\n+hns3_optical_module_existed(struct hns3_hw *hw)\n+{\n+\tstruct hns3_cmd_desc desc;\n+\tbool existed;\n+\tint ret;\n+\n+\thns3_cmd_setup_basic_desc(&desc, HNS3_OPC_GET_SFP_EXIST, true);\n+\tret = hns3_cmd_send(hw, &desc, 1);\n+\tif (ret) {\n+\t\thns3_err(hw,\n+\t\t\t \"fail to get optical module exist state, ret = %d.\\n\",\n+\t\t\t ret);\n+\t\treturn false;\n+\t}\n+\texisted = !!desc.data[0];\n+\n+\treturn existed;\n+}\n+\n+static int\n+hns3_get_module_eeprom_data(struct hns3_hw *hw, uint32_t offset,\n+\t\t\t\tuint32_t len, uint8_t *data)\n+{\n+#define HNS3_SFP_INFO_CMD_NUM 6\n+#define HNS3_SFP_INFO_MAX_LEN \\\n+\t(HNS3_SFP_INFO_BD0_LEN + \\\n+\t(HNS3_SFP_INFO_CMD_NUM - 1) * HNS3_SFP_INFO_BDX_LEN)\n+\tstruct hns3_cmd_desc desc[HNS3_SFP_INFO_CMD_NUM];\n+\tstruct hns3_sfp_info_bd0_cmd *sfp_info_bd0;\n+\tuint16_t read_len;\n+\tuint16_t copy_len;\n+\tint ret;\n+\tint i;\n+\n+\tfor (i = 0; i < HNS3_SFP_INFO_CMD_NUM; i++) {\n+\t\thns3_cmd_setup_basic_desc(&desc[i], HNS3_OPC_GET_SFP_EEPROM,\n+\t\t\t\t\t true);\n+\t\tif (i < HNS3_SFP_INFO_CMD_NUM - 1)\n+\t\t\tdesc[i].flag |= rte_cpu_to_le_16(HNS3_CMD_FLAG_NEXT);\n+\t}\n+\n+\tsfp_info_bd0 = (struct hns3_sfp_info_bd0_cmd *)desc[0].data;\n+\tsfp_info_bd0->offset = rte_cpu_to_le_16((uint16_t)offset);\n+\tread_len = RTE_MIN(len, HNS3_SFP_INFO_MAX_LEN);\n+\tsfp_info_bd0->read_len = rte_cpu_to_le_16((uint16_t)read_len);\n+\n+\tret = hns3_cmd_send(hw, desc, HNS3_SFP_INFO_CMD_NUM);\n+\tif (ret) {\n+\t\thns3_err(hw, \"fail to get module EEPROM info, ret = %d.\\n\",\n+\t\t\t\tret);\n+\t\treturn ret;\n+\t}\n+\n+\t/* The data format in BD0 is different with the others. */\n+\tcopy_len = RTE_MIN(len, HNS3_SFP_INFO_BD0_LEN);\n+\tmemcpy(data, sfp_info_bd0->data, copy_len);\n+\tread_len = copy_len;\n+\n+\tfor (i = 1; i < HNS3_SFP_INFO_CMD_NUM; i++) {\n+\t\tif (read_len >= len)\n+\t\t\tbreak;\n+\n+\t\tcopy_len = RTE_MIN(len - read_len, HNS3_SFP_INFO_BDX_LEN);\n+\t\tmemcpy(data + read_len, desc[i].data, copy_len);\n+\t\tread_len += copy_len;\n+\t}\n+\n+\treturn (int)read_len;\n+}\n+\n+static int\n+hns3_get_module_eeprom(struct rte_eth_dev *dev,\n+\t\t struct rte_dev_eeprom_info *info)\n+{\n+\tstruct hns3_adapter *hns = dev->data->dev_private;\n+\tstruct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(hns);\n+\tuint32_t offset = info->offset;\n+\tuint32_t len = info->length;\n+\tuint8_t *data = info->data;\n+\tuint32_t read_len = 0;\n+\n+\tif (hw->mac.media_type != HNS3_MEDIA_TYPE_FIBER)\n+\t\treturn -ENOTSUP;\n+\n+\tif (!hns3_optical_module_existed(hw)) {\n+\t\thns3_err(hw, \"fail to read module EEPROM: no module is connected.\\n\");\n+\t\treturn -EIO;\n+\t}\n+\n+\twhile (read_len < len) {\n+\t\tint ret;\n+\t\tret = hns3_get_module_eeprom_data(hw, offset + read_len,\n+\t\t\t\t\t\t len - read_len,\n+\t\t\t\t\t\t data + read_len);\n+\t\tif (ret < 0)\n+\t\t\treturn -EIO;\n+\t\tread_len += ret;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+hns3_get_module_info(struct rte_eth_dev *dev,\n+\t\t struct rte_eth_dev_module_info *modinfo)\n+{\n+#define HNS3_SFF8024_ID_SFP\t\t0x03\n+#define HNS3_SFF8024_ID_QSFP_8438\t0x0c\n+#define HNS3_SFF8024_ID_QSFP_8436_8636\t0x0d\n+#define HNS3_SFF8024_ID_QSFP28_8636\t0x11\n+#define HNS3_SFF_8636_V1_3\t\t0x03\n+\tstruct hns3_adapter *hns = dev->data->dev_private;\n+\tstruct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(hns);\n+\tstruct rte_dev_eeprom_info info;\n+\tstruct hns3_sfp_type sfp_type;\n+\tint ret;\n+\n+\tmemset(&sfp_type, 0, sizeof(sfp_type));\n+\tmemset(&info, 0, sizeof(info));\n+\tinfo.data = (uint8_t *)&sfp_type;\n+\tinfo.length = sizeof(sfp_type);\n+\tret = hns3_get_module_eeprom(dev, &info);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tswitch (sfp_type.type) {\n+\tcase HNS3_SFF8024_ID_SFP:\n+\t\tmodinfo->type = RTE_ETH_MODULE_SFF_8472;\n+\t\tmodinfo->eeprom_len = RTE_ETH_MODULE_SFF_8472_LEN;\n+\t\tbreak;\n+\tcase HNS3_SFF8024_ID_QSFP_8438:\n+\t\tmodinfo->type = RTE_ETH_MODULE_SFF_8436;\n+\t\tmodinfo->eeprom_len = RTE_ETH_MODULE_SFF_8436_MAX_LEN;\n+\t\tbreak;\n+\tcase HNS3_SFF8024_ID_QSFP_8436_8636:\n+\t\tif (sfp_type.ext_type < HNS3_SFF_8636_V1_3) {\n+\t\t\tmodinfo->type = RTE_ETH_MODULE_SFF_8436;\n+\t\t\tmodinfo->eeprom_len = RTE_ETH_MODULE_SFF_8436_MAX_LEN;\n+\t\t} else {\n+\t\t\tmodinfo->type = RTE_ETH_MODULE_SFF_8636;\n+\t\t\tmodinfo->eeprom_len = RTE_ETH_MODULE_SFF_8636_MAX_LEN;\n+\t\t}\n+\t\tbreak;\n+\tcase HNS3_SFF8024_ID_QSFP28_8636:\n+\t\tmodinfo->type = RTE_ETH_MODULE_SFF_8636;\n+\t\tmodinfo->eeprom_len = RTE_ETH_MODULE_SFF_8636_MAX_LEN;\n+\t\tbreak;\n+\tdefault:\n+\t\thns3_err(hw, \"unknown module, type = %u, extra_type = %u.\\n\",\n+\t\t\t sfp_type.type, sfp_type.ext_type);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static const struct eth_dev_ops hns3_eth_dev_ops = {\n \t.dev_configure = hns3_dev_configure,\n \t.dev_start = hns3_dev_start,\n@@ -6156,6 +6313,8 @@ static const struct eth_dev_ops hns3_eth_dev_ops = {\n \t.vlan_offload_set = hns3_vlan_offload_set,\n \t.vlan_pvid_set = hns3_vlan_pvid_set,\n \t.get_reg = hns3_get_regs,\n+\t.get_module_info = hns3_get_module_info,\n+\t.get_module_eeprom = hns3_get_module_eeprom,\n \t.get_dcb_info = hns3_get_dcb_info,\n \t.dev_supported_ptypes_get = hns3_dev_supported_ptypes_get,\n \t.fec_get_capability = hns3_fec_get_capability,\n", "prefixes": [ "01/17" ] }