Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87574/?format=api
{ "id": 87574, "url": "https://patches.dpdk.org/api/patches/87574/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210131123628.47883-1-Cheng1.jiang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210131123628.47883-1-Cheng1.jiang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210131123628.47883-1-Cheng1.jiang@intel.com", "date": "2021-01-31T12:36:28", "name": "examples/vhost: add error propagation in ioat ops", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0bcb5e80da951060aeef7a17edc882597353adaa", "submitter": { "id": 1530, "url": "https://patches.dpdk.org/api/people/1530/?format=api", "name": "Jiang, Cheng1", "email": "Cheng1.jiang@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210131123628.47883-1-Cheng1.jiang@intel.com/mbox/", "series": [ { "id": 15044, "url": "https://patches.dpdk.org/api/series/15044/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15044", "date": "2021-01-31T12:36:28", "name": "examples/vhost: add error propagation in ioat ops", "version": 1, "mbox": "https://patches.dpdk.org/series/15044/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87574/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/87574/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A5118A0A0D;\n\tSun, 31 Jan 2021 13:47:57 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 294D240693;\n\tSun, 31 Jan 2021 13:47:57 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 2F69B40692\n for <dev@dpdk.org>; Sun, 31 Jan 2021 13:47:55 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 31 Jan 2021 04:47:52 -0800", "from dpdk_jiangcheng.sh.intel.com ([10.67.119.112])\n by fmsmga008.fm.intel.com with ESMTP; 31 Jan 2021 04:47:50 -0800" ], "IronPort-SDR": [ "\n JIclE28Flz47RqqWVxN6m1fO6Il9P+HTWjuBfBr7uOqDzudWgeM7RhcNRsmsEjhU86lcXNNmQl\n ExwXzPyV37/Q==", "\n GN74ZLGO2x6dxFy3tbWghsY+M/cbQroYsnmoHz5oykIdtsCjXaRR/4ELSqL4d1QJy9894Aly7I\n oPYyeOvX7HUg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9880\"; a=\"199465574\"", "E=Sophos;i=\"5.79,390,1602572400\"; d=\"scan'208\";a=\"199465574\"", "E=Sophos;i=\"5.79,390,1602572400\"; d=\"scan'208\";a=\"367546122\"" ], "X-ExtLoop1": "1", "From": "Cheng Jiang <Cheng1.jiang@intel.com>", "To": "maxime.coquelin@redhat.com,\n\tchenbo.xia@intel.com", "Cc": "dev@dpdk.org, jiayu.hu@intel.com, yvonnex.yang@intel.com,\n yinan.wang@intel.com, Cheng Jiang <Cheng1.jiang@intel.com>", "Date": "Sun, 31 Jan 2021 12:36:28 +0000", "Message-Id": "<20210131123628.47883-1-Cheng1.jiang@intel.com>", "X-Mailer": "git-send-email 2.29.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] examples/vhost: add error propagation in ioat ops", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "It makes more sense to add error propagation for rte_ioat_completed_ops.\n\nSigned-off-by: Cheng Jiang <Cheng1.jiang@intel.com>\n---\n examples/vhost/ioat.c | 14 ++++++++++----\n 1 file changed, 10 insertions(+), 4 deletions(-)", "diff": "diff --git a/examples/vhost/ioat.c b/examples/vhost/ioat.c\nindex dbad28d43..60b73be93 100644\n--- a/examples/vhost/ioat.c\n+++ b/examples/vhost/ioat.c\n@@ -22,7 +22,6 @@ struct packet_tracker {\n \n struct packet_tracker cb_tracker[MAX_VHOST_DEVICE];\n \n-\n int\n open_ioat(const char *value)\n {\n@@ -129,7 +128,7 @@ ioat_transfer_data_cb(int vid, uint16_t queue_id,\n \t\tstruct rte_vhost_async_status *opaque_data, uint16_t count)\n {\n \tuint32_t i_desc;\n-\tint dev_id = dma_bind[vid].dmas[queue_id * 2 + VIRTIO_RXQ].dev_id;\n+\tuint16_t dev_id = dma_bind[vid].dmas[queue_id * 2 + VIRTIO_RXQ].dev_id;\n \tstruct rte_vhost_iov_iter *src = NULL;\n \tstruct rte_vhost_iov_iter *dst = NULL;\n \tunsigned long i_seg;\n@@ -182,10 +181,17 @@ ioat_check_completed_copies_cb(int vid, uint16_t queue_id,\n \t\tunsigned short mask = MAX_ENQUEUED_SIZE - 1;\n \t\tunsigned short i;\n \n-\t\tint dev_id = dma_bind[vid].dmas[queue_id * 2\n+\t\tuint16_t dev_id = dma_bind[vid].dmas[queue_id * 2\n \t\t\t\t+ VIRTIO_RXQ].dev_id;\n \t\tn_seg = rte_ioat_completed_ops(dev_id, 255, dump, dump);\n-\t\tif (n_seg <= 0)\n+\t\tif (n_seg < 0) {\n+\t\t\tRTE_LOG(ERR,\n+\t\t\t\tVHOST_DATA,\n+\t\t\t\t\"fail to poll completed buf on IOAT device %u\",\n+\t\t\t\tdev_id);\n+\t\t\treturn 0;\n+\t\t}\n+\t\tif (n_seg == 0)\n \t\t\treturn 0;\n \n \t\tcb_tracker[dev_id].ioat_space += n_seg;\n", "prefixes": [] }