Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87569/?format=api
{ "id": 87569, "url": "https://patches.dpdk.org/api/patches/87569/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210129224434.71536-1-aboyer@pensando.io/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210129224434.71536-1-aboyer@pensando.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20210129224434.71536-1-aboyer@pensando.io", "date": "2021-01-29T22:44:32", "name": "net: redefine array size macros", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "67ee191309afc8dfd7bb29268e3926877f5f8097", "submitter": { "id": 2036, "url": "https://patches.dpdk.org/api/people/2036/?format=api", "name": "Andrew Boyer", "email": "aboyer@pensando.io" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210129224434.71536-1-aboyer@pensando.io/mbox/", "series": [ { "id": 15041, "url": "https://patches.dpdk.org/api/series/15041/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15041", "date": "2021-01-29T22:44:32", "name": "net: redefine array size macros", "version": 1, "mbox": "https://patches.dpdk.org/series/15041/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87569/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87569/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E53C1A09E4;\n\tFri, 29 Jan 2021 23:44:49 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A91674067B;\n\tFri, 29 Jan 2021 23:44:48 +0100 (CET)", "from mail-pl1-f181.google.com (mail-pl1-f181.google.com\n [209.85.214.181])\n by mails.dpdk.org (Postfix) with ESMTP id 55C1940395\n for <dev@dpdk.org>; Fri, 29 Jan 2021 23:44:47 +0100 (CET)", "by mail-pl1-f181.google.com with SMTP id e9so6146548plh.3\n for <dev@dpdk.org>; Fri, 29 Jan 2021 14:44:47 -0800 (PST)", "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id i36sm10561557pgi.81.2021.01.29.14.44.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 29 Jan 2021 14:44:45 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id;\n bh=ZgQMCXr0GT86G+6ToCDbSSEiJ+sLl/7or2fpUS3zHbc=;\n b=E0ordYhnpur1D3m/UbgVxLg6D4mHksA2f3Oko9mu+unEhWa6f1pNwWH4ylCoaLm2vi\n gW1gvFvnf6Vtuw1heSgsipktsokGaVG+HHB4lC0jRbZB8bqfUH3HWoE6vsZjrrfhUlN3\n 75tOJ+ALaAJ0RtWWomc6NJtOqDW+TkZ2/ZveXPqyZDzwdBJyy+EaB+TK4V6ZfJThIfVm\n PDy9QqDs3X2mAFtehR4LldlFpNNdE0UTawqIco+o/JivVK7HlO3Ttj+CdwEx+JodJPsN\n bQDeMNk6DLbIBKpLce/O/P2WN85Kn86J8BNoIDtB/a19G+gwPi6huMnTSCj2um+Rl6EF\n naUQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id;\n bh=ZgQMCXr0GT86G+6ToCDbSSEiJ+sLl/7or2fpUS3zHbc=;\n b=q8SD4bPqCVyg+UbMmPW94SK4P6yvbBgq1vquM1/0+rgdQy/y6pk3dFNATDqD0Yren7\n hs2rn3NnwgRFoJ3ipGgZyNXlBg+GSQXnLCy34C7jFRJ/gbwAIz/YWHvZn9y9KlLIWdxc\n Joa2dix1ZED+7shJcbwgY3WuzP2+1FhxkkZuln8DPPgx5XHrcIrLKmEd7AqTlH0homhZ\n gAAolE/KdU5vbTsYnaLRWm7rWxlmwSvCyFT4huu+SJqBTS/CYLAnOakJ7RdfAdV8RYvR\n 5Maal24jkqYiKCMdUcZgFdo9shhe0Lo8R9NZcSKfEBxdbDB41Vb9Lb+K3AHzmZ5PV6PL\n o9Dg==", "X-Gm-Message-State": "AOAM530DPyovD4zBsh8tgYn4ecF8GHX8c0ZbsqE+eRCmhJ9f0wRztR+2\n rzbz/bzG/qqOW2eBh3epwqt35HjWmpKsPw==", "X-Google-Smtp-Source": "\n ABdhPJw0yOanmGvf0ZehYYx0P50RaKMcD99LYB1ygmyxDd6F42yYLFp/Wceed0xzmbt9+ddmupRE7A==", "X-Received": "by 2002:a17:902:9a93:b029:e0:e41:f088 with SMTP id\n w19-20020a1709029a93b02900e00e41f088mr6269226plp.55.1611960286238;\n Fri, 29 Jan 2021 14:44:46 -0800 (PST)", "From": "Andrew Boyer <aboyer@pensando.io>", "To": "dev@dpdk.org", "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>", "Date": "Fri, 29 Jan 2021 14:44:32 -0800", "Message-Id": "<20210129224434.71536-1-aboyer@pensando.io>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] net: redefine array size macros", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace copies of size(arr)/size(arr[0]) with RTE_DIM().\nEventually all of these macro definitions should be removed.\n\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/atlantic/atl_hw_regs.h | 2 +-\n drivers/net/axgbe/axgbe_common.h | 2 +-\n drivers/net/bnx2x/bnx2x.h | 2 +-\n drivers/net/bnx2x/elink.h | 2 +-\n drivers/net/ena/ena_ethdev.c | 2 +-\n drivers/net/enic/base/vnic_devcmd.h | 2 +-\n drivers/net/hns3/hns3_ethdev.h | 2 +-\n drivers/net/i40e/base/i40e_osdep.h | 2 +-\n drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h | 2 +-\n drivers/net/thunderx/base/nicvf_hw.h | 2 +-\n 10 files changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/atlantic/atl_hw_regs.h b/drivers/net/atlantic/atl_hw_regs.h\nindex a2d6ca804e..4f6cd35774 100644\n--- a/drivers/net/atlantic/atl_hw_regs.h\n+++ b/drivers/net/atlantic/atl_hw_regs.h\n@@ -26,7 +26,7 @@\n \n #define mdelay rte_delay_ms\n #define udelay rte_delay_us\n-#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))\n+#define ARRAY_SIZE(arr) RTE_DIM(arr)\n #define BIT(x)\t(1UL << (x))\n \n #define AQ_HW_WAIT_FOR(_B_, _US_, _N_) \\\ndiff --git a/drivers/net/axgbe/axgbe_common.h b/drivers/net/axgbe/axgbe_common.h\nindex 91404ca01c..ef8706cf0f 100644\n--- a/drivers/net/axgbe/axgbe_common.h\n+++ b/drivers/net/axgbe/axgbe_common.h\n@@ -42,7 +42,7 @@\n \n #define BIT(nr)\t (1 << (nr))\n #ifndef ARRAY_SIZE\n-#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))\n+#define ARRAY_SIZE(arr) RTE_DIM(arr)\n #endif\n \n #define AXGBE_HZ\t\t\t\t250\ndiff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h\nindex 69cc1430a4..e13ab15574 100644\n--- a/drivers/net/bnx2x/bnx2x.h\n+++ b/drivers/net/bnx2x/bnx2x.h\n@@ -81,7 +81,7 @@\n #endif\n \n #ifndef ARRAY_SIZE\n-#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))\n+#define ARRAY_SIZE(arr) RTE_DIM(arr)\n #endif\n #ifndef DIV_ROUND_UP\n #define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))\ndiff --git a/drivers/net/bnx2x/elink.h b/drivers/net/bnx2x/elink.h\nindex dd70ac6c66..6b2e85f1e1 100644\n--- a/drivers/net/bnx2x/elink.h\n+++ b/drivers/net/bnx2x/elink.h\n@@ -86,7 +86,7 @@ extern void elink_cb_notify_link_changed(struct bnx2x_softc *sc);\n #define ELINK_EVENT_ID_SFP_UNQUALIFIED_MODULE \t1\n #define ELINK_EVENT_ID_SFP_POWER_FAULT \t\t2\n \n-#define ARRAY_SIZE(x) (sizeof(x)/sizeof(x[0]))\n+#define ARRAY_SIZE(x) RTE_DIM(x)\n /* Debug prints */\n #ifdef ELINK_DEBUG\n \ndiff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 20ff3653c6..b4b8794bcc 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -47,7 +47,7 @@\n #define ENA_HASH_KEY_SIZE\t40\n #define ETH_GSTRING_LEN\t32\n \n-#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))\n+#define ARRAY_SIZE(x) RTE_DIM(x)\n \n #define ENA_MIN_RING_DESC\t128\n \ndiff --git a/drivers/net/enic/base/vnic_devcmd.h b/drivers/net/enic/base/vnic_devcmd.h\nindex 96a7c22b21..3157bc8cb5 100644\n--- a/drivers/net/enic/base/vnic_devcmd.h\n+++ b/drivers/net/enic/base/vnic_devcmd.h\n@@ -63,7 +63,7 @@\n #define _CMD_VTYPE(cmd) (((cmd) >> _CMD_VTYPESHIFT) & _CMD_VTYPEMASK)\n #define _CMD_N(cmd) (((cmd) >> _CMD_NSHIFT) & _CMD_NMASK)\n \n-#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))\n+#define ARRAY_SIZE(x) RTE_DIM(x)\n \n enum vnic_devcmd_cmd {\n \tCMD_NONE = _CMDC(_CMD_DIR_NONE, _CMD_VTYPE_NONE, 0),\ndiff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h\nindex 0d17170fa7..db80c2391c 100644\n--- a/drivers/net/hns3/hns3_ethdev.h\n+++ b/drivers/net/hns3/hns3_ethdev.h\n@@ -887,7 +887,7 @@ static inline uint32_t hns3_read_reg(void *base, uint32_t reg)\n #define hns3_read_dev(a, reg) \\\n \thns3_read_reg((a)->io_base, (reg))\n \n-#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))\n+#define ARRAY_SIZE(x) RTE_DIM(x)\n \n #define NEXT_ITEM_OF_ACTION(act, actions, index) \\\n \tdo {\t\t\t\t\t\t\t\t\\\ndiff --git a/drivers/net/i40e/base/i40e_osdep.h b/drivers/net/i40e/base/i40e_osdep.h\nindex ec9712c3a7..230d400149 100644\n--- a/drivers/net/i40e/base/i40e_osdep.h\n+++ b/drivers/net/i40e/base/i40e_osdep.h\n@@ -175,7 +175,7 @@ static inline uint64_t i40e_read64_addr(volatile void *addr)\n \tI40E_PCI_REG_WRITE(I40E_PCI_REG_ADDR((a), (reg)), (value))\n #define flush(a) i40e_read_addr(I40E_PCI_REG_ADDR((a), (I40E_GLGEN_STAT)))\n \n-#define ARRAY_SIZE(arr) (sizeof(arr)/sizeof(arr[0]))\n+#define ARRAY_SIZE(arr) RTE_DIM(arr)\n \n /* memory allocation tracking */\n struct i40e_dma_mem {\ndiff --git a/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h b/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h\nindex d46574b10e..7b64e2d32b 100644\n--- a/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h\n+++ b/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h\n@@ -23,7 +23,7 @@\n #endif\n \n #ifndef ARRAY_SIZE\n-#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))\n+#define ARRAY_SIZE(x) RTE_DIM(x)\n #endif\n \n #define NFP_ERRNO(err) (errno = (err), -1)\ndiff --git a/drivers/net/thunderx/base/nicvf_hw.h b/drivers/net/thunderx/base/nicvf_hw.h\nindex fd13ea84b6..d6f3a57703 100644\n--- a/drivers/net/thunderx/base/nicvf_hw.h\n+++ b/drivers/net/thunderx/base/nicvf_hw.h\n@@ -17,7 +17,7 @@\n #define\tPCI_SUB_DEVICE_ID_CN81XX_NICVF\t\t\t0xA234\n #define\tPCI_SUB_DEVICE_ID_CN83XX_NICVF\t\t\t0xA334\n \n-#define NICVF_ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))\n+#define NICVF_ARRAY_SIZE(arr) RTE_DIM(arr)\n \n #define NICVF_GET_RX_STATS(reg) \\\n \tnicvf_reg_read(nic, NIC_VNIC_RX_STAT_0_13 | (reg << 3))\n", "prefixes": [] }