Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87521/?format=api
{ "id": 87521, "url": "https://patches.dpdk.org/api/patches/87521/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210129055905.1768645-2-feifei.wang2@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210129055905.1768645-2-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210129055905.1768645-2-feifei.wang2@arm.com", "date": "2021-01-29T05:59:03", "name": "[v3,1/3] test/ring: reduce iteration numbers to make test duration shorter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ba32ffc7fc5bbb257beba019b6acadb3f78bbc1b", "submitter": { "id": 1771, "url": "https://patches.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210129055905.1768645-2-feifei.wang2@arm.com/mbox/", "series": [ { "id": 15026, "url": "https://patches.dpdk.org/api/series/15026/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15026", "date": "2021-01-29T05:59:02", "name": "refactoring ring library", "version": 3, "mbox": "https://patches.dpdk.org/series/15026/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87521/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/87521/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0DE1FA09E4;\n\tFri, 29 Jan 2021 06:59:24 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D7B0B2400FB;\n\tFri, 29 Jan 2021 06:59:18 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id C6BF92400F7;\n Fri, 29 Jan 2021 06:59:17 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E4D1E13A1;\n Thu, 28 Jan 2021 21:59:16 -0800 (PST)", "from net-x86-dell-8268.shanghai.arm.com\n (net-x86-dell-8268.shanghai.arm.com [10.169.210.127])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B153E3F66E;\n Thu, 28 Jan 2021 21:59:13 -0800 (PST)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>,\n Olivier Matz <olivier.matz@6wind.com>, Gavin Hu <gavin.hu@arm.com>", "Cc": "dev@dpdk.org, nd@arm.com, Feifei Wang <feifei.wang2@arm.com>,\n stable@dpdk.org, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>", "Date": "Fri, 29 Jan 2021 13:59:03 +0800", "Message-Id": "<20210129055905.1768645-2-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210129055905.1768645-1-feifei.wang2@arm.com>", "References": "<20201221111359.22013-1-feifei.wang2@arm.com>\n <20210129055905.1768645-1-feifei.wang2@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 1/3] test/ring: reduce iteration numbers to\n make test duration shorter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When testing ring performance in the case that multiple lcores are mapped to\nthe same physical core, e.g. --lcores '(0-3)@10', it takes a very long time\nto wait for the \"enqueue_dequeue_bulk_helper\" to finish. This is because\ntoo much iteration numbers and extremely low efficiency for enqueue and\ndequeue with this kind of core mapping. Following are the test results to\nshow the above phenomenon:\n\nx86-Intel(R) Xeon(R) Gold 6240:\n$sudo ./app/test/dpdk-test --lcores '(0-1)@25'\nTesting using two hyperthreads(bulk (size: 8):)\niter_shift: 3 5 7 9 11 13 *15 17 19 21 23\nrun time: 7s 7s 7s 8s 9s 16s 47s 170s 660s >0.5h >1h\nlegacy APIs: SP/SC: 37 11 6 40525 40525 40209 40367 40407 40541 NoData NoData\nlegacy APIs: MP/MC: 56 14 11 50657 40526 40526 40526 40625 40585 NoData NoData\n\naarch64-n1sdp:\n$sudo ./app/test/dpdk-test --lcore '(0-1)@1'\nTesting using two hyperthreads(bulk (size: 8):)\niter_shift: 3 5 7 9 11 13 *15 17 19 21 23\nrun time: 8s 8s 8s 9s 9s 14s 34s 111s 418s 25min >1h\nlegacy APIs: SP/SC: 0.4 0.2 0.1 488 488 488 488 488 489 489 NoData\nlegacy APIs: MP/MC: 0.4 0.3 0.2 488 488 488 488 490 489 489 NoData\n\nAs the number of iterations increases, so does the time which is required to\nrun the program. Currently (iter_shift = 23), it will take more than 1 hour\nto wait for the test to finish. To fix this, the \"iter_shift\" should decrease\nand ensure enough iterations to keep the test data stable. In order to achieve\nthis, we also test with \"-l\" EAL argument:\n\nx86-Intel(R) Xeon(R) Gold 6240:\n$sudo ./app/test/dpdk-test -l 25-26\nTesting using two NUMA nodes(bulk (size: 8):)\niter_shift: 3 5 7 9 11 13 *15 17 19 21 23\nrun time: 6s 6s 6s 6s 6s 6s 6s 7s 8s 11s 27s\nlegacy APIs: SP/SC: 47 20 13 22 54 83 91 73 81 75 95\nlegacy APIs: MP/MC: 44 18 18 240 245 270 250 249 252 250 253\n\naarch64-n1sdp:\n$sudo ./app/test/dpdk-test -l 1-2\nTesting using two physical cores(bulk (size: 8):)\niter_shift: 3 5 7 9 11 13 *15 17 19 21 23\nrun time: 8s 8s 8s 8s 8s 8s 8s 9s 9s 11s 23s\nlegacy APIs: SP/SC: 0.7 0.4 1.2 1.8 2.0 2.0 2.0 2.0 2.0 2.0 2.0\nlegacy APIs: MP/MC: 0.3 0.4 1.3 1.9 2.9 2.9 2.9 2.9 2.9 2.9 2.9\n\nAccording to above test data, when \"iter_shift\" is set as \"15\", the test run\ntime is reduced to less than 1 minute and the test result can keep stable\nin x86 and aarch64 servers.\n\nFixes: 1fa5d0099efc (\"test/ring: add custom element size performance tests\")\nCc: honnappa.nagarahalli@arm.com\nCc: stable@dpdk.org\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nAcked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n app/test/test_ring_perf.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c\nindex e63e25a86..fd82e2041 100644\n--- a/app/test/test_ring_perf.c\n+++ b/app/test/test_ring_perf.c\n@@ -178,7 +178,7 @@ enqueue_dequeue_bulk_helper(const unsigned int flag, const int esize,\n \tstruct thread_params *p)\n {\n \tint ret;\n-\tconst unsigned int iter_shift = 23;\n+\tconst unsigned int iter_shift = 15;\n \tconst unsigned int iterations = 1 << iter_shift;\n \tstruct rte_ring *r = p->r;\n \tunsigned int bsize = p->size;\n", "prefixes": [ "v3", "1/3" ] }