Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 87497,
    "url": "https://patches.dpdk.org/api/patches/87497/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210128171030.17013-1-akozyrev@nvidia.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210128171030.17013-1-akozyrev@nvidia.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210128171030.17013-1-akozyrev@nvidia.com",
    "date": "2021-01-28T17:10:30",
    "name": "net/mlx5: fix 32-bit arch compilation issue",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "2b399fb0cdd9e906cc30e9b52a947b4e12d4ac44",
    "submitter": {
        "id": 1873,
        "url": "https://patches.dpdk.org/api/people/1873/?format=api",
        "name": "Alexander Kozyrev",
        "email": "akozyrev@nvidia.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210128171030.17013-1-akozyrev@nvidia.com/mbox/",
    "series": [
        {
            "id": 15017,
            "url": "https://patches.dpdk.org/api/series/15017/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15017",
            "date": "2021-01-28T17:10:30",
            "name": "net/mlx5: fix 32-bit arch compilation issue",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/15017/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/87497/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/87497/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BDB6BA09E4;\n\tThu, 28 Jan 2021 18:10:36 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 60A4740682;\n\tThu, 28 Jan 2021 18:10:36 +0100 (CET)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id 0E56B4067A\n for <dev@dpdk.org>; Thu, 28 Jan 2021 18:10:33 +0100 (CET)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n akozyrev@nvidia.com) with SMTP; 28 Jan 2021 19:10:32 +0200",
            "from nvidia.com (pegasus02.mtr.labs.mlnx [10.210.16.122])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 10SHAWn4028844;\n Thu, 28 Jan 2021 19:10:32 +0200"
        ],
        "From": "Alexander Kozyrev <akozyrev@nvidia.com>",
        "To": "dev@dpdk.org",
        "Cc": "rasland@nvidia.com, ferruh.yigit@intel.com",
        "Date": "Thu, 28 Jan 2021 17:10:30 +0000",
        "Message-Id": "<20210128171030.17013-1-akozyrev@nvidia.com>",
        "X-Mailer": "git-send-email 2.24.1",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix 32-bit arch compilation issue",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "There is a \"cast to pointer from integer of different size\"\ncompilation failure on 32-bit machines introduced by the\nRTE_FLOW_ACTION_TYPE_MODIFY_FIELD implementation in mlx5 PMD.\n\nCast the specified value to be used as RTE_FLOW_FIELD_POINTER\nto a pointer with an appropriate size suited for underlying arch.\nPlease squash this patch into the original commit if possible.\n\nFixes: 80ec1e84a4 (\"net/mlx5: support modify field flow action\")\n\nSigned-off-by: Alexander Kozyrev <akozyrev@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex ec9cee8f25..a151c62c3a 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -1749,7 +1749,9 @@ mlx5_flow_field_id_to_modify_info\n \tcase RTE_FLOW_FIELD_POINTER:\n \t\tfor (idx = 0; idx < MLX5_ACT_MAX_MOD_FIELDS; idx++) {\n \t\t\tif (mask[idx]) {\n-\t\t\t\tvalue[idx] = RTE_BE32(*(uint64_t *)data->value);\n+\t\t\t\tmemcpy(&value[idx],\n+\t\t\t\t\t(void *)(uintptr_t)data->value, 32);\n+\t\t\t\tvalue[idx] = RTE_BE32(value[idx]);\n \t\t\t\tbreak;\n \t\t\t}\n \t\t}\n@@ -1757,7 +1759,7 @@ mlx5_flow_field_id_to_modify_info\n \tcase RTE_FLOW_FIELD_VALUE:\n \t\tfor (idx = 0; idx < MLX5_ACT_MAX_MOD_FIELDS; idx++) {\n \t\t\tif (mask[idx]) {\n-\t\t\t\tvalue[idx] = RTE_BE32(data->value);\n+\t\t\t\tvalue[idx] = RTE_BE32((uint32_t)data->value);\n \t\t\t\tbreak;\n \t\t\t}\n \t\t}\n",
    "prefixes": []
}