Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87441/?format=api
{ "id": 87441, "url": "https://patches.dpdk.org/api/patches/87441/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210127160948.6008-35-lironh@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210127160948.6008-35-lironh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210127160948.6008-35-lironh@marvell.com", "date": "2021-01-27T16:09:48", "name": "[v3,34/34] net/mvpp2: add fill buffs to configuration file", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "cb8762f05271a79e59bfdbb8e4b293dd72574646", "submitter": { "id": 996, "url": "https://patches.dpdk.org/api/people/996/?format=api", "name": "Liron Himi", "email": "lironh@marvell.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210127160948.6008-35-lironh@marvell.com/mbox/", "series": [ { "id": 14976, "url": "https://patches.dpdk.org/api/series/14976/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14976", "date": "2021-01-27T16:09:14", "name": "net/mvpp2: misc updates", "version": 3, "mbox": "https://patches.dpdk.org/series/14976/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87441/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/87441/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 60098A052A;\n\tWed, 27 Jan 2021 17:17:04 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9DE0E140F9E;\n\tWed, 27 Jan 2021 17:11:15 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 86B61140F93\n for <dev@dpdk.org>; Wed, 27 Jan 2021 17:11:12 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 10RG62Lj017168; Wed, 27 Jan 2021 08:11:11 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com with ESMTP id 36b1xphfwe-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 27 Jan 2021 08:11:11 -0800", "from SC-EXCH01.marvell.com (10.93.176.81) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 27 Jan 2021 08:11:09 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 27 Jan 2021 08:11:08 -0800", "from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 27 Jan 2021 08:11:07 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=UgUnwP74ua0fI5prsaKqNXJXJjaE3YSy5qpe7zYkX6I=;\n b=R9aOzwrb/vJJt2aaVmxzvgC7TTz7WKa+CcBzIXpARebten2tyhwhKD6VMrhlNXojF76M\n aSv0DRSiqJJND5gX1MJMCts9LQ8CaKWEj64Y8zqorntVIofj2F1h923vlM3NFwPXddno\n mNCLczV6OGk1wWpiyPHFP1MdmNR/G6vhCgK+W+MAmujbXWMzp0xV8Ruzxem8b4Gju2Yp\n ikoY9O1OFis4SQOyIv5UGKc9coJCQJZXWzqbNgh0u0wPJWVatBH35uBuYBhz0nVqW+Sl\n gXriWYpkIF8WRGKE5ljhPsebS395Zm1ZXNrZVjomi4KQ0htFidk3k8X90mm003f02L8B jw==", "From": "<lironh@marvell.com>", "To": "<jerinj@marvell.com>, <ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, Dana Vardi <danat@marvell.com>, Liron Himi\n <lironh@marvell.com>", "Date": "Wed, 27 Jan 2021 18:09:48 +0200", "Message-ID": "<20210127160948.6008-35-lironh@marvell.com>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20210127160948.6008-1-lironh@marvell.com>", "References": "<20210122191925.24308-1-lironh@marvell.com>\n <20210127160948.6008-1-lironh@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737\n definitions=2021-01-27_05:2021-01-27,\n 2021-01-27 signatures=0", "Subject": "[dpdk-dev] [PATCH v3 34/34] net/mvpp2: add fill buffs to\n configuration file", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Dana Vardi <danat@marvell.com>\n\nExtend config file with 'fill_bpool_buffs'\nwhich control the amount of refill buffers\n\nSigned-off-by: Dana Vardi <danat@marvell.com>\nReviewed-by: Liron Himi <lironh@marvell.com>\n---\n doc/guides/nics/mvpp2.rst | 3 +++\n drivers/net/mvpp2/mrvl_ethdev.c | 7 ++++---\n drivers/net/mvpp2/mrvl_ethdev.h | 3 +++\n drivers/net/mvpp2/mrvl_qos.c | 21 +++++++++++++++++++++\n drivers/net/mvpp2/mrvl_qos.h | 1 +\n 5 files changed, 32 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/nics/mvpp2.rst b/doc/guides/nics/mvpp2.rst\nindex 2af351ff57..12bd6fd5d3 100644\n--- a/doc/guides/nics/mvpp2.rst\n+++ b/doc/guides/nics/mvpp2.rst\n@@ -218,6 +218,7 @@ Configuration syntax\n [port <portnum> default]\n start_hdr = <start_hdr>\n forward_bad_frames = <forward_bad_frames>\n+ fill_bpool_buffs = <fill_bpool_buffs>\n default_tc = <default_tc>\n mapping_priority = <mapping_priority>\n \n@@ -266,6 +267,8 @@ Where:\n \n - ``<forward_bad_frames>``: Indicate whether to forward or drop l2 bad packets (0 or 1).\n \n+- ``<fill_bpool_buffs>``: Control the amount of refill buffers (default is 64).\n+\n - ``<default_tc>``: Default traffic class (e.g. 0)\n \n - ``<mapping_priority>``: QoS priority for mapping (`ip`, `vlan`, `ip/vlan` or `vlan/ip`).\ndiff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex 09da461476..009a60ea5c 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -52,8 +52,6 @@\n #define MRVL_IFACE_NAME_ARG \"iface\"\n #define MRVL_CFG_ARG \"cfg\"\n \n-#define MRVL_BURST_SIZE 64\n-\n #define MRVL_ARP_LENGTH 28\n \n #define MRVL_COOKIE_ADDR_INVALID ~0ULL\n@@ -814,12 +812,15 @@ mrvl_dev_start(struct rte_eth_dev *dev)\n \tpriv->ppio_params.match = match;\n \tpriv->ppio_params.eth_start_hdr = PP2_PPIO_HDR_ETH;\n \tpriv->forward_bad_frames = 0;\n+\tpriv->fill_bpool_buffs = MRVL_BURST_SIZE;\n \n \tif (mrvl_cfg) {\n \t\tpriv->ppio_params.eth_start_hdr =\n \t\t\tmrvl_cfg->port[dev->data->port_id].eth_start_hdr;\n \t\tpriv->forward_bad_frames =\n \t\t\tmrvl_cfg->port[dev->data->port_id].forward_bad_frames;\n+\t\tpriv->fill_bpool_buffs =\n+\t\t\tmrvl_cfg->port[dev->data->port_id].fill_bpool_buffs;\n \t}\n \n \t/*\n@@ -2666,7 +2667,7 @@ mrvl_rx_pkt_burst(void *rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \n \t\tif (unlikely(num <= q->priv->bpool_min_size ||\n \t\t\t (!rx_done && num < q->priv->bpool_init_size))) {\n-\t\t\tmrvl_fill_bpool(q, MRVL_BURST_SIZE);\n+\t\t\tmrvl_fill_bpool(q, q->priv->fill_bpool_buffs);\n \t\t} else if (unlikely(num > q->priv->bpool_max_size)) {\n \t\t\tint i;\n \t\t\tint pkt_to_remove = num - q->priv->bpool_init_size;\ndiff --git a/drivers/net/mvpp2/mrvl_ethdev.h b/drivers/net/mvpp2/mrvl_ethdev.h\nindex 8d5469c9d4..fda239a53c 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.h\n+++ b/drivers/net/mvpp2/mrvl_ethdev.h\n@@ -82,6 +82,8 @@\n /** Maximum length of a match string */\n #define MRVL_MATCH_LEN 16\n \n+#define MRVL_BURST_SIZE 64\n+\n /** PMD-specific definition of a flow rule handle. */\n struct mrvl_mtr;\n struct rte_flow {\n@@ -183,6 +185,7 @@ struct mrvl_priv {\n \tuint64_t rate_max;\n \n \tuint8_t forward_bad_frames;\n+\tuint32_t fill_bpool_buffs;\n };\n \n /** Flow operations forward declaration. */\ndiff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c\nindex a415584884..dbfc3b5d20 100644\n--- a/drivers/net/mvpp2/mrvl_qos.c\n+++ b/drivers/net/mvpp2/mrvl_qos.c\n@@ -79,6 +79,9 @@\n /* parser forward bad frames tokens */\n #define MRVL_TOK_FWD_BAD_FRAMES \"forward_bad_frames\"\n \n+/* parse fill bpool buffers tokens */\n+#define MRVL_TOK_FILL_BPOOL_BUFFS \"fill_bpool_buffs\"\n+\n /** Number of tokens in range a-b = 2. */\n #define MAX_RNG_TOKENS 2\n \n@@ -720,6 +723,11 @@ mrvl_get_cfg(const char *key __rte_unused, const char *path, void *extra_args)\n \t\t/* Use global defaults, unless an override occurs */\n \t\t(*cfg)->port[n].use_qos_global_defaults = 1;\n \n+\t\t/* Set non-zero defaults before the decision to continue to next\n+\t\t * port or to parse the port section in config file\n+\t\t */\n+\t\t(*cfg)->port[n].fill_bpool_buffs = MRVL_BURST_SIZE;\n+\n \t\t/* Skip ports non-existing in configuration. */\n \t\tif (rte_cfgfile_num_sections(file, sec_name,\n \t\t\t\tstrlen(sec_name)) <= 0) {\n@@ -889,6 +897,19 @@ mrvl_get_cfg(const char *key __rte_unused, const char *path, void *extra_args)\n \t\t} else {\n \t\t\t(*cfg)->port[n].forward_bad_frames = 0;\n \t\t}\n+\n+\t\t/* Parse fill bpool buffs option */\n+\t\tentry = rte_cfgfile_get_entry(file, sec_name,\n+\t\t\t\tMRVL_TOK_FILL_BPOOL_BUFFS);\n+\t\tif (entry) {\n+\t\t\tif (get_val_securely(entry, &val) < 0) {\n+\t\t\t\tMRVL_LOG(ERR,\n+\t\t\t\t\t\"Error in parsing %s value (%s)!\\n\",\n+\t\t\t\t\tMRVL_TOK_FILL_BPOOL_BUFFS, entry);\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\t\t\t(*cfg)->port[n].fill_bpool_buffs = val;\n+\t\t}\n \t}\n \n \treturn 0;\ndiff --git a/drivers/net/mvpp2/mrvl_qos.h b/drivers/net/mvpp2/mrvl_qos.h\nindex 763130bf17..38ea309caa 100644\n--- a/drivers/net/mvpp2/mrvl_qos.h\n+++ b/drivers/net/mvpp2/mrvl_qos.h\n@@ -49,6 +49,7 @@ struct mrvl_cfg {\n \t\tstruct pp2_cls_plcr_params policer_params;\n \t\tuint8_t setup_policer;\n \t\tuint8_t forward_bad_frames;\n+\t\tuint32_t fill_bpool_buffs;\n \t} port[RTE_MAX_ETHPORTS];\n };\n \n", "prefixes": [ "v3", "34/34" ] }