Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87418/?format=api
{ "id": 87418, "url": "https://patches.dpdk.org/api/patches/87418/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210127160948.6008-12-lironh@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210127160948.6008-12-lironh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210127160948.6008-12-lironh@marvell.com", "date": "2021-01-27T16:09:25", "name": "[v3,11/34] net/mvpp2: add VLAN offload support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "78f270ce891d3509e2ac2b8174bd58694ca808dd", "submitter": { "id": 996, "url": "https://patches.dpdk.org/api/people/996/?format=api", "name": "Liron Himi", "email": "lironh@marvell.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210127160948.6008-12-lironh@marvell.com/mbox/", "series": [ { "id": 14976, "url": "https://patches.dpdk.org/api/series/14976/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14976", "date": "2021-01-27T16:09:14", "name": "net/mvpp2: misc updates", "version": 3, "mbox": "https://patches.dpdk.org/series/14976/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87418/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87418/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 303EBA052A;\n\tWed, 27 Jan 2021 17:12:25 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C0A25140F01;\n\tWed, 27 Jan 2021 17:10:28 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 8A9D7140EFF\n for <dev@dpdk.org>; Wed, 27 Jan 2021 17:10:26 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 10RG5mYj027270; Wed, 27 Jan 2021 08:10:25 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com with ESMTP id 368j1uc389-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 27 Jan 2021 08:10:25 -0800", "from SC-EXCH04.marvell.com (10.93.176.84) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 27 Jan 2021 08:10:22 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH04.marvell.com\n (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 27 Jan 2021 08:10:21 -0800", "from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 27 Jan 2021 08:10:20 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=OCl/Ykxh+U5zXziu7UQvJYf5NZOTYzrUGeVSVeyYzgQ=;\n b=lEqrPm/3DjJiUR33P08F/y2BsQy8GDLWSkEfzIk7Qks35uTbixC9imVwMgiK52uej4+p\n pP1Hq4qFg/rs4UsAkD/8X09+x7uEO+5nXlvu+ZbcW+aDJ6wAZ0HMFF8GPbrIzjfPhNeS\n 2vhjNAtHAbnQFOK8bPXggbbe5flZgvSM30E1R2tdgfZ7PA22hgiOkJRkM+HPbI8N0hF3\n QjATl4V7Rr3jcILXFIXcu4ffSlS4pEUeesWz0TCCoWrjiCmj0aHJen3iUNVQ1kkx8Srl\n Y+hGquHVbC+h73NqOxBhaQ7yPtLmTbre+2ye3bo4v+uJZ0cMhTuVEY5YzwTRY8laMiYd fw==", "From": "<lironh@marvell.com>", "To": "<jerinj@marvell.com>, <ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, Yuri Chipchev <yuric@marvell.com>, Liron Himi\n <lironh@marvell.com>", "Date": "Wed, 27 Jan 2021 18:09:25 +0200", "Message-ID": "<20210127160948.6008-12-lironh@marvell.com>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20210127160948.6008-1-lironh@marvell.com>", "References": "<20210122191925.24308-1-lironh@marvell.com>\n <20210127160948.6008-1-lironh@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737\n definitions=2021-01-27_05:2021-01-27,\n 2021-01-27 signatures=0", "Subject": "[dpdk-dev] [PATCH v3 11/34] net/mvpp2: add VLAN offload support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yuri Chipchev <yuric@marvell.com>\n\nEnable VLAN filter configuration\n\nSigned-off-by: Yuri Chipchev <yuric@marvell.com>\nReviewed-by: Liron Himi <lironh@marvell.com>\n---\n drivers/net/mvpp2/mrvl_ethdev.c | 110 +++++++++++++++++++++++++-------\n 1 file changed, 86 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex e64847f4a1..8659cd9792 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -616,6 +616,51 @@ mrvl_tx_queue_stop(struct rte_eth_dev *dev, uint16_t queue_id)\n \treturn 0;\n }\n \n+/**\n+ * Populate VLAN Filter configuration.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device structure.\n+ * @param on\n+ * Toggle filter.\n+ *\n+ * @return\n+ * 0 on success, negative error value otherwise.\n+ */\n+static int mrvl_populate_vlan_table(struct rte_eth_dev *dev, int on)\n+{\n+\tuint32_t j;\n+\tint ret;\n+\tstruct rte_vlan_filter_conf *vfc;\n+\n+\tvfc = &dev->data->vlan_filter_conf;\n+\tfor (j = 0; j < RTE_DIM(vfc->ids); j++) {\n+\t\tuint64_t vlan;\n+\t\tuint64_t vbit;\n+\t\tuint64_t ids = vfc->ids[j];\n+\n+\t\tif (ids == 0)\n+\t\t\tcontinue;\n+\n+\t\twhile (ids) {\n+\t\t\tvlan = 64 * j;\n+\t\t\t/* count trailing zeroes */\n+\t\t\tvbit = ~ids & (ids - 1);\n+\t\t\t/* clear least significant bit set */\n+\t\t\tids ^= (ids ^ (ids - 1)) ^ vbit;\n+\t\t\tfor (; vbit; vlan++)\n+\t\t\t\tvbit >>= 1;\n+\t\t\tret = mrvl_vlan_filter_set(dev, vlan, on);\n+\t\t\tif (ret) {\n+\t\t\t\tMRVL_LOG(ERR, \"Failed to setup VLAN filter\\n\");\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\t\t}\n+\t}\n+\n+\treturn 0;\n+}\n+\n /**\n * DPDK callback to start the device.\n *\n@@ -631,8 +676,6 @@ mrvl_dev_start(struct rte_eth_dev *dev)\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n \tchar match[MRVL_MATCH_LEN];\n \tint ret = 0, i, def_init_size;\n-\tuint32_t j;\n-\tstruct rte_vlan_filter_conf *vfc;\n \tstruct rte_ether_addr *mac_addr;\n \n \tif (priv->ppio)\n@@ -715,28 +758,11 @@ mrvl_dev_start(struct rte_eth_dev *dev)\n \tif (dev->data->all_multicast == 1)\n \t\tmrvl_allmulticast_enable(dev);\n \n-\tvfc = &dev->data->vlan_filter_conf;\n-\tfor (j = 0; j < RTE_DIM(vfc->ids); j++) {\n-\t\tuint64_t vlan;\n-\t\tuint64_t vbit;\n-\t\tuint64_t ids = vfc->ids[j];\n-\n-\t\tif (ids == 0)\n-\t\t\tcontinue;\n-\n-\t\twhile (ids) {\n-\t\t\tvlan = 64 * j;\n-\t\t\t/* count trailing zeroes */\n-\t\t\tvbit = ~ids & (ids - 1);\n-\t\t\t/* clear least significant bit set */\n-\t\t\tids ^= (ids ^ (ids - 1)) ^ vbit;\n-\t\t\tfor (; vbit; vlan++)\n-\t\t\t\tvbit >>= 1;\n-\t\t\tret = mrvl_vlan_filter_set(dev, vlan, 1);\n-\t\t\tif (ret) {\n-\t\t\t\tMRVL_LOG(ERR, \"Failed to setup VLAN filter\\n\");\n-\t\t\t\tgoto out;\n-\t\t\t}\n+\tif (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_VLAN_FILTER) {\n+\t\tret = mrvl_populate_vlan_table(dev, 1);\n+\t\tif (ret) {\n+\t\t\tMRVL_LOG(ERR, \"Failed to populate VLAN table\");\n+\t\t\tgoto out;\n \t\t}\n \t}\n \n@@ -1671,6 +1697,41 @@ mrvl_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)\n \t\t pp2_ppio_remove_vlan(priv->ppio, vlan_id);\n }\n \n+/**\n+ * DPDK callback to Configure VLAN offload.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device structure.\n+ * @param mask\n+ * VLAN offload mask.\n+ *\n+ * @return\n+ * 0 on success, negative error value otherwise.\n+ */\n+static int mrvl_vlan_offload_set(struct rte_eth_dev *dev, int mask)\n+{\n+\tuint64_t rx_offloads = dev->data->dev_conf.rxmode.offloads;\n+\tint ret;\n+\n+\tif (mask & ETH_VLAN_STRIP_MASK)\n+\t\tMRVL_LOG(ERR, \"VLAN stripping is not supported\\n\");\n+\n+\tif (mask & ETH_VLAN_FILTER_MASK) {\n+\t\tif (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)\n+\t\t\tret = mrvl_populate_vlan_table(dev, 1);\n+\t\telse\n+\t\t\tret = mrvl_populate_vlan_table(dev, 0);\n+\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\t}\n+\n+\tif (mask & ETH_VLAN_EXTEND_MASK)\n+\t\tMRVL_LOG(ERR, \"Extend VLAN not supported\\n\");\n+\n+\treturn 0;\n+}\n+\n /**\n * Release buffers to hardware bpool (buffer-pool)\n *\n@@ -2164,6 +2225,7 @@ static const struct eth_dev_ops mrvl_ops = {\n \t.rxq_info_get = mrvl_rxq_info_get,\n \t.txq_info_get = mrvl_txq_info_get,\n \t.vlan_filter_set = mrvl_vlan_filter_set,\n+\t.vlan_offload_set = mrvl_vlan_offload_set,\n \t.tx_queue_start = mrvl_tx_queue_start,\n \t.tx_queue_stop = mrvl_tx_queue_stop,\n \t.rx_queue_setup = mrvl_rx_queue_setup,\n", "prefixes": [ "v3", "11/34" ] }