Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87331/?format=api
{ "id": 87331, "url": "https://patches.dpdk.org/api/patches/87331/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210126101639.250481-44-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210126101639.250481-44-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210126101639.250481-44-maxime.coquelin@redhat.com", "date": "2021-01-26T10:16:38", "name": "[v4,43/44] net/virtio: improve Vhost-user error logging", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a60678ce16bf97c31e65df8477588922f431e2ca", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210126101639.250481-44-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 14950, "url": "https://patches.dpdk.org/api/series/14950/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14950", "date": "2021-01-26T10:15:55", "name": "net/virtio: Virtio PMD rework", "version": 4, "mbox": "https://patches.dpdk.org/series/14950/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87331/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87331/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 61CCBA052A;\n\tTue, 26 Jan 2021 11:23:59 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 186DA141451;\n\tTue, 26 Jan 2021 11:18:52 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by mails.dpdk.org (Postfix) with ESMTP id EB183141448\n for <dev@dpdk.org>; Tue, 26 Jan 2021 11:18:47 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-545-jTF3vI0iMYy--9WI58Fe_w-1; Tue, 26 Jan 2021 05:18:45 -0500", "from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com\n [10.5.11.11])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6D72C1005504;\n Tue, 26 Jan 2021 10:18:44 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.36.110.31])\n by smtp.corp.redhat.com (Postfix) with ESMTP id DDF3A72171;\n Tue, 26 Jan 2021 10:18:39 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1611656327;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=bV+VK7GP4jLkhRqmpdH9ZEXdksebbGkXSYQhDugo24o=;\n b=a+C4d2n2T89tnXRe9OI8SB5LPArLAr/a8i5n2lj9TPf+2NgXHG0CTkCiZjy/Ejdcc6w3rx\n gFTnaHVEMPZevVxecuIaIN1ZLJA4zMNkkwxmL5qNVIAgHyq1DtX9CAHrTq2OAc36xEfy4d\n jAGJBzjNjEVcePZTAwByMMJhR6RVOEw=", "X-MC-Unique": "jTF3vI0iMYy--9WI58Fe_w-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, olivier.matz@6wind.com,\n amorenoz@redhat.com, david.marchand@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Tue, 26 Jan 2021 11:16:38 +0100", "Message-Id": "<20210126101639.250481-44-maxime.coquelin@redhat.com>", "In-Reply-To": "<20210126101639.250481-1-maxime.coquelin@redhat.com>", "References": "<20210126101639.250481-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH v4 43/44] net/virtio: improve Vhost-user error\n logging", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch improves error logging in vhost_user_read,\nespecially printing errno when recv() fails.\n\nSuggested-by: Adrian Moreno <amorenoz@redhat.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\n---\n drivers/net/virtio/virtio_user/vhost_user.c | 31 ++++++++++++---------\n 1 file changed, 18 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c\nindex 088aae3aa3..ec2c53c8fb 100644\n--- a/drivers/net/virtio/virtio_user/vhost_user.c\n+++ b/drivers/net/virtio/virtio_user/vhost_user.c\n@@ -148,38 +148,43 @@ vhost_user_read(int fd, struct vhost_user_msg *msg)\n \tint ret, sz_hdr = VHOST_USER_HDR_SIZE, sz_payload;\n \n \tret = recv(fd, (void *)msg, sz_hdr, 0);\n-\tif (ret < sz_hdr) {\n+\tif (ret < 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to recv msg header: %s\", strerror(errno));\n+\t\treturn -1;\n+\t} else if (ret < sz_hdr) {\n \t\tPMD_DRV_LOG(ERR, \"Failed to recv msg hdr: %d instead of %d.\",\n \t\t\t ret, sz_hdr);\n-\t\tgoto fail;\n+\t\treturn -1;\n \t}\n \n \t/* validate msg flags */\n \tif (msg->flags != (valid_flags)) {\n-\t\tPMD_DRV_LOG(ERR, \"Failed to recv msg: flags %x instead of %x.\",\n+\t\tPMD_DRV_LOG(ERR, \"Failed to recv msg: flags 0x%x instead of 0x%x.\",\n \t\t\t msg->flags, valid_flags);\n-\t\tgoto fail;\n+\t\treturn -1;\n \t}\n \n \tsz_payload = msg->size;\n \n-\tif ((size_t)sz_payload > sizeof(msg->payload))\n-\t\tgoto fail;\n+\tif ((size_t)sz_payload > sizeof(msg->payload)) {\n+\t\tPMD_DRV_LOG(ERR, \"Payload size overflow, header says %d but max %zu\\n\",\n+\t\t\t\tsz_payload, sizeof(msg->payload));\n+\t\treturn -1;\n+\t}\n \n \tif (sz_payload) {\n \t\tret = recv(fd, (void *)((char *)msg + sz_hdr), sz_payload, 0);\n-\t\tif (ret < sz_payload) {\n-\t\t\tPMD_DRV_LOG(ERR,\n-\t\t\t\t\"Failed to recv msg payload: %d instead of %d.\",\n+\t\tif (ret < 0) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Failed to recv msg payload: %s\", strerror(errno));\n+\t\t\treturn -1;\n+\t\t} else if (ret < sz_payload) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Failed to recv msg payload: %d instead of %u.\",\n \t\t\t\tret, msg->size);\n-\t\t\tgoto fail;\n+\t\t\treturn -1;\n \t\t}\n \t}\n \n \treturn 0;\n-\n-fail:\n-\treturn -1;\n }\n \n static int\n", "prefixes": [ "v4", "43/44" ] }