Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87317/?format=api
{ "id": 87317, "url": "https://patches.dpdk.org/api/patches/87317/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210126101639.250481-30-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210126101639.250481-30-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210126101639.250481-30-maxime.coquelin@redhat.com", "date": "2021-01-26T10:16:24", "name": "[v4,29/44] net/virtio: add Virtio-user memory tables ops", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ad3b1db818ff937877972fb0c32864b7696f77ab", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210126101639.250481-30-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 14950, "url": "https://patches.dpdk.org/api/series/14950/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14950", "date": "2021-01-26T10:15:55", "name": "net/virtio: Virtio PMD rework", "version": 4, "mbox": "https://patches.dpdk.org/series/14950/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87317/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/87317/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 78CC5A052A;\n\tTue, 26 Jan 2021 11:21:43 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1EF781413EA;\n\tTue, 26 Jan 2021 11:18:19 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by mails.dpdk.org (Postfix) with ESMTP id 6C0361413C2\n for <dev@dpdk.org>; Tue, 26 Jan 2021 11:18:13 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-207-8NYu2Hp4MJe1qdZUOHx-Mg-1; Tue, 26 Jan 2021 05:18:10 -0500", "from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com\n [10.5.11.11])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DBC70107ACE3;\n Tue, 26 Jan 2021 10:18:09 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.36.110.31])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 8502C6F45C;\n Tue, 26 Jan 2021 10:18:05 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1611656292;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=/vczVRTzeVnlq6wbTrQWHJ5YsrpUt/BMU9tdMKmHoO8=;\n b=CJc7aoxO+g7f2fmYHDUW9D7Waiz7Y4w4mjYgztbc/muyl9DQ2LBeSiYZ+ojabwEjj06NLB\n 124XNjht5/8uNY15FgFdOHfbb+gucozUkVH9e8adm8RRpUefRa1HULvdCAz1zy6DP+VzYY\n MFuBuUNvu5OrHbbZ3r0m/NBI160lfxQ=", "X-MC-Unique": "8NYu2Hp4MJe1qdZUOHx-Mg-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, olivier.matz@6wind.com,\n amorenoz@redhat.com, david.marchand@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Tue, 26 Jan 2021 11:16:24 +0100", "Message-Id": "<20210126101639.250481-30-maxime.coquelin@redhat.com>", "In-Reply-To": "<20210126101639.250481-1-maxime.coquelin@redhat.com>", "References": "<20210126101639.250481-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH v4 29/44] net/virtio: add Virtio-user memory\n tables ops", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch implements a dedicated callback for\npreparing and sending memory table to the backends.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\n---\n drivers/net/virtio/virtio_user/vhost.h | 1 +\n drivers/net/virtio/virtio_user/vhost_kernel.c | 60 ++++++-------\n drivers/net/virtio/virtio_user/vhost_user.c | 86 ++++++++++++++-----\n drivers/net/virtio/virtio_user/vhost_vdpa.c | 8 +-\n .../net/virtio/virtio_user/virtio_user_dev.c | 4 +-\n 5 files changed, 101 insertions(+), 58 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/vhost.h b/drivers/net/virtio/virtio_user/vhost.h\nindex d805526130..463801f563 100644\n--- a/drivers/net/virtio/virtio_user/vhost.h\n+++ b/drivers/net/virtio/virtio_user/vhost.h\n@@ -114,6 +114,7 @@ struct virtio_user_backend_ops {\n \tint (*set_features)(struct virtio_user_dev *dev, uint64_t features);\n \tint (*get_protocol_features)(struct virtio_user_dev *dev, uint64_t *features);\n \tint (*set_protocol_features)(struct virtio_user_dev *dev, uint64_t features);\n+\tint (*set_memory_table)(struct virtio_user_dev *dev);\n \tint (*send_request)(struct virtio_user_dev *dev,\n \t\t\t enum vhost_user_request req,\n \t\t\t void *arg);\ndiff --git a/drivers/net/virtio/virtio_user/vhost_kernel.c b/drivers/net/virtio/virtio_user/vhost_kernel.c\nindex e46039e649..69f932bede 100644\n--- a/drivers/net/virtio/virtio_user/vhost_kernel.c\n+++ b/drivers/net/virtio/virtio_user/vhost_kernel.c\n@@ -148,17 +148,6 @@ vhost_kernel_set_features(struct virtio_user_dev *dev, uint64_t features)\n \treturn vhost_kernel_ioctl(dev->vhostfds[0], VHOST_SET_FEATURES, &features);\n }\n \n-static uint64_t vhost_req_user_to_kernel[] = {\n-\t[VHOST_USER_RESET_OWNER] = VHOST_RESET_OWNER,\n-\t[VHOST_USER_SET_VRING_CALL] = VHOST_SET_VRING_CALL,\n-\t[VHOST_USER_SET_VRING_NUM] = VHOST_SET_VRING_NUM,\n-\t[VHOST_USER_SET_VRING_BASE] = VHOST_SET_VRING_BASE,\n-\t[VHOST_USER_GET_VRING_BASE] = VHOST_GET_VRING_BASE,\n-\t[VHOST_USER_SET_VRING_ADDR] = VHOST_SET_VRING_ADDR,\n-\t[VHOST_USER_SET_VRING_KICK] = VHOST_SET_VRING_KICK,\n-\t[VHOST_USER_SET_MEM_TABLE] = VHOST_SET_MEM_TABLE,\n-};\n-\n static int\n add_memseg_list(const struct rte_memseg_list *msl, void *arg)\n {\n@@ -193,16 +182,17 @@ add_memseg_list(const struct rte_memseg_list *msl, void *arg)\n * have much more memory regions. Below function will treat each\n * contiguous memory space reserved by DPDK as one region.\n */\n-static struct vhost_memory_kernel *\n-prepare_vhost_memory_kernel(void)\n+static int\n+vhost_kernel_set_memory_table(struct virtio_user_dev *dev)\n {\n \tstruct vhost_memory_kernel *vm;\n+\tint ret;\n \n \tvm = malloc(sizeof(struct vhost_memory_kernel) +\n \t\t\tmax_regions *\n \t\t\tsizeof(struct vhost_memory_region));\n \tif (!vm)\n-\t\treturn NULL;\n+\t\tgoto err;\n \n \tvm->nregions = 0;\n \tvm->padding = 0;\n@@ -211,14 +201,34 @@ prepare_vhost_memory_kernel(void)\n \t * The memory lock has already been taken by memory subsystem\n \t * or virtio_user_start_device().\n \t */\n-\tif (rte_memseg_list_walk_thread_unsafe(add_memseg_list, vm) < 0) {\n-\t\tfree(vm);\n-\t\treturn NULL;\n-\t}\n+\tret = rte_memseg_list_walk_thread_unsafe(add_memseg_list, vm);\n+\tif (ret < 0)\n+\t\tgoto err_free;\n+\n+\tret = vhost_kernel_ioctl(dev->vhostfds[0], VHOST_SET_MEM_TABLE, vm);\n+\tif (ret < 0)\n+\t\tgoto err_free;\n \n-\treturn vm;\n+\tfree(vm);\n+\n+\treturn 0;\n+err_free:\n+\tfree(vm);\n+err:\n+\tPMD_DRV_LOG(ERR, \"Failed to set memory table\");\n+\treturn -1;\n }\n \n+static uint64_t vhost_req_user_to_kernel[] = {\n+\t[VHOST_USER_RESET_OWNER] = VHOST_RESET_OWNER,\n+\t[VHOST_USER_SET_VRING_CALL] = VHOST_SET_VRING_CALL,\n+\t[VHOST_USER_SET_VRING_NUM] = VHOST_SET_VRING_NUM,\n+\t[VHOST_USER_SET_VRING_BASE] = VHOST_SET_VRING_BASE,\n+\t[VHOST_USER_GET_VRING_BASE] = VHOST_GET_VRING_BASE,\n+\t[VHOST_USER_SET_VRING_ADDR] = VHOST_SET_VRING_ADDR,\n+\t[VHOST_USER_SET_VRING_KICK] = VHOST_SET_VRING_KICK,\n+};\n+\n static int\n vhost_kernel_send_request(struct virtio_user_dev *dev,\n \t\t enum vhost_user_request req,\n@@ -227,7 +237,6 @@ vhost_kernel_send_request(struct virtio_user_dev *dev,\n \tint ret = -1;\n \tunsigned int i;\n \tuint64_t req_kernel;\n-\tstruct vhost_memory_kernel *vm = NULL;\n \tint vhostfd;\n \tunsigned int queue_sel;\n \n@@ -235,13 +244,6 @@ vhost_kernel_send_request(struct virtio_user_dev *dev,\n \n \treq_kernel = vhost_req_user_to_kernel[req];\n \n-\tif (req_kernel == VHOST_SET_MEM_TABLE) {\n-\t\tvm = prepare_vhost_memory_kernel();\n-\t\tif (!vm)\n-\t\t\treturn -1;\n-\t\targ = (void *)vm;\n-\t}\n-\n \tswitch (req_kernel) {\n \tcase VHOST_SET_VRING_NUM:\n \tcase VHOST_SET_VRING_ADDR:\n@@ -271,9 +273,6 @@ vhost_kernel_send_request(struct virtio_user_dev *dev,\n \t\tret = ioctl(vhostfd, req_kernel, arg);\n \t}\n \n-\tif (vm)\n-\t\tfree(vm);\n-\n \tif (ret < 0)\n \t\tPMD_DRV_LOG(ERR, \"%s failed: %s\",\n \t\t\t vhost_msg_strings[req], strerror(errno));\n@@ -403,6 +402,7 @@ struct virtio_user_backend_ops virtio_ops_kernel = {\n \t.set_owner = vhost_kernel_set_owner,\n \t.get_features = vhost_kernel_get_features,\n \t.set_features = vhost_kernel_set_features,\n+\t.set_memory_table = vhost_kernel_set_memory_table,\n \t.send_request = vhost_kernel_send_request,\n \t.enable_qp = vhost_kernel_enable_queue_pair\n };\ndiff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c\nindex 4877574f72..84765d5fdf 100644\n--- a/drivers/net/virtio/virtio_user/vhost_user.c\n+++ b/drivers/net/virtio/virtio_user/vhost_user.c\n@@ -81,6 +81,9 @@ vhost_user_write(int fd, struct vhost_user_msg *msg, int *fds, int fd_num)\n \t\tr = sendmsg(fd, &msgh, 0);\n \t} while (r < 0 && errno == EINTR);\n \n+\tif (r < 0)\n+\t\tPMD_DRV_LOG(ERR, \"Failed to send msg: %s\", strerror(errno));\n+\n \treturn r;\n }\n \n@@ -125,6 +128,39 @@ vhost_user_read(int fd, struct vhost_user_msg *msg)\n \treturn -1;\n }\n \n+static int\n+vhost_user_check_reply_ack(struct virtio_user_dev *dev, struct vhost_user_msg *msg)\n+{\n+\tenum vhost_user_request req = msg->request;\n+\tint ret;\n+\n+\tif (!(msg->flags & VHOST_USER_NEED_REPLY_MASK))\n+\t\treturn 0;\n+\n+\tret = vhost_user_read(dev->vhostfd, msg);\n+\tif (ret < 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to read reply-ack\");\n+\t\treturn -1;\n+\t}\n+\n+\tif (req != msg->request) {\n+\t\tPMD_DRV_LOG(ERR, \"Unexpected reply-ack request type (%d)\", msg->request);\n+\t\treturn -1;\n+\t}\n+\n+\tif (msg->size != sizeof(msg->payload.u64)) {\n+\t\tPMD_DRV_LOG(ERR, \"Unexpected reply-ack payload size (%u)\", msg->size);\n+\t\treturn -1;\n+\t}\n+\n+\tif (msg->payload.u64) {\n+\t\tPMD_DRV_LOG(ERR, \"Slave replied NACK to request type (%d)\", msg->request);\n+\t\treturn -1;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static int\n vhost_user_set_owner(struct virtio_user_dev *dev)\n {\n@@ -338,25 +374,47 @@ update_memory_region(const struct rte_memseg_list *msl __rte_unused,\n }\n \n static int\n-prepare_vhost_memory_user(struct vhost_user_msg *msg, int fds[])\n+vhost_user_set_memory_table(struct virtio_user_dev *dev)\n {\n \tstruct walk_arg wa;\n+\tint fds[VHOST_MEMORY_MAX_NREGIONS];\n+\tint ret, fd_num;\n+\tstruct vhost_user_msg msg = {\n+\t\t.request = VHOST_USER_SET_MEM_TABLE,\n+\t\t.flags = VHOST_USER_VERSION,\n+\t};\n+\n+\tif (dev->protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK))\n+\t\tmsg.flags |= VHOST_USER_NEED_REPLY_MASK;\n \n \twa.region_nr = 0;\n-\twa.vm = &msg->payload.memory;\n+\twa.vm = &msg.payload.memory;\n \twa.fds = fds;\n \n \t/*\n \t * The memory lock has already been taken by memory subsystem\n \t * or virtio_user_start_device().\n \t */\n-\tif (rte_memseg_walk_thread_unsafe(update_memory_region, &wa) < 0)\n-\t\treturn -1;\n+\tret = rte_memseg_walk_thread_unsafe(update_memory_region, &wa);\n+\tif (ret < 0)\n+\t\tgoto err;\n \n-\tmsg->payload.memory.nregions = wa.region_nr;\n-\tmsg->payload.memory.padding = 0;\n+\tfd_num = wa.region_nr;\n+\tmsg.payload.memory.nregions = wa.region_nr;\n+\tmsg.payload.memory.padding = 0;\n \n-\treturn 0;\n+\tmsg.size = sizeof(msg.payload.memory.nregions);\n+\tmsg.size += sizeof(msg.payload.memory.padding);\n+\tmsg.size += fd_num * sizeof(struct vhost_memory_region);\n+\n+\tret = vhost_user_write(dev->vhostfd, &msg, fds, fd_num);\n+\tif (ret < 0)\n+\t\tgoto err;\n+\n+\treturn vhost_user_check_reply_ack(dev, &msg);\n+err:\n+\tPMD_DRV_LOG(ERR, \"Failed to set memory table\");\n+\treturn -1;\n }\n \n static struct vhost_user_msg m;\n@@ -369,7 +427,6 @@ const char * const vhost_msg_strings[] = {\n \t[VHOST_USER_GET_VRING_BASE] = \"VHOST_GET_VRING_BASE\",\n \t[VHOST_USER_SET_VRING_ADDR] = \"VHOST_SET_VRING_ADDR\",\n \t[VHOST_USER_SET_VRING_KICK] = \"VHOST_SET_VRING_KICK\",\n-\t[VHOST_USER_SET_MEM_TABLE] = \"VHOST_SET_MEM_TABLE\",\n \t[VHOST_USER_SET_VRING_ENABLE] = \"VHOST_SET_VRING_ENABLE\",\n \t[VHOST_USER_SET_STATUS] = \"VHOST_SET_STATUS\",\n \t[VHOST_USER_GET_STATUS] = \"VHOST_GET_STATUS\",\n@@ -434,18 +491,6 @@ vhost_user_sock(struct virtio_user_dev *dev,\n \tcase VHOST_USER_RESET_OWNER:\n \t\tbreak;\n \n-\tcase VHOST_USER_SET_MEM_TABLE:\n-\t\tif (prepare_vhost_memory_user(&msg, fds) < 0)\n-\t\t\treturn -1;\n-\t\tfd_num = msg.payload.memory.nregions;\n-\t\tmsg.size = sizeof(m.payload.memory.nregions);\n-\t\tmsg.size += sizeof(m.payload.memory.padding);\n-\t\tmsg.size += fd_num * sizeof(struct vhost_memory_region);\n-\n-\t\tif (has_reply_ack)\n-\t\t\tmsg.flags |= VHOST_USER_NEED_REPLY_MASK;\n-\t\tbreak;\n-\n \tcase VHOST_USER_SET_LOG_FD:\n \t\tfds[fd_num++] = *((int *)arg);\n \t\tbreak;\n@@ -644,6 +689,7 @@ struct virtio_user_backend_ops virtio_ops_user = {\n \t.set_features = vhost_user_set_features,\n \t.get_protocol_features = vhost_user_get_protocol_features,\n \t.set_protocol_features = vhost_user_set_protocol_features,\n+\t.set_memory_table = vhost_user_set_memory_table,\n \t.send_request = vhost_user_sock,\n \t.enable_qp = vhost_user_enable_queue_pair\n };\ndiff --git a/drivers/net/virtio/virtio_user/vhost_vdpa.c b/drivers/net/virtio/virtio_user/vhost_vdpa.c\nindex f627afbcfc..bd7daebf0c 100644\n--- a/drivers/net/virtio/virtio_user/vhost_vdpa.c\n+++ b/drivers/net/virtio/virtio_user/vhost_vdpa.c\n@@ -19,7 +19,6 @@\n #define VHOST_SET_FEATURES _IOW(VHOST_VIRTIO, 0x00, __u64)\n #define VHOST_SET_OWNER _IO(VHOST_VIRTIO, 0x01)\n #define VHOST_RESET_OWNER _IO(VHOST_VIRTIO, 0x02)\n-#define VHOST_SET_MEM_TABLE _IOW(VHOST_VIRTIO, 0x03, void *)\n #define VHOST_SET_LOG_BASE _IOW(VHOST_VIRTIO, 0x04, __u64)\n #define VHOST_SET_LOG_FD _IOW(VHOST_VIRTIO, 0x07, int)\n #define VHOST_SET_VRING_NUM _IOW(VHOST_VIRTIO, 0x10, struct vhost_vring_state)\n@@ -46,7 +45,6 @@ static uint64_t vhost_req_user_to_vdpa[] = {\n \t[VHOST_USER_GET_VRING_BASE] = VHOST_GET_VRING_BASE,\n \t[VHOST_USER_SET_VRING_ADDR] = VHOST_SET_VRING_ADDR,\n \t[VHOST_USER_SET_VRING_KICK] = VHOST_SET_VRING_KICK,\n-\t[VHOST_USER_SET_MEM_TABLE] = VHOST_SET_MEM_TABLE,\n \t[VHOST_USER_SET_STATUS] = VHOST_VDPA_SET_STATUS,\n \t[VHOST_USER_GET_STATUS] = VHOST_VDPA_GET_STATUS,\n \t[VHOST_USER_SET_VRING_ENABLE] = VHOST_VDPA_SET_VRING_ENABLE,\n@@ -319,7 +317,7 @@ vhost_vdpa_map(const struct rte_memseg_list *msl, const struct rte_memseg *ms,\n }\n \n static int\n-vhost_vdpa_dma_map_all(struct virtio_user_dev *dev)\n+vhost_vdpa_set_memory_table(struct virtio_user_dev *dev)\n {\n \tint ret;\n \n@@ -376,9 +374,6 @@ vhost_vdpa_send_request(struct virtio_user_dev *dev,\n \n \treq_vdpa = vhost_req_user_to_vdpa[req];\n \n-\tif (req_vdpa == VHOST_SET_MEM_TABLE)\n-\t\treturn vhost_vdpa_dma_map_all(dev);\n-\n \tswitch (req_vdpa) {\n \tcase VHOST_SET_VRING_NUM:\n \tcase VHOST_SET_VRING_ADDR:\n@@ -461,6 +456,7 @@ struct virtio_user_backend_ops virtio_ops_vdpa = {\n \t.set_features = vhost_vdpa_set_features,\n \t.get_protocol_features = vhost_vdpa_get_backend_features,\n \t.set_protocol_features = vhost_vdpa_set_backend_features,\n+\t.set_memory_table = vhost_vdpa_set_memory_table,\n \t.send_request = vhost_vdpa_send_request,\n \t.enable_qp = vhost_vdpa_enable_queue_pair,\n \t.dma_map = vhost_vdpa_dma_map_batch,\ndiff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 45417bbc5d..cb8f8a872c 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -177,7 +177,7 @@ virtio_user_start_device(struct virtio_user_dev *dev)\n \t\tgoto error;\n \n \t/* Step 2: share memory regions */\n-\tret = dev->ops->send_request(dev, VHOST_USER_SET_MEM_TABLE, NULL);\n+\tret = dev->ops->set_memory_table(dev);\n \tif (ret < 0)\n \t\tgoto error;\n \n@@ -352,7 +352,7 @@ virtio_user_mem_event_cb(enum rte_mem_event type __rte_unused,\n \t\tdev->ops->enable_qp(dev, i, 0);\n \n \t/* Step 2: update memory regions */\n-\tdev->ops->send_request(dev, VHOST_USER_SET_MEM_TABLE, NULL);\n+\tdev->ops->set_memory_table(dev);\n \n \t/* Step 3: resume the active queues */\n \tfor (i = 0; i < dev->queue_pairs; i++)\n", "prefixes": [ "v4", "29/44" ] }