Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87301/?format=api
{ "id": 87301, "url": "https://patches.dpdk.org/api/patches/87301/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210126101639.250481-14-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210126101639.250481-14-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210126101639.250481-14-maxime.coquelin@redhat.com", "date": "2021-01-26T10:16:08", "name": "[v4,13/44] net/virtio: validate features at bus level", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "18bb53485bba1d0f5e5b21f59c2ca948e6a736de", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210126101639.250481-14-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 14950, "url": "https://patches.dpdk.org/api/series/14950/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14950", "date": "2021-01-26T10:15:55", "name": "net/virtio: Virtio PMD rework", "version": 4, "mbox": "https://patches.dpdk.org/series/14950/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87301/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87301/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B6D6BA052A;\n\tTue, 26 Jan 2021 11:19:02 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E9F08141362;\n\tTue, 26 Jan 2021 11:17:32 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [63.128.21.124])\n by mails.dpdk.org (Postfix) with ESMTP id 91E3614135B\n for <dev@dpdk.org>; Tue, 26 Jan 2021 11:17:28 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-330-Wa2opeJcNEij4FYZjv8qbw-1; Tue, 26 Jan 2021 05:17:24 -0500", "from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com\n [10.5.11.11])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1A6EE8145ED;\n Tue, 26 Jan 2021 10:17:23 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.36.110.31])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 9FF2272163;\n Tue, 26 Jan 2021 10:17:21 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1611656247;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=AshjaMTrL4Uon4rzOS1iIeZtNck0JoPLf7rqbkQhS88=;\n b=OoDIgcWZRfs9Frl31yDyEoQi52cU3QBNP8aQRChncBcJtoyd7e2l+3gIbfgD8hC6IyYEu7\n NH5Py9SMMpYWGuCR7sjHwizqwG5m3N2gJmMZikXYu3+kgR9bnOOYWSHN24Ch3JMVgtHzxM\n OAm4EvOIvWh7XwN9RfgwzMXax5RJjGY=", "X-MC-Unique": "Wa2opeJcNEij4FYZjv8qbw-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, olivier.matz@6wind.com,\n amorenoz@redhat.com, david.marchand@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Tue, 26 Jan 2021 11:16:08 +0100", "Message-Id": "<20210126101639.250481-14-maxime.coquelin@redhat.com>", "In-Reply-To": "<20210126101639.250481-1-maxime.coquelin@redhat.com>", "References": "<20210126101639.250481-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH v4 13/44] net/virtio: validate features at bus\n level", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch provides a new callback for the bus type\nto validate negotiated features are compatible with it.\n\nOnly user for now is PCI modern bus type, which implies\nthat the device supports Virtio 1.0+.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 11 ++++-------\n drivers/net/virtio/virtio_pci.c | 19 +++++++++++++++++++\n drivers/net/virtio/virtio_pci.h | 1 +\n drivers/net/virtio/virtio_user_ethdev.c | 7 +++++++\n 4 files changed, 31 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 84edcd4724..72f527144e 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1330,17 +1330,14 @@ virtio_negotiate_features(struct virtio_hw *hw, uint64_t req_features)\n \tPMD_INIT_LOG(DEBUG, \"features after negotiate = %\" PRIx64,\n \t\thw->guest_features);\n \n-\tif (hw->bus_type == VIRTIO_BUS_PCI_MODERN && !vtpci_with_feature(hw, VIRTIO_F_VERSION_1)) {\n-\t\tPMD_INIT_LOG(ERR,\n-\t\t\t\"VIRTIO_F_VERSION_1 features is not enabled.\");\n+\tif (VTPCI_OPS(hw)->features_ok(hw) < 0)\n \t\treturn -1;\n-\t}\n \n-\tif (hw->bus_type == VIRTIO_BUS_PCI_MODERN || hw->bus_type == VIRTIO_BUS_USER) {\n+\tif (vtpci_with_feature(hw, VIRTIO_F_VERSION_1)) {\n \t\tvtpci_set_status(hw, VIRTIO_CONFIG_STATUS_FEATURES_OK);\n+\n \t\tif (!(vtpci_get_status(hw) & VIRTIO_CONFIG_STATUS_FEATURES_OK)) {\n-\t\t\tPMD_INIT_LOG(ERR,\n-\t\t\t\t\"failed to set FEATURES_OK status!\");\n+\t\t\tPMD_INIT_LOG(ERR, \"Failed to set FEATURES_OK status!\");\n \t\t\treturn -1;\n \t\t}\n \t}\ndiff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c\nindex ea4ab381a6..1c8d4b7ddd 100644\n--- a/drivers/net/virtio/virtio_pci.c\n+++ b/drivers/net/virtio/virtio_pci.c\n@@ -201,6 +201,12 @@ legacy_set_features(struct virtio_hw *hw, uint64_t features)\n \t\tVIRTIO_PCI_GUEST_FEATURES);\n }\n \n+static int\n+legacy_features_ok(struct virtio_hw *hw __rte_unused)\n+{\n+\treturn 0;\n+}\n+\n static uint8_t\n legacy_get_status(struct virtio_hw *hw)\n {\n@@ -315,6 +321,7 @@ const struct virtio_pci_ops legacy_ops = {\n \t.set_status\t= legacy_set_status,\n \t.get_features\t= legacy_get_features,\n \t.set_features\t= legacy_set_features,\n+\t.features_ok\t= legacy_features_ok,\n \t.get_isr\t= legacy_get_isr,\n \t.set_config_irq\t= legacy_set_config_irq,\n \t.set_queue_irq = legacy_set_queue_irq,\n@@ -389,6 +396,17 @@ modern_set_features(struct virtio_hw *hw, uint64_t features)\n \t\t &hw->common_cfg->guest_feature);\n }\n \n+static int\n+modern_features_ok(struct virtio_hw *hw)\n+{\n+\tif (!vtpci_with_feature(hw, VIRTIO_F_VERSION_1)) {\n+\t\tPMD_INIT_LOG(ERR, \"Version 1+ required with modern devices\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static uint8_t\n modern_get_status(struct virtio_hw *hw)\n {\n@@ -540,6 +558,7 @@ const struct virtio_pci_ops modern_ops = {\n \t.set_status\t= modern_set_status,\n \t.get_features\t= modern_get_features,\n \t.set_features\t= modern_set_features,\n+\t.features_ok\t= modern_features_ok,\n \t.get_isr\t= modern_get_isr,\n \t.set_config_irq\t= modern_set_config_irq,\n \t.set_queue_irq = modern_set_queue_irq,\ndiff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h\nindex 0515bbb247..6aacc942fc 100644\n--- a/drivers/net/virtio/virtio_pci.h\n+++ b/drivers/net/virtio/virtio_pci.h\n@@ -227,6 +227,7 @@ struct virtio_pci_ops {\n \n \tuint64_t (*get_features)(struct virtio_hw *hw);\n \tvoid (*set_features)(struct virtio_hw *hw, uint64_t features);\n+\tint (*features_ok)(struct virtio_hw *hw);\n \n \tuint8_t (*get_isr)(struct virtio_hw *hw);\n \ndiff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c\nindex 3cbf310c03..bf958de571 100644\n--- a/drivers/net/virtio/virtio_user_ethdev.c\n+++ b/drivers/net/virtio/virtio_user_ethdev.c\n@@ -327,6 +327,12 @@ virtio_user_set_features(struct virtio_hw *hw, uint64_t features)\n \tdev->features = features & dev->device_features;\n }\n \n+static int\n+virtio_user_features_ok(struct virtio_hw *hw __rte_unused)\n+{\n+\treturn 0;\n+}\n+\n static uint8_t\n virtio_user_get_isr(struct virtio_hw *hw __rte_unused)\n {\n@@ -479,6 +485,7 @@ const struct virtio_pci_ops virtio_user_ops = {\n \t.set_status\t= virtio_user_set_status,\n \t.get_features\t= virtio_user_get_features,\n \t.set_features\t= virtio_user_set_features,\n+\t.features_ok\t= virtio_user_features_ok,\n \t.get_isr\t= virtio_user_get_isr,\n \t.set_config_irq\t= virtio_user_set_config_irq,\n \t.set_queue_irq\t= virtio_user_set_queue_irq,\n", "prefixes": [ "v4", "13/44" ] }