Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87272/?format=api
{ "id": 87272, "url": "https://patches.dpdk.org/api/patches/87272/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1611632982-415500-1-git-send-email-jiaweiw@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1611632982-415500-1-git-send-email-jiaweiw@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1611632982-415500-1-git-send-email-jiaweiw@nvidia.com", "date": "2021-01-26T03:49:42", "name": "app/testpmd: fix the sample RSS issue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b0be04983877636777b7b6d32c65cc8b62d0d1f8", "submitter": { "id": 1939, "url": "https://patches.dpdk.org/api/people/1939/?format=api", "name": "Jiawei Wang", "email": "jiaweiw@nvidia.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1611632982-415500-1-git-send-email-jiaweiw@nvidia.com/mbox/", "series": [ { "id": 14941, "url": "https://patches.dpdk.org/api/series/14941/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14941", "date": "2021-01-26T03:49:42", "name": "app/testpmd: fix the sample RSS issue", "version": 1, "mbox": "https://patches.dpdk.org/series/14941/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87272/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/87272/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C4E69A052A;\n\tTue, 26 Jan 2021 04:49:47 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AD0731411FD;\n\tTue, 26 Jan 2021 04:49:47 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id 956181411FC\n for <dev@dpdk.org>; Tue, 26 Jan 2021 04:49:46 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n jiaweiw@nvidia.com) with SMTP; 26 Jan 2021 05:49:42 +0200", "from nvidia.com (gen-l-vrt-281.mtl.labs.mlnx [10.237.44.1])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 10Q3ngEi012814;\n Tue, 26 Jan 2021 05:49:42 +0200" ], "From": "Jiawei Wang <jiaweiw@nvidia.com>", "To": "viacheslavo@nvidia.com, orika@nvidia.com, thomas@monjalon.net,\n ferruh.yigit@intel.com", "Cc": "dev@dpdk.org", "Date": "Tue, 26 Jan 2021 05:49:42 +0200", "Message-Id": "<1611632982-415500-1-git-send-email-jiaweiw@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH] app/testpmd: fix the sample RSS issue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When the RSS with null key was set in sample actions list, it\ncaused the segmentation fault since the RSS key pointer was\nNULL while did the memory copy.\n\nThis patch adds the RSS key NULL pointer checking before copying\nto fix the segmentation fault issue.\n\nFixes: 11b1b0eddade (\"app/testpmd: support RSS in sample action\")\n\nSigned-off-by: Jiawei Wang <jiaweiw@nvidia.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n---\n app/test-pmd/cmdline_flow.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex 0618611..64c0e0f 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -7885,7 +7885,7 @@ static int comp_set_modify_field_id(struct context *, const struct token *,\n \t\t\trss = action->conf;\n \t\t\trte_memcpy(&sample_rss_data[idx].conf,\n \t\t\t\t (const void *)rss, size);\n-\t\t\tif (rss->key_len) {\n+\t\t\tif (rss->key_len && rss->key) {\n \t\t\t\tsample_rss_data[idx].conf.key =\n \t\t\t\t\t\tsample_rss_data[idx].key;\n \t\t\t\trte_memcpy((void *)((uintptr_t)\n@@ -7893,7 +7893,7 @@ static int comp_set_modify_field_id(struct context *, const struct token *,\n \t\t\t\t\t (const void *)rss->key,\n \t\t\t\t\t sizeof(uint8_t) * rss->key_len);\n \t\t\t}\n-\t\t\tif (rss->queue_num) {\n+\t\t\tif (rss->queue_num && rss->queue) {\n \t\t\t\tsample_rss_data[idx].conf.queue =\n \t\t\t\t\t\tsample_rss_data[idx].queue;\n \t\t\t\trte_memcpy((void *)((uintptr_t)\n", "prefixes": [] }