Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87270/?format=api
{ "id": 87270, "url": "https://patches.dpdk.org/api/patches/87270/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210126030308.517216-1-dapengx.yu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210126030308.517216-1-dapengx.yu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210126030308.517216-1-dapengx.yu@intel.com", "date": "2021-01-26T03:03:08", "name": "[v3] net/ixgbe: disable NFS filtering", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f0e920fb937195c7489733da5cd7f62c0a31321b", "submitter": { "id": 2042, "url": "https://patches.dpdk.org/api/people/2042/?format=api", "name": "Yu, DapengX", "email": "dapengx.yu@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210126030308.517216-1-dapengx.yu@intel.com/mbox/", "series": [ { "id": 14939, "url": "https://patches.dpdk.org/api/series/14939/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14939", "date": "2021-01-26T03:03:08", "name": "[v3] net/ixgbe: disable NFS filtering", "version": 3, "mbox": "https://patches.dpdk.org/series/14939/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87270/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/87270/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C004BA052A;\n\tTue, 26 Jan 2021 04:03:22 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 485181411B6;\n\tTue, 26 Jan 2021 04:03:22 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 62E9C1411B5;\n Tue, 26 Jan 2021 04:03:20 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Jan 2021 19:03:18 -0800", "from unknown (HELO localhost.localdomain) ([10.240.183.93])\n by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Jan 2021 19:03:16 -0800" ], "IronPort-SDR": [ "\n V6mnj4vogo/HMYWudEx87yWsx3apz5vRu0lK6QYee9/GhYD2D07qr7qzn6H93X5E+dAePdK1qB\n Wd9PWRTm6jiA==", "\n GnUoWJqyi95fSvONl2urF3wLg3LU3qeMBrS2yAXpzsm5fwvUSHy62Ivjex+2kG9yKKIHmkXpdK\n girnjZg0nCeA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9875\"; a=\"241370467\"", "E=Sophos;i=\"5.79,375,1602572400\"; d=\"scan'208\";a=\"241370467\"", "E=Sophos;i=\"5.79,375,1602572400\"; d=\"scan'208\";a=\"429539057\"" ], "From": "dapengx.yu@intel.com", "To": "jia.guo@intel.com,\n\thaiyue.wang@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org,\n\tDapeng Yu <dapengx.yu@intel.com>,\n\tstable@dpdk.org", "Date": "Tue, 26 Jan 2021 11:03:08 +0800", "Message-Id": "<20210126030308.517216-1-dapengx.yu@intel.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210125031041.429268-1-dapengx.yu@intel.com>", "References": "<20210125031041.429268-1-dapengx.yu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3] net/ixgbe: disable NFS filtering", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Dapeng Yu <dapengx.yu@intel.com>\n\nDisable NFS header filtering whether NFS packets coalescing are\nrequired or not, in order to make RSS can work on NFS packets.\n\nThe code without the patch does follow datasheet, but not consistent\nwith the ixgbe kernel driver. It causes NFS packets to be filtered\nand make them flow into queue 0, before RSS can work on them.\n\nFixes: b826efba6de4 (\"net/ixgbe: align register setting when RSC is disabled\")\nFixes: 8eecb3295aed (\"ixgbe: add LRO support\")\nCc: stable@dpdk.org\n\nSigned-off-by: Dapeng Yu <dapengx.yu@intel.com>\n---\n drivers/net/ixgbe/ixgbe_rxtx.c | 10 +++-------\n 1 file changed, 3 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex cc8f70e6d..2efd054f7 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -4923,15 +4923,11 @@ ixgbe_set_rsc(struct rte_eth_dev *dev)\n \t/* RFCTL configuration */\n \trfctl = IXGBE_READ_REG(hw, IXGBE_RFCTL);\n \tif ((rsc_capable) && (rx_conf->offloads & DEV_RX_OFFLOAD_TCP_LRO))\n-\t\t/*\n-\t\t * Since NFS packets coalescing is not supported - clear\n-\t\t * RFCTL.NFSW_DIS and RFCTL.NFSR_DIS when RSC is\n-\t\t * enabled.\n-\t\t */\n-\t\trfctl &= ~(IXGBE_RFCTL_RSC_DIS | IXGBE_RFCTL_NFSW_DIS |\n-\t\t\t IXGBE_RFCTL_NFSR_DIS);\n+\t\trfctl &= ~IXGBE_RFCTL_RSC_DIS;\n \telse\n \t\trfctl |= IXGBE_RFCTL_RSC_DIS;\n+\t/* disable NFS filtering */\n+\trfctl |= IXGBE_RFCTL_NFSW_DIS | IXGBE_RFCTL_NFSR_DIS;\n \tIXGBE_WRITE_REG(hw, IXGBE_RFCTL, rfctl);\n \n \t/* If LRO hasn't been requested - we are done here. */\n", "prefixes": [ "v3" ] }