Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87174/?format=api
{ "id": 87174, "url": "https://patches.dpdk.org/api/patches/87174/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210125083202.38267-2-stevex.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210125083202.38267-2-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210125083202.38267-2-stevex.yang@intel.com", "date": "2021-01-25T08:32:01", "name": "[v4,1/2] ethdev: fix MTU doesn't update when jumbo frame disabled", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1fe83b386d3b2a7ec98da292257e2527a7a2aa8c", "submitter": { "id": 1883, "url": "https://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210125083202.38267-2-stevex.yang@intel.com/mbox/", "series": [ { "id": 14925, "url": "https://patches.dpdk.org/api/series/14925/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14925", "date": "2021-01-25T08:32:00", "name": "fix 'max-pkt-len' errors", "version": 4, "mbox": "https://patches.dpdk.org/series/14925/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87174/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87174/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 51755A052A;\n\tMon, 25 Jan 2021 09:35:34 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8BC03140DA7;\n\tMon, 25 Jan 2021 09:35:31 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 84BF2140DA0\n for <dev@dpdk.org>; Mon, 25 Jan 2021 09:35:29 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Jan 2021 00:35:29 -0800", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])\n by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Jan 2021 00:35:26 -0800" ], "IronPort-SDR": [ "\n 1l8CrcMhgZ9/4gCneyrqr9Yw6FcGjW0x8tLq6/LlWCrw6BfnUbkpDTpH3PiLvHl9SdxfwB58vq\n 9TC2AZ/JfgPw==", "\n G9TzqZVA72kWqq1ZfhfWBPceuXnj4aRPWPRqiHrqeVrtSfZ4hKyA4fWnQNP5AbmiIMSBe1cBR8\n ls/Sa6OnYl+Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9874\"; a=\"241220750\"", "E=Sophos;i=\"5.79,373,1602572400\"; d=\"scan'208\";a=\"241220750\"", "E=Sophos;i=\"5.79,373,1602572400\"; d=\"scan'208\";a=\"361281587\"" ], "From": "Steve Yang <stevex.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "wenzhuo.lu@intel.com, xiaoyun.li@intel.com, bernard.iremonger@intel.com,\n thomas@monjalon.net, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru,\n qiming.yang@intel.com, Steve Yang <stevex.yang@intel.com>", "Date": "Mon, 25 Jan 2021 08:32:01 +0000", "Message-Id": "<20210125083202.38267-2-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210125083202.38267-1-stevex.yang@intel.com>", "References": "<20210122090110.50453-1-stevex.yang@intel.com>\n <20210125083202.38267-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 1/2] ethdev: fix MTU doesn't update when jumbo\n frame disabled", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The MTU value should be updated to 'max_rx_pkt_len - overhead'\nno matter if the JUMBO FRAME offload enabled. If not update this MTU,\nuse will get the wrong MTU info via some command.\nE.g.: 'show port info all' in testpmd tool.\n\nActually, the 'max_rx_pkt_len' has been used for other purposes in many\nplaces now, even though the 'max_rx_pkt_len' is expected 'Only used if\nJUMBO_FRAME enabled'.\n\nFor examples,\n'max_rx_pkt_len' perhaps can be used as the 'rx_ctx.rxmax' in i40e.\n\nFixes: bf0f90d92d30 (\"ethdev: fix max Rx packet length check\")\n\nSigned-off-by: Steve Yang <stevex.yang@intel.com>\n---\n lib/librte_ethdev/rte_ethdev.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex daf5f24f7e..42857e3b67 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -1421,10 +1421,6 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \t\t\tret = -EINVAL;\n \t\t\tgoto rollback;\n \t\t}\n-\n-\t\t/* Scale the MTU size to adapt max_rx_pkt_len */\n-\t\tdev->data->mtu = dev->data->dev_conf.rxmode.max_rx_pkt_len -\n-\t\t\t\toverhead_len;\n \t} else {\n \t\tuint16_t pktlen = dev_conf->rxmode.max_rx_pkt_len;\n \t\tif (pktlen < RTE_ETHER_MIN_MTU + overhead_len ||\n@@ -1434,6 +1430,10 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \t\t\t\t\t\tRTE_ETHER_MTU + overhead_len;\n \t}\n \n+\t/* Scale the MTU size to adapt max_rx_pkt_len */\n+\tdev->data->mtu = dev->data->dev_conf.rxmode.max_rx_pkt_len -\n+\t\t\t\toverhead_len;\n+\n \t/*\n \t * If LRO is enabled, check that the maximum aggregated packet\n \t * size is supported by the configured device.\n", "prefixes": [ "v4", "1/2" ] }