Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87172/?format=api
{ "id": 87172, "url": "https://patches.dpdk.org/api/patches/87172/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1611562534-6699-2-git-send-email-g.singh@nxp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1611562534-6699-2-git-send-email-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1611562534-6699-2-git-send-email-g.singh@nxp.com", "date": "2021-01-25T08:15:34", "name": "[2/2] crypto/dpaa2_sec: fix if check on memory allocation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "16ddfb68e00fc96b5a9d224d21737ece8be5844b", "submitter": { "id": 1068, "url": "https://patches.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1611562534-6699-2-git-send-email-g.singh@nxp.com/mbox/", "series": [ { "id": 14924, "url": "https://patches.dpdk.org/api/series/14924/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14924", "date": "2021-01-25T08:15:33", "name": "[1/2] test/ipsec: fix return values", "version": 1, "mbox": "https://patches.dpdk.org/series/14924/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87172/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/87172/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CC4B8A052A;\n\tMon, 25 Jan 2021 09:15:56 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 736CE140D52;\n\tMon, 25 Jan 2021 09:15:50 +0100 (CET)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by mails.dpdk.org (Postfix) with ESMTP id 4DAD9140D41\n for <dev@dpdk.org>; Mon, 25 Jan 2021 09:15:48 +0100 (CET)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 2FD39201C74;\n Mon, 25 Jan 2021 09:15:48 +0100 (CET)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 380FA201C5B;\n Mon, 25 Jan 2021 09:15:46 +0100 (CET)", "from lsv11086.swis.cn-sha01.nxp.com (lsv11086.swis.cn-sha01.nxp.com\n [92.121.210.87])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 87789402B3;\n Mon, 25 Jan 2021 09:15:42 +0100 (CET)" ], "From": "Gagandeep Singh <g.singh@nxp.com>", "To": "dev@dpdk.org,\n\takhil.goyal@nxp.com", "Cc": "thomas@monjalon.net,\n\tGagandeep Singh <g.singh@nxp.com>", "Date": "Mon, 25 Jan 2021 16:15:34 +0800", "Message-Id": "<1611562534-6699-2-git-send-email-g.singh@nxp.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1611562534-6699-1-git-send-email-g.singh@nxp.com>", "References": "<1611562534-6699-1-git-send-email-g.singh@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 2/2] crypto/dpaa2_sec: fix if check on memory\n allocation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When key length is 0, zmalloc will return NULL pointor\nand in that case it should not return NOMEM.\nSo in this patch, adding a check on key length.\n\nFixes: 8d1f3a5d751b (\"crypto/dpaa2_sec: support crypto operation\")\nCc: akhil.goyal@nxp.com\n---\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\nindex cab79db..05b194c 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n@@ -1842,7 +1842,7 @@ dpaa2_sec_cipher_init(struct rte_cryptodev *dev,\n \tsession->ctxt_type = DPAA2_SEC_CIPHER;\n \tsession->cipher_key.data = rte_zmalloc(NULL, xform->cipher.key.length,\n \t\t\tRTE_CACHE_LINE_SIZE);\n-\tif (session->cipher_key.data == NULL) {\n+\tif (session->cipher_key.data == NULL && xform->cipher.key.length > 0) {\n \t\tDPAA2_SEC_ERR(\"No Memory for cipher key\");\n \t\trte_free(priv);\n \t\treturn -ENOMEM;\n", "prefixes": [ "2/2" ] }