Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87171/?format=api
{ "id": 87171, "url": "https://patches.dpdk.org/api/patches/87171/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1611562534-6699-1-git-send-email-g.singh@nxp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1611562534-6699-1-git-send-email-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1611562534-6699-1-git-send-email-g.singh@nxp.com", "date": "2021-01-25T08:15:33", "name": "[1/2] test/ipsec: fix return values", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "92390213c22a5c46fe718631f28768aaef7c958e", "submitter": { "id": 1068, "url": "https://patches.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1611562534-6699-1-git-send-email-g.singh@nxp.com/mbox/", "series": [ { "id": 14924, "url": "https://patches.dpdk.org/api/series/14924/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14924", "date": "2021-01-25T08:15:33", "name": "[1/2] test/ipsec: fix return values", "version": 1, "mbox": "https://patches.dpdk.org/series/14924/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87171/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87171/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DFFFDA052A;\n\tMon, 25 Jan 2021 09:15:49 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5814C140D41;\n\tMon, 25 Jan 2021 09:15:49 +0100 (CET)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by mails.dpdk.org (Postfix) with ESMTP id 1DF7B140D22\n for <dev@dpdk.org>; Mon, 25 Jan 2021 09:15:48 +0100 (CET)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id D2BD9201C44;\n Mon, 25 Jan 2021 09:15:47 +0100 (CET)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 59C4D20072E;\n Mon, 25 Jan 2021 09:15:45 +0100 (CET)", "from lsv11086.swis.cn-sha01.nxp.com (lsv11086.swis.cn-sha01.nxp.com\n [92.121.210.87])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 52C4E40297;\n Mon, 25 Jan 2021 09:15:41 +0100 (CET)" ], "From": "Gagandeep Singh <g.singh@nxp.com>", "To": "dev@dpdk.org,\n\takhil.goyal@nxp.com", "Cc": "thomas@monjalon.net, Gagandeep Singh <g.singh@nxp.com>,\n konstantin.ananyev@intel.com", "Date": "Mon, 25 Jan 2021 16:15:33 +0800", "Message-Id": "<1611562534-6699-1-git-send-email-g.singh@nxp.com>", "X-Mailer": "git-send-email 2.7.4", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 1/2] test/ipsec: fix return values", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "During SA creation, if the required algorithm is not supported,\ndrivers can return ENOTSUP. But in most of the IPsec test cases,\nif the SA creation does not success, it just returns\nTEST_FAILED.\n\nThis patch fixes this issue by returning the actual return values\nfrom the driver to the application, so that it can make decisions\nwhether the test case is passed, failed or unsupported.\n\nFixes: 05fe65eb66b2 (\"test/ipsec: introduce functional test\")\nCc: konstantin.ananyev@intel.com\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n app/test/test_ipsec.c | 32 ++++++++++++++++----------------\n 1 file changed, 16 insertions(+), 16 deletions(-)", "diff": "diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c\nindex 9ad07a1..d18220a 100644\n--- a/app/test/test_ipsec.c\n+++ b/app/test/test_ipsec.c\n@@ -744,7 +744,7 @@ create_sa(enum rte_security_session_action_type action_type,\n \tut->ss[j].type = action_type;\n \trc = create_session(ut, &ts->qp_conf, ts->valid_dev, j);\n \tif (rc != 0)\n-\t\treturn TEST_FAILED;\n+\t\treturn rc;\n \n \trc = rte_ipsec_sa_init(ut->ss[j].sa, &ut->sa_prm, sz);\n \trc = (rc > 0 && (uint32_t)rc <= sz) ? 0 : -EINVAL;\n@@ -1247,7 +1247,7 @@ test_ipsec_crypto_inb_burst_null_null(int i)\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n \t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n-\t\treturn TEST_FAILED;\n+\t\treturn rc;\n \t}\n \n \t/* Generate test mbuf data */\n@@ -1349,7 +1349,7 @@ test_ipsec_crypto_outb_burst_null_null(int i)\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n \t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n-\t\treturn TEST_FAILED;\n+\t\treturn rc;\n \t}\n \n \t/* Generate input mbuf data */\n@@ -1458,7 +1458,7 @@ test_ipsec_inline_crypto_inb_burst_null_null(int i)\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n \t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n-\t\treturn TEST_FAILED;\n+\t\treturn rc;\n \t}\n \n \t/* Generate inbound mbuf data */\n@@ -1536,7 +1536,7 @@ test_ipsec_inline_proto_inb_burst_null_null(int i)\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n \t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n-\t\treturn TEST_FAILED;\n+\t\treturn rc;\n \t}\n \n \t/* Generate inbound mbuf data */\n@@ -1644,7 +1644,7 @@ test_ipsec_inline_crypto_outb_burst_null_null(int i)\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n \t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n-\t\treturn TEST_FAILED;\n+\t\treturn rc;\n \t}\n \n \t/* Generate test mbuf data */\n@@ -1722,7 +1722,7 @@ test_ipsec_inline_proto_outb_burst_null_null(int i)\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n \t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n-\t\treturn TEST_FAILED;\n+\t\treturn rc;\n \t}\n \n \t/* Generate test mbuf data */\n@@ -1798,7 +1798,7 @@ test_ipsec_lksd_proto_inb_burst_null_null(int i)\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n \t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n-\t\treturn TEST_FAILED;\n+\t\treturn rc;\n \t}\n \n \t/* Generate test mbuf data */\n@@ -1911,7 +1911,7 @@ test_ipsec_replay_inb_inside_null_null(int i)\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n \t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n-\t\treturn TEST_FAILED;\n+\t\treturn rc;\n \t}\n \n \t/* Generate inbound mbuf data */\n@@ -2004,7 +2004,7 @@ test_ipsec_replay_inb_outside_null_null(int i)\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n \t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n-\t\treturn TEST_FAILED;\n+\t\treturn rc;\n \t}\n \n \t/* Generate test mbuf data */\n@@ -2104,7 +2104,7 @@ test_ipsec_replay_inb_repeat_null_null(int i)\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n \t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n-\t\treturn TEST_FAILED;\n+\t\treturn rc;\n \t}\n \n \t/* Generate test mbuf data */\n@@ -2205,7 +2205,7 @@ test_ipsec_replay_inb_inside_burst_null_null(int i)\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n \t\tRTE_LOG(ERR, USER1, \"create_sa failed, cfg %d\\n\", i);\n-\t\treturn TEST_FAILED;\n+\t\treturn rc;\n \t}\n \n \t/* Generate inbound mbuf data */\n@@ -2338,7 +2338,7 @@ test_ipsec_crypto_inb_burst_2sa_null_null(int i)\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n \t\tRTE_LOG(ERR, USER1, \"create_sa 0 failed, cfg %d\\n\", i);\n-\t\treturn TEST_FAILED;\n+\t\treturn rc;\n \t}\n \n \t/* create second rte_ipsec_sa */\n@@ -2348,7 +2348,7 @@ test_ipsec_crypto_inb_burst_2sa_null_null(int i)\n \tif (rc != 0) {\n \t\tRTE_LOG(ERR, USER1, \"create_sa 1 failed, cfg %d\\n\", i);\n \t\tdestroy_sa(0);\n-\t\treturn TEST_FAILED;\n+\t\treturn rc;\n \t}\n \n \t/* Generate test mbuf data */\n@@ -2424,7 +2424,7 @@ test_ipsec_crypto_inb_burst_2sa_4grp_null_null(int i)\n \t\t\ttest_cfg[i].replay_win_sz, test_cfg[i].flags, 0);\n \tif (rc != 0) {\n \t\tRTE_LOG(ERR, USER1, \"create_sa 0 failed, cfg %d\\n\", i);\n-\t\treturn TEST_FAILED;\n+\t\treturn rc;\n \t}\n \n \t/* create second rte_ipsec_sa */\n@@ -2434,7 +2434,7 @@ test_ipsec_crypto_inb_burst_2sa_4grp_null_null(int i)\n \tif (rc != 0) {\n \t\tRTE_LOG(ERR, USER1, \"create_sa 1 failed, cfg %d\\n\", i);\n \t\tdestroy_sa(0);\n-\t\treturn TEST_FAILED;\n+\t\treturn rc;\n \t}\n \n \t/* Generate test mbuf data */\n", "prefixes": [ "1/2" ] }