Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87145/?format=api
{ "id": 87145, "url": "https://patches.dpdk.org/api/patches/87145/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210122191925.24308-36-lironh@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210122191925.24308-36-lironh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210122191925.24308-36-lironh@marvell.com", "date": "2021-01-22T19:19:23", "name": "[v2,35/37] net/mvpp2: forward bad packets support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6780d315e10087b35874a2569c2fd08e1d589540", "submitter": { "id": 996, "url": "https://patches.dpdk.org/api/people/996/?format=api", "name": "Liron Himi", "email": "lironh@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210122191925.24308-36-lironh@marvell.com/mbox/", "series": [ { "id": 14911, "url": "https://patches.dpdk.org/api/series/14911/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14911", "date": "2021-01-22T19:18:48", "name": "net/mvpp2: misc updates", "version": 2, "mbox": "https://patches.dpdk.org/series/14911/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87145/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87145/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0F7FDA0A0A;\n\tFri, 22 Jan 2021 20:24:15 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 12EAD141189;\n\tFri, 22 Jan 2021 20:21:00 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id CE729141182\n for <dev@dpdk.org>; Fri, 22 Jan 2021 20:20:57 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 10MJB74J008693 for <dev@dpdk.org>; Fri, 22 Jan 2021 11:20:57 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com with ESMTP id 3668p32vbb-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 22 Jan 2021 11:20:56 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Fri, 22 Jan 2021 11:20:53 -0800", "from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Fri, 22 Jan 2021 11:20:52 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=TOoKbWqw+2/TvgTCCffxbqr1XUHe6FtMuUJYVlnUk70=;\n b=g3wmyF+1u673+R7K1hvNQXdHVd2cvuSYDbKmBsgmrMzDeiZpdYLO74xDRuRAwTle9E6J\n nWPUeDzP7kCIZv9zzc/GV+6bTPP67F9ck5Cl2J+rcBjV7lm7Fli1oEVOFT72l/SWmbfz\n v/dFistTb0VnGkjI+E47w+hipMayWLWUIeNQxYeDqsYJGFSImGGnUbQSGHQ03eOZeYZ1\n nQ4S2uVY9yMy1Ehlyf1Vg+o1Kw0aS/vnmvWj9SLwWDz24RBdySGl4h4xgMiKTPVnyc1Y\n s+66rmiSxYdOXOXbtwaN7UXo3ptWGXDAh7pULF8PIt8XCZ1TCMUsucSrRzONgx2id/EV ig==", "From": "<lironh@marvell.com>", "To": "<jerinj@marvell.com>", "CC": "<dev@dpdk.org>, Dana Vardi <danat@marvell.com>, Liron Himi\n <lironh@marvell.com>", "Date": "Fri, 22 Jan 2021 21:19:23 +0200", "Message-ID": "<20210122191925.24308-36-lironh@marvell.com>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20210122191925.24308-1-lironh@marvell.com>", "References": "<20201202101212.4717-1-lironh@marvell.com>\n <20210122191925.24308-1-lironh@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737\n definitions=2021-01-22_14:2021-01-22,\n 2021-01-22 signatures=0", "Subject": "[dpdk-dev] [PATCH v2 35/37] net/mvpp2: forward bad packets support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Dana Vardi <danat@marvell.com>\n\nExtend the config file with option to forward packets\nthat were marked as \"l2 bad pkts\".\nby default the driver drop those packets\n\nSigned-off-by: Dana Vardi <danat@marvell.com>\nReviewed-by: Liron Himi <lironh@marvell.com>\n---\n drivers/net/mvpp2/mrvl_ethdev.c | 10 ++++++++--\n drivers/net/mvpp2/mrvl_ethdev.h | 2 ++\n drivers/net/mvpp2/mrvl_qos.c | 17 +++++++++++++++++\n drivers/net/mvpp2/mrvl_qos.h | 1 +\n 4 files changed, 28 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex 40b69ed55..df7bf9056 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -820,9 +820,14 @@ mrvl_dev_start(struct rte_eth_dev *dev)\n \t\t priv->pp_id, priv->ppio_id);\n \tpriv->ppio_params.match = match;\n \tpriv->ppio_params.eth_start_hdr = PP2_PPIO_HDR_ETH;\n-\tif (mrvl_cfg)\n+\tpriv->forward_bad_frames = 0;\n+\n+\tif (mrvl_cfg) {\n \t\tpriv->ppio_params.eth_start_hdr =\n \t\t\tmrvl_cfg->port[dev->data->port_id].eth_start_hdr;\n+\t\tpriv->forward_bad_frames =\n+\t\t\tmrvl_cfg->port[dev->data->port_id].forward_bad_frames;\n+\t}\n \n \t/*\n \t * Calculate the minimum bpool size for refill feature as follows:\n@@ -2718,7 +2723,8 @@ mrvl_rx_pkt_burst(void *rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \n \t\t/* drop packet in case of mac, overrun or resource error */\n \t\tstatus = pp2_ppio_inq_desc_get_l2_pkt_error(&descs[i]);\n-\t\tif (unlikely(status != PP2_DESC_ERR_OK)) {\n+\t\tif ((unlikely(status != PP2_DESC_ERR_OK)) &&\n+\t\t\t!(q->priv->forward_bad_frames)) {\n \t\t\tstruct pp2_buff_inf binf = {\n \t\t\t\t.addr = rte_mbuf_data_iova_default(mbuf),\n \t\t\t\t.cookie = (uint64_t)mbuf,\ndiff --git a/drivers/net/mvpp2/mrvl_ethdev.h b/drivers/net/mvpp2/mrvl_ethdev.h\nindex 0ee7208fb..8d5469c9d 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.h\n+++ b/drivers/net/mvpp2/mrvl_ethdev.h\n@@ -181,6 +181,8 @@ struct mrvl_priv {\n \tLIST_HEAD(shaper_profiles, mrvl_tm_shaper_profile) shaper_profiles;\n \tLIST_HEAD(nodes, mrvl_tm_node) nodes;\n \tuint64_t rate_max;\n+\n+\tuint8_t forward_bad_frames;\n };\n \n /** Flow operations forward declaration. */\ndiff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c\nindex 9fec3c156..38556b228 100644\n--- a/drivers/net/mvpp2/mrvl_qos.c\n+++ b/drivers/net/mvpp2/mrvl_qos.c\n@@ -76,6 +76,8 @@\n #define MRVL_TOK_PARSER_UDF_PROTO_UDP \"udp\"\n #define MRVL_TOK_PARSER_UDF_FIELD_UDP_DPORT \"dport\"\n \n+/* parser forward bad frames tokens */\n+#define MRVL_TOK_FWD_BAD_FRAMES \"forward_bad_frames\"\n \n /** Number of tokens in range a-b = 2. */\n #define MAX_RNG_TOKENS 2\n@@ -872,6 +874,21 @@ mrvl_get_cfg(const char *key __rte_unused, const char *path, void *extra_args)\n \t\t\t\treturn -1;\n \t\t\t}\n \t\t}\n+\n+\t\t/* Parse forward bad frames option */\n+\t\tentry = rte_cfgfile_get_entry(file, sec_name,\n+\t\t\t\tMRVL_TOK_FWD_BAD_FRAMES);\n+\t\tif (entry) {\n+\t\t\tif (get_val_securely(entry, &val) < 0) {\n+\t\t\t\tMRVL_LOG(ERR,\n+\t\t\t\t\t\"Error in parsing %s value (%s)!\\n\",\n+\t\t\t\t\tMRVL_TOK_FWD_BAD_FRAMES, entry);\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\t\t\t(*cfg)->port[n].forward_bad_frames = (uint8_t)val;\n+\t\t} else {\n+\t\t\t(*cfg)->port[n].forward_bad_frames = 0;\n+\t\t}\n \t}\n \n \treturn 0;\ndiff --git a/drivers/net/mvpp2/mrvl_qos.h b/drivers/net/mvpp2/mrvl_qos.h\nindex daf4776ec..f2e341c37 100644\n--- a/drivers/net/mvpp2/mrvl_qos.h\n+++ b/drivers/net/mvpp2/mrvl_qos.h\n@@ -48,6 +48,7 @@ struct mrvl_cfg {\n \t\tuint8_t use_global_defaults;\n \t\tstruct pp2_cls_plcr_params policer_params;\n \t\tuint8_t setup_policer;\n+\t\tuint8_t forward_bad_frames;\n \t} port[RTE_MAX_ETHPORTS];\n };\n \n", "prefixes": [ "v2", "35/37" ] }