Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87121/?format=api
{ "id": 87121, "url": "https://patches.dpdk.org/api/patches/87121/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210122191925.24308-11-lironh@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210122191925.24308-11-lironh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210122191925.24308-11-lironh@marvell.com", "date": "2021-01-22T19:18:58", "name": "[v2,10/37] net/mvpp2: align checking order", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "196f70cc95bdf7866bed946382de66f5d65b1de2", "submitter": { "id": 996, "url": "https://patches.dpdk.org/api/people/996/?format=api", "name": "Liron Himi", "email": "lironh@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210122191925.24308-11-lironh@marvell.com/mbox/", "series": [ { "id": 14911, "url": "https://patches.dpdk.org/api/series/14911/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14911", "date": "2021-01-22T19:18:48", "name": "net/mvpp2: misc updates", "version": 2, "mbox": "https://patches.dpdk.org/series/14911/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87121/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87121/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3C787A0A0A;\n\tFri, 22 Jan 2021 20:21:13 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 607C91410D5;\n\tFri, 22 Jan 2021 20:20:12 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 7C74D1410D5\n for <dev@dpdk.org>; Fri, 22 Jan 2021 20:20:09 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 10MJBfCn008811 for <dev@dpdk.org>; Fri, 22 Jan 2021 11:20:08 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com with ESMTP id 3668p32v8x-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 22 Jan 2021 11:20:08 -0800", "from SC-EXCH01.marvell.com (10.93.176.81) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Fri, 22 Jan 2021 11:20:07 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Fri, 22 Jan 2021 11:20:06 -0800", "from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Fri, 22 Jan 2021 11:20:05 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=y6nRXiAHUmgkQyq3pYjV7GFz8Fn4xRlCYrFH4LtrcNI=;\n b=bFSXkWv9owdykXgU6/FLyat2Zk9lKKKW7VcI30ZmoNAKK7DjdDi3PSow1AvhDE5I54/6\n 1Sq8gEebMHP8EvQDjCsHOfj+W6CRoxH4ep+YkrOfHYVOJNEKeabD6uPoOQqyGSxYeRxc\n zwwiOe5BsHKEfwSbWMLxPD5K/TI5B3o3rXY1hLguVgrufYgTrZQbA1u0rUzqfGhwuuRK\n +t9mBlBLqIAKkFsSk+yC/pGAcfF4Oxx6fPCfHpHLc4cLMKRXs9O6vVGNI5tbn155dYyb\n vS/oNNo0P/1NOjOkE5ncnoS0I2JGc7v/dc0xlQ9k78jnky/5Sc+aJCjQ195A9f1R+OuX xQ==", "From": "<lironh@marvell.com>", "To": "<jerinj@marvell.com>", "CC": "<dev@dpdk.org>, Yuri Chipchev <yuric@marvell.com>, Liron Himi\n <lironh@marvell.com>", "Date": "Fri, 22 Jan 2021 21:18:58 +0200", "Message-ID": "<20210122191925.24308-11-lironh@marvell.com>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20210122191925.24308-1-lironh@marvell.com>", "References": "<20201202101212.4717-1-lironh@marvell.com>\n <20210122191925.24308-1-lironh@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737\n definitions=2021-01-22_14:2021-01-22,\n 2021-01-22 signatures=0", "Subject": "[dpdk-dev] [PATCH v2 10/37] net/mvpp2: align checking order", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yuri Chipchev <yuric@marvell.com>\n\nFirst check for 'isolated' and then for '!ppio'\n\nSigned-off-by: Yuri Chipchev <yuric@marvell.com>\nReviewed-by: Liron Himi <lironh@marvell.com>\n---\n drivers/net/mvpp2/mrvl_ethdev.c | 40 +++++++++++++++++++--------------\n 1 file changed, 23 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex 596aa7622..47b3aa28f 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -997,10 +997,10 @@ mrvl_promiscuous_enable(struct rte_eth_dev *dev)\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n \tint ret;\n \n-\tif (!priv->ppio)\n-\t\treturn 0;\n-\n \tif (priv->isolated)\n+\t\treturn -ENOTSUP;\n+\n+\tif (!priv->ppio)\n \t\treturn 0;\n \n \tret = pp2_ppio_set_promisc(priv->ppio, 1);\n@@ -1027,10 +1027,10 @@ mrvl_allmulticast_enable(struct rte_eth_dev *dev)\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n \tint ret;\n \n-\tif (!priv->ppio)\n-\t\treturn 0;\n-\n \tif (priv->isolated)\n+\t\treturn -ENOTSUP;\n+\n+\tif (!priv->ppio)\n \t\treturn 0;\n \n \tret = pp2_ppio_set_mc_promisc(priv->ppio, 1);\n@@ -1057,6 +1057,9 @@ mrvl_promiscuous_disable(struct rte_eth_dev *dev)\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n \tint ret;\n \n+\tif (priv->isolated)\n+\t\treturn -ENOTSUP;\n+\n \tif (!priv->ppio)\n \t\treturn 0;\n \n@@ -1084,6 +1087,9 @@ mrvl_allmulticast_disable(struct rte_eth_dev *dev)\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n \tint ret;\n \n+\tif (priv->isolated)\n+\t\treturn -ENOTSUP;\n+\n \tif (!priv->ppio)\n \t\treturn 0;\n \n@@ -1111,10 +1117,10 @@ mrvl_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index)\n \tchar buf[RTE_ETHER_ADDR_FMT_SIZE];\n \tint ret;\n \n-\tif (!priv->ppio)\n+\tif (priv->isolated)\n \t\treturn;\n \n-\tif (priv->isolated)\n+\tif (!priv->ppio)\n \t\treturn;\n \n \tret = pp2_ppio_remove_mac_addr(priv->ppio,\n@@ -1152,13 +1158,13 @@ mrvl_mac_addr_add(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr,\n \tif (priv->isolated)\n \t\treturn -ENOTSUP;\n \n+\tif (!priv->ppio)\n+\t\treturn 0;\n+\n \tif (index == 0)\n \t\t/* For setting index 0, mrvl_mac_addr_set() should be used.*/\n \t\treturn -1;\n \n-\tif (!priv->ppio)\n-\t\treturn 0;\n-\n \t/*\n \t * Maximum number of uc addresses can be tuned via kernel module mvpp2x\n \t * parameter uc_filter_max. Maximum number of mc addresses is then\n@@ -1199,12 +1205,12 @@ mrvl_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr)\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n \tint ret;\n \n-\tif (!priv->ppio)\n-\t\treturn 0;\n-\n \tif (priv->isolated)\n \t\treturn -ENOTSUP;\n \n+\tif (!priv->ppio)\n+\t\treturn 0;\n+\n \tret = pp2_ppio_set_mac_addr(priv->ppio, mac_addr->addr_bytes);\n \tif (ret) {\n \t\tchar buf[RTE_ETHER_ADDR_FMT_SIZE];\n@@ -1580,12 +1586,12 @@ mrvl_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)\n {\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n \n-\tif (!priv->ppio)\n-\t\treturn -EPERM;\n-\n \tif (priv->isolated)\n \t\treturn -ENOTSUP;\n \n+\tif (!priv->ppio)\n+\t\treturn 0;\n+\n \treturn on ? pp2_ppio_add_vlan(priv->ppio, vlan_id) :\n \t\t pp2_ppio_remove_vlan(priv->ppio, vlan_id);\n }\n", "prefixes": [ "v2", "10/37" ] }