Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 87119,
    "url": "https://patches.dpdk.org/api/patches/87119/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210122191925.24308-9-lironh@marvell.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210122191925.24308-9-lironh@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210122191925.24308-9-lironh@marvell.com",
    "date": "2021-01-22T19:18:56",
    "name": "[v2,08/37] net/mvpp2: extend xstats support",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "7c5a48d0eaf0f64b93b4948308553dc9a6ef4861",
    "submitter": {
        "id": 996,
        "url": "https://patches.dpdk.org/api/people/996/?format=api",
        "name": "Liron Himi",
        "email": "lironh@marvell.com"
    },
    "delegate": {
        "id": 310,
        "url": "https://patches.dpdk.org/api/users/310/?format=api",
        "username": "jerin",
        "first_name": "Jerin",
        "last_name": "Jacob",
        "email": "jerinj@marvell.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210122191925.24308-9-lironh@marvell.com/mbox/",
    "series": [
        {
            "id": 14911,
            "url": "https://patches.dpdk.org/api/series/14911/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14911",
            "date": "2021-01-22T19:18:48",
            "name": "net/mvpp2: misc updates",
            "version": 2,
            "mbox": "https://patches.dpdk.org/series/14911/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/87119/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/87119/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 89A04A0A0A;\n\tFri, 22 Jan 2021 20:20:57 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C15A51410D0;\n\tFri, 22 Jan 2021 20:20:08 +0100 (CET)",
            "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 35EDA1410C3\n for <dev@dpdk.org>; Fri, 22 Jan 2021 20:20:05 +0100 (CET)",
            "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 10MJB74B008693 for <dev@dpdk.org>; Fri, 22 Jan 2021 11:20:04 -0800",
            "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com with ESMTP id 3668p32v8t-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 22 Jan 2021 11:20:04 -0800",
            "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Fri, 22 Jan 2021 11:20:02 -0800",
            "from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Fri, 22 Jan 2021 11:20:01 -0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=xq27euLPdggCwEUfwh8fjEgvEJm4zO1mbmpyddyRIYc=;\n b=jlBO1vloK9BFqFZDcZD9LojZsBTcqjSznCKjkPE9umBdnI94QH375xFju6OLUlyOQ+vb\n rVRQTznj+M3eNH8XuYkFY0FzoXdiKpUEHTK2gbwDHLYitG7YNYE/shOfZMrdeBAP5WDm\n wEKFlgWzIHjKomXjcJib+YYqTGTGcpjESjLxTn8V4Q6EHTttpGdLS3ZNoutLd580qR9x\n O15z8ztt9FG73P4LN3O+GMgI0P+Eu7FC/HAQ60UdfHTgyEdDRmDJrlX5gHJul6eoK15z\n UTv3nvyiOQXBfV1SZ44eTVH4sBEe1RBpgqOn1UkZ8QRDNjjYxDsmVy8CwIvWSBFkmeOp eg==",
        "From": "<lironh@marvell.com>",
        "To": "<jerinj@marvell.com>",
        "CC": "<dev@dpdk.org>, Yuri Chipchev <yuric@marvell.com>, Liron Himi\n <lironh@marvell.com>",
        "Date": "Fri, 22 Jan 2021 21:18:56 +0200",
        "Message-ID": "<20210122191925.24308-9-lironh@marvell.com>",
        "X-Mailer": "git-send-email 2.28.0",
        "In-Reply-To": "<20210122191925.24308-1-lironh@marvell.com>",
        "References": "<20201202101212.4717-1-lironh@marvell.com>\n <20210122191925.24308-1-lironh@marvell.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737\n definitions=2021-01-22_14:2021-01-22,\n 2021-01-22 signatures=0",
        "Subject": "[dpdk-dev] [PATCH v2 08/37] net/mvpp2: extend xstats support",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Yuri Chipchev <yuric@marvell.com>\n\nAdd xstats_by_id callbacks\n\nSigned-off-by: Yuri Chipchev <yuric@marvell.com>\nReviewed-by: Liron Himi <lironh@marvell.com>\n---\n drivers/net/mvpp2/mrvl_ethdev.c | 98 ++++++++++++++++++++++++++++++++-\n 1 file changed, 95 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex e4ec343d5..ba1882266 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -173,6 +173,8 @@ static struct {\n \tMRVL_XSTATS_TBL_ENTRY(tx_errors)\n };\n \n+#define MRVL_NUM_XSTATS RTE_DIM(mrvl_xstats_tbl)\n+\n static inline void\n mrvl_fill_shadowq(struct mrvl_shadow_txq *sq, struct rte_mbuf *buf)\n {\n@@ -1376,7 +1378,7 @@ mrvl_xstats_get(struct rte_eth_dev *dev,\n \t\treturn 0;\n \n \tpp2_ppio_get_statistics(priv->ppio, &ppio_stats, 0);\n-\tfor (i = 0; i < n && i < RTE_DIM(mrvl_xstats_tbl); i++) {\n+\tfor (i = 0; i < n && i < MRVL_NUM_XSTATS; i++) {\n \t\tuint64_t val;\n \n \t\tif (mrvl_xstats_tbl[i].size == sizeof(uint32_t))\n@@ -1430,9 +1432,9 @@ mrvl_xstats_get_names(struct rte_eth_dev *dev __rte_unused,\n \tunsigned int i;\n \n \tif (!xstats_names)\n-\t\treturn RTE_DIM(mrvl_xstats_tbl);\n+\t\treturn MRVL_NUM_XSTATS;\n \n-\tfor (i = 0; i < size && i < RTE_DIM(mrvl_xstats_tbl); i++)\n+\tfor (i = 0; i < size && i < MRVL_NUM_XSTATS; i++)\n \t\tstrlcpy(xstats_names[i].name, mrvl_xstats_tbl[i].name,\n \t\t\tRTE_ETH_XSTATS_NAME_SIZE);\n \n@@ -2015,6 +2017,94 @@ mrvl_eth_filter_ctrl(struct rte_eth_dev *dev __rte_unused,\n \t}\n }\n \n+/**\n+ * DPDK callback to get xstats by id.\n+ *\n+ * @param dev\n+ *   Pointer to the device structure.\n+ * @param ids\n+ *   Pointer to the ids table.\n+ * @param values\n+ *   Pointer to the values table.\n+ * @param n\n+ *   Values table size.\n+ * @returns\n+ *   Number of read values, negative value otherwise.\n+ */\n+static int\n+mrvl_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,\n+\t\t      uint64_t *values, unsigned int n)\n+{\n+\tstruct rte_eth_xstat xstats[MRVL_NUM_XSTATS];\n+\tuint16_t i;\n+\n+\tif (n < MRVL_NUM_XSTATS && ids == NULL)\n+\t\treturn MRVL_NUM_XSTATS;\n+\n+\tif (n > MRVL_NUM_XSTATS)\n+\t\treturn -EINVAL;\n+\n+\tif (values == NULL)\n+\t\treturn -ENOMEM;\n+\n+\tmrvl_xstats_get(dev, xstats, n);\n+\n+\tfor (i = 0; i < MRVL_NUM_XSTATS; i++) {\n+\t\tif (ids[i] >= MRVL_NUM_XSTATS) {\n+\t\t\tMRVL_LOG(ERR, \"id value is not valid\\n\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\t\tvalues[i] = xstats[ids[i]].value;\n+\t}\n+\n+\treturn n;\n+}\n+\n+/**\n+ * DPDK callback to get xstats names by ids.\n+ *\n+ * @param dev\n+ *   Pointer to the device structure.\n+ * @param xstats_names\n+ *   Pointer to table with xstats names.\n+ * @param ids\n+ *   Pointer to table with ids.\n+ * @param size\n+ *   Xstats names table size.\n+ * @returns\n+ *   Number of names read, negative value otherwise.\n+ */\n+static int\n+mrvl_xstats_get_names_by_id(struct rte_eth_dev *dev,\n+\t\t\t    struct rte_eth_xstat_name *xstats_names,\n+\t\t\t    const uint64_t *ids, unsigned int size)\n+{\n+\tstruct rte_eth_xstat_name names[MRVL_NUM_XSTATS];\n+\tuint16_t i;\n+\n+\tif (size < MRVL_NUM_XSTATS && ids == NULL)\n+\t\treturn MRVL_NUM_XSTATS;\n+\n+\tif (size > MRVL_NUM_XSTATS)\n+\t\treturn -EINVAL;\n+\n+\tif (xstats_names == NULL)\n+\t\treturn -ENOMEM;\n+\n+\tmrvl_xstats_get_names(dev, names, size);\n+\n+\tfor (i = 0; i < MRVL_NUM_XSTATS; i++) {\n+\t\tif (ids[i] >= MRVL_NUM_XSTATS) {\n+\t\t\tMRVL_LOG(ERR, \"id value is not valid\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\t\tstrncpy(xstats_names[i].name, names[ids[i]].name,\n+\t\t\tsizeof(xstats_names[i].name));\n+\t}\n+\n+\treturn size;\n+}\n+\n /**\n  * DPDK callback to get rte_mtr callbacks.\n  *\n@@ -2090,6 +2180,8 @@ static const struct eth_dev_ops mrvl_ops = {\n \t.rss_hash_update = mrvl_rss_hash_update,\n \t.rss_hash_conf_get = mrvl_rss_hash_conf_get,\n \t.filter_ctrl = mrvl_eth_filter_ctrl,\n+\t.xstats_get_by_id = mrvl_xstats_get_by_id,\n+\t.xstats_get_names_by_id = mrvl_xstats_get_names_by_id,\n \t.mtr_ops_get = mrvl_mtr_ops_get,\n \t.tm_ops_get = mrvl_tm_ops_get,\n };\n",
    "prefixes": [
        "v2",
        "08/37"
    ]
}