Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87094/?format=api
{ "id": 87094, "url": "https://patches.dpdk.org/api/patches/87094/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210122133523.22507-1-adwivedi@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210122133523.22507-1-adwivedi@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210122133523.22507-1-adwivedi@marvell.com", "date": "2021-01-22T13:35:23", "name": "crypto/octeontx2: fix null pointer dereferences", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "76c0de20501a890a2081360dd13c24ddd4032311", "submitter": { "id": 1561, "url": "https://patches.dpdk.org/api/people/1561/?format=api", "name": "Ankur Dwivedi", "email": "adwivedi@marvell.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210122133523.22507-1-adwivedi@marvell.com/mbox/", "series": [ { "id": 14904, "url": "https://patches.dpdk.org/api/series/14904/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14904", "date": "2021-01-22T13:35:23", "name": "crypto/octeontx2: fix null pointer dereferences", "version": 1, "mbox": "https://patches.dpdk.org/series/14904/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87094/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/87094/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BAABEA0A0A;\n\tFri, 22 Jan 2021 14:35:38 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8070F140FBA;\n\tFri, 22 Jan 2021 14:35:38 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 5CA22140FB4\n for <dev@dpdk.org>; Fri, 22 Jan 2021 14:35:37 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 10MDZ3Cl004000; Fri, 22 Jan 2021 05:35:36 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com with ESMTP id 3668p31yjy-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Fri, 22 Jan 2021 05:35:36 -0800", "from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Fri, 22 Jan 2021 05:35:34 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Fri, 22 Jan 2021 05:35:34 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Fri, 22 Jan 2021 05:35:34 -0800", "from hyd1349.t110.caveonetworks.com.com (unknown [10.29.45.13])\n by maili.marvell.com (Postfix) with ESMTP id A5E9C3F7040;\n Fri, 22 Jan 2021 05:35:32 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=qbLqwOXldv1lBJIYO8KgsBHFa4vwvmhlZpYS6zbhKPQ=;\n b=LzFzdO5c1dkpA43X9585WaH6y8fhDVbym11ngEc/8So9Jk4nRMY7JV4gqkSTAvdp/Y4H\n WDXIMpOyy2y0Fzgq4vWAgD4PExUCiUGP5lB3YffVXTEEm5TqbDZR8zTmsBsblMKK1Sqi\n 4o32t+ExRz2aihS5Cp6sHa7RChXEsLhevIZmXP3BGobYCMv+4bMen5GMlINE9GzSyMCm\n OcuDHr2yHLz2qqWxFzHNYy8btzWc/mCddycj6JWSfeTmsziR5aOhT5sdWN2nOWa7dVW3\n eB6uYEakRO6OqwLNvqbST2ZUYes5ub43GVjLrM7O+jNxbw5EhMudCn3GQT8bD5vur8JD 7Q==", "From": "Ankur Dwivedi <adwivedi@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<akhil.goyal@nxp.com>, <anoobj@marvell.com>, <ktejasree@marvell.com>,\n Ankur Dwivedi <adwivedi@marvell.com>", "Date": "Fri, 22 Jan 2021 19:05:23 +0530", "Message-ID": "<20210122133523.22507-1-adwivedi@marvell.com>", "X-Mailer": "git-send-email 2.28.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737\n definitions=2021-01-22_09:2021-01-21,\n 2021-01-22 signatures=0", "Subject": "[dpdk-dev] [PATCH] crypto/octeontx2: fix null pointer dereferences", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Coverity reports that pointers ip and ip6 may be dereferenced\nwith null value. This patch fixes this.\n\nCoverity issue: 365549\nCoverity issue: 365551\n\nFixes: 1c119d38876d (\"crypto/octeontx2: support lookaside AES-CBC SHA1-HMAC\")\n\nSigned-off-by: Ankur Dwivedi <adwivedi@marvell.com>\n---\n drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_sec.c b/drivers/crypto/octeontx2/otx2_cryptodev_sec.c\nindex 89ed7cbd25..342f089df8 100644\n--- a/drivers/crypto/octeontx2/otx2_cryptodev_sec.c\n+++ b/drivers/crypto/octeontx2/otx2_cryptodev_sec.c\n@@ -208,10 +208,10 @@ crypto_sec_ipsec_outb_session_create(struct rte_cryptodev *crypto_dev,\n \tstruct otx2_ipsec_po_sa_ctl *ctl;\n \tint cipher_key_len, auth_key_len;\n \tstruct otx2_ipsec_po_out_sa *sa;\n-\tstruct rte_ipv6_hdr *ip6 = NULL;\n-\tstruct rte_ipv4_hdr *ip = NULL;\n \tstruct otx2_sec_session *sess;\n \tstruct otx2_cpt_inst_s inst;\n+\tstruct rte_ipv6_hdr *ip6;\n+\tstruct rte_ipv4_hdr *ip;\n \tint ret, ctx_len;\n \n \tsess = get_sec_session_private_data(sec_sess);\n@@ -282,6 +282,8 @@ crypto_sec_ipsec_outb_session_create(struct rte_cryptodev *crypto_dev,\n \t\t\t\t\t\tsa->sha2.template.ip4);\n \t\t\t\tctx_len = RTE_ALIGN_CEIL(ctx_len, 8);\n \t\t\t\tlp->ctx_len = ctx_len >> 3;\n+\t\t\t} else {\n+\t\t\t\treturn -EINVAL;\n \t\t\t}\n \t\t\tip->version_ihl = RTE_IPV4_VHL_DEF;\n \t\t\tip->next_proto_id = IPPROTO_ESP;\n@@ -331,6 +333,8 @@ crypto_sec_ipsec_outb_session_create(struct rte_cryptodev *crypto_dev,\n \t\t\t\t\t\tsa->sha2.template.ip6);\n \t\t\t\tctx_len = RTE_ALIGN_CEIL(ctx_len, 8);\n \t\t\t\tlp->ctx_len = ctx_len >> 3;\n+\t\t\t} else {\n+\t\t\t\treturn -EINVAL;\n \t\t\t}\n \n \t\t\tip6->vtc_flow = rte_cpu_to_be_32(0x60000000 |\n", "prefixes": [] }