Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87088/?format=api
{ "id": 87088, "url": "https://patches.dpdk.org/api/patches/87088/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1611310732-51975-5-git-send-email-oulijun@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1611310732-51975-5-git-send-email-oulijun@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1611310732-51975-5-git-send-email-oulijun@huawei.com", "date": "2021-01-22T10:18:42", "name": "[04/14] net/hns3: move judgment conditions to separated functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3e40600dbb68c1a3f8442c2186da042a9f993a01", "submitter": { "id": 1675, "url": "https://patches.dpdk.org/api/people/1675/?format=api", "name": "Lijun Ou", "email": "oulijun@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1611310732-51975-5-git-send-email-oulijun@huawei.com/mbox/", "series": [ { "id": 14903, "url": "https://patches.dpdk.org/api/series/14903/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14903", "date": "2021-01-22T10:18:38", "name": "Misc updates for hns3", "version": 1, "mbox": "https://patches.dpdk.org/series/14903/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87088/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87088/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D93A0A0A0A;\n\tFri, 22 Jan 2021 11:20:31 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C3CC4140F50;\n\tFri, 22 Jan 2021 11:19:28 +0100 (CET)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id 5CF4E140F0D\n for <dev@dpdk.org>; Fri, 22 Jan 2021 11:19:17 +0100 (CET)", "from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DMZvx75SmzjBrt;\n Fri, 22 Jan 2021 18:18:05 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id\n 14.3.498.0; Fri, 22 Jan 2021 18:19:10 +0800" ], "From": "Lijun Ou <oulijun@huawei.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, <linuxarm@openeuler.org>", "Date": "Fri, 22 Jan 2021 18:18:42 +0800", "Message-ID": "<1611310732-51975-5-git-send-email-oulijun@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1611310732-51975-1-git-send-email-oulijun@huawei.com>", "References": "<1611310732-51975-1-git-send-email-oulijun@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 04/14] net/hns3: move judgment conditions to\n separated functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Here moves some judgement conditions to a separated function\nfor parsing IPv4 hdr and TCP hdr in hns3_parse_normal function.\nAlso, move the check of the selected input tuple of RSS to a\nseparated functions named hns3_rss_input_tuple_supported\nin order to enhance scalability and complexity.\n\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\n---\n drivers/net/hns3/hns3_flow.c | 69 ++++++++++++++++++++++++++++++--------------\n 1 file changed, 48 insertions(+), 21 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c\nindex f303df4..889fa2f 100644\n--- a/drivers/net/hns3/hns3_flow.c\n+++ b/drivers/net/hns3/hns3_flow.c\n@@ -525,6 +525,17 @@ hns3_parse_vlan(const struct rte_flow_item *item, struct hns3_fdir_rule *rule,\n \treturn 0;\n }\n \n+static bool\n+hns3_check_ipv4_mask_supported(const struct rte_flow_item_ipv4 *ipv4_mask)\n+{\n+\tif (ipv4_mask->hdr.total_length || ipv4_mask->hdr.packet_id ||\n+\t ipv4_mask->hdr.fragment_offset || ipv4_mask->hdr.time_to_live ||\n+\t ipv4_mask->hdr.hdr_checksum)\n+\t\treturn false;\n+\n+\treturn true;\n+}\n+\n static int\n hns3_parse_ipv4(const struct rte_flow_item *item, struct hns3_fdir_rule *rule,\n \t\tstruct rte_flow_error *error)\n@@ -546,11 +557,7 @@ hns3_parse_ipv4(const struct rte_flow_item *item, struct hns3_fdir_rule *rule,\n \n \tif (item->mask) {\n \t\tipv4_mask = item->mask;\n-\t\tif (ipv4_mask->hdr.total_length ||\n-\t\t ipv4_mask->hdr.packet_id ||\n-\t\t ipv4_mask->hdr.fragment_offset ||\n-\t\t ipv4_mask->hdr.time_to_live ||\n-\t\t ipv4_mask->hdr.hdr_checksum) {\n+\t\tif (!hns3_check_ipv4_mask_supported(ipv4_mask)) {\n \t\t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM_MASK,\n \t\t\t\t\t\t item,\n@@ -648,6 +655,18 @@ hns3_parse_ipv6(const struct rte_flow_item *item, struct hns3_fdir_rule *rule,\n \treturn 0;\n }\n \n+static bool\n+hns3_check_tcp_mask_supported(const struct rte_flow_item_tcp *tcp_mask)\n+{\n+\tif (tcp_mask->hdr.sent_seq || tcp_mask->hdr.recv_ack ||\n+\t tcp_mask->hdr.data_off || tcp_mask->hdr.tcp_flags ||\n+\t tcp_mask->hdr.rx_win || tcp_mask->hdr.cksum ||\n+\t tcp_mask->hdr.tcp_urp)\n+\t\treturn false;\n+\n+\treturn true;\n+}\n+\n static int\n hns3_parse_tcp(const struct rte_flow_item *item, struct hns3_fdir_rule *rule,\n \t struct rte_flow_error *error)\n@@ -670,10 +689,7 @@ hns3_parse_tcp(const struct rte_flow_item *item, struct hns3_fdir_rule *rule,\n \n \tif (item->mask) {\n \t\ttcp_mask = item->mask;\n-\t\tif (tcp_mask->hdr.sent_seq || tcp_mask->hdr.recv_ack ||\n-\t\t tcp_mask->hdr.data_off || tcp_mask->hdr.tcp_flags ||\n-\t\t tcp_mask->hdr.rx_win || tcp_mask->hdr.cksum ||\n-\t\t tcp_mask->hdr.tcp_urp) {\n+\t\tif (!hns3_check_tcp_mask_supported(tcp_mask)) {\n \t\t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM_MASK,\n \t\t\t\t\t\t item,\n@@ -1328,6 +1344,28 @@ hns3_rss_conf_copy(struct hns3_rss_conf *out,\n \treturn 0;\n }\n \n+static bool\n+hns3_rss_input_tuple_supported(struct hns3_hw *hw,\n+\t\t\t const struct rte_flow_action_rss *rss)\n+{\n+\t/*\n+\t * For IP packet, it is not supported to use src/dst port fields to RSS\n+\t * hash for the following packet types.\n+\t * - IPV4 FRAG | IPV4 NONFRAG | IPV6 FRAG | IPV6 NONFRAG\n+\t * Besides, for Kunpeng920, the NIC HW is not supported to use src/dst\n+\t * port fields to RSS hash for IPV6 SCTP packet type. However, the\n+\t * Kunpeng930 and future kunpeng series support to use src/dst port\n+\t * fields to RSS hash for IPv6 SCTP packet type.\n+\t */\n+\tif (rss->types & (ETH_RSS_L4_DST_ONLY | ETH_RSS_L4_SRC_ONLY) &&\n+\t (rss->types & ETH_RSS_IP ||\n+\t (!hw->rss_info.ipv6_sctp_offload_supported &&\n+\t rss->types & ETH_RSS_NONFRAG_IPV6_SCTP)))\n+\t\treturn false;\n+\n+\treturn true;\n+}\n+\n /*\n * This function is used to parse rss action validatation.\n */\n@@ -1386,18 +1424,7 @@ hns3_parse_rss_filter(struct rte_eth_dev *dev,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_CONF, act,\n \t\t\t\t\t \"RSS hash key must be exactly 40 bytes\");\n \n-\t/*\n-\t * For Kunpeng920 and Kunpeng930 NIC hardware, it is not supported to\n-\t * use dst port/src port fields to RSS hash for the following packet\n-\t * types.\n-\t * - IPV4 FRAG | IPV4 NONFRAG | IPV6 FRAG | IPV6 NONFRAG\n-\t * Besides, for Kunpeng920, The NIC hardware is not supported to use\n-\t * src/dst port fields to RSS hash for IPV6 SCTP packet type.\n-\t */\n-\tif (rss->types & (ETH_RSS_L4_DST_ONLY | ETH_RSS_L4_SRC_ONLY) &&\n-\t (rss->types & ETH_RSS_IP ||\n-\t (!hw->rss_info.ipv6_sctp_offload_supported &&\n-\t rss->types & ETH_RSS_NONFRAG_IPV6_SCTP)))\n+\tif (!hns3_rss_input_tuple_supported(hw, rss))\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION_CONF,\n \t\t\t\t\t &rss->types,\n", "prefixes": [ "04/14" ] }