Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87087/?format=api
{ "id": 87087, "url": "https://patches.dpdk.org/api/patches/87087/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1611310732-51975-12-git-send-email-oulijun@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1611310732-51975-12-git-send-email-oulijun@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1611310732-51975-12-git-send-email-oulijun@huawei.com", "date": "2021-01-22T10:18:49", "name": "[11/14] net/hns3: adjust some comments", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5a74deeccd7a1ec201ffb8fc32106aea22f7a4e6", "submitter": { "id": 1675, "url": "https://patches.dpdk.org/api/people/1675/?format=api", "name": "Lijun Ou", "email": "oulijun@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1611310732-51975-12-git-send-email-oulijun@huawei.com/mbox/", "series": [ { "id": 14903, "url": "https://patches.dpdk.org/api/series/14903/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14903", "date": "2021-01-22T10:18:38", "name": "Misc updates for hns3", "version": 1, "mbox": "https://patches.dpdk.org/series/14903/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87087/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/87087/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 447AEA0A0A;\n\tFri, 22 Jan 2021 11:20:25 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 921A6140F48;\n\tFri, 22 Jan 2021 11:19:27 +0100 (CET)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id 2920F140F09\n for <dev@dpdk.org>; Fri, 22 Jan 2021 11:19:17 +0100 (CET)", "from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DMZvx5rWVzjC0M;\n Fri, 22 Jan 2021 18:18:05 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id\n 14.3.498.0; Fri, 22 Jan 2021 18:19:12 +0800" ], "From": "Lijun Ou <oulijun@huawei.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, <linuxarm@openeuler.org>", "Date": "Fri, 22 Jan 2021 18:18:49 +0800", "Message-ID": "<1611310732-51975-12-git-send-email-oulijun@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1611310732-51975-1-git-send-email-oulijun@huawei.com>", "References": "<1611310732-51975-1-git-send-email-oulijun@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 11/14] net/hns3: adjust some comments", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fixe some error comments and remove some meaningless comments.\n\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\n---\n drivers/net/hns3/hns3_flow.c | 19 ++++++++-----------\n 1 file changed, 8 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c\nindex 8a5179d..f2bff1e 100644\n--- a/drivers/net/hns3/hns3_flow.c\n+++ b/drivers/net/hns3/hns3_flow.c\n@@ -91,9 +91,9 @@ net_addr_to_host(uint32_t *dst, const rte_be32_t *src, size_t len)\n /*\n * This function is used to find rss general action.\n * 1. As we know RSS is used to spread packets among several queues, the flow\n- * API provide the struct rte_flow_action_rss, user could config it's field\n+ * API provide the struct rte_flow_action_rss, user could config its field\n * sush as: func/level/types/key/queue to control RSS function.\n- * 2. The flow API also support queue region configuration for hns3. It was\n+ * 2. The flow API also supports queue region configuration for hns3. It was\n * implemented by FDIR + RSS in hns3 hardware, user can create one FDIR rule\n * which action is RSS queues region.\n * 3. When action is RSS, we use the following rule to distinguish:\n@@ -128,11 +128,11 @@ hns3_find_rss_general_action(const struct rte_flow_item pattern[],\n \trss = act->conf;\n \tif (have_eth && rss->conf.queue_num) {\n \t\t/*\n-\t\t * Patter have ETH and action's queue_num > 0, indicate this is\n+\t\t * Pattern have ETH and action's queue_num > 0, indicate this is\n \t\t * queue region configuration.\n \t\t * Because queue region is implemented by FDIR + RSS in hns3\n-\t\t * hardware, it need enter FDIR process, so here return NULL to\n-\t\t * avoid enter RSS process.\n+\t\t * hardware, it needs to enter FDIR process, so here return NULL\n+\t\t * to avoid enter RSS process.\n \t\t */\n \t\treturn NULL;\n \t}\n@@ -405,7 +405,6 @@ hns3_handle_actions(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n-/* Parse to get the attr and action info of flow director rule. */\n static int\n hns3_check_attr(const struct rte_flow_attr *attr, struct rte_flow_error *error)\n {\n@@ -782,7 +781,7 @@ hns3_parse_sctp(const struct rte_flow_item *item, struct hns3_fdir_rule *rule,\n }\n \n /*\n- * Check items before tunnel, save inner configs to outer configs,and clear\n+ * Check items before tunnel, save inner configs to outer configs, and clear\n * inner configs.\n * The key consists of two parts: meta_data and tuple keys.\n * Meta data uses 15 bits, including vlan_num(2bit), des_port(12bit) and tunnel\n@@ -1473,10 +1472,8 @@ hns3_hw_rss_hash_set(struct hns3_hw *hw, struct rte_flow_action_rss *rss_config)\n \tif (ret)\n \t\treturn ret;\n \n-\t/* Update algorithm of hw */\n \thw->rss_info.conf.func = rss_config->func;\n \n-\t/* Set flow type supported */\n \ttuple = &hw->rss_info.rss_tuple_sets;\n \tret = hns3_set_rss_tuple_by_rss_hf(hw, tuple, rss_config->types);\n \tif (ret)\n@@ -1561,7 +1558,7 @@ hns3_config_rss_filter(struct rte_eth_dev *dev,\n \t\tif (rss_flow_conf.queue_num) {\n \t\t\t/*\n \t\t\t * Due the content of queue pointer have been reset to\n-\t\t\t * 0, the rss_info->conf.queue should be set NULL\n+\t\t\t * 0, the rss_info->conf.queue should be set to NULL\n \t\t\t */\n \t\t\trss_info->conf.queue = NULL;\n \t\t\trss_info->conf.queue_num = 0;\n@@ -1727,7 +1724,7 @@ hns3_flow_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,\n /*\n * Create or destroy a flow rule.\n * Theorically one rule can match more than one filters.\n- * We will let it use the filter which it hitt first.\n+ * We will let it use the filter which it hit first.\n * So, the sequence matters.\n */\n static struct rte_flow *\n", "prefixes": [ "11/14" ] }