Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87076/?format=api
{ "id": 87076, "url": "https://patches.dpdk.org/api/patches/87076/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210122094800.197748-20-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210122094800.197748-20-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210122094800.197748-20-jiawenwu@trustnetic.com", "date": "2021-01-22T09:47:59", "name": "[v1,19/20] net/txgbe: support VLAN filter for VF representor", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "95b82fc207f42f82ba16415a0c84083d6b308710", "submitter": { "id": 1932, "url": "https://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210122094800.197748-20-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 14902, "url": "https://patches.dpdk.org/api/series/14902/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14902", "date": "2021-01-22T09:47:41", "name": "net/txgbe: add VF driver support", "version": 1, "mbox": "https://patches.dpdk.org/series/14902/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87076/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/87076/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5A342A0A0A;\n\tFri, 22 Jan 2021 10:50:42 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3A510140EDD;\n\tFri, 22 Jan 2021 10:48:26 +0100 (CET)", "from smtpproxy21.qq.com (smtpbg704.qq.com [203.205.195.105])\n by mails.dpdk.org (Postfix) with ESMTP id 3886A140EC3\n for <dev@dpdk.org>; Fri, 22 Jan 2021 10:48:22 +0100 (CET)", "from wxdbg.localdomain.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Fri, 22 Jan 2021 17:48:18 +0800 (CST)" ], "X-QQ-mid": "bizesmtp9t1611308899tkm3b0gny", "X-QQ-SSF": "01400000002000C0D000B00A0000000", "X-QQ-FEAT": "1X540h/VXvDWsxxy8/WqENmEirl+Oa2ttNX4OmiUyICeaGcXu9Ezi8STeGZ1F\n VxGhhsW7++tqqRSO2+GLwQ/sdzhw5zvOza9UsqU74OjdGZENUAQq1T6PnikGz/9UhFDAL56\n ksx1x5z46w1T8v22S0wRShwdm25NuvmCzQHTbB/SuxisgkNdEY4qRUh+ah28KY47V7e8eCO\n OMdlxM5VXTtErUD6hO5bS82axKOKlazOZDwyfYwUjroR7lhQ/bXiKyF9V1HS1n8KA3YPu8c\n 7NsOpdy39ohoUGIR1NfM9UEcUrrwA1sZLs69ukdQUS+qdU+7sn2GZusgOKMi3fewGyB3/VM\n 9hX+sw8XnVL6+YjWT7X4Np7gd7n4w==", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Fri, 22 Jan 2021 17:47:59 +0800", "Message-Id": "<20210122094800.197748-20-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210122094800.197748-1-jiawenwu@trustnetic.com>", "References": "<20210122094800.197748-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign7", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v1 19/20] net/txgbe: support VLAN filter for VF\n representor", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support to setup VLAN filter and set VLAN strip for VF representor.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/rte_pmd_txgbe.c | 78 ++++++++++++++++++++++++\n drivers/net/txgbe/rte_pmd_txgbe.h | 43 +++++++++++++\n drivers/net/txgbe/txgbe_ethdev.c | 15 +++++\n drivers/net/txgbe/txgbe_ethdev.h | 1 +\n drivers/net/txgbe/txgbe_vf_representor.c | 25 ++++++++\n 5 files changed, 162 insertions(+)", "diff": "diff --git a/drivers/net/txgbe/rte_pmd_txgbe.c b/drivers/net/txgbe/rte_pmd_txgbe.c\nindex c84233bd6..b34089b75 100644\n--- a/drivers/net/txgbe/rte_pmd_txgbe.c\n+++ b/drivers/net/txgbe/rte_pmd_txgbe.c\n@@ -43,3 +43,81 @@ rte_pmd_txgbe_set_vf_mac_addr(uint16_t port, uint16_t vf,\n \treturn -EINVAL;\n }\n \n+int\n+rte_pmd_txgbe_set_vf_vlan_stripq(uint16_t port, uint16_t vf, uint8_t on)\n+{\n+\tstruct rte_eth_dev *dev;\n+\tstruct rte_pci_device *pci_dev;\n+\tstruct txgbe_hw *hw;\n+\tuint16_t queues_per_pool;\n+\tuint32_t q;\n+\n+\tRTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);\n+\n+\tdev = &rte_eth_devices[port];\n+\tpci_dev = RTE_ETH_DEV_TO_PCI(dev);\n+\thw = TXGBE_DEV_HW(dev);\n+\n+\tif (!is_txgbe_supported(dev))\n+\t\treturn -ENOTSUP;\n+\n+\tif (vf >= pci_dev->max_vfs)\n+\t\treturn -EINVAL;\n+\n+\tif (on > 1)\n+\t\treturn -EINVAL;\n+\n+\tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->vlan_strip_queue_set, -ENOTSUP);\n+\n+\t/* The PF has 128 queue pairs and in SRIOV configuration\n+\t * those queues will be assigned to VF's, so RXDCTL\n+\t * registers will be dealing with queues which will be\n+\t * assigned to VF's.\n+\t * Let's say we have SRIOV configured with 31 VF's then the\n+\t * first 124 queues 0-123 will be allocated to VF's and only\n+\t * the last 4 queues 123-127 will be assigned to the PF.\n+\t */\n+\tqueues_per_pool = (uint16_t)hw->mac.max_rx_queues /\n+\t\t\t ETH_64_POOLS;\n+\n+\tfor (q = 0; q < queues_per_pool; q++)\n+\t\t(*dev->dev_ops->vlan_strip_queue_set)(dev,\n+\t\t\t\tq + vf * queues_per_pool, on);\n+\treturn 0;\n+}\n+\n+int\n+rte_pmd_txgbe_set_vf_vlan_filter(uint16_t port, uint16_t vlan,\n+\t\t\t\t uint64_t vf_mask, uint8_t vlan_on)\n+{\n+\tstruct rte_eth_dev *dev;\n+\tint ret = 0;\n+\tuint16_t vf_idx;\n+\tstruct txgbe_hw *hw;\n+\n+\tRTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);\n+\n+\tdev = &rte_eth_devices[port];\n+\n+\tif (!is_txgbe_supported(dev))\n+\t\treturn -ENOTSUP;\n+\n+\tif (vlan > RTE_ETHER_MAX_VLAN_ID || vf_mask == 0)\n+\t\treturn -EINVAL;\n+\n+\thw = TXGBE_DEV_HW(dev);\n+\tif (txgbe_vt_check(hw) < 0)\n+\t\treturn -ENOTSUP;\n+\n+\tfor (vf_idx = 0; vf_idx < 64; vf_idx++) {\n+\t\tif (vf_mask & ((uint64_t)(1ULL << vf_idx))) {\n+\t\t\tret = hw->mac.set_vfta(hw, vlan, vf_idx,\n+\t\t\t\t\t\t vlan_on, false);\n+\t\t\tif (ret < 0)\n+\t\t\t\treturn ret;\n+\t\t}\n+\t}\n+\n+\treturn ret;\n+}\n+\ndiff --git a/drivers/net/txgbe/rte_pmd_txgbe.h b/drivers/net/txgbe/rte_pmd_txgbe.h\nindex b994b476e..3d8c41286 100644\n--- a/drivers/net/txgbe/rte_pmd_txgbe.h\n+++ b/drivers/net/txgbe/rte_pmd_txgbe.h\n@@ -32,6 +32,49 @@\n int rte_pmd_txgbe_set_vf_mac_addr(uint16_t port, uint16_t vf,\n \t\tstruct rte_ether_addr *mac_addr);\n \n+/**\n+ * Enable/Disable vf vlan strip for all queues in a pool\n+ *\n+ * @param port\n+ * The port identifier of the Ethernet device.\n+ * @param vf\n+ * ID specifying VF.\n+ * @param on\n+ * 1 - Enable VF's vlan strip on RX queues.\n+ * 0 - Disable VF's vlan strip on RX queues.\n+ *\n+ * @return\n+ * - (0) if successful.\n+ * - (-ENOTSUP) if hardware doesn't support this feature.\n+ * - (-ENODEV) if *port* invalid.\n+ * - (-EINVAL) if bad parameter.\n+ */\n+int\n+rte_pmd_txgbe_set_vf_vlan_stripq(uint16_t port, uint16_t vf, uint8_t on);\n+\n+/**\n+ * Enable/Disable hardware VF VLAN filtering by an Ethernet device of\n+ * received VLAN packets tagged with a given VLAN Tag Identifier.\n+ *\n+ * @param port\n+ * The port identifier of the Ethernet device.\n+ * @param vlan\n+ * The VLAN Tag Identifier whose filtering must be enabled or disabled.\n+ * @param vf_mask\n+ * Bitmap listing which VFs participate in the VLAN filtering.\n+ * @param vlan_on\n+ * 1 - Enable VFs VLAN filtering.\n+ * 0 - Disable VFs VLAN filtering.\n+ * @return\n+ * - (0) if successful.\n+ * - (-ENOTSUP) if hardware doesn't support.\n+ * - (-ENODEV) if *port_id* invalid.\n+ * - (-EINVAL) if bad parameter.\n+ */\n+int\n+rte_pmd_txgbe_set_vf_vlan_filter(uint16_t port, uint16_t vlan,\n+\t\t\t\t uint64_t vf_mask, uint8_t vlan_on);\n+\n /**\n * Response sent back to txgbe driver from user app after callback\n */\ndiff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex 0fe8e3415..40d98abfb 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -3413,6 +3413,21 @@ txgbe_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n \treturn 0;\n }\n \n+int\n+txgbe_vt_check(struct txgbe_hw *hw)\n+{\n+\tuint32_t reg_val;\n+\n+\t/* if Virtualization Technology is enabled */\n+\treg_val = rd32(hw, TXGBE_PORTCTL);\n+\tif (!(reg_val & TXGBE_PORTCTL_NUMVT_MASK)) {\n+\t\tPMD_INIT_LOG(ERR, \"VT must be enabled for this setting\");\n+\t\treturn -1;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static uint32_t\n txgbe_uta_vector(struct txgbe_hw *hw, struct rte_ether_addr *uc_addr)\n {\ndiff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/txgbe/txgbe_ethdev.h\nindex 73ca975e7..71ccabcbc 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.h\n+++ b/drivers/net/txgbe/txgbe_ethdev.h\n@@ -593,6 +593,7 @@ void txgbe_clear_all_ntuple_filter(struct rte_eth_dev *dev);\n void txgbe_clear_syn_filter(struct rte_eth_dev *dev);\n int txgbe_clear_all_l2_tn_filter(struct rte_eth_dev *dev);\n \n+int txgbe_vt_check(struct txgbe_hw *hw);\n int txgbe_set_vf_rate_limit(struct rte_eth_dev *dev, uint16_t vf,\n \t\t\t uint16_t tx_rate, uint64_t q_msk);\n int txgbe_tm_ops_get(struct rte_eth_dev *dev, void *ops);\ndiff --git a/drivers/net/txgbe/txgbe_vf_representor.c b/drivers/net/txgbe/txgbe_vf_representor.c\nindex 87af9b34b..a404e272d 100644\n--- a/drivers/net/txgbe/txgbe_vf_representor.c\n+++ b/drivers/net/txgbe/txgbe_vf_representor.c\n@@ -81,9 +81,34 @@ txgbe_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev,\n \treturn 0;\n }\n \n+static int\n+txgbe_vf_representor_vlan_filter_set(struct rte_eth_dev *ethdev,\n+\tuint16_t vlan_id, int on)\n+{\n+\tstruct txgbe_vf_representor *representor =\n+\t\t\tTXGBE_DEV_REPRESENTOR(ethdev);\n+\tuint64_t vf_mask = 1ULL << representor->vf_id;\n+\n+\treturn rte_pmd_txgbe_set_vf_vlan_filter(\n+\t\trepresentor->pf_ethdev->data->port_id, vlan_id, vf_mask, on);\n+}\n+\n+static void\n+txgbe_vf_representor_vlan_strip_queue_set(struct rte_eth_dev *ethdev,\n+\t__rte_unused uint16_t rx_queue_id, int on)\n+{\n+\tstruct txgbe_vf_representor *representor =\n+\t\t\tTXGBE_DEV_REPRESENTOR(ethdev);\n+\n+\trte_pmd_txgbe_set_vf_vlan_stripq(representor->pf_ethdev->data->port_id,\n+\t\trepresentor->vf_id, on);\n+}\n+\n static const struct eth_dev_ops txgbe_vf_representor_dev_ops = {\n \t.dev_infos_get\t\t= txgbe_vf_representor_dev_infos_get,\n \t.link_update\t\t= txgbe_vf_representor_link_update,\n+\t.vlan_filter_set\t= txgbe_vf_representor_vlan_filter_set,\n+\t.vlan_strip_queue_set\t= txgbe_vf_representor_vlan_strip_queue_set,\n \t.mac_addr_set\t\t= txgbe_vf_representor_mac_addr_set,\n };\n \n", "prefixes": [ "v1", "19/20" ] }