Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87070/?format=api
{ "id": 87070, "url": "https://patches.dpdk.org/api/patches/87070/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210122094800.197748-13-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210122094800.197748-13-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210122094800.197748-13-jiawenwu@trustnetic.com", "date": "2021-01-22T09:47:52", "name": "[v1,12/20] net/txgbe: support multicast MAC filter for VF driver", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "9d814edb5a6dffd7e8c2d509a767b8e0dd0c4ed2", "submitter": { "id": 1932, "url": "https://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210122094800.197748-13-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 14902, "url": "https://patches.dpdk.org/api/series/14902/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14902", "date": "2021-01-22T09:47:41", "name": "net/txgbe: add VF driver support", "version": 1, "mbox": "https://patches.dpdk.org/series/14902/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87070/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87070/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1F5CAA0A0A;\n\tFri, 22 Jan 2021 10:49:51 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 73FF0140EAD;\n\tFri, 22 Jan 2021 10:48:18 +0100 (CET)", "from smtpproxy21.qq.com (smtpbg702.qq.com [203.205.195.102])\n by mails.dpdk.org (Postfix) with ESMTP id E4D3C140E8C\n for <dev@dpdk.org>; Fri, 22 Jan 2021 10:48:12 +0100 (CET)", "from wxdbg.localdomain.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Fri, 22 Jan 2021 17:48:08 +0800 (CST)" ], "X-QQ-mid": "bizesmtp9t1611308888t5j6bn97n", "X-QQ-SSF": "01400000002000C0D000B00A0000000", "X-QQ-FEAT": "lm51M56XDGyaWtEGYKnizkus4Dd6qbxbV1YXuC8opvU1XQyIGvjB+0HMkpH7K\n iD2vt/hiNyiKoCfi6s4xxvc3+LILgc0efkZiM0xg38lv8IUzOBwYHdaQ5b5ldyuzd9Krj2c\n 9wrnBONfJkgpeqmNSR2PAHW1K9Gz5/vd+gOJwDhUb7GxtoKYJysaqTpdlHfusvZUcVtGQ/M\n QHwXlgkvwgPYWTb3OE29PiPYBYCsv7HSclrymKFRbXtqM4eSAOOvr+tiQuyhV6GhsrSYgCq\n QkVnt/KqHlColapCXqSc/GMYmXYIb8BUNbNB7Z5QrL/nLRUcYBDYa20XLt61/xaFftrQ9lg\n bXSDkZaxu+ux1MdkIFXzqBl/LCZ8g==", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Fri, 22 Jan 2021 17:47:52 +0800", "Message-Id": "<20210122094800.197748-13-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210122094800.197748-1-jiawenwu@trustnetic.com>", "References": "<20210122094800.197748-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign5", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v1 12/20] net/txgbe: support multicast MAC filter\n for VF driver", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add multicast MAC filter support for VF driver.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n doc/guides/nics/features/txgbe_vf.ini | 1 +\n drivers/net/txgbe/base/txgbe_hw.c | 1 +\n drivers/net/txgbe/base/txgbe_vf.c | 83 +++++++++++++++++++++++++++\n drivers/net/txgbe/base/txgbe_vf.h | 3 +\n drivers/net/txgbe/txgbe_ethdev.c | 2 +-\n drivers/net/txgbe/txgbe_ethdev_vf.c | 1 +\n 6 files changed, 90 insertions(+), 1 deletion(-)", "diff": "diff --git a/doc/guides/nics/features/txgbe_vf.ini b/doc/guides/nics/features/txgbe_vf.ini\nindex 80a194673..480af52bd 100644\n--- a/doc/guides/nics/features/txgbe_vf.ini\n+++ b/doc/guides/nics/features/txgbe_vf.ini\n@@ -12,6 +12,7 @@ LRO = Y\n TSO = Y\n Promiscuous mode = Y\n Allmulticast mode = Y\n+Multicast MAC filter = Y\n RSS hash = Y\n RSS key update = Y\n RSS reta update = Y\ndiff --git a/drivers/net/txgbe/base/txgbe_hw.c b/drivers/net/txgbe/base/txgbe_hw.c\nindex c357c8658..3cee8b857 100644\n--- a/drivers/net/txgbe/base/txgbe_hw.c\n+++ b/drivers/net/txgbe/base/txgbe_hw.c\n@@ -2808,6 +2808,7 @@ s32 txgbe_init_ops_pf(struct txgbe_hw *hw)\n \tmac->acquire_swfw_sync = txgbe_acquire_swfw_sync;\n \tmac->release_swfw_sync = txgbe_release_swfw_sync;\n \tmac->reset_hw = txgbe_reset_hw;\n+\tmac->update_mc_addr_list = txgbe_update_mc_addr_list;\n \n \tmac->disable_sec_rx_path = txgbe_disable_sec_rx_path;\n \tmac->enable_sec_rx_path = txgbe_enable_sec_rx_path;\ndiff --git a/drivers/net/txgbe/base/txgbe_vf.c b/drivers/net/txgbe/base/txgbe_vf.c\nindex 844d2ec2f..92bd6463a 100644\n--- a/drivers/net/txgbe/base/txgbe_vf.c\n+++ b/drivers/net/txgbe/base/txgbe_vf.c\n@@ -26,6 +26,7 @@ s32 txgbe_init_ops_vf(struct txgbe_hw *hw)\n \tmac->get_mac_addr = txgbe_get_mac_addr_vf;\n \tmac->stop_hw = txgbe_stop_hw_vf;\n \tmac->negotiate_api_version = txgbevf_negotiate_api_version;\n+\tmac->update_mc_addr_list = txgbe_update_mc_addr_list_vf;\n \n \t/* Link */\n \tmac->check_link = txgbe_check_mac_link_vf;\n@@ -213,6 +214,39 @@ s32 txgbe_stop_hw_vf(struct txgbe_hw *hw)\n \treturn 0;\n }\n \n+/**\n+ * txgbe_mta_vector - Determines bit-vector in multicast table to set\n+ * @hw: pointer to hardware structure\n+ * @mc_addr: the multicast address\n+ **/\n+STATIC s32 txgbe_mta_vector(struct txgbe_hw *hw, u8 *mc_addr)\n+{\n+\tu32 vector = 0;\n+\n+\tswitch (hw->mac.mc_filter_type) {\n+\tcase 0: /* use bits [47:36] of the address */\n+\t\tvector = ((mc_addr[4] >> 4) | (((u16)mc_addr[5]) << 4));\n+\t\tbreak;\n+\tcase 1: /* use bits [46:35] of the address */\n+\t\tvector = ((mc_addr[4] >> 3) | (((u16)mc_addr[5]) << 5));\n+\t\tbreak;\n+\tcase 2: /* use bits [45:34] of the address */\n+\t\tvector = ((mc_addr[4] >> 2) | (((u16)mc_addr[5]) << 6));\n+\t\tbreak;\n+\tcase 3: /* use bits [43:32] of the address */\n+\t\tvector = ((mc_addr[4]) | (((u16)mc_addr[5]) << 8));\n+\t\tbreak;\n+\tdefault: /* Invalid mc_filter_type */\n+\t\tDEBUGOUT(\"MC filter type param set incorrectly\\n\");\n+\t\tASSERT(0);\n+\t\tbreak;\n+\t}\n+\n+\t/* vector can only be 12-bits or boundary will be exceeded */\n+\tvector &= 0xFFF;\n+\treturn vector;\n+}\n+\n STATIC s32 txgbevf_write_msg_read_ack(struct txgbe_hw *hw, u32 *msg,\n \t\t\t\t u32 *retmsg, u16 size)\n {\n@@ -258,6 +292,55 @@ s32 txgbe_set_rar_vf(struct txgbe_hw *hw, u32 index, u8 *addr, u32 vmdq,\n \treturn ret_val;\n }\n \n+/**\n+ * txgbe_update_mc_addr_list_vf - Update Multicast addresses\n+ * @hw: pointer to the HW structure\n+ * @mc_addr_list: array of multicast addresses to program\n+ * @mc_addr_count: number of multicast addresses to program\n+ * @next: caller supplied function to return next address in list\n+ * @clear: unused\n+ *\n+ * Updates the Multicast Table Array.\n+ **/\n+s32 txgbe_update_mc_addr_list_vf(struct txgbe_hw *hw, u8 *mc_addr_list,\n+\t\t\t\t u32 mc_addr_count, txgbe_mc_addr_itr next,\n+\t\t\t\t bool clear)\n+{\n+\tstruct txgbe_mbx_info *mbx = &hw->mbx;\n+\tu32 msgbuf[TXGBE_P2VMBX_SIZE];\n+\tu16 *vector_list = (u16 *)&msgbuf[1];\n+\tu32 vector;\n+\tu32 cnt, i;\n+\tu32 vmdq;\n+\n+\tUNREFERENCED_PARAMETER(clear);\n+\n+\tDEBUGFUNC(\"txgbe_update_mc_addr_list_vf\");\n+\n+\t/* Each entry in the list uses 1 16 bit word. We have 30\n+\t * 16 bit words available in our HW msg buffer (minus 1 for the\n+\t * msg type). That's 30 hash values if we pack 'em right. If\n+\t * there are more than 30 MC addresses to add then punt the\n+\t * extras for now and then add code to handle more than 30 later.\n+\t * It would be unusual for a server to request that many multi-cast\n+\t * addresses except for in large enterprise network environments.\n+\t */\n+\n+\tDEBUGOUT(\"MC Addr Count = %d\\n\", mc_addr_count);\n+\n+\tcnt = (mc_addr_count > 30) ? 30 : mc_addr_count;\n+\tmsgbuf[0] = TXGBE_VF_SET_MULTICAST;\n+\tmsgbuf[0] |= cnt << TXGBE_VT_MSGINFO_SHIFT;\n+\n+\tfor (i = 0; i < cnt; i++) {\n+\t\tvector = txgbe_mta_vector(hw, next(hw, &mc_addr_list, &vmdq));\n+\t\tDEBUGOUT(\"Hash value = 0x%03X\\n\", vector);\n+\t\tvector_list[i] = (u16)vector;\n+\t}\n+\n+\treturn mbx->write_posted(hw, msgbuf, TXGBE_P2VMBX_SIZE, 0);\n+}\n+\n /**\n * txgbevf_update_xcast_mode - Update Multicast mode\n * @hw: pointer to the HW structure\ndiff --git a/drivers/net/txgbe/base/txgbe_vf.h b/drivers/net/txgbe/base/txgbe_vf.h\nindex 710df838f..39714d102 100644\n--- a/drivers/net/txgbe/base/txgbe_vf.h\n+++ b/drivers/net/txgbe/base/txgbe_vf.h\n@@ -47,6 +47,9 @@ s32 txgbe_check_mac_link_vf(struct txgbe_hw *hw, u32 *speed,\n s32 txgbe_set_rar_vf(struct txgbe_hw *hw, u32 index, u8 *addr, u32 vmdq,\n \t\t u32 enable_addr);\n s32 txgbevf_set_uc_addr_vf(struct txgbe_hw *hw, u32 index, u8 *addr);\n+s32 txgbe_update_mc_addr_list_vf(struct txgbe_hw *hw, u8 *mc_addr_list,\n+\t\t\t\t u32 mc_addr_count, txgbe_mc_addr_itr next,\n+\t\t\t\t bool clear);\n s32 txgbevf_update_xcast_mode(struct txgbe_hw *hw, int xcast_mode);\n s32 txgbe_set_vfta_vf(struct txgbe_hw *hw, u32 vlan, u32 vind,\n \t\t bool vlan_on, bool vlvf_bypass);\ndiff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex fbea236f9..0f473d49a 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -4121,7 +4121,7 @@ txgbe_dev_set_mc_addr_list(struct rte_eth_dev *dev,\n \n \thw = TXGBE_DEV_HW(dev);\n \tmc_addr_list = (u8 *)mc_addr_set;\n-\treturn txgbe_update_mc_addr_list(hw, mc_addr_list, nb_mc_addr,\n+\treturn hw->mac.update_mc_addr_list(hw, mc_addr_list, nb_mc_addr,\n \t\t\t\t\t txgbe_dev_addr_list_itr, TRUE);\n }\n \ndiff --git a/drivers/net/txgbe/txgbe_ethdev_vf.c b/drivers/net/txgbe/txgbe_ethdev_vf.c\nindex e544ea89b..58fd2c5a1 100644\n--- a/drivers/net/txgbe/txgbe_ethdev_vf.c\n+++ b/drivers/net/txgbe/txgbe_ethdev_vf.c\n@@ -1083,6 +1083,7 @@ static const struct eth_dev_ops txgbevf_eth_dev_ops = {\n \t.rx_queue_intr_disable = txgbevf_dev_rx_queue_intr_disable,\n \t.mac_addr_add = txgbevf_add_mac_addr,\n \t.mac_addr_remove = txgbevf_remove_mac_addr,\n+\t.set_mc_addr_list = txgbe_dev_set_mc_addr_list,\n \t.rxq_info_get = txgbe_rxq_info_get,\n \t.txq_info_get = txgbe_txq_info_get,\n \t.mac_addr_set = txgbevf_set_default_mac_addr,\n", "prefixes": [ "v1", "12/20" ] }