Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87068/?format=api
{ "id": 87068, "url": "https://patches.dpdk.org/api/patches/87068/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210122094800.197748-12-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210122094800.197748-12-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210122094800.197748-12-jiawenwu@trustnetic.com", "date": "2021-01-22T09:47:51", "name": "[v1,11/20] net/txgbe: add VF device promiscuous and allmulticast mode", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "468c9619cf60f9a42349638cb0027354fb98f4e6", "submitter": { "id": 1932, "url": "https://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210122094800.197748-12-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 14902, "url": "https://patches.dpdk.org/api/series/14902/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14902", "date": "2021-01-22T09:47:41", "name": "net/txgbe: add VF driver support", "version": 1, "mbox": "https://patches.dpdk.org/series/14902/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87068/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87068/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 59488A0A0A;\n\tFri, 22 Jan 2021 10:49:32 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9F618140E9A;\n\tFri, 22 Jan 2021 10:48:15 +0100 (CET)", "from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56])\n by mails.dpdk.org (Postfix) with ESMTP id 2FC36140E6A\n for <dev@dpdk.org>; Fri, 22 Jan 2021 10:48:12 +0100 (CET)", "from wxdbg.localdomain.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Fri, 22 Jan 2021 17:48:07 +0800 (CST)" ], "X-QQ-mid": "bizesmtp9t1611308887tc6hepeo7", "X-QQ-SSF": "01400000002000C0D000B00A0000000", "X-QQ-FEAT": "VvqLbp3JaDNeXJfTC1yhyC8q5xPpr28ECEzL599aH98nWMfDuwK/Ya3zlkRQ4\n nJOM+CglQlZgEQd0+CkuDk3ZXKnDHxb59/h6YSsx9P9MeMviNJb49Utp0OzzzQJ19xMDwzQ\n bsDjaMDtA69Ocg4uGOvBBWOE+AYKMgEVA6WeQ1BTYOd7zDF6KMC1H2JsNV3qqu0kWq9yOKi\n WsuFwrmJBWg1n1J0Ip8fVYstUhQ2l0vajpNVLfGFrdrK6eDKPeH8aDi8OrRye4pKYJB+K4K\n 7yyYgvVjMeVMSg3rr7mLhJp0L2626k4bB8+ENFj6hddrDUax+ZC63HqzasScvIwN2WjHQfR\n VVtik5Q8hkWZk7x++LTgv4+mf/tjg==", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Fri, 22 Jan 2021 17:47:51 +0800", "Message-Id": "<20210122094800.197748-12-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210122094800.197748-1-jiawenwu@trustnetic.com>", "References": "<20210122094800.197748-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign5", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v1 11/20] net/txgbe: add VF device promiscuous\n and allmulticast mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support to enable and disable promiscuous and allmulticast mode on VF\ndevice.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n doc/guides/nics/features/txgbe_vf.ini | 2 +\n drivers/net/txgbe/base/txgbe_vf.c | 38 +++++++++++\n drivers/net/txgbe/base/txgbe_vf.h | 1 +\n drivers/net/txgbe/txgbe_ethdev_vf.c | 93 +++++++++++++++++++++++++++\n 4 files changed, 134 insertions(+)", "diff": "diff --git a/doc/guides/nics/features/txgbe_vf.ini b/doc/guides/nics/features/txgbe_vf.ini\nindex 42c2dcf40..80a194673 100644\n--- a/doc/guides/nics/features/txgbe_vf.ini\n+++ b/doc/guides/nics/features/txgbe_vf.ini\n@@ -10,6 +10,8 @@ Jumbo frame = Y\n Scattered Rx = Y\n LRO = Y\n TSO = Y\n+Promiscuous mode = Y\n+Allmulticast mode = Y\n RSS hash = Y\n RSS key update = Y\n RSS reta update = Y\ndiff --git a/drivers/net/txgbe/base/txgbe_vf.c b/drivers/net/txgbe/base/txgbe_vf.c\nindex 1342dfaae..844d2ec2f 100644\n--- a/drivers/net/txgbe/base/txgbe_vf.c\n+++ b/drivers/net/txgbe/base/txgbe_vf.c\n@@ -33,6 +33,7 @@ s32 txgbe_init_ops_vf(struct txgbe_hw *hw)\n \t/* RAR, Multicast, VLAN */\n \tmac->set_rar = txgbe_set_rar_vf;\n \tmac->set_uc_addr = txgbevf_set_uc_addr_vf;\n+\tmac->update_xcast_mode = txgbevf_update_xcast_mode;\n \tmac->set_vfta = txgbe_set_vfta_vf;\n \tmac->set_rlpml = txgbevf_rlpml_set_vf;\n \n@@ -257,6 +258,43 @@ s32 txgbe_set_rar_vf(struct txgbe_hw *hw, u32 index, u8 *addr, u32 vmdq,\n \treturn ret_val;\n }\n \n+/**\n+ * txgbevf_update_xcast_mode - Update Multicast mode\n+ * @hw: pointer to the HW structure\n+ * @xcast_mode: new multicast mode\n+ *\n+ * Updates the Multicast Mode of VF.\n+ **/\n+s32 txgbevf_update_xcast_mode(struct txgbe_hw *hw, int xcast_mode)\n+{\n+\tu32 msgbuf[2];\n+\ts32 err;\n+\n+\tswitch (hw->api_version) {\n+\tcase txgbe_mbox_api_12:\n+\t\t/* New modes were introduced in 1.3 version */\n+\t\tif (xcast_mode > TXGBEVF_XCAST_MODE_ALLMULTI)\n+\t\t\treturn TXGBE_ERR_FEATURE_NOT_SUPPORTED;\n+\t\t/* Fall through */\n+\tcase txgbe_mbox_api_13:\n+\t\tbreak;\n+\tdefault:\n+\t\treturn TXGBE_ERR_FEATURE_NOT_SUPPORTED;\n+\t}\n+\n+\tmsgbuf[0] = TXGBE_VF_UPDATE_XCAST_MODE;\n+\tmsgbuf[1] = xcast_mode;\n+\n+\terr = txgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, 2);\n+\tif (err)\n+\t\treturn err;\n+\n+\tmsgbuf[0] &= ~TXGBE_VT_MSGTYPE_CTS;\n+\tif (msgbuf[0] == (TXGBE_VF_UPDATE_XCAST_MODE | TXGBE_VT_MSGTYPE_NACK))\n+\t\treturn TXGBE_ERR_FEATURE_NOT_SUPPORTED;\n+\treturn 0;\n+}\n+\n /**\n * txgbe_set_vfta_vf - Set/Unset vlan filter table address\n * @hw: pointer to the HW structure\ndiff --git a/drivers/net/txgbe/base/txgbe_vf.h b/drivers/net/txgbe/base/txgbe_vf.h\nindex 45db1b776..710df838f 100644\n--- a/drivers/net/txgbe/base/txgbe_vf.h\n+++ b/drivers/net/txgbe/base/txgbe_vf.h\n@@ -47,6 +47,7 @@ s32 txgbe_check_mac_link_vf(struct txgbe_hw *hw, u32 *speed,\n s32 txgbe_set_rar_vf(struct txgbe_hw *hw, u32 index, u8 *addr, u32 vmdq,\n \t\t u32 enable_addr);\n s32 txgbevf_set_uc_addr_vf(struct txgbe_hw *hw, u32 index, u8 *addr);\n+s32 txgbevf_update_xcast_mode(struct txgbe_hw *hw, int xcast_mode);\n s32 txgbe_set_vfta_vf(struct txgbe_hw *hw, u32 vlan, u32 vind,\n \t\t bool vlan_on, bool vlvf_bypass);\n s32 txgbevf_rlpml_set_vf(struct txgbe_hw *hw, u16 max_size);\ndiff --git a/drivers/net/txgbe/txgbe_ethdev_vf.c b/drivers/net/txgbe/txgbe_ethdev_vf.c\nindex 03e690c0e..e544ea89b 100644\n--- a/drivers/net/txgbe/txgbe_ethdev_vf.c\n+++ b/drivers/net/txgbe/txgbe_ethdev_vf.c\n@@ -30,6 +30,8 @@ static int txgbevf_dev_stats_reset(struct rte_eth_dev *dev);\n static int txgbevf_vlan_offload_config(struct rte_eth_dev *dev, int mask);\n static void txgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on);\n static void txgbevf_configure_msix(struct rte_eth_dev *dev);\n+static int txgbevf_dev_promiscuous_enable(struct rte_eth_dev *dev);\n+static int txgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev);\n static void txgbevf_remove_mac_addr(struct rte_eth_dev *dev, uint32_t index);\n static void txgbevf_dev_interrupt_handler(void *param);\n \n@@ -266,6 +268,9 @@ eth_txgbevf_dev_init(struct rte_eth_dev *eth_dev)\n \t\treturn -EIO;\n \t}\n \n+\t/* enter promiscuous mode */\n+\ttxgbevf_dev_promiscuous_enable(eth_dev);\n+\n \trte_intr_callback_register(intr_handle,\n \t\t\t\t txgbevf_dev_interrupt_handler, eth_dev);\n \trte_intr_enable(intr_handle);\n@@ -908,6 +913,90 @@ txgbevf_set_default_mac_addr(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+static int\n+txgbevf_dev_promiscuous_enable(struct rte_eth_dev *dev)\n+{\n+\tstruct txgbe_hw *hw = TXGBE_DEV_HW(dev);\n+\tint ret;\n+\n+\tswitch (hw->mac.update_xcast_mode(hw, TXGBEVF_XCAST_MODE_PROMISC)) {\n+\tcase 0:\n+\t\tret = 0;\n+\t\tbreak;\n+\tcase TXGBE_ERR_FEATURE_NOT_SUPPORTED:\n+\t\tret = -ENOTSUP;\n+\t\tbreak;\n+\tdefault:\n+\t\tret = -EAGAIN;\n+\t\tbreak;\n+\t}\n+\n+\treturn ret;\n+}\n+\n+static int\n+txgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev)\n+{\n+\tstruct txgbe_hw *hw = TXGBE_DEV_HW(dev);\n+\tint ret;\n+\n+\tswitch (hw->mac.update_xcast_mode(hw, TXGBEVF_XCAST_MODE_NONE)) {\n+\tcase 0:\n+\t\tret = 0;\n+\t\tbreak;\n+\tcase TXGBE_ERR_FEATURE_NOT_SUPPORTED:\n+\t\tret = -ENOTSUP;\n+\t\tbreak;\n+\tdefault:\n+\t\tret = -EAGAIN;\n+\t\tbreak;\n+\t}\n+\n+\treturn ret;\n+}\n+\n+static int\n+txgbevf_dev_allmulticast_enable(struct rte_eth_dev *dev)\n+{\n+\tstruct txgbe_hw *hw = TXGBE_DEV_HW(dev);\n+\tint ret;\n+\n+\tswitch (hw->mac.update_xcast_mode(hw, TXGBEVF_XCAST_MODE_ALLMULTI)) {\n+\tcase 0:\n+\t\tret = 0;\n+\t\tbreak;\n+\tcase TXGBE_ERR_FEATURE_NOT_SUPPORTED:\n+\t\tret = -ENOTSUP;\n+\t\tbreak;\n+\tdefault:\n+\t\tret = -EAGAIN;\n+\t\tbreak;\n+\t}\n+\n+\treturn ret;\n+}\n+\n+static int\n+txgbevf_dev_allmulticast_disable(struct rte_eth_dev *dev)\n+{\n+\tstruct txgbe_hw *hw = TXGBE_DEV_HW(dev);\n+\tint ret;\n+\n+\tswitch (hw->mac.update_xcast_mode(hw, TXGBEVF_XCAST_MODE_MULTI)) {\n+\tcase 0:\n+\t\tret = 0;\n+\t\tbreak;\n+\tcase TXGBE_ERR_FEATURE_NOT_SUPPORTED:\n+\t\tret = -ENOTSUP;\n+\t\tbreak;\n+\tdefault:\n+\t\tret = -EAGAIN;\n+\t\tbreak;\n+\t}\n+\n+\treturn ret;\n+}\n+\n static void txgbevf_mbx_process(struct rte_eth_dev *dev)\n {\n \tstruct txgbe_hw *hw = TXGBE_DEV_HW(dev);\n@@ -982,6 +1071,10 @@ static const struct eth_dev_ops txgbevf_eth_dev_ops = {\n \t.stats_reset = txgbevf_dev_stats_reset,\n \t.xstats_reset = txgbevf_dev_stats_reset,\n \t.xstats_get_names = txgbevf_dev_xstats_get_names,\n+\t.promiscuous_enable = txgbevf_dev_promiscuous_enable,\n+\t.promiscuous_disable = txgbevf_dev_promiscuous_disable,\n+\t.allmulticast_enable = txgbevf_dev_allmulticast_enable,\n+\t.allmulticast_disable = txgbevf_dev_allmulticast_disable,\n \t.dev_infos_get = txgbevf_dev_info_get,\n \t.vlan_filter_set = txgbevf_vlan_filter_set,\n \t.vlan_strip_queue_set = txgbevf_vlan_strip_queue_set,\n", "prefixes": [ "v1", "11/20" ] }