Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87056/?format=api
{ "id": 87056, "url": "https://patches.dpdk.org/api/patches/87056/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210122090110.50453-4-stevex.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210122090110.50453-4-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210122090110.50453-4-stevex.yang@intel.com", "date": "2021-01-22T09:01:10", "name": "[v3,3/3] app/testpmd: fix dynamic config error", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ed67c79e6c466decbb4de6f28d70b67e2040dcc5", "submitter": { "id": 1883, "url": "https://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210122090110.50453-4-stevex.yang@intel.com/mbox/", "series": [ { "id": 14900, "url": "https://patches.dpdk.org/api/series/14900/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14900", "date": "2021-01-22T09:01:07", "name": "fix 'max-pkt-len' errors", "version": 3, "mbox": "https://patches.dpdk.org/series/14900/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87056/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/87056/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 81671A0A0A;\n\tFri, 22 Jan 2021 10:04:51 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0C23B140DE5;\n\tFri, 22 Jan 2021 10:04:42 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 626E5140DE5\n for <dev@dpdk.org>; Fri, 22 Jan 2021 10:04:40 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Jan 2021 01:04:40 -0800", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])\n by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Jan 2021 01:04:37 -0800" ], "IronPort-SDR": [ "\n kLXVA+/6v0VSAjy0IefP4XziuJcR4sTNZ+qoaaBoT5Vgf1j5aQ3Um+aPrDGOuufkfqU9tKnPCe\n CMQewmaT8RFA==", "\n JnokwB9fy2rS0C7PXQP+ny313kSNaOfopHMwY9mTcTK0pr7Rtui96LUYBL6zsCksOdYm0+TSC/\n jKqXTFmJ9OBg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9871\"; a=\"240962318\"", "E=Sophos;i=\"5.79,366,1602572400\"; d=\"scan'208\";a=\"240962318\"", "E=Sophos;i=\"5.79,366,1602572400\"; d=\"scan'208\";a=\"427910777\"" ], "From": "Steve Yang <stevex.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "wenzhuo.lu@intel.com, xiaoyun.li@intel.com, bernard.iremonger@intel.com,\n thomas@monjalon.net, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru,\n stevex.yang@intel.com, qiming.yang@intel.com", "Date": "Fri, 22 Jan 2021 09:01:10 +0000", "Message-Id": "<20210122090110.50453-4-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210122090110.50453-1-stevex.yang@intel.com>", "References": "<20201223085152.20866-1-stevex.yang@intel.com>\n <20210122090110.50453-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 3/3] app/testpmd: fix dynamic config error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The offloads of 'tx/rx_conf' didn't keep up with the corresponding\noffloads of 'dev_conf' if rx queue capability was 0, it would cause\nthe configuration invalid.\n\nFor example:\nConfiguring 'max-pkt-len' would change 'rx_offloads' in dev_conf while\nrx_conf.offloads of each queue still kept the old value.\nIt would cause the failure of offloads check in 'rte_eth_rx_queue_setup'.\n\nThis patch applied tx/rx offloads configuration for each queue\nonce it changed and corresponding tx/rx queue capability was 0.\n\nFixes: 5e91aeef218c (\"app/testpmd: fix offload flags after port config\")\n\nSigned-off-by: Steve Yang <stevex.yang@intel.com>\n---\n app/test-pmd/testpmd.c | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex a2c9aad960..8307c7f9e9 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -3296,7 +3296,11 @@ rxtx_port_config(struct rte_port *port)\n \tfor (qid = 0; qid < nb_rxq; qid++) {\n \t\toffloads = port->rx_conf[qid].offloads;\n \t\tport->rx_conf[qid] = port->dev_info.default_rxconf;\n-\t\tif (offloads != 0)\n+\t\tif (port->dev_info.rx_queue_offload_capa == 0 &&\n+\t\t offloads != port->dev_conf.rxmode.offloads)\n+\t\t\tport->rx_conf[qid].offloads =\n+\t\t\t\tport->dev_conf.rxmode.offloads;\n+\t\telse if (offloads != 0)\n \t\t\tport->rx_conf[qid].offloads = offloads;\n \n \t\t/* Check if any Rx parameters have been passed */\n@@ -3321,7 +3325,11 @@ rxtx_port_config(struct rte_port *port)\n \tfor (qid = 0; qid < nb_txq; qid++) {\n \t\toffloads = port->tx_conf[qid].offloads;\n \t\tport->tx_conf[qid] = port->dev_info.default_txconf;\n-\t\tif (offloads != 0)\n+\t\tif (port->dev_info.tx_queue_offload_capa == 0 &&\n+\t\t offloads != port->dev_conf.txmode.offloads)\n+\t\t\tport->tx_conf[qid].offloads =\n+\t\t\t\tport->dev_conf.txmode.offloads;\n+\t\telse if (offloads != 0)\n \t\t\tport->tx_conf[qid].offloads = offloads;\n \n \t\t/* Check if any Tx parameters have been passed */\n", "prefixes": [ "v3", "3/3" ] }