Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87050/?format=api
{ "id": 87050, "url": "https://patches.dpdk.org/api/patches/87050/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210122051916.1408093-2-feifei.wang2@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210122051916.1408093-2-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210122051916.1408093-2-feifei.wang2@arm.com", "date": "2021-01-22T05:19:15", "name": "[v1,1/2] app/eventdev: adjust event count order for pipeline test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "afe26d53dde6b2d4f39292b1d1191e5695ac03c7", "submitter": { "id": 1771, "url": "https://patches.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210122051916.1408093-2-feifei.wang2@arm.com/mbox/", "series": [ { "id": 14898, "url": "https://patches.dpdk.org/api/series/14898/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14898", "date": "2021-01-22T05:19:14", "name": "fix bugs of app eventdev", "version": 1, "mbox": "https://patches.dpdk.org/series/14898/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87050/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87050/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A8F6CA0A0A;\n\tFri, 22 Jan 2021 06:19:34 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EA948140E37;\n\tFri, 22 Jan 2021 06:19:29 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 418E5140E33;\n Fri, 22 Jan 2021 06:19:29 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8798911B3;\n Thu, 21 Jan 2021 21:19:28 -0800 (PST)", "from net-x86-dell-8268.shanghai.arm.com\n (net-x86-dell-8268.shanghai.arm.com [10.169.210.127])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 966A13F68F;\n Thu, 21 Jan 2021 21:19:25 -0800 (PST)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "Jerin Jacob <jerinj@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>", "Cc": "dev@dpdk.org, nd@arm.com, Feifei Wang <feifei.wang2@arm.com>,\n pbhagavatula@marvell.com, stable@dpdk.org,\n Ruifeng Wang <ruifeng.wang@arm.com>", "Date": "Fri, 22 Jan 2021 13:19:15 +0800", "Message-Id": "<20210122051916.1408093-2-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210122051916.1408093-1-feifei.wang2@arm.com>", "References": "<20210122051916.1408093-1-feifei.wang2@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 1/2] app/eventdev: adjust event count order\n for pipeline test", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For the fwd mode (internal_port = false) in pipeline test,\nprocessed-pkts increment should after enqueue. However, in\nmulti_stage_fwd and multi_stage_burst_fwd, \"w->processed_pkts\" is\nincreased before enqueue.\n\nTo fix this, move \"w->processed_pkts\" increment after enqueue, and then\nthe main core can load the correct number of processed packets.\n\nFixes: 314bcf58ca8f (\"app/eventdev: add pipeline queue worker functions\")\nCc: pbhagavatula@marvell.com\nCc: stable@dpdk.org\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n app/test-eventdev/test_pipeline_queue.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test-eventdev/test_pipeline_queue.c b/app/test-eventdev/test_pipeline_queue.c\nindex 7bebac34f..01f33e3b4 100644\n--- a/app/test-eventdev/test_pipeline_queue.c\n+++ b/app/test-eventdev/test_pipeline_queue.c\n@@ -180,13 +180,13 @@ pipeline_queue_worker_multi_stage_fwd(void *arg)\n \t\t\tev.queue_id = tx_queue[ev.mbuf->port];\n \t\t\trte_event_eth_tx_adapter_txq_set(ev.mbuf, 0);\n \t\t\tpipeline_fwd_event(&ev, RTE_SCHED_TYPE_ATOMIC);\n+\t\t\tpipeline_event_enqueue(dev, port, &ev);\n \t\t\tw->processed_pkts++;\n \t\t} else {\n \t\t\tev.queue_id++;\n \t\t\tpipeline_fwd_event(&ev, sched_type_list[cq_id]);\n+\t\t\tpipeline_event_enqueue(dev, port, &ev);\n \t\t}\n-\n-\t\tpipeline_event_enqueue(dev, port, &ev);\n \t}\n \n \treturn 0;\n@@ -237,6 +237,7 @@ pipeline_queue_worker_multi_stage_burst_fwd(void *arg)\n \tconst uint8_t *tx_queue = t->tx_evqueue_id;\n \n \twhile (t->done == false) {\n+\t\tuint16_t processed_pkts = 0;\n \t\tuint16_t nb_rx = rte_event_dequeue_burst(dev, port, ev,\n \t\t\t\tBURST_SIZE, 0);\n \n@@ -254,7 +255,7 @@ pipeline_queue_worker_multi_stage_burst_fwd(void *arg)\n \t\t\t\trte_event_eth_tx_adapter_txq_set(ev[i].mbuf, 0);\n \t\t\t\tpipeline_fwd_event(&ev[i],\n \t\t\t\t\t\tRTE_SCHED_TYPE_ATOMIC);\n-\t\t\t\tw->processed_pkts++;\n+\t\t\t\tprocessed_pkts++;\n \t\t\t} else {\n \t\t\t\tev[i].queue_id++;\n \t\t\t\tpipeline_fwd_event(&ev[i],\n@@ -263,6 +264,7 @@ pipeline_queue_worker_multi_stage_burst_fwd(void *arg)\n \t\t}\n \n \t\tpipeline_event_enqueue_burst(dev, port, ev, nb_rx);\n+\t\tw->processed_pkts += processed_pkts;\n \t}\n \n \treturn 0;\n", "prefixes": [ "v1", "1/2" ] }