Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87027/?format=api
{ "id": 87027, "url": "https://patches.dpdk.org/api/patches/87027/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210121094154.6788-1-alvinx.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210121094154.6788-1-alvinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210121094154.6788-1-alvinx.zhang@intel.com", "date": "2021-01-21T09:41:54", "name": "[v2] app/testpmd: fix RSS key", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "30c3bca53af927b393f7de2b03f66aebc5e34935", "submitter": { "id": 1398, "url": "https://patches.dpdk.org/api/people/1398/?format=api", "name": "Alvin Zhang", "email": "alvinx.zhang@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210121094154.6788-1-alvinx.zhang@intel.com/mbox/", "series": [ { "id": 14885, "url": "https://patches.dpdk.org/api/series/14885/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14885", "date": "2021-01-21T09:41:54", "name": "[v2] app/testpmd: fix RSS key", "version": 2, "mbox": "https://patches.dpdk.org/series/14885/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87027/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/87027/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 878C3A09E4;\n\tThu, 21 Jan 2021 10:42:09 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 211BE140F35;\n\tThu, 21 Jan 2021 10:42:09 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id D023F140F34;\n Thu, 21 Jan 2021 10:42:07 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jan 2021 01:42:06 -0800", "from shwdenpg235.ccr.corp.intel.com ([10.240.182.60])\n by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jan 2021 01:42:04 -0800" ], "IronPort-SDR": [ "\n PH2Jg1j5srNPuqbj+8PZfvo9oyxS8Vi6c1vbMSTz005UxXMWoa1715jOyHPl+B94iI+/RmpQOZ\n BC5dYPuFTXEA==", "\n zTDVAsnNt7dG2PJfrDf+F47L5DvQgwOcAvNmF0E5zsM0deWEsyIHoUSCM78wuTdOgg/d3IGIR8\n S6OVG9bhOFeg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9870\"; a=\"179394733\"", "E=Sophos;i=\"5.79,363,1602572400\"; d=\"scan'208\";a=\"179394733\"", "E=Sophos;i=\"5.79,363,1602572400\"; d=\"scan'208\";a=\"403130523\"" ], "From": "\"Zhang,Alvin\" <alvinx.zhang@intel.com>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org,\n\tAlvin Zhang <alvinx.zhang@intel.com>,\n\tstable@dpdk.org", "Date": "Thu, 21 Jan 2021 17:41:54 +0800", "Message-Id": "<20210121094154.6788-1-alvinx.zhang@intel.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20210118085937.12072-1-alvinx.zhang@intel.com>", "References": "<20210118085937.12072-1-alvinx.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] app/testpmd: fix RSS key", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Alvin Zhang <alvinx.zhang@intel.com>\n\nSince the patch '1848b117' has initialized the variable 'key' in\n'struct rte_flow_action_rss' with 'NULL', the PMD cannot get the\nRSS key now. Details as bellow:\n\ntestpmd> flow create 0 ingress pattern eth / ipv4 / end actions\n rss types ipv4-other end key\n 1234567890123456789012345678901234567890FFFFFFFFFFFF123\n 4567890123456789012345678901234567890FFFFFFFFFFFF\n queues end / end\nFlow rule #1 created\ntestpmd> show port 0 rss-hash key\nRSS functions:\n all ipv4-other ip\nRSS key:\n 4439796BB54C5023B675EA5B124F9F30B8A2C03DDFDC4D02A08C9B3\n 34AF64A4C05C6FA343958D8557D99583AE138C92E81150366\n\nThis patch sets offset and size of the 'key' variable as the first\nparameter of the token 'key'. Later, the address of the RSS key will\nbe copied to 'key' variable.\n\nFixes: 1848b117cca1 (\"app/testpmd: fix RSS key for flow API RSS rule\")\nCc: stable@dpdk.org\n\nSigned-off-by: Alvin Zhang <alvinx.zhang@intel.com>\n---\n app/test-pmd/cmdline_flow.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex 0618611..067e120 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -3541,7 +3541,10 @@ static int comp_set_modify_field_id(struct context *, const struct token *,\n \t\t.name = \"key\",\n \t\t.help = \"RSS hash key\",\n \t\t.next = NEXT(action_rss, NEXT_ENTRY(HEX)),\n-\t\t.args = ARGS(ARGS_ENTRY_ARB(0, 0),\n+\t\t.args = ARGS(ARGS_ENTRY_ARB\n+\t\t\t (offsetof(struct action_rss_data, conf) +\n+\t\t\t offsetof(struct rte_flow_action_rss, key),\n+\t\t\t sizeof(((struct rte_flow_action_rss *)0)->key)),\n \t\t\t ARGS_ENTRY_ARB\n \t\t\t (offsetof(struct action_rss_data, conf) +\n \t\t\t offsetof(struct rte_flow_action_rss, key_len),\n", "prefixes": [ "v2" ] }