Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87002/?format=api
{ "id": 87002, "url": "https://patches.dpdk.org/api/patches/87002/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210120172931.3135778-3-ciara.power@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210120172931.3135778-3-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210120172931.3135778-3-ciara.power@intel.com", "date": "2021-01-20T17:29:29", "name": "[v3,2/4] test/cryptodev: fix csv output format", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "44c3d05e2ca5210d5e4b21c048c0c005637c7ce9", "submitter": { "id": 978, "url": "https://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210120172931.3135778-3-ciara.power@intel.com/mbox/", "series": [ { "id": 14875, "url": "https://patches.dpdk.org/api/series/14875/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14875", "date": "2021-01-20T17:29:28", "name": "add crypto perf test graphing script", "version": 3, "mbox": "https://patches.dpdk.org/series/14875/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87002/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87002/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E4AE3A0A0A;\n\tWed, 20 Jan 2021 18:30:08 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BB9B0140E29;\n\tWed, 20 Jan 2021 18:29:58 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id ED939140DDA;\n Wed, 20 Jan 2021 18:29:54 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jan 2021 09:29:48 -0800", "from silpixa00400355.ir.intel.com (HELO\n silpixa00400355.ger.corp.intel.com) ([10.237.223.148])\n by fmsmga008.fm.intel.com with ESMTP; 20 Jan 2021 09:29:46 -0800" ], "IronPort-SDR": [ "\n UjjuubgokyPncclql2C2vwQYIh8H/MsBPCtDHPSKzoAFCEv+cyQL8x9D7IDutcmStP6n0sVqCV\n LOVmjLtDs3fw==", "\n 8AQLoRJ3lOUFPwwm1ZaLG9TGUUXYKf8m0cqioxnSofRdeEoR8oHvP6g6Zx0v3Nk3y4BMopKBLY\n b5UYBuoMwIsA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9870\"; a=\"179230266\"", "E=Sophos;i=\"5.79,361,1602572400\"; d=\"scan'208\";a=\"179230266\"", "E=Sophos;i=\"5.79,361,1602572400\"; d=\"scan'208\";a=\"356126420\"" ], "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "declan.doherty@intel.com, akhil.goyal@nxp.com, stephen@networkplumber.org,\n adamx.dybkowski@intel.com, thomas@monjalon.net,\n Ciara Power <ciara.power@intel.com>, anatoly.burakov@intel.com,\n pablo.de.lara.guarch@intel.com, stable@dpdk.org", "Date": "Wed, 20 Jan 2021 17:29:29 +0000", "Message-Id": "<20210120172931.3135778-3-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210120172931.3135778-1-ciara.power@intel.com>", "References": "<20201211173114.1924772-1-ciara.power@intel.com>\n <20210120172931.3135778-1-ciara.power@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 2/4] test/cryptodev: fix csv output format", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The csv output for each ptest type used \";\" instead of \",\".\nThis has now been fixed to use the comma format that is used in the csv\nheaders.\n\nFixes: f6cefe253cc8 (\"app/crypto-perf: add range/list of sizes\")\nFixes: 96dfeb609be1 (\"app/crypto-perf: add new PMD benchmarking mode\")\nFixes: da40ebd6d383 (\"app/crypto-perf: display results in test runner\")\nCc: anatoly.burakov@intel.com\nCc: pablo.de.lara.guarch@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\nAcked-by: Declan Doherty <declan.doherty@intel.com>\nAcked-by: Adam Dybkowski <adamx.dybkowski@intel.com>\n\n---\nv2:\n - Reduced changes to only fix csv format.\n---\n app/test-crypto-perf/cperf_test_latency.c | 2 +-\n app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 2 +-\n app/test-crypto-perf/cperf_test_throughput.c | 4 ++--\n app/test-crypto-perf/cperf_test_verify.c | 2 +-\n 4 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test-crypto-perf/cperf_test_latency.c b/app/test-crypto-perf/cperf_test_latency.c\nindex c2590a4dcf..159fe8492b 100644\n--- a/app/test-crypto-perf/cperf_test_latency.c\n+++ b/app/test-crypto-perf/cperf_test_latency.c\n@@ -314,7 +314,7 @@ cperf_latency_test_runner(void *arg)\n \n \t\t\tfor (i = 0; i < ctx->options->total_ops; i++) {\n \n-\t\t\t\tprintf(\"\\n%u;%u;%u;%\"PRIu64\";%\"PRIu64\";%.3f\",\n+\t\t\t\tprintf(\"\\n%u,%u,%u,%\"PRIu64\",%\"PRIu64\",%.3f\",\n \t\t\t\t\tctx->lcore_id, ctx->options->test_buffer_size,\n \t\t\t\t\ttest_burst_size, i + 1,\n \t\t\t\t\tctx->res[i].tsc_end - ctx->res[i].tsc_start,\ndiff --git a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c\nindex 4e67d3aebd..844659aeca 100644\n--- a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c\n+++ b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c\n@@ -16,7 +16,7 @@\n #define PRETTY_HDR_FMT \"%12s%12s%12s%12s%12s%12s%12s%12s%12s%12s\\n\\n\"\n #define PRETTY_LINE_FMT \"%12u%12u%12u%12u%12u%12u%12u%12.0f%12.0f%12.0f\\n\"\n #define CSV_HDR_FMT \"%s,%s,%s,%s,%s,%s,%s,%s,%s,%s\\n\"\n-#define CSV_LINE_FMT \"%10u;%10u;%u;%u;%u;%u;%u;%.3f;%.3f;%.3f\\n\"\n+#define CSV_LINE_FMT \"%10u,%10u,%u,%u,%u,%u,%u,%.3f,%.3f,%.3f\\n\"\n \n struct cperf_pmd_cyclecount_ctx {\n \tuint8_t dev_id;\ndiff --git a/app/test-crypto-perf/cperf_test_throughput.c b/app/test-crypto-perf/cperf_test_throughput.c\nindex f30f7d5c2c..f6eb8cf259 100644\n--- a/app/test-crypto-perf/cperf_test_throughput.c\n+++ b/app/test-crypto-perf/cperf_test_throughput.c\n@@ -299,8 +299,8 @@ cperf_throughput_test_runner(void *test_ctx)\n \t\t\t\t\t\"Failed Deq,Ops(Millions),Throughput(Gbps),\"\n \t\t\t\t\t\"Cycles/Buf\\n\\n\");\n \n-\t\t\tprintf(\"%u;%u;%u;%\"PRIu64\";%\"PRIu64\";%\"PRIu64\";%\"PRIu64\";\"\n-\t\t\t\t\t\"%.3f;%.3f;%.3f\\n\",\n+\t\t\tprintf(\"%u,%u,%u,%\"PRIu64\",%\"PRIu64\",%\"PRIu64\",%\"PRIu64\",\"\n+\t\t\t\t\t\"%.3f,%.3f,%.3f\\n\",\n \t\t\t\t\tctx->lcore_id,\n \t\t\t\t\tctx->options->test_buffer_size,\n \t\t\t\t\ttest_burst_size,\ndiff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c\nindex 833bc9a552..2939aeaa93 100644\n--- a/app/test-crypto-perf/cperf_test_verify.c\n+++ b/app/test-crypto-perf/cperf_test_verify.c\n@@ -406,7 +406,7 @@ cperf_verify_test_runner(void *test_ctx)\n \t\t\t\t\"Burst Size,Enqueued,Dequeued,Failed Enq,\"\n \t\t\t\t\"Failed Deq,Failed Ops\\n\");\n \n-\t\tprintf(\"%10u;%10u;%u;%\"PRIu64\";%\"PRIu64\";%\"PRIu64\";%\"PRIu64\";\"\n+\t\tprintf(\"%10u,%10u,%u,%\"PRIu64\",%\"PRIu64\",%\"PRIu64\",%\"PRIu64\",\"\n \t\t\t\t\"%\"PRIu64\"\\n\",\n \t\t\t\tctx->lcore_id,\n \t\t\t\tctx->options->max_buffer_size,\n", "prefixes": [ "v3", "2/4" ] }