Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86987/?format=api
{ "id": 86987, "url": "https://patches.dpdk.org/api/patches/86987/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210120135556.33763-7-david.hunt@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210120135556.33763-7-david.hunt@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210120135556.33763-7-david.hunt@intel.com", "date": "2021-01-20T13:55:56", "name": "[v3,6/6] power: clean up includes", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "13d8fe440968658115a5780701d599a91f9961d6", "submitter": { "id": 342, "url": "https://patches.dpdk.org/api/people/342/?format=api", "name": "Hunt, David", "email": "david.hunt@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210120135556.33763-7-david.hunt@intel.com/mbox/", "series": [ { "id": 14869, "url": "https://patches.dpdk.org/api/series/14869/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14869", "date": "2021-01-20T13:55:50", "name": "power: fix make build for power apps", "version": 3, "mbox": "https://patches.dpdk.org/series/14869/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86987/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/86987/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 35DD6A0A05;\n\tWed, 20 Jan 2021 15:00:49 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3DD25140E27;\n\tWed, 20 Jan 2021 14:59:58 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id 34488140E08;\n Wed, 20 Jan 2021 14:59:55 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jan 2021 05:59:54 -0800", "from silpixa00399952.ir.intel.com (HELO\n silpixa00399952.ger.corp.intel.com) ([10.237.222.38])\n by fmsmga006.fm.intel.com with ESMTP; 20 Jan 2021 05:59:53 -0800" ], "IronPort-SDR": [ "\n RXCuxrXse2PnSJcdCt48HfDXqt/Ch8gxb4RmcVk8g4VfFULmuMC9+WVWAOP/aXHqG+ISGMxL5e\n +Umnhb6vE2ZQ==", "\n W7inqn3XOOttYNiHIkgjQbJCVfP4t1pdkdMoRhNdKt//6MCROKELSzaG1nDcK9u5Hww5ACtvx0\n wHbANvCBR6yw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9869\"; a=\"176535709\"", "E=Sophos;i=\"5.79,361,1602572400\"; d=\"scan'208\";a=\"176535709\"", "E=Sophos;i=\"5.79,361,1602572400\"; d=\"scan'208\";a=\"571344994\"" ], "X-ExtLoop1": "1", "From": "David Hunt <david.hunt@intel.com>", "To": "dev@dpdk.org", "Cc": "david.hunt@intel.com, stable@dpdk.org,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Wed, 20 Jan 2021 13:55:56 +0000", "Message-Id": "<20210120135556.33763-7-david.hunt@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210120135556.33763-1-david.hunt@intel.com>", "References": "<20210108143048.23755-2-david.hunt@intel.com>\n <20210120135556.33763-1-david.hunt@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 6/6] power: clean up includes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Bruce Richardson <bruce.richardson@intel.com>\n\nre-organise the including of the new public header file and\nremove un-needed includes\n\nFixes: 210c383e247b (\"power: packet format for vm power management\")\nFixes: cd0d5547e873 (\"power: vm communication channels in guest\")\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: David Hunt <david.hunt@intel.com>\n---\n examples/vm_power_manager/channel_manager.c | 1 -\n examples/vm_power_manager/channel_monitor.c | 1 -\n examples/vm_power_manager/channel_monitor.h | 2 +-\n examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 1 -\n examples/vm_power_manager/guest_cli/vm_power_cli_guest.h | 2 --\n examples/vm_power_manager/vm_power_cli.c | 1 -\n lib/librte_power/guest_channel.c | 2 +-\n lib/librte_power/guest_channel.h | 2 --\n lib/librte_power/power_kvm_vm.c | 2 +-\n lib/librte_power/rte_power.h | 1 +\n lib/librte_power/rte_power_guest_channel.h | 3 ---\n 11 files changed, 4 insertions(+), 14 deletions(-)", "diff": "diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c\nindex c7d5bf5a8..0a28cb643 100644\n--- a/examples/vm_power_manager/channel_manager.c\n+++ b/examples/vm_power_manager/channel_manager.c\n@@ -27,7 +27,6 @@\n #include <libvirt/libvirt.h>\n \n #include \"channel_manager.h\"\n-#include \"rte_power_guest_channel.h\"\n #include \"channel_monitor.h\"\n #include \"power_manager.h\"\n \ndiff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c\nindex 06af3796f..306a78d3e 100644\n--- a/examples/vm_power_manager/channel_monitor.c\n+++ b/examples/vm_power_manager/channel_monitor.c\n@@ -35,7 +35,6 @@\n \n #include <libvirt/libvirt.h>\n #include \"channel_monitor.h\"\n-#include \"rte_power_guest_channel.h\"\n #include \"channel_manager.h\"\n #include \"power_manager.h\"\n #include \"oob_monitor.h\"\ndiff --git a/examples/vm_power_manager/channel_monitor.h b/examples/vm_power_manager/channel_monitor.h\nindex 5d3537b91..9184a8327 100644\n--- a/examples/vm_power_manager/channel_monitor.h\n+++ b/examples/vm_power_manager/channel_monitor.h\n@@ -5,8 +5,8 @@\n #ifndef CHANNEL_MONITOR_H_\n #define CHANNEL_MONITOR_H_\n \n+#include <rte_power.h>\n #include \"channel_manager.h\"\n-#include \"rte_power_guest_channel.h\"\n \n struct core_share {\n \tunsigned int pcpu;\ndiff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c\nindex 3fde38dd3..32a2808d3 100644\n--- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c\n+++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c\n@@ -19,7 +19,6 @@\n #include <rte_ethdev.h>\n \n #include <rte_power.h>\n-#include <guest_channel.h>\n \n #include \"vm_power_cli_guest.h\"\n \ndiff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.h b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.h\nindex 5d285ca9d..b578ec072 100644\n--- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.h\n+++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.h\n@@ -9,8 +9,6 @@\n extern \"C\" {\n #endif\n \n-#include \"rte_power_guest_channel.h\"\n-\n struct rte_power_channel_packet *get_policy(void);\n \n int set_policy_mac(int port, int idx);\ndiff --git a/examples/vm_power_manager/vm_power_cli.c b/examples/vm_power_manager/vm_power_cli.c\nindex f7e1b596e..1a55e553b 100644\n--- a/examples/vm_power_manager/vm_power_cli.c\n+++ b/examples/vm_power_manager/vm_power_cli.c\n@@ -21,7 +21,6 @@\n #include \"channel_manager.h\"\n #include \"channel_monitor.h\"\n #include \"power_manager.h\"\n-#include \"rte_power_guest_channel.h\"\n \n struct cmd_quit_result {\n \tcmdline_fixed_string_t quit;\ndiff --git a/lib/librte_power/guest_channel.c b/lib/librte_power/guest_channel.c\nindex 039cb1872..2f7507a03 100644\n--- a/lib/librte_power/guest_channel.c\n+++ b/lib/librte_power/guest_channel.c\n@@ -15,9 +15,9 @@\n \n \n #include <rte_log.h>\n+#include <rte_power.h>\n \n #include \"guest_channel.h\"\n-#include \"rte_power_guest_channel.h\"\n \n #define RTE_LOGTYPE_GUEST_CHANNEL RTE_LOGTYPE_USER1\n \ndiff --git a/lib/librte_power/guest_channel.h b/lib/librte_power/guest_channel.h\nindex 7d3a909d9..24f609df3 100644\n--- a/lib/librte_power/guest_channel.h\n+++ b/lib/librte_power/guest_channel.h\n@@ -8,8 +8,6 @@\n extern \"C\" {\n #endif\n \n-#include <rte_power_guest_channel.h>\n-\n /**\n * Check if any Virtio-Serial VM end-points exist in path.\n *\ndiff --git a/lib/librte_power/power_kvm_vm.c b/lib/librte_power/power_kvm_vm.c\nindex 27f9937aa..ab7d4b8ce 100644\n--- a/lib/librte_power/power_kvm_vm.c\n+++ b/lib/librte_power/power_kvm_vm.c\n@@ -6,8 +6,8 @@\n \n #include <rte_log.h>\n \n-#include \"guest_channel.h\"\n #include \"rte_power_guest_channel.h\"\n+#include \"guest_channel.h\"\n #include \"power_kvm_vm.h\"\n #include \"power_common.h\"\n \ndiff --git a/lib/librte_power/rte_power.h b/lib/librte_power/rte_power.h\nindex bbbde4dfb..c8086bf6b 100644\n--- a/lib/librte_power/rte_power.h\n+++ b/lib/librte_power/rte_power.h\n@@ -14,6 +14,7 @@\n #include <rte_byteorder.h>\n #include <rte_log.h>\n #include <rte_string_fns.h>\n+#include <rte_power_guest_channel.h>\n \n #ifdef __cplusplus\n extern \"C\" {\ndiff --git a/lib/librte_power/rte_power_guest_channel.h b/lib/librte_power/rte_power_guest_channel.h\nindex 0e7082c51..f9c3f12e4 100644\n--- a/lib/librte_power/rte_power_guest_channel.h\n+++ b/lib/librte_power/rte_power_guest_channel.h\n@@ -8,9 +8,6 @@\n extern \"C\" {\n #endif\n \n-#include <stdint.h>\n-#include <stdbool.h>\n-\n #define RTE_POWER_MAX_VFS 10\n #define RTE_POWER_VM_MAX_NAME_SZ 32\n #define RTE_POWER_MAX_VCPU_PER_VM 8\n", "prefixes": [ "v3", "6/6" ] }