Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86831/?format=api
{ "id": 86831, "url": "https://patches.dpdk.org/api/patches/86831/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210118203508.1332-12-aboyer@pensando.io/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210118203508.1332-12-aboyer@pensando.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20210118203508.1332-12-aboyer@pensando.io", "date": "2021-01-18T20:35:06", "name": "[11/13] net/ionic: convert per-queue offloads into queue flags", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3a05778fdd01c84ae6660d80e19d2210720526f8", "submitter": { "id": 2036, "url": "https://patches.dpdk.org/api/people/2036/?format=api", "name": "Andrew Boyer", "email": "aboyer@pensando.io" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210118203508.1332-12-aboyer@pensando.io/mbox/", "series": [ { "id": 14820, "url": "https://patches.dpdk.org/api/series/14820/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14820", "date": "2021-01-18T20:34:55", "name": "net/ionic: fixes and optimizations", "version": 1, "mbox": "https://patches.dpdk.org/series/14820/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/86831/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/86831/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 471D9A0A03;\n\tMon, 18 Jan 2021 21:36:53 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E3718140E9B;\n\tMon, 18 Jan 2021 21:35:55 +0100 (CET)", "from mail-pg1-f177.google.com (mail-pg1-f177.google.com\n [209.85.215.177])\n by mails.dpdk.org (Postfix) with ESMTP id D7BF8140EA3\n for <dev@dpdk.org>; Mon, 18 Jan 2021 21:35:53 +0100 (CET)", "by mail-pg1-f177.google.com with SMTP id n25so11658770pgb.0\n for <dev@dpdk.org>; Mon, 18 Jan 2021 12:35:53 -0800 (PST)", "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id g201sm795160pfb.81.2021.01.18.12.35.52\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 18 Jan 2021 12:35:52 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=eZHLIajdEoFA3Nym+Z5BFhCDgWh82946qXblVzvYSvA=;\n b=x9YCfjcT/W/SWF9m2z/JA+OtaxInk4dJFRZcaWSypXy0A3DTfRviogk/7gqaUMy/Bz\n Iy2DcZM5j6Dn5gUmQ0Na30cXaDW6U7VG/59V5geLt/DwYPXE8lDSiEaIxD8rbZxCXqn4\n zHB2magFPL3tTqXpX6XI+MR/c/HiZYs9r3+TAAQHaqBtM9zxw5M6CuRom8ozd74HOGtU\n gPqP0PQ1JfITbYS+OjBmOY+PoWNoKzdNwmvNaeCJlajl1snu2CJv6BN+r8Uf0YaaqY/G\n z1Cz5gZ2s3pX5Gvkro/c/bTiNYZywVlq1zQKucwHiytWaSyJMafvUtdxrFlcMvCiwITJ\n Trrg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=eZHLIajdEoFA3Nym+Z5BFhCDgWh82946qXblVzvYSvA=;\n b=Dl2bcp2eFyg/N70DHuS9uLdD0gjdBKywpRzEHix2H4R0ILMonoO/iDsL90NAodv5FV\n mph179vj95OiqRB6EGTuorAyBm63doXYJGQgI4rCHllDUKrz5nr7wd/L3QiL/CdbOjOW\n kMP0cuftM97nJ/HL4Ek8naX4d5hxEKCAJhYt/Y4sLsCw5FZlrH+TorG1UBKjrCh7jSwB\n eiC3niZmLQTWXk/mpjlOnKkNKjqModyJJioL0go6ef/saeb11aP3iTcZb8wRI4BLKHt3\n FKzQIjijEr2dIaHT7YdjPjyqD6nV2tN7ESvq8HDZk9dMHuTuGE4o2rCvU1RZwYFzqKSh\n Cc3A==", "X-Gm-Message-State": "AOAM530UaGPuUAw/pv+qvra4Cwcbr9BE1Wzam/lhowU8v5IeW36mWnXN\n AGW3Mih1KPrQIcDFO9psFuZWErBVbD5rvw==", "X-Google-Smtp-Source": "\n ABdhPJzBX6cu2n6tMwsZOz8w65SsdxnNQmH71sv5H9lStBhB/BGiRBj5DqDAKBtu4nytpuBBLD2UgA==", "X-Received": "by 2002:a62:b60c:0:b029:1ae:6d91:4eb6 with SMTP id\n j12-20020a62b60c0000b02901ae6d914eb6mr1158160pff.33.1611002152897;\n Mon, 18 Jan 2021 12:35:52 -0800 (PST)", "From": "Andrew Boyer <aboyer@pensando.io>", "To": "dev@dpdk.org", "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>", "Date": "Mon, 18 Jan 2021 12:35:06 -0800", "Message-Id": "<20210118203508.1332-12-aboyer@pensando.io>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210118203508.1332-1-aboyer@pensando.io>", "References": "<20210118203508.1332-1-aboyer@pensando.io>", "Subject": "[dpdk-dev] [PATCH 11/13] net/ionic: convert per-queue offloads into\n queue flags", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This will conserve resources by reducing struct ionic_qcq.\n\nSaving a cacheline or two in the rxq and txq structs helps when\nrunning in embedded configurations where CPU cache space is at a\npremium.\n\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/ionic/ionic_lif.h | 4 +++-\n drivers/net/ionic/ionic_rxtx.c | 35 +++++++++++++++++++---------------\n 2 files changed, 23 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_lif.h b/drivers/net/ionic/ionic_lif.h\nindex bf5637afce..8f01aefd60 100644\n--- a/drivers/net/ionic/ionic_lif.h\n+++ b/drivers/net/ionic/ionic_lif.h\n@@ -49,10 +49,12 @@ struct ionic_rx_stats {\n #define IONIC_QCQ_F_INITED\tBIT(0)\n #define IONIC_QCQ_F_SG\t\tBIT(1)\n #define IONIC_QCQ_F_DEFERRED\tBIT(4)\n+#define IONIC_QCQ_F_CSUM_L3\tBIT(7)\n+#define IONIC_QCQ_F_CSUM_UDP\tBIT(8)\n+#define IONIC_QCQ_F_CSUM_TCP\tBIT(9)\n \n /* Queue / Completion Queue */\n struct ionic_qcq {\n-\tuint64_t offloads;\n \tstruct ionic_queue q; /**< Queue */\n \tstruct ionic_cq cq; /**< Completion Queue */\n \tstruct ionic_lif *lif; /**< LIF */\ndiff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex d0f8954753..918701f463 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -63,7 +63,7 @@ ionic_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,\n \tstruct ionic_queue *q = &txq->q;\n \n \tqinfo->nb_desc = q->num_descs;\n-\tqinfo->conf.offloads = txq->offloads;\n+\tqinfo->conf.offloads = dev->data->dev_conf.txmode.offloads;\n \tqinfo->conf.tx_deferred_start = txq->flags & IONIC_QCQ_F_DEFERRED;\n }\n \n@@ -200,7 +200,13 @@ ionic_dev_tx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id,\n \tif (tx_conf->tx_deferred_start)\n \t\ttxq->flags |= IONIC_QCQ_F_DEFERRED;\n \n-\ttxq->offloads = offloads;\n+\t/* Convert the offload flags into queue flags */\n+\tif (offloads & DEV_TX_OFFLOAD_IPV4_CKSUM)\n+\t\ttxq->flags |= IONIC_QCQ_F_CSUM_L3;\n+\tif (offloads & DEV_TX_OFFLOAD_TCP_CKSUM)\n+\t\ttxq->flags |= IONIC_QCQ_F_CSUM_TCP;\n+\tif (offloads & DEV_TX_OFFLOAD_UDP_CKSUM)\n+\t\ttxq->flags |= IONIC_QCQ_F_CSUM_UDP;\n \n \teth_dev->data->tx_queues[tx_queue_id] = txq;\n \n@@ -320,9 +326,10 @@ ionic_tx_tso_next(struct ionic_queue *q, struct ionic_txq_sg_elem **elem)\n }\n \n static int\n-ionic_tx_tso(struct ionic_queue *q, struct rte_mbuf *txm,\n-\t\tuint64_t offloads __rte_unused, bool not_xmit_more)\n+ionic_tx_tso(struct ionic_qcq *txq, struct rte_mbuf *txm,\n+\t\tbool not_xmit_more)\n {\n+\tstruct ionic_queue *q = &txq->q;\n \tstruct ionic_tx_stats *stats = IONIC_Q_TO_TX_STATS(q);\n \tstruct ionic_txq_desc *desc;\n \tstruct ionic_txq_sg_elem *elem;\n@@ -442,9 +449,10 @@ ionic_tx_tso(struct ionic_queue *q, struct rte_mbuf *txm,\n }\n \n static int\n-ionic_tx(struct ionic_queue *q, struct rte_mbuf *txm,\n-\t\tuint64_t offloads, bool not_xmit_more)\n+ionic_tx(struct ionic_qcq *txq, struct rte_mbuf *txm,\n+\t\tbool not_xmit_more)\n {\n+\tstruct ionic_queue *q = &txq->q;\n \tstruct ionic_txq_desc *desc_base = q->base;\n \tstruct ionic_txq_sg_desc_v1 *sg_desc_base = q->sg_base;\n \tstruct ionic_txq_desc *desc = &desc_base[q->head_idx];\n@@ -460,15 +468,15 @@ ionic_tx(struct ionic_queue *q, struct rte_mbuf *txm,\n \tuint8_t flags = 0;\n \n \tif ((ol_flags & PKT_TX_IP_CKSUM) &&\n-\t (offloads & DEV_TX_OFFLOAD_IPV4_CKSUM)) {\n+\t (txq->flags & IONIC_QCQ_F_CSUM_L3)) {\n \t\topcode = IONIC_TXQ_DESC_OPCODE_CSUM_HW;\n \t\tflags |= IONIC_TXQ_DESC_FLAG_CSUM_L3;\n \t}\n \n \tif (((ol_flags & PKT_TX_TCP_CKSUM) &&\n-\t (offloads & DEV_TX_OFFLOAD_TCP_CKSUM)) ||\n+\t (txq->flags & IONIC_QCQ_F_CSUM_TCP)) ||\n \t ((ol_flags & PKT_TX_UDP_CKSUM) &&\n-\t (offloads & DEV_TX_OFFLOAD_UDP_CKSUM))) {\n+\t (txq->flags & IONIC_QCQ_F_CSUM_UDP))) {\n \t\topcode = IONIC_TXQ_DESC_OPCODE_CSUM_HW;\n \t\tflags |= IONIC_TXQ_DESC_FLAG_CSUM_L4;\n \t}\n@@ -536,10 +544,9 @@ ionic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t}\n \n \t\tif (tx_pkts[nb_tx]->ol_flags & PKT_TX_TCP_SEG)\n-\t\t\terr = ionic_tx_tso(q, tx_pkts[nb_tx], txq->offloads,\n-\t\t\t\tlast);\n+\t\t\terr = ionic_tx_tso(txq, tx_pkts[nb_tx], last);\n \t\telse\n-\t\t\terr = ionic_tx(q, tx_pkts[nb_tx], txq->offloads, last);\n+\t\t\terr = ionic_tx(txq, tx_pkts[nb_tx], last);\n \t\tif (err) {\n \t\t\tstats->drop += nb_pkts - nb_tx;\n \t\t\tif (nb_tx > 0)\n@@ -621,7 +628,7 @@ ionic_rxq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,\n \tqinfo->scattered_rx = dev->data->scattered_rx;\n \tqinfo->nb_desc = q->num_descs;\n \tqinfo->conf.rx_deferred_start = rxq->flags & IONIC_QCQ_F_DEFERRED;\n-\tqinfo->conf.offloads = rxq->offloads;\n+\tqinfo->conf.offloads = dev->data->dev_conf.rxmode.offloads;\n }\n \n static void __rte_cold\n@@ -724,8 +731,6 @@ ionic_dev_rx_queue_setup(struct rte_eth_dev *eth_dev,\n \tif (rx_conf->rx_deferred_start)\n \t\trxq->flags |= IONIC_QCQ_F_DEFERRED;\n \n-\trxq->offloads = offloads;\n-\n \teth_dev->data->rx_queues[rx_queue_id] = rxq;\n \n \treturn 0;\n", "prefixes": [ "11/13" ] }